From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Raphael Hertzog <hertzog@debian.org>,
Konstantin Khlebnikov <koct9i@gmail.com>,
Miklos Szeredi <mszeredi@redhat.com>,
"linux-unionfs@vger.kernel.org" <linux-unionfs@vger.kernel.org>,
Guillem Jover <guillem@debian.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] ovl: redirect on rename-dir
Date: Mon, 14 Nov 2016 18:25:39 +0200 [thread overview]
Message-ID: <CAOQ4uxjAZAWTy14B1HA-=RmPVsgBBXve7914g0gn7EG3xADebA@mail.gmail.com> (raw)
In-Reply-To: <CAOQ4uxiC+O93=Dbgogc-GpL_7rF-qCRXeGzy3epVfpZRHNQf=A@mail.gmail.com>
On Sun, Nov 13, 2016 at 12:00 PM, Amir Goldstein <amir73il@gmail.com> wrote:
> On Fri, Nov 11, 2016 at 12:39 AM, Miklos Szeredi <miklos@szeredi.hu> wrote:
>> New version is at:
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git #redirect
>>
>> News:
>> - it actually should work in all cases
>> - when rename is not cross directory, just store the new name instead
>> of a full path, as suggested by Amir
>> - when redirect path is too long fall back to EXDEV (the max length
>> should probably be a module param)
>>
>
> Looks goods, except for the case of change from relative to absolute
> redirect of the victim dentry. IIUC, ovl_set_redirect() will return immediately
> because ovl_dentry_is_redirect() and will not get to setting the absolute
> redirect.
>
I added some more tests to catch this problem at:
https://github.com/amir73il/unionmount-testsuite.git #ovl_rename_dir
In the new version, upper recycling is optional and you can set a bound
to the number of layers. This is needed to catch the bug because the
scenario is:
- Rename populated dir in same dir
- Move the populated dir to another dir
- Re-mount
- Populated dir is empty
The following test run demonstrates it:
$ sudo ./run --ov=0 rename-move-dir
...
TEST rename-move-dir.py:37: Rename populated dir and move into another
./run --rename /mnt/a/dir102 /mnt/a/dir102x
./run --rename /mnt/a/dir102 /mnt/a/dir102x -E ENOENT
./run --rename /mnt/a/dir102x /mnt/a/empty102/dir102
./run --rename /mnt/a/dir102x /mnt/a/empty102/dir102 -E ENOENT
./run --open-file /mnt/a/dir102 -r -d -E ENOENT
./run --open-file /mnt/a/dir102x -r -d -E ENOENT
./run --open-file /mnt/a/empty102/dir102 -r -d
/mnt/a/empty102/dir102/a: File is missing
Amir.
next prev parent reply other threads:[~2016-11-14 16:25 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 7:34 [PATCH 0/3] overlayfs: allow moving directory trees Miklos Szeredi
2016-10-25 7:34 ` [PATCH 1/3] ovl: check fs features Miklos Szeredi
2016-10-25 7:34 ` Miklos Szeredi
2016-10-25 11:24 ` Amir Goldstein
2016-11-05 20:40 ` Amir Goldstein
2016-10-25 7:34 ` [PATCH 2/3] vfs: export vfs_path_lookup() Miklos Szeredi
2016-10-25 7:34 ` [PATCH 3/3] ovl: redirect on rename-dir Miklos Szeredi
2016-10-25 11:57 ` Raphael Hertzog
2016-10-26 11:12 ` Miklos Szeredi
2016-10-28 12:56 ` Raphael Hertzog
2016-10-28 12:59 ` Miklos Szeredi
2016-11-06 19:14 ` Konstantin Khlebnikov
2016-11-07 8:07 ` Miklos Szeredi
2016-11-07 9:58 ` Konstantin Khlebnikov
2016-11-07 10:04 ` Miklos Szeredi
2016-11-07 10:08 ` Konstantin Khlebnikov
2016-11-07 13:38 ` Amir Goldstein
2016-11-10 22:56 ` Amir Goldstein
2016-11-11 9:46 ` Konstantin Khlebnikov
2016-11-11 10:06 ` Miklos Szeredi
2016-11-11 12:42 ` Amir Goldstein
2016-11-13 9:11 ` Amir Goldstein
2016-11-07 11:03 ` Raphael Hertzog
2016-11-07 11:31 ` Konstantin Khlebnikov
2016-11-07 13:42 ` Raphael Hertzog
2016-11-10 22:39 ` Miklos Szeredi
2016-11-11 9:41 ` Konstantin Khlebnikov
2016-11-13 10:00 ` Amir Goldstein
2016-11-14 16:25 ` Amir Goldstein [this message]
2016-11-16 22:00 ` Miklos Szeredi
2016-11-18 15:37 ` Amir Goldstein
2016-11-20 11:39 ` Amir Goldstein
2016-11-21 9:54 ` Miklos Szeredi
2016-11-21 10:13 ` Amir Goldstein
2016-11-21 10:16 ` Miklos Szeredi
2016-11-22 13:42 ` Amir Goldstein
2016-10-25 12:49 ` Amir Goldstein
2016-10-26 11:26 ` Miklos Szeredi
2016-10-26 12:11 ` Amir Goldstein
2016-10-26 12:51 ` Miklos Szeredi
2016-10-26 19:56 ` Amir Goldstein
2016-10-30 22:00 ` Amir Goldstein
2016-10-31 14:59 ` Miklos Szeredi
2016-10-31 15:02 ` Amir Goldstein
2016-10-28 16:15 ` Al Viro
2016-11-03 15:50 ` Miklos Szeredi
2016-11-04 9:29 ` Amir Goldstein
2016-11-04 13:48 ` Miklos Szeredi
2016-10-25 20:25 ` [PATCH 0/3] overlayfs: allow moving directory trees Amir Goldstein
2016-10-26 9:37 ` Amir Goldstein
2016-10-26 9:34 ` [PATCH] ovl: check for emptiness of redirect dir Amir Goldstein
2016-10-26 10:45 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOQ4uxjAZAWTy14B1HA-=RmPVsgBBXve7914g0gn7EG3xADebA@mail.gmail.com' \
--to=amir73il@gmail.com \
--cc=guillem@debian.org \
--cc=hertzog@debian.org \
--cc=koct9i@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mszeredi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.