All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <mszeredi@redhat.com>
Cc: linux-unionfs@vger.kernel.org, Guillem Jover <guillem@debian.org>,
	Raphael Hertzog <hertzog@debian.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 0/3] overlayfs: allow moving directory trees
Date: Wed, 26 Oct 2016 12:37:18 +0300	[thread overview]
Message-ID: <CAOQ4uxjPcot7Puf0qw4YLtQ24cWKFDC5AhX5skQf4UYbXT0mJg@mail.gmail.com> (raw)
In-Reply-To: <CAOQ4uxjLQzJE-M1MNmKS3_jCwEKrYOsXgAXRDs2vudpn0Ladvg@mail.gmail.com>

On Tue, Oct 25, 2016 at 11:25 PM, Amir Goldstein <amir73il@gmail.com> wrote:
> On Tue, Oct 25, 2016 at 10:34 AM, Miklos Szeredi <mszeredi@redhat.com> wrote:
>> This allows overlayfs to move directory trees (residing on lower layer)
>> without having to recursively copy up the whole tree first.
>>
>> This series is available in git at:
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git#redirect
>>
>
> Gave this a run through xfstests -g quick, pjdfstest and unionmount-testsuite.
> After cleaning out all the xerr= failure expectations from unionmount tests,
> all tests pass except for rename-pop-dir, which appears to be successful in
> removal of non empty dir.
>

I sent out a patch to ovl_remove_upper() that fixes the problem.

> Changes to unionmount-testsuite are available on my github:
> https://github.com/amir73il/unionmount-testsuite/tree/ovl_rename_dir
>
>> And is on top of the overlayfs-next branch.
>>
>> ---
>> Miklos Szeredi (3):
>>   ovl: check fs features
>>   vfs: export vfs_path_lookup()
>>   ovl: redirect on rename-dir
>>
>>  Documentation/filesystems/overlayfs.txt | 33 ++++++++++-
>>  fs/internal.h                           |  2 -
>>  fs/overlayfs/copy_up.c                  | 20 ++-----
>>  fs/overlayfs/dir.c                      | 86 +++++++++++++++++++---------
>>  fs/overlayfs/namei.c                    | 99 ++++++++++++++++++++++++++++++---
>>  fs/overlayfs/overlayfs.h                |  5 ++
>>  fs/overlayfs/ovl_entry.h                |  4 ++
>>  fs/overlayfs/super.c                    | 56 +++++++++++++++++--
>>  fs/overlayfs/util.c                     | 19 +++++++
>>  include/linux/namei.h                   |  2 +
>>  10 files changed, 268 insertions(+), 58 deletions(-)
>>
>> --
>> 2.5.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-10-26  9:37 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25  7:34 [PATCH 0/3] overlayfs: allow moving directory trees Miklos Szeredi
2016-10-25  7:34 ` [PATCH 1/3] ovl: check fs features Miklos Szeredi
2016-10-25  7:34   ` Miklos Szeredi
2016-10-25 11:24   ` Amir Goldstein
2016-11-05 20:40     ` Amir Goldstein
2016-10-25  7:34 ` [PATCH 2/3] vfs: export vfs_path_lookup() Miklos Szeredi
2016-10-25  7:34 ` [PATCH 3/3] ovl: redirect on rename-dir Miklos Szeredi
2016-10-25 11:57   ` Raphael Hertzog
2016-10-26 11:12     ` Miklos Szeredi
2016-10-28 12:56       ` Raphael Hertzog
2016-10-28 12:59         ` Miklos Szeredi
2016-11-06 19:14       ` Konstantin Khlebnikov
2016-11-07  8:07         ` Miklos Szeredi
2016-11-07  9:58           ` Konstantin Khlebnikov
2016-11-07 10:04             ` Miklos Szeredi
2016-11-07 10:08               ` Konstantin Khlebnikov
2016-11-07 13:38                 ` Amir Goldstein
2016-11-10 22:56                   ` Amir Goldstein
2016-11-11  9:46                     ` Konstantin Khlebnikov
2016-11-11 10:06                       ` Miklos Szeredi
2016-11-11 12:42                         ` Amir Goldstein
2016-11-13  9:11                           ` Amir Goldstein
2016-11-07 11:03         ` Raphael Hertzog
2016-11-07 11:31           ` Konstantin Khlebnikov
2016-11-07 13:42             ` Raphael Hertzog
2016-11-10 22:39               ` Miklos Szeredi
2016-11-11  9:41                 ` Konstantin Khlebnikov
2016-11-13 10:00                 ` Amir Goldstein
2016-11-14 16:25                   ` Amir Goldstein
2016-11-16 22:00                     ` Miklos Szeredi
2016-11-18 15:37                       ` Amir Goldstein
2016-11-20 11:39                         ` Amir Goldstein
2016-11-21  9:54                         ` Miklos Szeredi
2016-11-21 10:13                           ` Amir Goldstein
2016-11-21 10:16                             ` Miklos Szeredi
2016-11-22 13:42                               ` Amir Goldstein
2016-10-25 12:49   ` Amir Goldstein
2016-10-26 11:26     ` Miklos Szeredi
2016-10-26 12:11       ` Amir Goldstein
2016-10-26 12:51         ` Miklos Szeredi
2016-10-26 19:56       ` Amir Goldstein
2016-10-30 22:00       ` Amir Goldstein
2016-10-31 14:59         ` Miklos Szeredi
2016-10-31 15:02           ` Amir Goldstein
2016-10-28 16:15   ` Al Viro
2016-11-03 15:50     ` Miklos Szeredi
2016-11-04  9:29       ` Amir Goldstein
2016-11-04 13:48         ` Miklos Szeredi
2016-10-25 20:25 ` [PATCH 0/3] overlayfs: allow moving directory trees Amir Goldstein
2016-10-26  9:37   ` Amir Goldstein [this message]
2016-10-26  9:34 ` [PATCH] ovl: check for emptiness of redirect dir Amir Goldstein
2016-10-26 10:45   ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOQ4uxjPcot7Puf0qw4YLtQ24cWKFDC5AhX5skQf4UYbXT0mJg@mail.gmail.com \
    --to=amir73il@gmail.com \
    --cc=guillem@debian.org \
    --cc=hertzog@debian.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=mszeredi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.