From: Amir Goldstein <amir73il@gmail.com> To: Christoph Hellwig <hch@lst.de> Cc: linux-xfs <linux-xfs@vger.kernel.org>, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, Mimi Zohar <zohar@linux.vnet.ibm.com>, linux-kernel <linux-kernel@vger.kernel.org>, David Howells <dhowells@redhat.com>, linux-fsdevel <linux-fsdevel@vger.kernel.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Shaohua Li <shli@kernel.org>, Steven Whitehouse <swhiteho@redhat.com> Subject: Re: [PATCH 03/16] uuid: rename uuid types Date: Wed, 10 May 2017 22:15:51 +0300 [thread overview] Message-ID: <CAOQ4uxjSpCgM=RK5jXkuY5HmseQT2EKh_huntvK2ADKBuNqi4A@mail.gmail.com> (raw) In-Reply-To: <20170510180214.16852-4-hch@lst.de> On Wed, May 10, 2017 at 9:02 PM, Christoph Hellwig <hch@lst.de> wrote: > Our "little endian" UUID really is a Wintel GUID, so rename it and its > helpers such (guid_t). The big endian UUID is the only true one, so > give it the name uuid_t. The uuid_le and uuid_be names are retained for, > but will hopefully go away soon. > > Also remove the existing typedef in XFS that's now been superceeded by > the generic type name. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > [andy: also updated the UUID_LE/UUID_BE macros including fallout] > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- [...] > > -static inline int uuid_le_cmp(const uuid_le u1, const uuid_le u2) > +static inline int guid_cmp(const guid_t u1, const guid_t u2) > { > - return memcmp(&u1, &u2, sizeof(uuid_le)); > + return memcmp(&u1, &u2, sizeof(guid_t)); > } > > -static inline int uuid_be_cmp(const uuid_be u1, const uuid_be u2) > +static inline int uuid_cmp(const uuid_t u1, const uuid_t u2) > { > - return memcmp(&u1, &u2, sizeof(uuid_be)); > + return memcmp(&u1, &u2, sizeof(uuid_t)); > } > I think we should use this opportunity to change these to (uuid_t *, uuid_t *) which is more in line with the rest of the helpers including the new helpers hoisted from xfs. [...] > +/* backwards compatibility, don't use in new code */ > +#define uuid_le_cmp(u1, u2) guid_cmp(u1, u2) > +#define uuid_be_cmp(u1, u2) uuid_cmp(u1, u2) Therefore: #define uuid_le_cmp(u1, u2) guid_cmp(&(u1), &(u2)) #define uuid_be_cmp(u1, u2) uuid_cmp(&(u1), &(u2)) _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID
From: Amir Goldstein <amir73il-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> Cc: linux-xfs <linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, Mimi Zohar <zohar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>, linux-kernel <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, linux-fsdevel <linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, Shaohua Li <shli-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Steven Whitehouse <swhiteho-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Subject: Re: [PATCH 03/16] uuid: rename uuid types Date: Wed, 10 May 2017 22:15:51 +0300 [thread overview] Message-ID: <CAOQ4uxjSpCgM=RK5jXkuY5HmseQT2EKh_huntvK2ADKBuNqi4A@mail.gmail.com> (raw) In-Reply-To: <20170510180214.16852-4-hch-jcswGhMUV9g@public.gmane.org> On Wed, May 10, 2017 at 9:02 PM, Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> wrote: > Our "little endian" UUID really is a Wintel GUID, so rename it and its > helpers such (guid_t). The big endian UUID is the only true one, so > give it the name uuid_t. The uuid_le and uuid_be names are retained for, > but will hopefully go away soon. > > Also remove the existing typedef in XFS that's now been superceeded by > the generic type name. > > Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> > [andy: also updated the UUID_LE/UUID_BE macros including fallout] > Signed-off-by: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> > --- [...] > > -static inline int uuid_le_cmp(const uuid_le u1, const uuid_le u2) > +static inline int guid_cmp(const guid_t u1, const guid_t u2) > { > - return memcmp(&u1, &u2, sizeof(uuid_le)); > + return memcmp(&u1, &u2, sizeof(guid_t)); > } > > -static inline int uuid_be_cmp(const uuid_be u1, const uuid_be u2) > +static inline int uuid_cmp(const uuid_t u1, const uuid_t u2) > { > - return memcmp(&u1, &u2, sizeof(uuid_be)); > + return memcmp(&u1, &u2, sizeof(uuid_t)); > } > I think we should use this opportunity to change these to (uuid_t *, uuid_t *) which is more in line with the rest of the helpers including the new helpers hoisted from xfs. [...] > +/* backwards compatibility, don't use in new code */ > +#define uuid_le_cmp(u1, u2) guid_cmp(u1, u2) > +#define uuid_be_cmp(u1, u2) uuid_cmp(u1, u2) Therefore: #define uuid_le_cmp(u1, u2) guid_cmp(&(u1), &(u2)) #define uuid_be_cmp(u1, u2) uuid_cmp(&(u1), &(u2))
WARNING: multiple messages have this Message-ID
From: Amir Goldstein <amir73il@gmail.com> To: Christoph Hellwig <hch@lst.de> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, linux-fsdevel <linux-fsdevel@vger.kernel.org>, Shaohua Li <shli@kernel.org>, Dan Williams <dan.j.williams@intel.com>, David Howells <dhowells@redhat.com>, Steven Whitehouse <swhiteho@redhat.com>, Mimi Zohar <zohar@linux.vnet.ibm.com>, linux-xfs <linux-xfs@vger.kernel.org>, linux-raid@vger.kernel.org, linux-nvdimm@ml01.01.org, linux-kernel <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 03/16] uuid: rename uuid types Date: Wed, 10 May 2017 22:15:51 +0300 [thread overview] Message-ID: <CAOQ4uxjSpCgM=RK5jXkuY5HmseQT2EKh_huntvK2ADKBuNqi4A@mail.gmail.com> (raw) In-Reply-To: <20170510180214.16852-4-hch@lst.de> On Wed, May 10, 2017 at 9:02 PM, Christoph Hellwig <hch@lst.de> wrote: > Our "little endian" UUID really is a Wintel GUID, so rename it and its > helpers such (guid_t). The big endian UUID is the only true one, so > give it the name uuid_t. The uuid_le and uuid_be names are retained for, > but will hopefully go away soon. > > Also remove the existing typedef in XFS that's now been superceeded by > the generic type name. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > [andy: also updated the UUID_LE/UUID_BE macros including fallout] > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- [...] > > -static inline int uuid_le_cmp(const uuid_le u1, const uuid_le u2) > +static inline int guid_cmp(const guid_t u1, const guid_t u2) > { > - return memcmp(&u1, &u2, sizeof(uuid_le)); > + return memcmp(&u1, &u2, sizeof(guid_t)); > } > > -static inline int uuid_be_cmp(const uuid_be u1, const uuid_be u2) > +static inline int uuid_cmp(const uuid_t u1, const uuid_t u2) > { > - return memcmp(&u1, &u2, sizeof(uuid_be)); > + return memcmp(&u1, &u2, sizeof(uuid_t)); > } > I think we should use this opportunity to change these to (uuid_t *, uuid_t *) which is more in line with the rest of the helpers including the new helpers hoisted from xfs. [...] > +/* backwards compatibility, don't use in new code */ > +#define uuid_le_cmp(u1, u2) guid_cmp(u1, u2) > +#define uuid_be_cmp(u1, u2) uuid_cmp(u1, u2) Therefore: #define uuid_le_cmp(u1, u2) guid_cmp(&(u1), &(u2)) #define uuid_be_cmp(u1, u2) uuid_cmp(&(u1), &(u2))
WARNING: multiple messages have this Message-ID
From: Amir Goldstein <amir73il@gmail.com> To: Christoph Hellwig <hch@lst.de> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, linux-fsdevel <linux-fsdevel@vger.kernel.org>, Shaohua Li <shli@kernel.org>, Dan Williams <dan.j.williams@intel.com>, David Howells <dhowells@redhat.com>, Steven Whitehouse <swhiteho@redhat.com>, Mimi Zohar <zohar@linux.vnet.ibm.com>, linux-xfs <linux-xfs@vger.kernel.org>, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 03/16] uuid: rename uuid types Date: Wed, 10 May 2017 22:15:51 +0300 [thread overview] Message-ID: <CAOQ4uxjSpCgM=RK5jXkuY5HmseQT2EKh_huntvK2ADKBuNqi4A@mail.gmail.com> (raw) In-Reply-To: <20170510180214.16852-4-hch@lst.de> On Wed, May 10, 2017 at 9:02 PM, Christoph Hellwig <hch@lst.de> wrote: > Our "little endian" UUID really is a Wintel GUID, so rename it and its > helpers such (guid_t). The big endian UUID is the only true one, so > give it the name uuid_t. The uuid_le and uuid_be names are retained for, > but will hopefully go away soon. > > Also remove the existing typedef in XFS that's now been superceeded by > the generic type name. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > [andy: also updated the UUID_LE/UUID_BE macros including fallout] > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- [...] > > -static inline int uuid_le_cmp(const uuid_le u1, const uuid_le u2) > +static inline int guid_cmp(const guid_t u1, const guid_t u2) > { > - return memcmp(&u1, &u2, sizeof(uuid_le)); > + return memcmp(&u1, &u2, sizeof(guid_t)); > } > > -static inline int uuid_be_cmp(const uuid_be u1, const uuid_be u2) > +static inline int uuid_cmp(const uuid_t u1, const uuid_t u2) > { > - return memcmp(&u1, &u2, sizeof(uuid_be)); > + return memcmp(&u1, &u2, sizeof(uuid_t)); > } > I think we should use this opportunity to change these to (uuid_t *, uuid_t *) which is more in line with the rest of the helpers including the new helpers hoisted from xfs. [...] > +/* backwards compatibility, don't use in new code */ > +#define uuid_le_cmp(u1, u2) guid_cmp(u1, u2) > +#define uuid_be_cmp(u1, u2) uuid_cmp(u1, u2) Therefore: #define uuid_le_cmp(u1, u2) guid_cmp(&(u1), &(u2)) #define uuid_be_cmp(u1, u2) uuid_cmp(&(u1), &(u2))
next prev parent reply other threads:[~2017-05-10 19:15 UTC|newest] Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-10 18:01 cleanup UUID types Christoph Hellwig 2017-05-10 18:01 ` Christoph Hellwig 2017-05-10 18:01 ` Christoph Hellwig 2017-05-10 18:01 ` Christoph Hellwig 2017-05-10 18:01 ` [PATCH 01/16] xfs: use uuid_copy() helper to abstract uuid_t Christoph Hellwig 2017-05-10 18:01 ` Christoph Hellwig 2017-05-10 18:01 ` Christoph Hellwig 2017-05-10 18:01 ` Christoph Hellwig 2017-05-10 18:02 ` [PATCH 02/16] xfs: use uuid_be to implement the uuid_t type Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` [PATCH 03/16] uuid: rename uuid types Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 19:15 ` Amir Goldstein [this message] 2017-05-10 19:15 ` Amir Goldstein 2017-05-10 19:15 ` Amir Goldstein 2017-05-10 19:15 ` Amir Goldstein 2017-05-11 7:59 ` Christoph Hellwig 2017-05-11 7:59 ` Christoph Hellwig 2017-05-11 7:59 ` Christoph Hellwig 2017-05-11 7:59 ` Christoph Hellwig 2017-05-11 8:31 ` Amir Goldstein 2017-05-11 8:31 ` Amir Goldstein 2017-05-11 8:31 ` Amir Goldstein 2017-05-11 8:31 ` Amir Goldstein 2017-05-10 18:02 ` [PATCH 04/16] uuid: don't export guid_index and uuid_index Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` [PATCH 05/16] uuid: add the v1 layout to uuid_t Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-11 11:40 ` Andy Shevchenko 2017-05-11 11:40 ` Andy Shevchenko 2017-05-11 11:40 ` Andy Shevchenko 2017-05-11 11:40 ` Andy Shevchenko 2017-05-11 12:07 ` Christoph Hellwig 2017-05-11 12:07 ` Christoph Hellwig 2017-05-11 12:07 ` Christoph Hellwig 2017-05-11 12:07 ` Christoph Hellwig 2017-05-10 18:02 ` [PATCH 06/16] afs: switch to use uuid_t and uuid_gen Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` [PATCH 07/16] uuid: remove struct uuid_v1 Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` [PATCH 08/16] xfs: remove uuid_getnodeuniq and xfs_uu_t Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` [PATCH 09/16] md: namespace private helper names Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` [PATCH 10/16] uuid: hoist helpers uuid_equal() and uuid_copy() from xfs Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` [PATCH 11/16] uuid: hoist uuid_is_null() helper from libnvdimm Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` [PATCH 12/16] xfs: use the common helper uuid_is_null() Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` [PATCH 13/16] block: remove blk_part_pack_uuid Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` [PATCH 14/16] " Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:09 ` Christoph Hellwig 2017-05-10 18:09 ` Christoph Hellwig 2017-05-10 18:09 ` Christoph Hellwig 2017-05-10 18:09 ` Christoph Hellwig 2017-05-10 18:02 ` [PATCH 15/16] ima/policy: switch to use uuid_t Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` [PATCH 16/16] fs: switch ->s_uuid to uuid_t Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 18:02 ` Christoph Hellwig 2017-05-10 19:08 ` Amir Goldstein 2017-05-10 19:08 ` Amir Goldstein 2017-05-10 19:08 ` Amir Goldstein 2017-05-10 19:08 ` Amir Goldstein 2017-05-11 7:58 ` Christoph Hellwig 2017-05-11 7:58 ` Christoph Hellwig 2017-05-11 7:58 ` Christoph Hellwig 2017-05-11 7:58 ` Christoph Hellwig 2017-05-10 18:20 ` [PATCH 03/16] uuid: rename uuid types David Howells 2017-05-10 18:20 ` David Howells 2017-05-10 18:20 ` David Howells 2017-05-10 18:20 ` David Howells 2017-05-11 11:38 ` Andy Shevchenko 2017-05-11 11:38 ` Andy Shevchenko 2017-05-11 11:38 ` Andy Shevchenko 2017-05-11 11:38 ` Andy Shevchenko 2017-05-10 18:21 ` [PATCH 05/16] uuid: add the v1 layout to uuid_t David Howells 2017-05-10 18:21 ` David Howells 2017-05-10 18:21 ` David Howells 2017-05-10 18:21 ` David Howells 2017-05-10 18:22 ` [PATCH 06/16] afs: switch to use uuid_t and uuid_gen David Howells 2017-05-10 18:22 ` David Howells 2017-05-10 18:22 ` David Howells 2017-05-10 18:22 ` David Howells
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAOQ4uxjSpCgM=RK5jXkuY5HmseQT2EKh_huntvK2ADKBuNqi4A@mail.gmail.com' \ --to=amir73il@gmail.com \ --cc=andriy.shevchenko@linux.intel.com \ --cc=dhowells@redhat.com \ --cc=hch@lst.de \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=linux-raid@vger.kernel.org \ --cc=linux-xfs@vger.kernel.org \ --cc=shli@kernel.org \ --cc=swhiteho@redhat.com \ --cc=zohar@linux.vnet.ibm.com \ --subject='Re: [PATCH 03/16] uuid: rename uuid types' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.