From: Carlo Caione <carlo@caione.org>
To: Mark Brown <broonie@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org,
maxime.ripard@free-electrons.com, hdegoede@redhat.com,
emilio@elopez.com.ar, wens@csie.org, sameo@linux.intel.com,
devicetree@vger.kernel.org, dmitry.torokhov@gmail.com,
linux-input@vger.kernel.org, linux-doc@vger.kernel.org,
lgirdwood@gmail.com, linux-sunxi@googlegroups.com
Subject: Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC
Date: Sat, 22 Mar 2014 19:13:36 +0100 [thread overview]
Message-ID: <CAOQ7t2Yg5pp_rXYfsdnHpy-zGFGimzT3EW15P_0ugYMtgPtOrw@mail.gmail.com> (raw)
In-Reply-To: <20140322173313.GU552@sirena.org.uk>
On Sat, Mar 22, 2014 at 6:33 PM, Mark Brown <broonie@kernel.org> wrote:
> On Sat, Mar 22, 2014 at 05:51:32PM +0100, Carlo Caione wrote:
>> On Tue, Mar 18, 2014 at 03:59:19PM +0000, Lee Jones wrote:
>
>> > > + of_id = of_match_device(axp20x_of_match, &i2c->dev);
>> > > + if (!of_id) {
>> > > + dev_err(&i2c->dev, "Unable to setup AXP20X data\n");
>> > > + return -ENODEV;
>> > > + }
>> > > + axp20x->variant = (int) of_id->data;
>
>> > No need to cast from void *.
>
>> My compiler says otherwise :)
>
> Are you sure your compiler isn't correctly telling you not to cast away
> const? If the compiler is complaining about a cast on void then it's
> spotted a definite bug.
[resend since gmail decided to not put broonie in CC]
drivers/mfd/axp20x.c:172:18: warning: assignment makes integer
frompointer without a cast [enabled by default]
--
Carlo Caione
WARNING: multiple messages have this Message-ID (diff)
From: carlo@caione.org (Carlo Caione)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC
Date: Sat, 22 Mar 2014 19:13:36 +0100 [thread overview]
Message-ID: <CAOQ7t2Yg5pp_rXYfsdnHpy-zGFGimzT3EW15P_0ugYMtgPtOrw@mail.gmail.com> (raw)
In-Reply-To: <20140322173313.GU552@sirena.org.uk>
On Sat, Mar 22, 2014 at 6:33 PM, Mark Brown <broonie@kernel.org> wrote:
> On Sat, Mar 22, 2014 at 05:51:32PM +0100, Carlo Caione wrote:
>> On Tue, Mar 18, 2014 at 03:59:19PM +0000, Lee Jones wrote:
>
>> > > + of_id = of_match_device(axp20x_of_match, &i2c->dev);
>> > > + if (!of_id) {
>> > > + dev_err(&i2c->dev, "Unable to setup AXP20X data\n");
>> > > + return -ENODEV;
>> > > + }
>> > > + axp20x->variant = (int) of_id->data;
>
>> > No need to cast from void *.
>
>> My compiler says otherwise :)
>
> Are you sure your compiler isn't correctly telling you not to cast away
> const? If the compiler is complaining about a cast on void then it's
> spotted a definite bug.
[resend since gmail decided to not put broonie in CC]
drivers/mfd/axp20x.c:172:18: warning: assignment makes integer
frompointer without a cast [enabled by default]
--
Carlo Caione
next prev parent reply other threads:[~2014-03-22 18:13 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-15 15:43 [PATCH v2 0/8] mfd: AXP20x: Add support for AXP202 and AXP209 Carlo Caione
2014-03-15 15:43 ` Carlo Caione
[not found] ` <1394898225-28452-1-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
2014-03-15 15:43 ` [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC Carlo Caione
2014-03-15 15:43 ` Carlo Caione
[not found] ` <1394898225-28452-2-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
2014-03-18 15:59 ` Lee Jones
2014-03-18 15:59 ` Lee Jones
2014-03-22 16:51 ` Carlo Caione
2014-03-22 16:51 ` [linux-sunxi] " Carlo Caione
[not found] ` <20140322165132.GC20668-bi+AKbBUZKZeIdyRz4JgOMwOAu8XWILU@public.gmane.org>
2014-03-22 17:33 ` Mark Brown
2014-03-22 17:33 ` [linux-sunxi] " Mark Brown
[not found] ` <20140322173313.GU552-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-03-22 18:05 ` Carlo Caione
2014-03-22 18:05 ` [linux-sunxi] " Carlo Caione
2014-03-22 18:13 ` Carlo Caione [this message]
2014-03-22 18:13 ` Carlo Caione
[not found] ` <CAOQ7t2Yg5pp_rXYfsdnHpy-zGFGimzT3EW15P_0ugYMtgPtOrw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-22 18:42 ` Dmitry Torokhov
2014-03-22 18:42 ` [linux-sunxi] " Dmitry Torokhov
[not found] ` <20140322184201.GA27611-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2014-03-22 19:08 ` Carlo Caione
2014-03-22 19:08 ` [linux-sunxi] " Carlo Caione
[not found] ` <20140322190803.GA20987-bi+AKbBUZKZeIdyRz4JgOMwOAu8XWILU@public.gmane.org>
2014-03-22 19:29 ` Mark Brown
2014-03-22 19:29 ` [linux-sunxi] " Mark Brown
2014-03-24 8:34 ` Lee Jones
2014-03-24 8:34 ` [linux-sunxi] " Lee Jones
2014-03-15 15:43 ` [PATCH v2 2/8] mfd: AXP20x: Add bindings documentation Carlo Caione
2014-03-15 15:43 ` Carlo Caione
[not found] ` <1394898225-28452-3-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
2014-03-18 8:45 ` Maxime Ripard
2014-03-18 8:45 ` Maxime Ripard
2014-03-22 14:11 ` Carlo Caione
2014-03-22 14:11 ` [linux-sunxi] " Carlo Caione
[not found] ` <20140322141157.GA20668-bi+AKbBUZKZeIdyRz4JgOMwOAu8XWILU@public.gmane.org>
2014-03-25 10:11 ` Maxime Ripard
2014-03-25 10:11 ` [linux-sunxi] " Maxime Ripard
2014-03-15 15:43 ` [PATCH v2 3/8] input: misc: Add driver for AXP20x Power Enable Key Carlo Caione
2014-03-15 15:43 ` Carlo Caione
[not found] ` <1394898225-28452-4-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
2014-03-18 9:00 ` Maxime Ripard
2014-03-18 9:00 ` Maxime Ripard
2014-03-18 9:50 ` Lee Jones
2014-03-18 9:50 ` Lee Jones
2014-03-18 10:15 ` Maxime Ripard
2014-03-18 10:15 ` Maxime Ripard
2014-03-18 10:58 ` Lee Jones
2014-03-18 10:58 ` Lee Jones
2014-03-18 14:03 ` Maxime Ripard
2014-03-18 14:03 ` Maxime Ripard
2014-03-15 15:43 ` [PATCH v2 4/8] input: misc: Add ABI docs for AXP20x PEK Carlo Caione
2014-03-15 15:43 ` Carlo Caione
2014-03-15 15:43 ` [PATCH v2 5/8] regulator: AXP20x: Add support for regulators subsystem Carlo Caione
2014-03-15 15:43 ` Carlo Caione
2014-03-17 8:19 ` Krzysztof Kozlowski
2014-03-17 8:19 ` Krzysztof Kozlowski
[not found] ` <1394898225-28452-6-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
2014-03-17 17:33 ` Mark Brown
2014-03-17 17:33 ` Mark Brown
2014-03-15 15:43 ` [PATCH v2 6/8] ARM: sunxi: dt: Add x-powers-axp209.dtsi file Carlo Caione
2014-03-15 15:43 ` Carlo Caione
[not found] ` <1394898225-28452-7-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
2014-03-18 9:04 ` Maxime Ripard
2014-03-18 9:04 ` Maxime Ripard
2014-03-22 14:31 ` Carlo Caione
2014-03-22 14:31 ` [linux-sunxi] " Carlo Caione
[not found] ` <20140322143157.GB20668-bi+AKbBUZKZeIdyRz4JgOMwOAu8XWILU@public.gmane.org>
2014-03-25 10:11 ` Maxime Ripard
2014-03-25 10:11 ` [linux-sunxi] " Maxime Ripard
2014-03-15 15:43 ` [PATCH v2 7/8] ARM: sun7i: dt: Add AXP209 support to various boards Carlo Caione
2014-03-15 15:43 ` Carlo Caione
[not found] ` <1394898225-28452-8-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
2014-03-15 15:45 ` Hans de Goede
2014-03-15 15:45 ` Hans de Goede
[not found] ` <53247584.8060701-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-03-15 15:48 ` Carlo Caione
2014-03-15 15:48 ` Carlo Caione
2014-03-15 15:43 ` [PATCH v2 8/8] ARM: sunxi: Add AXP20x support in defconfig Carlo Caione
2014-03-15 15:43 ` Carlo Caione
[not found] ` <1394898225-28452-9-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
2014-03-18 9:05 ` Maxime Ripard
2014-03-18 9:05 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQ7t2Yg5pp_rXYfsdnHpy-zGFGimzT3EW15P_0ugYMtgPtOrw@mail.gmail.com \
--to=carlo@caione.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=emilio@elopez.com.ar \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=sameo@linux.intel.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.