* Re: [PATCH] hw/i386/kvm/ioapic.c: fix typo in error message
2020-07-17 12:35 [PATCH] hw/i386/kvm/ioapic.c: fix typo in error message Kenta Ishiguro
@ 2020-07-20 8:24 ` Stefano Garzarella
2020-07-20 9:31 ` Philippe Mathieu-Daudé
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Stefano Garzarella @ 2020-07-20 8:24 UTC (permalink / raw)
To: Kenta Ishiguro; +Cc: qemu-trivial, qemu-devel
+Cc qemu-trivial@nongnu.org
On Fri, Jul 17, 2020 at 09:35:14PM +0900, Kenta Ishiguro wrote:
> Fix a typo in an error message for KVM_SET_IRQCHIP ioctl:
> "KVM_GET_IRQCHIP" should be "KVM_SET_IRQCHIP".
>
> Signed-off-by: Kenta Ishiguro <kentaishiguro@slowstart.org>
> ---
> hw/i386/kvm/ioapic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/kvm/ioapic.c b/hw/i386/kvm/ioapic.c
> index 4ba8e47251..c5528df942 100644
> --- a/hw/i386/kvm/ioapic.c
> +++ b/hw/i386/kvm/ioapic.c
> @@ -97,7 +97,7 @@ static void kvm_ioapic_put(IOAPICCommonState *s)
>
> ret = kvm_vm_ioctl(kvm_state, KVM_SET_IRQCHIP, &chip);
> if (ret < 0) {
> - fprintf(stderr, "KVM_GET_IRQCHIP failed: %s\n", strerror(ret));
> + fprintf(stderr, "KVM_SET_IRQCHIP failed: %s\n", strerror(ret));
> abort();
> }
> }
> --
> 2.17.1
>
>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] hw/i386/kvm/ioapic.c: fix typo in error message
2020-07-17 12:35 [PATCH] hw/i386/kvm/ioapic.c: fix typo in error message Kenta Ishiguro
2020-07-20 8:24 ` Stefano Garzarella
@ 2020-07-20 9:31 ` Philippe Mathieu-Daudé
2020-07-20 9:55 ` Kenta Ishiguro
2020-07-21 1:01 ` Li Qiang
2020-09-01 7:00 ` Laurent Vivier
3 siblings, 1 reply; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-07-20 9:31 UTC (permalink / raw)
To: Kenta Ishiguro, qemu-devel
On 7/17/20 2:35 PM, Kenta Ishiguro wrote:
> Fix a typo in an error message for KVM_SET_IRQCHIP ioctl:
> "KVM_GET_IRQCHIP" should be "KVM_SET_IRQCHIP".
>
> Signed-off-by: Kenta Ishiguro <kentaishiguro@slowstart.org>
> ---
> hw/i386/kvm/ioapic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/kvm/ioapic.c b/hw/i386/kvm/ioapic.c
> index 4ba8e47251..c5528df942 100644
> --- a/hw/i386/kvm/ioapic.c
> +++ b/hw/i386/kvm/ioapic.c
> @@ -97,7 +97,7 @@ static void kvm_ioapic_put(IOAPICCommonState *s)
>
> ret = kvm_vm_ioctl(kvm_state, KVM_SET_IRQCHIP, &chip);
> if (ret < 0) {
> - fprintf(stderr, "KVM_GET_IRQCHIP failed: %s\n", strerror(ret));
> + fprintf(stderr, "KVM_SET_IRQCHIP failed: %s\n", strerror(ret));
> abort();
9 years later this abort seems violent. Kenta, did it fired for you?
> }
> }
>
Fixes: a39c1d47ac ("kvm: x86: Add user space part for in-kernel IOAPIC")
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] hw/i386/kvm/ioapic.c: fix typo in error message
2020-07-20 9:31 ` Philippe Mathieu-Daudé
@ 2020-07-20 9:55 ` Kenta Ishiguro
0 siblings, 0 replies; 6+ messages in thread
From: Kenta Ishiguro @ 2020-07-20 9:55 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]
No, it didn't.
I just checked the usage of this API and I found this inconsistent error
message.
On Mon, Jul 20, 2020 at 6:31 PM Philippe Mathieu-Daudé <philmd@redhat.com>
wrote:
> On 7/17/20 2:35 PM, Kenta Ishiguro wrote:
> > Fix a typo in an error message for KVM_SET_IRQCHIP ioctl:
> > "KVM_GET_IRQCHIP" should be "KVM_SET_IRQCHIP".
> >
> > Signed-off-by: Kenta Ishiguro <kentaishiguro@slowstart.org>
> > ---
> > hw/i386/kvm/ioapic.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/i386/kvm/ioapic.c b/hw/i386/kvm/ioapic.c
> > index 4ba8e47251..c5528df942 100644
> > --- a/hw/i386/kvm/ioapic.c
> > +++ b/hw/i386/kvm/ioapic.c
> > @@ -97,7 +97,7 @@ static void kvm_ioapic_put(IOAPICCommonState *s)
> >
> > ret = kvm_vm_ioctl(kvm_state, KVM_SET_IRQCHIP, &chip);
> > if (ret < 0) {
> > - fprintf(stderr, "KVM_GET_IRQCHIP failed: %s\n", strerror(ret));
> > + fprintf(stderr, "KVM_SET_IRQCHIP failed: %s\n", strerror(ret));
> > abort();
>
> 9 years later this abort seems violent. Kenta, did it fired for you?
>
> > }
> > }
> >
>
> Fixes: a39c1d47ac ("kvm: x86: Add user space part for in-kernel IOAPIC")
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
>
[-- Attachment #2: Type: text/html, Size: 1929 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] hw/i386/kvm/ioapic.c: fix typo in error message
2020-07-17 12:35 [PATCH] hw/i386/kvm/ioapic.c: fix typo in error message Kenta Ishiguro
2020-07-20 8:24 ` Stefano Garzarella
2020-07-20 9:31 ` Philippe Mathieu-Daudé
@ 2020-07-21 1:01 ` Li Qiang
2020-09-01 7:00 ` Laurent Vivier
3 siblings, 0 replies; 6+ messages in thread
From: Li Qiang @ 2020-07-21 1:01 UTC (permalink / raw)
To: Kenta Ishiguro; +Cc: Qemu Developers
Kenta Ishiguro <kentaishiguro@slowstart.org> 于2020年7月20日周一 上午11:14写道：
>
> Fix a typo in an error message for KVM_SET_IRQCHIP ioctl:
> "KVM_GET_IRQCHIP" should be "KVM_SET_IRQCHIP".
>
> Signed-off-by: Kenta Ishiguro <kentaishiguro@slowstart.org>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
> ---
> hw/i386/kvm/ioapic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/kvm/ioapic.c b/hw/i386/kvm/ioapic.c
> index 4ba8e47251..c5528df942 100644
> --- a/hw/i386/kvm/ioapic.c
> +++ b/hw/i386/kvm/ioapic.c
> @@ -97,7 +97,7 @@ static void kvm_ioapic_put(IOAPICCommonState *s)
>
> ret = kvm_vm_ioctl(kvm_state, KVM_SET_IRQCHIP, &chip);
> if (ret < 0) {
> - fprintf(stderr, "KVM_GET_IRQCHIP failed: %s\n", strerror(ret));
> + fprintf(stderr, "KVM_SET_IRQCHIP failed: %s\n", strerror(ret));
> abort();
> }
> }
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] hw/i386/kvm/ioapic.c: fix typo in error message
2020-07-17 12:35 [PATCH] hw/i386/kvm/ioapic.c: fix typo in error message Kenta Ishiguro
` (2 preceding siblings ...)
2020-07-21 1:01 ` Li Qiang
@ 2020-09-01 7:00 ` Laurent Vivier
3 siblings, 0 replies; 6+ messages in thread
From: Laurent Vivier @ 2020-09-01 7:00 UTC (permalink / raw)
To: Kenta Ishiguro, qemu-devel; +Cc: qemu-trivial
Le 17/07/2020 à 14:35, Kenta Ishiguro a écrit :
> Fix a typo in an error message for KVM_SET_IRQCHIP ioctl:
> "KVM_GET_IRQCHIP" should be "KVM_SET_IRQCHIP".
>
> Signed-off-by: Kenta Ishiguro <kentaishiguro@slowstart.org>
> ---
> hw/i386/kvm/ioapic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/kvm/ioapic.c b/hw/i386/kvm/ioapic.c
> index 4ba8e47251..c5528df942 100644
> --- a/hw/i386/kvm/ioapic.c
> +++ b/hw/i386/kvm/ioapic.c
> @@ -97,7 +97,7 @@ static void kvm_ioapic_put(IOAPICCommonState *s)
>
> ret = kvm_vm_ioctl(kvm_state, KVM_SET_IRQCHIP, &chip);
> if (ret < 0) {
> - fprintf(stderr, "KVM_GET_IRQCHIP failed: %s\n", strerror(ret));
> + fprintf(stderr, "KVM_SET_IRQCHIP failed: %s\n", strerror(ret));
> abort();
> }
> }
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 6+ messages in thread