why does gupnp depends on gnome-icon-theme?

why does gupnp depends on gnome-icon-theme?

[Nicolas Dechesne]

hi there,

i have noticed that gupnp (in meta-multimedia/recipes-connectivity)
depends on gnome-icon-theme, and I don't really understand why, see

http://cgit.openembedded.org/meta-openembedded/tree/meta-multimedia/recipes-connectivity/gupnp/gupnp.inc#n5

i was able to build an image with gupnp even after patching DEPENDS to
get rid of the dependency, and the main concern with this dependency
is that it brings:

RRECOMMENDS_${PN} = "librsvg-gtk"
and as such attempts to build gtk+, while I am trying to make a
directfb image without GTK.

so, is there any specific reason why there is such a dependency?

thanks!

nicolas

Re: why does gupnp depends on gnome-icon-theme?

[Burton, Ross]

On 10 April 2013 14:12, Nicolas Dechesne <ndec13@gmail.com> wrote:
> i have noticed that gupnp (in meta-multimedia/recipes-connectivity)
> depends on gnome-icon-theme, and I don't really understand why, see
>
> http://cgit.openembedded.org/meta-openembedded/tree/meta-multimedia/recipes-connectivity/gupnp/gupnp.inc#n5

That's historical, the only dependency on g-i-t is in gupnp-tools.
Patch welcome to remove it!

> i was able to build an image with gupnp even after patching DEPENDS to
> get rid of the dependency, and the main concern with this dependency
> is that it brings:
>
> RRECOMMENDS_${PN} = "librsvg-gtk"
> and as such attempts to build gtk+, while I am trying to make a
> directfb image without GTK.

That's also a bit annoying isn't it...  Maybe that should be removed
generally, and we'll leave it to distros/products to decide/know
whether they are using SVG icons or not.

Ross

Re: why does gupnp depends on gnome-icon-theme?

[Nicolas Dechesne]

On Wed, Apr 10, 2013 at 3:40 PM, Burton, Ross <ross.burton@intel.com> wrote:
>> i have noticed that gupnp (in meta-multimedia/recipes-connectivity)
>> depends on gnome-icon-theme, and I don't really understand why, see
>>
>> http://cgit.openembedded.org/meta-openembedded/tree/meta-multimedia/recipes-connectivity/gupnp/gupnp.inc#n5
>
> That's historical, the only dependency on g-i-t is in gupnp-tools.
> Patch welcome to remove it!

ok. thanks. will send shortly.

>
>> i was able to build an image with gupnp even after patching DEPENDS to
>> get rid of the dependency, and the main concern with this dependency
>> is that it brings:
>>
>> RRECOMMENDS_${PN} = "librsvg-gtk"
>> and as such attempts to build gtk+, while I am trying to make a
>> directfb image without GTK.
>
> That's also a bit annoying isn't it...  Maybe that should be removed
> generally, and we'll leave it to distros/products to decide/know
> whether they are using SVG icons or not.

i will not send this one, as i think more discussions might be
needed... and my initial issue is fixed with the first patch anyways.

Re: why does gupnp depends on gnome-icon-theme?

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]

On Wed, Apr 10, 2013 at 02:40:16PM +0100, Burton, Ross wrote:
> On 10 April 2013 14:12, Nicolas Dechesne <ndec13@gmail.com> wrote:
> > i have noticed that gupnp (in meta-multimedia/recipes-connectivity)
> > depends on gnome-icon-theme, and I don't really understand why, see
> >
> > http://cgit.openembedded.org/meta-openembedded/tree/meta-multimedia/recipes-connectivity/gupnp/gupnp.inc#n5
> 
> That's historical, the only dependency on g-i-t is in gupnp-tools.
> Patch welcome to remove it!
> 
> > i was able to build an image with gupnp even after patching DEPENDS to
> > get rid of the dependency, and the main concern with this dependency
> > is that it brings:
> >
> > RRECOMMENDS_${PN} = "librsvg-gtk"
> > and as such attempts to build gtk+, while I am trying to make a
> > directfb image without GTK.
> 
> That's also a bit annoying isn't it...  Maybe that should be removed
> generally, and we'll leave it to distros/products to decide/know
> whether they are using SVG icons or not.

Well I'm not sure if it's still segfaulting like before, but e.g. midori
was segfaulting when loading some pages without gtk-theme-clearlooks or
some other usable theme :/. That's why we keep .bbappend with added
RDEPENDS to change gtk-theme :/.

https://github.com/shr-distribution/meta-smartphone/blob/shr/meta-shr/recipes-connectivity/midori/midori_0.5.0.bbappend

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]