[PATCH] OEToolchainConfig.cmake: Remove CMAKE_FIND_ROOT_PATH

[PATCH] OEToolchainConfig.cmake: Remove CMAKE_FIND_ROOT_PATH

[Cristian Morales Vega]

Since cb42802f2fe CMAKE_SYSROOT has been set, making
CMAKE_FIND_ROOT_PATH unnecessary.
It also overwrites any CMAKE_FIND_ROOT_PATH the user may have provided,
which is wrong.
---
I am using this file because I received it as part of a Yocto SDK. I
have never used OpenEmbedded, I guess this can potentially break
something. Test before merging.

 meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake b/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake
index 8f6f3a272d..4403f8aa9c 100644
--- a/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake
+++ b/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake
@@ -5,7 +5,6 @@ set( CMAKE_ASM_FLAGS ${CMAKE_C_FLAGS} CACHE STRING "" FORCE )
 set( CMAKE_LDFLAGS_FLAGS ${CMAKE_CXX_FLAGS} CACHE STRING "" FORCE )
 set( CMAKE_SYSROOT $ENV{OECORE_TARGET_SYSROOT} )
 
-set( CMAKE_FIND_ROOT_PATH $ENV{OECORE_TARGET_SYSROOT} )
 set( CMAKE_FIND_ROOT_PATH_MODE_PROGRAM NEVER )
 set( CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY )
 set( CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY )
-- 
2.31.1

Re: [PATCH] OEToolchainConfig.cmake: Remove CMAKE_FIND_ROOT_PATH

[Cristian Morales Vega]

Any feedback?

At the very least it should be
list( APPEND CMAKE_FIND_ROOT_PATH $ENV{OECORE_TARGET_SYSROOT} )
to avoid ignoring user input.

In general the file could use some love:

> set( CMAKE_C_FLAGS $ENV{CFLAGS} CACHE STRING "" FORCE )

Why? cmake already reads CFLAGS from the environment and toolchain
files are supposed to use CMAKE_C_FLAGS_INIT anyway.

> set( CMAKE_CXX_FLAGS $ENV{CXXFLAGS}  CACHE STRING "" FORCE )

Same.

> set( CMAKE_ASM_FLAGS ${CMAKE_C_FLAGS} CACHE STRING "" FORCE )

I wonder why this is needed, and CMAKE_ASM_FLAGS_INIT.

> set( CMAKE_LDFLAGS_FLAGS ${CMAKE_CXX_FLAGS} CACHE STRING "" FORCE )

This isn't even a real cmake variable. If any package depends on it
it's broken and it should be patched.
The actual variables would be CMAKE_EXE_LINKER_FLAGS_INIT,
CMAKE_MODULE_LINKER_FLAGS_INIT and CMAKE_SHARED_LINKER_FLAGS_INIT.


On Tue, 11 May 2021 at 22:36, Cristian Morales Vega
<christian.morales.vega@gmail.com> wrote:
>
> Since cb42802f2fe CMAKE_SYSROOT has been set, making
> CMAKE_FIND_ROOT_PATH unnecessary.
> It also overwrites any CMAKE_FIND_ROOT_PATH the user may have provided,
> which is wrong.
> ---
> I am using this file because I received it as part of a Yocto SDK. I
> have never used OpenEmbedded, I guess this can potentially break
> something. Test before merging.
>
>  meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake b/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake
> index 8f6f3a272d..4403f8aa9c 100644
> --- a/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake
> +++ b/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake
> @@ -5,7 +5,6 @@ set( CMAKE_ASM_FLAGS ${CMAKE_C_FLAGS} CACHE STRING "" FORCE )
>  set( CMAKE_LDFLAGS_FLAGS ${CMAKE_CXX_FLAGS} CACHE STRING "" FORCE )
>  set( CMAKE_SYSROOT $ENV{OECORE_TARGET_SYSROOT} )
>
> -set( CMAKE_FIND_ROOT_PATH $ENV{OECORE_TARGET_SYSROOT} )
>  set( CMAKE_FIND_ROOT_PATH_MODE_PROGRAM NEVER )
>  set( CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY )
>  set( CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY )
> --
> 2.31.1
>