All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/mdio-tools: new package
@ 2022-09-28 19:23 Robert Marko
  2022-10-01 18:51 ` Yann E. MORIN
  0 siblings, 1 reply; 3+ messages in thread
From: Robert Marko @ 2022-09-28 19:23 UTC (permalink / raw)
  To: buildroot; +Cc: Robert Marko, Thomas Petazzoni

mdio-tools are kernel module and accompanying tools for low-level
debugging of devices attached on MDIO bus like PHY-s, switches etc.

Userspace tools provide C22 or C45 reads and writes, benchmarking
and even dedicated Marvell Link Street tools via the included
kernel module.

Signed-off-by: Robert Marko <robimarko@gmail.com>
---
 package/Config.in                  |  1 +
 package/mdio-tools/Config.in       |  9 +++++++++
 package/mdio-tools/mdio-tools.hash |  3 +++
 package/mdio-tools/mdio-tools.mk   | 16 ++++++++++++++++
 4 files changed, 29 insertions(+)
 create mode 100644 package/mdio-tools/Config.in
 create mode 100644 package/mdio-tools/mdio-tools.hash
 create mode 100644 package/mdio-tools/mdio-tools.mk

diff --git a/package/Config.in b/package/Config.in
index e3a34d6e97..ed41e8bdd4 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -536,6 +536,7 @@ endmenu
 	source "package/mbpfan/Config.in"
 	source "package/mdadm/Config.in"
 	source "package/mdevd/Config.in"
+	source "package/mdio-tools/Config.in"
 	source "package/memtest86/Config.in"
 	source "package/memtester/Config.in"
 	source "package/memtool/Config.in"
diff --git a/package/mdio-tools/Config.in b/package/mdio-tools/Config.in
new file mode 100644
index 0000000000..feb1e825ac
--- /dev/null
+++ b/package/mdio-tools/Config.in
@@ -0,0 +1,9 @@
+comment "mdio-tools needs a Linux kernel to be built"
+	depends on !BR2_LINUX_KERNEL
+
+config BR2_PACKAGE_MDIO_TOOLS
+	bool "mdio-tools"
+	depends on BR2_LINUX_KERNEL
+	select BR2_PACKAGE_LIBMNL
+	help
+	  Low-level debug tools for MDIO devices
diff --git a/package/mdio-tools/mdio-tools.hash b/package/mdio-tools/mdio-tools.hash
new file mode 100644
index 0000000000..0111165f27
--- /dev/null
+++ b/package/mdio-tools/mdio-tools.hash
@@ -0,0 +1,3 @@
+# Locally computed
+sha256  c5e17431c62392f6c1da1ba4fb0a6f5918521509a377af74485851f93ff2a106  mdio-tools-1.2.0.tar.gz
+sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
diff --git a/package/mdio-tools/mdio-tools.mk b/package/mdio-tools/mdio-tools.mk
new file mode 100644
index 0000000000..e4ea6f8224
--- /dev/null
+++ b/package/mdio-tools/mdio-tools.mk
@@ -0,0 +1,16 @@
+################################################################################
+#
+# mdio-tools
+#
+################################################################################
+
+MDIO_TOOLS_VERSION = 1.2.0
+MDIO_TOOLS_SITE = https://github.com/wkz/mdio-tools/releases/download/$(MDIO_TOOLS_VERSION)
+MDIO_TOOLS_LICENSE = GPL-2.0-only
+MDIO_TOOLS_LICENSE_FILES = COPYING
+MDIO_TOOLS_DEPENDENCIES = libmnl
+
+MDIO_TOOLS_MODULE_SUBDIRS = kernel
+
+$(eval $(kernel-module))
+$(eval $(autotools-package))
-- 
2.37.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/mdio-tools: new package
  2022-09-28 19:23 [Buildroot] [PATCH] package/mdio-tools: new package Robert Marko
@ 2022-10-01 18:51 ` Yann E. MORIN
  2022-10-01 19:05   ` Robert Marko
  0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2022-10-01 18:51 UTC (permalink / raw)
  To: Robert Marko; +Cc: Thomas Petazzoni, buildroot

Robert, All,

On 2022-09-28 21:23 +0200, Robert Marko spake thusly:
> mdio-tools are kernel module and accompanying tools for low-level
> debugging of devices attached on MDIO bus like PHY-s, switches etc.
> 
> Userspace tools provide C22 or C45 reads and writes, benchmarking
> and even dedicated Marvell Link Street tools via the included
> kernel module.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
[--SNIP--]
> diff --git a/package/mdio-tools/mdio-tools.mk b/package/mdio-tools/mdio-tools.mk
> new file mode 100644
> index 0000000000..e4ea6f8224
> --- /dev/null
> +++ b/package/mdio-tools/mdio-tools.mk
> @@ -0,0 +1,16 @@
> +################################################################################
> +#
> +# mdio-tools
> +#
> +################################################################################
> +
> +MDIO_TOOLS_VERSION = 1.2.0
> +MDIO_TOOLS_SITE = https://github.com/wkz/mdio-tools/releases/download/$(MDIO_TOOLS_VERSION)
> +MDIO_TOOLS_LICENSE = GPL-2.0-only

We do not strictly follow the SPDX nomenclature (because we somewhat
predate it), so for consistency, this should be just 'GPL-2.0'.

> +MDIO_TOOLS_LICENSE_FILES = COPYING
> +MDIO_TOOLS_DEPENDENCIES = libmnl

mdio-tools uses pkg-config to look for libmnl, so you also need to add
host-pkgconf to the _DEPENDENCES.

> +MDIO_TOOLS_MODULE_SUBDIRS = kernel

I did not have a thorough look, but doesn't mdio-tools need some kernel
options to always be enabled? IF so, you can do so with:

    define MDIO_TOOLS_LINUX_CONFIG_FIXUPS
        $(call KCONFIG_ENABLE_OPT,CONFIG_MDIO)
    endef

(given the package name, it should at least require that, I'd guess, but
adapt as needed.)

If there had been only the license and host-pkgconf issues, I'd have
fixed those when applying. But the kernel options are a bit more
involved, and requie someone who actually knows and uses mdio-tools, to
come up with the required options. Can you look into that, please?

Regards,
Yann E. MORIN.

> +$(eval $(kernel-module))
> +$(eval $(autotools-package))
> -- 
> 2.37.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/mdio-tools: new package
  2022-10-01 18:51 ` Yann E. MORIN
@ 2022-10-01 19:05   ` Robert Marko
  0 siblings, 0 replies; 3+ messages in thread
From: Robert Marko @ 2022-10-01 19:05 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: Thomas Petazzoni, buildroot

On Sat, 1 Oct 2022 at 20:51, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> Robert, All,
>
> On 2022-09-28 21:23 +0200, Robert Marko spake thusly:
> > mdio-tools are kernel module and accompanying tools for low-level
> > debugging of devices attached on MDIO bus like PHY-s, switches etc.
> >
> > Userspace tools provide C22 or C45 reads and writes, benchmarking
> > and even dedicated Marvell Link Street tools via the included
> > kernel module.
> >
> > Signed-off-by: Robert Marko <robimarko@gmail.com>
> > ---
> [--SNIP--]
> > diff --git a/package/mdio-tools/mdio-tools.mk b/package/mdio-tools/mdio-tools.mk
> > new file mode 100644
> > index 0000000000..e4ea6f8224
> > --- /dev/null
> > +++ b/package/mdio-tools/mdio-tools.mk
> > @@ -0,0 +1,16 @@
> > +################################################################################
> > +#
> > +# mdio-tools
> > +#
> > +################################################################################
> > +
> > +MDIO_TOOLS_VERSION = 1.2.0
> > +MDIO_TOOLS_SITE = https://github.com/wkz/mdio-tools/releases/download/$(MDIO_TOOLS_VERSION)
> > +MDIO_TOOLS_LICENSE = GPL-2.0-only
>
> We do not strictly follow the SPDX nomenclature (because we somewhat
> predate it), so for consistency, this should be just 'GPL-2.0'.

Hi,
I will change it, wasn't really sure what was appropriate so I went with SPDX.

>
> > +MDIO_TOOLS_LICENSE_FILES = COPYING
> > +MDIO_TOOLS_DEPENDENCIES = libmnl
>
> mdio-tools uses pkg-config to look for libmnl, so you also need to add
> host-pkgconf to the _DEPENDENCES.

Will fixup in v2.

>
> > +MDIO_TOOLS_MODULE_SUBDIRS = kernel
>
> I did not have a thorough look, but doesn't mdio-tools need some kernel
> options to always be enabled? IF so, you can do so with:
>
>     define MDIO_TOOLS_LINUX_CONFIG_FIXUPS
>         $(call KCONFIG_ENABLE_OPT,CONFIG_MDIO)
>     endef
>
> (given the package name, it should at least require that, I'd guess, but
> adapt as needed.)

Thanks for reminding me of this, haven't really though of that, but as far as
I can tell it basically needs generic netlink which gets compiled if CONFIG_NET
is set, that is minimum.

CONFIG_MDIO_DEVICE is then required so that mdio buses actually can
be used.

>
> If there had been only the license and host-pkgconf issues, I'd have
> fixed those when applying. But the kernel options are a bit more
> involved, and requie someone who actually knows and uses mdio-tools, to
> come up with the required options. Can you look into that, please?

Will fix this up v2, thanks for the review.
Regards,
Robert
>
> Regards,
> Yann E. MORIN.
>
> > +$(eval $(kernel-module))
> > +$(eval $(autotools-package))
> > --
> > 2.37.3
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-01 19:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-28 19:23 [Buildroot] [PATCH] package/mdio-tools: new package Robert Marko
2022-10-01 18:51 ` Yann E. MORIN
2022-10-01 19:05   ` Robert Marko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.