* [PATCH 1/2] powerpc/e500: make load_up_spe a normal fuction
@ 2012-02-27 10:59 ` Olivia Yin
0 siblings, 0 replies; 14+ messages in thread
From: Olivia Yin @ 2012-02-27 10:59 UTC (permalink / raw)
To: kvm-ppc, kvm, linuxppc-dev; +Cc: Olivia Yin, Liu Yu
So that we can call it in kernel.
Signed-off-by: Liu Yu <yu.liu@freescale.com>
---
arch/powerpc/kernel/head_fsl_booke.S | 23 ++++++-----------------
1 files changed, 6 insertions(+), 17 deletions(-)
diff --git a/arch/powerpc/kernel/head_fsl_booke.S b/arch/powerpc/kernel/head_fsl_booke.S
index d5d78c4..c96e025 100644
--- a/arch/powerpc/kernel/head_fsl_booke.S
+++ b/arch/powerpc/kernel/head_fsl_booke.S
@@ -539,8 +539,10 @@ interrupt_base:
/* SPE Unavailable */
START_EXCEPTION(SPEUnavailable)
NORMAL_EXCEPTION_PROLOG
- bne load_up_spe
- addi r3,r1,STACK_FRAME_OVERHEAD
+ beq 1f
+ bl load_up_spe
+ b fast_exception_return
+1: addi r3,r1,STACK_FRAME_OVERHEAD
EXC_XFER_EE_LITE(0x2010, KernelSPE)
#else
EXCEPTION(0x2020, SPEUnavailable, unknown_exception, EXC_XFER_EE)
@@ -743,7 +745,7 @@ tlb_write_entry:
/* Note that the SPE support is closely modeled after the AltiVec
* support. Changes to one are likely to be applicable to the
* other! */
-load_up_spe:
+_GLOBAL(load_up_spe)
/*
* Disable SPE for the task which had SPE previously,
* and save its SPE registers in its thread_struct.
@@ -791,20 +793,7 @@ load_up_spe:
subi r4,r5,THREAD
stw r4,last_task_used_spe@l(r3)
#endif /* !CONFIG_SMP */
- /* restore registers and return */
-2: REST_4GPRS(3, r11)
- lwz r10,_CCR(r11)
- REST_GPR(1, r11)
- mtcr r10
- lwz r10,_LINK(r11)
- mtlr r10
- REST_GPR(10, r11)
- mtspr SPRN_SRR1,r9
- mtspr SPRN_SRR0,r12
- REST_GPR(9, r11)
- REST_GPR(12, r11)
- lwz r11,GPR11(r11)
- rfi
+ blr
/*
* SPE unavailable trap from kernel - print a message, but let
--
1.6.4
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 1/2] powerpc/e500: make load_up_spe a normal fuction
@ 2012-02-27 10:59 ` Olivia Yin
0 siblings, 0 replies; 14+ messages in thread
From: Olivia Yin @ 2012-02-27 10:59 UTC (permalink / raw)
To: kvm-ppc, kvm, linuxppc-dev; +Cc: Olivia Yin, Liu Yu
So that we can call it in kernel.
Signed-off-by: Liu Yu <yu.liu@freescale.com>
---
arch/powerpc/kernel/head_fsl_booke.S | 23 ++++++-----------------
1 files changed, 6 insertions(+), 17 deletions(-)
diff --git a/arch/powerpc/kernel/head_fsl_booke.S b/arch/powerpc/kernel/head_fsl_booke.S
index d5d78c4..c96e025 100644
--- a/arch/powerpc/kernel/head_fsl_booke.S
+++ b/arch/powerpc/kernel/head_fsl_booke.S
@@ -539,8 +539,10 @@ interrupt_base:
/* SPE Unavailable */
START_EXCEPTION(SPEUnavailable)
NORMAL_EXCEPTION_PROLOG
- bne load_up_spe
- addi r3,r1,STACK_FRAME_OVERHEAD
+ beq 1f
+ bl load_up_spe
+ b fast_exception_return
+1: addi r3,r1,STACK_FRAME_OVERHEAD
EXC_XFER_EE_LITE(0x2010, KernelSPE)
#else
EXCEPTION(0x2020, SPEUnavailable, unknown_exception, EXC_XFER_EE)
@@ -743,7 +745,7 @@ tlb_write_entry:
/* Note that the SPE support is closely modeled after the AltiVec
* support. Changes to one are likely to be applicable to the
* other! */
-load_up_spe:
+_GLOBAL(load_up_spe)
/*
* Disable SPE for the task which had SPE previously,
* and save its SPE registers in its thread_struct.
@@ -791,20 +793,7 @@ load_up_spe:
subi r4,r5,THREAD
stw r4,last_task_used_spe@l(r3)
#endif /* !CONFIG_SMP */
- /* restore registers and return */
-2: REST_4GPRS(3, r11)
- lwz r10,_CCR(r11)
- REST_GPR(1, r11)
- mtcr r10
- lwz r10,_LINK(r11)
- mtlr r10
- REST_GPR(10, r11)
- mtspr SPRN_SRR1,r9
- mtspr SPRN_SRR0,r12
- REST_GPR(9, r11)
- REST_GPR(12, r11)
- lwz r11,GPR11(r11)
- rfi
+ blr
/*
* SPE unavailable trap from kernel - print a message, but let
--
1.6.4
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 1/2] powerpc/e500: make load_up_spe a normal fuction
@ 2012-02-27 10:59 ` Olivia Yin
0 siblings, 0 replies; 14+ messages in thread
From: Olivia Yin @ 2012-02-27 10:59 UTC (permalink / raw)
To: kvm-ppc, kvm, linuxppc-dev; +Cc: Liu Yu, Olivia Yin
So that we can call it in kernel.
Signed-off-by: Liu Yu <yu.liu@freescale.com>
---
arch/powerpc/kernel/head_fsl_booke.S | 23 ++++++-----------------
1 files changed, 6 insertions(+), 17 deletions(-)
diff --git a/arch/powerpc/kernel/head_fsl_booke.S b/arch/powerpc/kernel/head_fsl_booke.S
index d5d78c4..c96e025 100644
--- a/arch/powerpc/kernel/head_fsl_booke.S
+++ b/arch/powerpc/kernel/head_fsl_booke.S
@@ -539,8 +539,10 @@ interrupt_base:
/* SPE Unavailable */
START_EXCEPTION(SPEUnavailable)
NORMAL_EXCEPTION_PROLOG
- bne load_up_spe
- addi r3,r1,STACK_FRAME_OVERHEAD
+ beq 1f
+ bl load_up_spe
+ b fast_exception_return
+1: addi r3,r1,STACK_FRAME_OVERHEAD
EXC_XFER_EE_LITE(0x2010, KernelSPE)
#else
EXCEPTION(0x2020, SPEUnavailable, unknown_exception, EXC_XFER_EE)
@@ -743,7 +745,7 @@ tlb_write_entry:
/* Note that the SPE support is closely modeled after the AltiVec
* support. Changes to one are likely to be applicable to the
* other! */
-load_up_spe:
+_GLOBAL(load_up_spe)
/*
* Disable SPE for the task which had SPE previously,
* and save its SPE registers in its thread_struct.
@@ -791,20 +793,7 @@ load_up_spe:
subi r4,r5,THREAD
stw r4,last_task_used_spe@l(r3)
#endif /* !CONFIG_SMP */
- /* restore registers and return */
-2: REST_4GPRS(3, r11)
- lwz r10,_CCR(r11)
- REST_GPR(1, r11)
- mtcr r10
- lwz r10,_LINK(r11)
- mtlr r10
- REST_GPR(10, r11)
- mtspr SPRN_SRR1,r9
- mtspr SPRN_SRR0,r12
- REST_GPR(9, r11)
- REST_GPR(12, r11)
- lwz r11,GPR11(r11)
- rfi
+ blr
/*
* SPE unavailable trap from kernel - print a message, but let
--
1.6.4
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] powerpc/e500: make load_up_spe a normal fuction
2012-02-27 10:59 ` Olivia Yin
@ 2012-02-27 15:50 ` Tabi Timur-B04825
-1 siblings, 0 replies; 14+ messages in thread
From: Tabi Timur-B04825 @ 2012-02-27 15:50 UTC (permalink / raw)
To: Yin Olivia-R63875; +Cc: kvm-ppc, kvm, linuxppc-dev, Liu Yu-B13201
On Mon, Feb 27, 2012 at 4:59 AM, Olivia Yin <hong-hua.yin@freescale.com> wrote:
> So that we can call it in kernel.
And why would we want that?
--
Timur Tabi
Linux kernel developer at Freescale
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] powerpc/e500: make load_up_spe a normal fuction
2012-02-27 10:59 ` Olivia Yin
(?)
@ 2012-02-27 19:19 ` Scott Wood
-1 siblings, 0 replies; 14+ messages in thread
From: Scott Wood @ 2012-02-27 19:19 UTC (permalink / raw)
To: Olivia Yin; +Cc: kvm-ppc, kvm, linuxppc-dev, Liu Yu
On 02/27/2012 04:59 AM, Olivia Yin wrote:
> So that we can call it in kernel.
>
> Signed-off-by: Liu Yu <yu.liu@freescale.com>
Explain why we want this, and point out that this makes it similar to
load_up_fpu.
> ---
> arch/powerpc/kernel/head_fsl_booke.S | 23 ++++++-----------------
> 1 files changed, 6 insertions(+), 17 deletions(-)
When posting a patch authored by someone else, more or less unchanged,
you should put a From: line in the body of the e-mail.
git send-email will do this automatically if you preserve the authorship
in the git commit.
Also, you should add your own Signed-off-by.
-Scott
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] powerpc/e500: make load_up_spe a normal fuction
@ 2012-02-27 19:19 ` Scott Wood
0 siblings, 0 replies; 14+ messages in thread
From: Scott Wood @ 2012-02-27 19:19 UTC (permalink / raw)
To: Olivia Yin; +Cc: kvm-ppc, kvm, linuxppc-dev, Liu Yu
On 02/27/2012 04:59 AM, Olivia Yin wrote:
> So that we can call it in kernel.
>
> Signed-off-by: Liu Yu <yu.liu@freescale.com>
Explain why we want this, and point out that this makes it similar to
load_up_fpu.
> ---
> arch/powerpc/kernel/head_fsl_booke.S | 23 ++++++-----------------
> 1 files changed, 6 insertions(+), 17 deletions(-)
When posting a patch authored by someone else, more or less unchanged,
you should put a From: line in the body of the e-mail.
git send-email will do this automatically if you preserve the authorship
in the git commit.
Also, you should add your own Signed-off-by.
-Scott
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] powerpc/e500: make load_up_spe a normal fuction
@ 2012-02-27 19:19 ` Scott Wood
0 siblings, 0 replies; 14+ messages in thread
From: Scott Wood @ 2012-02-27 19:19 UTC (permalink / raw)
To: Olivia Yin; +Cc: Liu Yu, linuxppc-dev, kvm, kvm-ppc
On 02/27/2012 04:59 AM, Olivia Yin wrote:
> So that we can call it in kernel.
>
> Signed-off-by: Liu Yu <yu.liu@freescale.com>
Explain why we want this, and point out that this makes it similar to
load_up_fpu.
> ---
> arch/powerpc/kernel/head_fsl_booke.S | 23 ++++++-----------------
> 1 files changed, 6 insertions(+), 17 deletions(-)
When posting a patch authored by someone else, more or less unchanged,
you should put a From: line in the body of the e-mail.
git send-email will do this automatically if you preserve the authorship
in the git commit.
Also, you should add your own Signed-off-by.
-Scott
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH 1/2] powerpc/e500: make load_up_spe a normal fuction
2012-02-27 19:19 ` Scott Wood
(?)
@ 2012-02-28 7:09 ` Yin Olivia-R63875
-1 siblings, 0 replies; 14+ messages in thread
From: Yin Olivia-R63875 @ 2012-02-28 7:09 UTC (permalink / raw)
To: Wood Scott-B07421; +Cc: kvm-ppc, kvm, linuxppc-dev, Liu Yu-B13201
Hi Scott,
This had been reviewed before and accepted by internal tree.
http://linux.freescale.net/patchwork/patch/11100/
http://git.am.freescale.net/gitolite/gitweb.cgi/sdk/kvm.git/commit/?h=for-sdk1.2&id=c5088844dc665dbdae4fa51b8d58dc203bacc17e
I didn't change anything except the line.
I just commit to external kvm-ppc mailing list. Should I add my own Signed-off-by?
Best Regards,
Olivia
-----Original Message-----
From: Wood Scott-B07421
Sent: Tuesday, February 28, 2012 3:19 AM
To: Yin Olivia-R63875
Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Liu Yu-B13201
Subject: Re: [PATCH 1/2] powerpc/e500: make load_up_spe a normal fuction
On 02/27/2012 04:59 AM, Olivia Yin wrote:
> So that we can call it in kernel.
>
> Signed-off-by: Liu Yu <yu.liu@freescale.com>
Explain why we want this, and point out that this makes it similar to load_up_fpu.
> ---
> arch/powerpc/kernel/head_fsl_booke.S | 23 ++++++-----------------
> 1 files changed, 6 insertions(+), 17 deletions(-)
When posting a patch authored by someone else, more or less unchanged, you should put a From: line in the body of the e-mail.
git send-email will do this automatically if you preserve the authorship in the git commit.
Also, you should add your own Signed-off-by.
-Scott
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH 1/2] powerpc/e500: make load_up_spe a normal fuction
@ 2012-02-28 7:09 ` Yin Olivia-R63875
0 siblings, 0 replies; 14+ messages in thread
From: Yin Olivia-R63875 @ 2012-02-28 7:09 UTC (permalink / raw)
To: Wood Scott-B07421; +Cc: kvm-ppc, kvm, linuxppc-dev, Liu Yu-B13201
SGkgU2NvdHQsDQoNClRoaXMgaGFkIGJlZW4gcmV2aWV3ZWQgYmVmb3JlIGFuZCBhY2NlcHRlZCBi
eSBpbnRlcm5hbCB0cmVlLg0KaHR0cDovL2xpbnV4LmZyZWVzY2FsZS5uZXQvcGF0Y2h3b3JrL3Bh
dGNoLzExMTAwLw0KaHR0cDovL2dpdC5hbS5mcmVlc2NhbGUubmV0L2dpdG9saXRlL2dpdHdlYi5j
Z2kvc2RrL2t2bS5naXQvY29tbWl0Lz9oPWZvci1zZGsxLjImaWQ9YzUwODg4NDRkYzY2NWRiZGFl
NGZhNTFiOGQ1OGRjMjAzYmFjYzE3ZQ0KDQpJIGRpZG4ndCBjaGFuZ2UgYW55dGhpbmcgZXhjZXB0
IHRoZSBsaW5lLg0KSSBqdXN0IGNvbW1pdCB0byBleHRlcm5hbCBrdm0tcHBjIG1haWxpbmcgbGlz
dC4gU2hvdWxkIEkgYWRkIG15IG93biBTaWduZWQtb2ZmLWJ5Pw0KDQpCZXN0IFJlZ2FyZHMsDQpP
bGl2aWENCg0KLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IFdvb2QgU2NvdHQtQjA3
NDIxIA0KU2VudDogVHVlc2RheSwgRmVicnVhcnkgMjgsIDIwMTIgMzoxOSBBTQ0KVG86IFlpbiBP
bGl2aWEtUjYzODc1DQpDYzoga3ZtLXBwY0B2Z2VyLmtlcm5lbC5vcmc7IGt2bUB2Z2VyLmtlcm5l
bC5vcmc7IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnOyBMaXUgWXUtQjEzMjAxDQpTdWJq
ZWN0OiBSZTogW1BBVENIIDEvMl0gcG93ZXJwYy9lNTAwOiBtYWtlIGxvYWRfdXBfc3BlIGEgbm9y
bWFsIGZ1Y3Rpb24NCg0KT24gMDIvMjcvMjAxMiAwNDo1OSBBTSwgT2xpdmlhIFlpbiB3cm90ZToN
Cj4gU28gdGhhdCB3ZSBjYW4gY2FsbCBpdCBpbiBrZXJuZWwuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5
OiBMaXUgWXUgPHl1LmxpdUBmcmVlc2NhbGUuY29tPg0KDQpFeHBsYWluIHdoeSB3ZSB3YW50IHRo
aXMsIGFuZCBwb2ludCBvdXQgdGhhdCB0aGlzIG1ha2VzIGl0IHNpbWlsYXIgdG8gbG9hZF91cF9m
cHUuDQoNCj4gLS0tDQo+ICBhcmNoL3Bvd2VycGMva2VybmVsL2hlYWRfZnNsX2Jvb2tlLlMgfCAg
IDIzICsrKysrKy0tLS0tLS0tLS0tLS0tLS0tDQo+ICAxIGZpbGVzIGNoYW5nZWQsIDYgaW5zZXJ0
aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pDQoNCldoZW4gcG9zdGluZyBhIHBhdGNoIGF1dGhvcmVk
IGJ5IHNvbWVvbmUgZWxzZSwgbW9yZSBvciBsZXNzIHVuY2hhbmdlZCwgeW91IHNob3VsZCBwdXQg
YSBGcm9tOiBsaW5lIGluIHRoZSBib2R5IG9mIHRoZSBlLW1haWwuDQoNCmdpdCBzZW5kLWVtYWls
IHdpbGwgZG8gdGhpcyBhdXRvbWF0aWNhbGx5IGlmIHlvdSBwcmVzZXJ2ZSB0aGUgYXV0aG9yc2hp
cCBpbiB0aGUgZ2l0IGNvbW1pdC4NCg0KQWxzbywgeW91IHNob3VsZCBhZGQgeW91ciBvd24gU2ln
bmVkLW9mZi1ieS4NCg0KLVNjb3R0DQo
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH 1/2] powerpc/e500: make load_up_spe a normal fuction
@ 2012-02-28 7:09 ` Yin Olivia-R63875
0 siblings, 0 replies; 14+ messages in thread
From: Yin Olivia-R63875 @ 2012-02-28 7:09 UTC (permalink / raw)
To: Wood Scott-B07421; +Cc: linuxppc-dev, kvm, kvm-ppc
SGkgU2NvdHQsDQoNClRoaXMgaGFkIGJlZW4gcmV2aWV3ZWQgYmVmb3JlIGFuZCBhY2NlcHRlZCBi
eSBpbnRlcm5hbCB0cmVlLg0KaHR0cDovL2xpbnV4LmZyZWVzY2FsZS5uZXQvcGF0Y2h3b3JrL3Bh
dGNoLzExMTAwLw0KaHR0cDovL2dpdC5hbS5mcmVlc2NhbGUubmV0L2dpdG9saXRlL2dpdHdlYi5j
Z2kvc2RrL2t2bS5naXQvY29tbWl0Lz9oPWZvci1zZGsxLjImaWQ9YzUwODg4NDRkYzY2NWRiZGFl
NGZhNTFiOGQ1OGRjMjAzYmFjYzE3ZQ0KDQpJIGRpZG4ndCBjaGFuZ2UgYW55dGhpbmcgZXhjZXB0
IHRoZSBsaW5lLg0KSSBqdXN0IGNvbW1pdCB0byBleHRlcm5hbCBrdm0tcHBjIG1haWxpbmcgbGlz
dC4gU2hvdWxkIEkgYWRkIG15IG93biBTaWduZWQtb2ZmLWJ5Pw0KDQpCZXN0IFJlZ2FyZHMsDQpP
bGl2aWENCg0KLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IFdvb2QgU2NvdHQtQjA3
NDIxIA0KU2VudDogVHVlc2RheSwgRmVicnVhcnkgMjgsIDIwMTIgMzoxOSBBTQ0KVG86IFlpbiBP
bGl2aWEtUjYzODc1DQpDYzoga3ZtLXBwY0B2Z2VyLmtlcm5lbC5vcmc7IGt2bUB2Z2VyLmtlcm5l
bC5vcmc7IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnOyBMaXUgWXUtQjEzMjAxDQpTdWJq
ZWN0OiBSZTogW1BBVENIIDEvMl0gcG93ZXJwYy9lNTAwOiBtYWtlIGxvYWRfdXBfc3BlIGEgbm9y
bWFsIGZ1Y3Rpb24NCg0KT24gMDIvMjcvMjAxMiAwNDo1OSBBTSwgT2xpdmlhIFlpbiB3cm90ZToN
Cj4gU28gdGhhdCB3ZSBjYW4gY2FsbCBpdCBpbiBrZXJuZWwuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5
OiBMaXUgWXUgPHl1LmxpdUBmcmVlc2NhbGUuY29tPg0KDQpFeHBsYWluIHdoeSB3ZSB3YW50IHRo
aXMsIGFuZCBwb2ludCBvdXQgdGhhdCB0aGlzIG1ha2VzIGl0IHNpbWlsYXIgdG8gbG9hZF91cF9m
cHUuDQoNCj4gLS0tDQo+ICBhcmNoL3Bvd2VycGMva2VybmVsL2hlYWRfZnNsX2Jvb2tlLlMgfCAg
IDIzICsrKysrKy0tLS0tLS0tLS0tLS0tLS0tDQo+ICAxIGZpbGVzIGNoYW5nZWQsIDYgaW5zZXJ0
aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pDQoNCldoZW4gcG9zdGluZyBhIHBhdGNoIGF1dGhvcmVk
IGJ5IHNvbWVvbmUgZWxzZSwgbW9yZSBvciBsZXNzIHVuY2hhbmdlZCwgeW91IHNob3VsZCBwdXQg
YSBGcm9tOiBsaW5lIGluIHRoZSBib2R5IG9mIHRoZSBlLW1haWwuDQoNCmdpdCBzZW5kLWVtYWls
IHdpbGwgZG8gdGhpcyBhdXRvbWF0aWNhbGx5IGlmIHlvdSBwcmVzZXJ2ZSB0aGUgYXV0aG9yc2hp
cCBpbiB0aGUgZ2l0IGNvbW1pdC4NCg0KQWxzbywgeW91IHNob3VsZCBhZGQgeW91ciBvd24gU2ln
bmVkLW9mZi1ieS4NCg0KLVNjb3R0DQo=
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] powerpc/e500: make load_up_spe a normal fuction
2012-02-28 7:09 ` Yin Olivia-R63875
(?)
@ 2012-03-07 13:53 ` Alexander Graf
-1 siblings, 0 replies; 14+ messages in thread
From: Alexander Graf @ 2012-03-07 13:53 UTC (permalink / raw)
To: Yin Olivia-R63875
Cc: Wood Scott-B07421, kvm-ppc, kvm, linuxppc-dev, Liu Yu-B13201
On 02/28/2012 08:09 AM, Yin Olivia-R63875 wrote:
> Hi Scott,
>
> This had been reviewed before and accepted by internal tree.
> http://linux.freescale.net/patchwork/patch/11100/
> http://git.am.freescale.net/gitolite/gitweb.cgi/sdk/kvm.git/commit/?h=for-sdk1.2&id=c5088844dc665dbdae4fa51b8d58dc203bacc17e
>
> I didn't change anything except the line.
> I just commit to external kvm-ppc mailing list. Should I add my own Signed-off-by?
Yes, if you just take a patch from someone else and direct it to another
tree, you keep the From: line (git cherry-pick or git am should do that
automatically for you) and add your own SOB-line (git am -s can do that
for example).
Since you're also supposed to change the description, please note that
between Yu's SOB line and your SOB line with something like
Signed-off-by: Liu Yu<yu.liu@freescale.com>
[olivia: change description]
Signed-off-by: Olivia Yin<r63875@freescale.com>
Alex
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] powerpc/e500: make load_up_spe a normal fuction
@ 2012-03-07 13:53 ` Alexander Graf
0 siblings, 0 replies; 14+ messages in thread
From: Alexander Graf @ 2012-03-07 13:53 UTC (permalink / raw)
To: Yin Olivia-R63875
Cc: Wood Scott-B07421, kvm-ppc, kvm, linuxppc-dev, Liu Yu-B13201
On 02/28/2012 08:09 AM, Yin Olivia-R63875 wrote:
> Hi Scott,
>
> This had been reviewed before and accepted by internal tree.
> http://linux.freescale.net/patchwork/patch/11100/
> http://git.am.freescale.net/gitolite/gitweb.cgi/sdk/kvm.git/commit/?h=for-sdk1.2&idÅ088844dc665dbdae4fa51b8d58dc203bacc17e
>
> I didn't change anything except the line.
> I just commit to external kvm-ppc mailing list. Should I add my own Signed-off-by?
Yes, if you just take a patch from someone else and direct it to another
tree, you keep the From: line (git cherry-pick or git am should do that
automatically for you) and add your own SOB-line (git am -s can do that
for example).
Since you're also supposed to change the description, please note that
between Yu's SOB line and your SOB line with something like
Signed-off-by: Liu Yu<yu.liu@freescale.com>
[olivia: change description]
Signed-off-by: Olivia Yin<r63875@freescale.com>
Alex
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] powerpc/e500: make load_up_spe a normal fuction
@ 2012-03-07 13:53 ` Alexander Graf
0 siblings, 0 replies; 14+ messages in thread
From: Alexander Graf @ 2012-03-07 13:53 UTC (permalink / raw)
To: Yin Olivia-R63875; +Cc: Wood Scott-B07421, linuxppc-dev, kvm, kvm-ppc
On 02/28/2012 08:09 AM, Yin Olivia-R63875 wrote:
> Hi Scott,
>
> This had been reviewed before and accepted by internal tree.
> http://linux.freescale.net/patchwork/patch/11100/
> http://git.am.freescale.net/gitolite/gitweb.cgi/sdk/kvm.git/commit/?h=for-sdk1.2&id=c5088844dc665dbdae4fa51b8d58dc203bacc17e
>
> I didn't change anything except the line.
> I just commit to external kvm-ppc mailing list. Should I add my own Signed-off-by?
Yes, if you just take a patch from someone else and direct it to another
tree, you keep the From: line (git cherry-pick or git am should do that
automatically for you) and add your own SOB-line (git am -s can do that
for example).
Since you're also supposed to change the description, please note that
between Yu's SOB line and your SOB line with something like
Signed-off-by: Liu Yu<yu.liu@freescale.com>
[olivia: change description]
Signed-off-by: Olivia Yin<r63875@freescale.com>
Alex
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2012-03-07 13:54 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-27 10:59 [PATCH 1/2] powerpc/e500: make load_up_spe a normal fuction Olivia Yin
2012-02-27 10:59 ` Olivia Yin
2012-02-27 10:59 ` Olivia Yin
2012-02-27 15:50 ` Tabi Timur-B04825
2012-02-27 15:50 ` Tabi Timur-B04825
2012-02-27 19:19 ` Scott Wood
2012-02-27 19:19 ` Scott Wood
2012-02-27 19:19 ` Scott Wood
2012-02-28 7:09 ` Yin Olivia-R63875
2012-02-28 7:09 ` Yin Olivia-R63875
2012-02-28 7:09 ` Yin Olivia-R63875
2012-03-07 13:53 ` Alexander Graf
2012-03-07 13:53 ` Alexander Graf
2012-03-07 13:53 ` Alexander Graf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.