From: Timur Tabi <timur@codeaurora.org>
To: Al Stone <ahs3@redhat.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
lkml <linux-kernel@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>
Subject: Re: [PATCH 3/3] arm64: cpuinfo: display product info in /proc/cpuinfo
Date: Fri, 13 Oct 2017 14:27:33 -0500 [thread overview]
Message-ID: <CAOZdJXWok=kHsLQLqf9sWiPibnhjnJptAteWoOA57ddEacniRg@mail.gmail.com> (raw)
In-Reply-To: <20170926222324.17409-4-ahs3@redhat.com>
On Tue, Sep 26, 2017 at 5:23 PM, Al Stone <ahs3@redhat.com> wrote:
> + if (IS_ENABLED(CONFIG_DMI)) {
> + seq_puts(m, "product name\t: ");
> +
> + if (!dmi_product_info)
> + get_dmi_product_info();
> + if (dmi_product_info)
> + seq_printf(m, "%s", dmi_product_info);
This line prints out like this:
product name : QUALCOMM BASEBOARD ASSEMBLY, AMBERWIN
20-P7989-H1S , ARM 8.0 (r0p0) CPU @ 2.500GHz
Is this a bug in our DMI table? 'dmidecode' reports this:
Handle 0x0004, DMI type 2, 17 bytes
Base Board Information
Manufacturer: QUALCOMM
Product Name: BASEBOARD ASSEMBLY, AMBERWIN..
Version: 20-P7989-H1S
I'm guessing that the actual string has a CR/LF at the end of "AMBERWIN"
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
WARNING: multiple messages have this Message-ID (diff)
From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] arm64: cpuinfo: display product info in /proc/cpuinfo
Date: Fri, 13 Oct 2017 14:27:33 -0500 [thread overview]
Message-ID: <CAOZdJXWok=kHsLQLqf9sWiPibnhjnJptAteWoOA57ddEacniRg@mail.gmail.com> (raw)
In-Reply-To: <20170926222324.17409-4-ahs3@redhat.com>
On Tue, Sep 26, 2017 at 5:23 PM, Al Stone <ahs3@redhat.com> wrote:
> + if (IS_ENABLED(CONFIG_DMI)) {
> + seq_puts(m, "product name\t: ");
> +
> + if (!dmi_product_info)
> + get_dmi_product_info();
> + if (dmi_product_info)
> + seq_printf(m, "%s", dmi_product_info);
This line prints out like this:
product name : QUALCOMM BASEBOARD ASSEMBLY, AMBERWIN
20-P7989-H1S , ARM 8.0 (r0p0) CPU @ 2.500GHz
Is this a bug in our DMI table? 'dmidecode' reports this:
Handle 0x0004, DMI type 2, 17 bytes
Base Board Information
Manufacturer: QUALCOMM
Product Name: BASEBOARD ASSEMBLY, AMBERWIN..
Version: 20-P7989-H1S
I'm guessing that the actual string has a CR/LF at the end of "AMBERWIN"
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-10-13 19:27 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 22:23 [PATCH 0/3] arm64: cpuinfo: make /proc/cpuinfo more human-readable Al Stone
2017-09-26 22:23 ` Al Stone
2017-09-26 22:23 ` [PATCH 1/3] arm64: cpuinfo: add MPIDR value to /proc/cpuinfo Al Stone
2017-09-26 22:23 ` Al Stone
2017-09-27 11:33 ` Mark Rutland
2017-09-27 11:33 ` Mark Rutland
2017-09-26 22:23 ` [PATCH 2/3] arm64: cpuinfo: add human readable CPU names " Al Stone
2017-09-26 22:23 ` Al Stone
2017-09-27 10:35 ` Robin Murphy
2017-09-27 10:35 ` Robin Murphy
2017-09-27 11:26 ` Mark Rutland
2017-09-27 11:26 ` Mark Rutland
2017-10-13 14:16 ` Timur Tabi
2017-10-13 14:16 ` Timur Tabi
2017-09-26 22:23 ` [PATCH 3/3] arm64: cpuinfo: display product info in /proc/cpuinfo Al Stone
2017-09-26 22:23 ` Al Stone
2017-09-27 0:40 ` Florian Fainelli
2017-09-27 0:40 ` Florian Fainelli
2017-09-27 10:42 ` Robin Murphy
2017-09-27 10:42 ` Robin Murphy
2017-09-27 13:39 ` Mark Rutland
2017-09-27 13:39 ` Mark Rutland
2017-09-27 11:36 ` Mark Rutland
2017-09-27 11:36 ` Mark Rutland
2017-10-13 19:27 ` Timur Tabi [this message]
2017-10-13 19:27 ` Timur Tabi
2017-09-27 10:34 ` [PATCH 0/3] arm64: cpuinfo: make /proc/cpuinfo more human-readable Mark Rutland
2017-09-27 10:34 ` Mark Rutland
2017-10-09 22:46 ` Al Stone
2017-10-09 22:46 ` Al Stone
2017-10-13 13:39 ` Timur Tabi
2017-10-13 13:39 ` Timur Tabi
2017-10-13 14:27 ` Mark Rutland
2017-10-13 14:27 ` Mark Rutland
2017-10-16 23:43 ` Al Stone
2017-10-16 23:43 ` Al Stone
2017-10-20 16:10 ` Mark Rutland
2017-10-20 16:10 ` Mark Rutland
2017-10-20 17:24 ` Jon Masters
2017-10-20 17:24 ` Jon Masters
2017-10-21 0:50 ` Jon Masters
2017-10-21 0:50 ` Jon Masters
2017-10-20 23:26 ` Al Stone
2017-10-20 23:26 ` Al Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOZdJXWok=kHsLQLqf9sWiPibnhjnJptAteWoOA57ddEacniRg@mail.gmail.com' \
--to=timur@codeaurora.org \
--cc=ahs3@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.