From: Sumit Semwal <sumit.semwal@linaro.org>
To: "Christian König" <christian.koenig@amd.com>
Cc: Zou Wei <zou_wei@huawei.com>, "Andrew F. Davis" <afd@ti.com>,
"(Exiting) Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
Liam Mark <lmark@codeaurora.org>,
Laura Abbott <labbott@redhat.com>,
Brian Starkey <Brian.Starkey@arm.com>,
John Stultz <john.stultz@linaro.org>,
"open list:DMA BUFFER SHARING FRAMEWORK"
<linux-media@vger.kernel.org>,
DRI mailing list <dri-devel@lists.freedesktop.org>,
Linaro MM SIG <linaro-mm-sig@lists.linaro.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] dma-buf: heaps: Remove unused variable ret
Date: Tue, 22 Sep 2020 20:21:42 +0530 [thread overview]
Message-ID: <CAO_48GHVUnHm38nPSc3zYU7ZoFmZDTZdc7Du5pyrVbz6ytwgEA@mail.gmail.com> (raw)
In-Reply-To: <16d720b7-9bf3-ad3a-0785-76f21c87c9e1@amd.com>
Hello Zou,
On Tue, 22 Sep 2020 at 18:12, Christian König <christian.koenig@amd.com> wrote:
>
> Am 22.09.20 um 09:53 schrieb Zou Wei:
> > This patch fixes below warnings reported by coccicheck
> >
> > ./drivers/dma-buf/heaps/heap-helpers.c:202:5-8: Unneeded variable: "ret". Return "0" on line 215
> >
> > Signed-off-by: Zou Wei <zou_wei@huawei.com>
>
> Acked-by: Christian König <christian.koenig@amd.com>
>
> Going to pick this up for drm-misc-next.
Thanks Christian!
Fwiw, feel free to add my
Acked-by: Sumit Semwal <sumit.semwal@linaro.org>
>
> > ---
> > drivers/dma-buf/heaps/heap-helpers.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/dma-buf/heaps/heap-helpers.c b/drivers/dma-buf/heaps/heap-helpers.c
> > index d0696cf..7969510 100644
> > --- a/drivers/dma-buf/heaps/heap-helpers.c
> > +++ b/drivers/dma-buf/heaps/heap-helpers.c
> > @@ -199,7 +199,6 @@ static int dma_heap_dma_buf_begin_cpu_access(struct dma_buf *dmabuf,
> > {
> > struct heap_helper_buffer *buffer = dmabuf->priv;
> > struct dma_heaps_attachment *a;
> > - int ret = 0;
> >
> > mutex_lock(&buffer->lock);
> >
> > @@ -212,7 +211,7 @@ static int dma_heap_dma_buf_begin_cpu_access(struct dma_buf *dmabuf,
> > }
> > mutex_unlock(&buffer->lock);
> >
> > - return ret;
> > + return 0;
> > }
> >
> > static int dma_heap_dma_buf_end_cpu_access(struct dma_buf *dmabuf,
>
Best,
Sumit.
WARNING: multiple messages have this Message-ID (diff)
From: Sumit Semwal <sumit.semwal@linaro.org>
To: "Christian König" <christian.koenig@amd.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Liam Mark <lmark@codeaurora.org>, "Andrew F. Davis" <afd@ti.com>,
Linaro MM SIG <linaro-mm-sig@lists.linaro.org>,
DRI mailing list <dri-devel@lists.freedesktop.org>,
Zou Wei <zou_wei@huawei.com>, Laura Abbott <labbott@redhat.com>,
"open list:DMA BUFFER SHARING FRAMEWORK"
<linux-media@vger.kernel.org>
Subject: Re: [PATCH -next] dma-buf: heaps: Remove unused variable ret
Date: Tue, 22 Sep 2020 20:21:42 +0530 [thread overview]
Message-ID: <CAO_48GHVUnHm38nPSc3zYU7ZoFmZDTZdc7Du5pyrVbz6ytwgEA@mail.gmail.com> (raw)
In-Reply-To: <16d720b7-9bf3-ad3a-0785-76f21c87c9e1@amd.com>
Hello Zou,
On Tue, 22 Sep 2020 at 18:12, Christian König <christian.koenig@amd.com> wrote:
>
> Am 22.09.20 um 09:53 schrieb Zou Wei:
> > This patch fixes below warnings reported by coccicheck
> >
> > ./drivers/dma-buf/heaps/heap-helpers.c:202:5-8: Unneeded variable: "ret". Return "0" on line 215
> >
> > Signed-off-by: Zou Wei <zou_wei@huawei.com>
>
> Acked-by: Christian König <christian.koenig@amd.com>
>
> Going to pick this up for drm-misc-next.
Thanks Christian!
Fwiw, feel free to add my
Acked-by: Sumit Semwal <sumit.semwal@linaro.org>
>
> > ---
> > drivers/dma-buf/heaps/heap-helpers.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/dma-buf/heaps/heap-helpers.c b/drivers/dma-buf/heaps/heap-helpers.c
> > index d0696cf..7969510 100644
> > --- a/drivers/dma-buf/heaps/heap-helpers.c
> > +++ b/drivers/dma-buf/heaps/heap-helpers.c
> > @@ -199,7 +199,6 @@ static int dma_heap_dma_buf_begin_cpu_access(struct dma_buf *dmabuf,
> > {
> > struct heap_helper_buffer *buffer = dmabuf->priv;
> > struct dma_heaps_attachment *a;
> > - int ret = 0;
> >
> > mutex_lock(&buffer->lock);
> >
> > @@ -212,7 +211,7 @@ static int dma_heap_dma_buf_begin_cpu_access(struct dma_buf *dmabuf,
> > }
> > mutex_unlock(&buffer->lock);
> >
> > - return ret;
> > + return 0;
> > }
> >
> > static int dma_heap_dma_buf_end_cpu_access(struct dma_buf *dmabuf,
>
Best,
Sumit.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-09-22 14:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 7:53 [PATCH -next] dma-buf: heaps: Remove unused variable ret Zou Wei
2020-09-22 7:53 ` Zou Wei
2020-09-22 12:41 ` Christian König
2020-09-22 12:41 ` Christian König
2020-09-22 14:51 ` Sumit Semwal [this message]
2020-09-22 14:51 ` Sumit Semwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO_48GHVUnHm38nPSc3zYU7ZoFmZDTZdc7Du5pyrVbz6ytwgEA@mail.gmail.com \
--to=sumit.semwal@linaro.org \
--cc=Brian.Starkey@arm.com \
--cc=afd@ti.com \
--cc=benjamin.gaignard@linaro.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=john.stultz@linaro.org \
--cc=labbott@redhat.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lmark@codeaurora.org \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.