All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Renieris <makren67@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Richard Henderson <richard.henderson@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] AVX support for TCG
Date: Fri, 28 Dec 2018 19:19:18 +0200	[thread overview]
Message-ID: <CAObpvQkX3Yq_a=zTCKndKF17k+j3nWJ3TdqOFw6KQ2R-WFcCOA@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA_OV8=ThCRi_PuqgeqGfXquL13HrXXURX6LuPTF0HG2Dw@mail.gmail.com>

Στις Παρ, 28 Δεκ 2018 στις 4:39 μ.μ., ο/η Peter Maydell
<peter.maydell@linaro.org> έγραψε:
> If your editor can't show multiple views onto one file with
> the same simplicity and UI as it has for multiple different
> files then I would suggest getting a better editor :-)

Apparently I just didn't know how to use my editor :) In my defense,
I've never had to do this before.

> Unless you want to restrict all your files to 100 lines or
> shorter then you need to be able to see multiple parts of them
> at once -- one 10,000 line file is no worse than 4 2500 line
> files for this.

As you mention below, logical separation is key here, I definitely
didn't mean that there should be arbitrary LoC limits for each file.

> There are definitely improvements that could be made to
> the x86 code, and where splitting of files makes conceptual
> sense it's certainly worthwhile. The trick is finding the
> right logical splitting points.

Agreed, though it's not something I can personally help on, unless I
spend quite a long time getting acquainted with _this_ code first.

I'd like to get some answers to my previous question about estimates
of the total amount of work required before considering diving into
it.

  reply	other threads:[~2018-12-28 17:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-25 23:43 [Qemu-devel] AVX support for TCG Nick Renieris
2018-12-26  1:07 ` Richard Henderson
2018-12-26  1:28   ` Nick Renieris
2018-12-26  2:12     ` Richard Henderson
2018-12-28 13:43       ` Nick Renieris
2018-12-28 14:13         ` Peter Maydell
2018-12-28 14:28           ` Nick Renieris
2018-12-28 14:38             ` Peter Maydell
2018-12-28 17:19               ` Nick Renieris [this message]
2018-12-28 21:15         ` Alex Bennée
2018-12-29 20:24         ` Richard Henderson
2018-12-30 20:51           ` Nick Renieris
2018-12-31  1:58             ` Richard Henderson
2019-01-04 21:43               ` Nick Renieris
2019-01-04 21:51                 ` Richard Henderson
2019-01-04 22:09                   ` Nick Renieris
2019-01-04 22:14                     ` Richard Henderson
2019-01-04 22:33                       ` Nick Renieris
2019-01-04 22:38                         ` Richard Henderson
2019-01-04 22:42                           ` Nick Renieris
2019-01-17  9:29     ` Stefan Hajnoczi
2019-01-17 13:57       ` Nick Renieris
2019-01-18  9:57         ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAObpvQkX3Yq_a=zTCKndKF17k+j3nWJ3TdqOFw6KQ2R-WFcCOA@mail.gmail.com' \
    --to=makren67@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.