From: Olof Johansson <olof@lixom.net>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: alsa-devel@alsa-project.org, Stephen Warren <swarren@nvidia.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Colin Cross <ccross@android.com>,
linux-tegra@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 4/5] ARM: dt: tegra30.dtsi: Add audio-related nodes
Date: Tue, 10 Apr 2012 21:27:08 -0700 [thread overview]
Message-ID: <CAOesGMhDDenRK_GeR=jWJbcoacRMUPnjFu5w4DCyUWC=CadnbA@mail.gmail.com> (raw)
In-Reply-To: <1334099980-19527-4-git-send-email-swarren@wwwdotorg.org>
Hi,
Nits/questions below.
On Tue, Apr 10, 2012 at 4:19 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Add nodes for the Tegra30 AHUB and I2S controllers.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> v2:
> * Move I2S nodes inside AHUB node, since it's the bus that contains them.
> * Correct APBIF reg size
> * Add nvidia,ahub-cif-ids to I2S nodes
> ---
> arch/arm/boot/dts/tegra30.dtsi | 41 ++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 41 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
> index 62a7b39..98c29d1 100644
> --- a/arch/arm/boot/dts/tegra30.dtsi
> +++ b/arch/arm/boot/dts/tegra30.dtsi
> @@ -183,4 +183,45 @@
> reg = < 0x70000868 0xd0 /* Pad control registers */
> 0x70003000 0x3e0 >; /* Mux registers */
> };
> +
> + ahub@70080000 {
No need for unit address here since there's only one node with this
name -- "ahub {" is sufficient.
> + compatible = "nvidia,tegra30-ahub";
> + reg = <0x70080000 0x200 0x70080200 0x100>;
Why not just use 0x70080000 0x300?
> + interrupts = < 0 103 0x04 >;
> + nvidia,dma-request-selector = <&apbdma 1>;
> +
> + ranges;
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + tegra_i2s0: i2s@70080300 {
> + compatible = "nvidia,tegra30-i2s";
> + reg = <0x70080300 0x100>;
> + nvidia,ahub-cif-ids = <4 4>;
> + };
> +
> + tegra_i2s1: i2s@70080400 {
> + compatible = "nvidia,tegra30-i2s";
> + reg = <0x70080400 0x100>;
> + nvidia,ahub-cif-ids = <5 5>;
> + };
> +
> + tegra_i2s2: i2s@70080500 {
> + compatible = "nvidia,tegra30-i2s";
> + reg = <0x70080500 0x100>;
> + nvidia,ahub-cif-ids = <6 6>;
> + };
> +
> + tegra_i2s3: i2s@70080600 {
> + compatible = "nvidia,tegra30-i2s";
> + reg = <0x70080600 0x100>;
> + nvidia,ahub-cif-ids = <7 7>;
> + };
> +
> + tegra_i2s4: i2s@70080700 {
> + compatible = "nvidia,tegra30-i2s";
> + reg = <0x70080700 0x100>;
> + nvidia,ahub-cif-ids = <8 8>;
> + };
> + };
> };
> --
> 1.7.0.4
>
WARNING: multiple messages have this Message-ID (diff)
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 4/5] ARM: dt: tegra30.dtsi: Add audio-related nodes
Date: Tue, 10 Apr 2012 21:27:08 -0700 [thread overview]
Message-ID: <CAOesGMhDDenRK_GeR=jWJbcoacRMUPnjFu5w4DCyUWC=CadnbA@mail.gmail.com> (raw)
In-Reply-To: <1334099980-19527-4-git-send-email-swarren@wwwdotorg.org>
Hi,
Nits/questions below.
On Tue, Apr 10, 2012 at 4:19 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Add nodes for the Tegra30 AHUB and I2S controllers.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> v2:
> * Move I2S nodes inside AHUB node, since it's the bus that contains them.
> * Correct APBIF reg size
> * Add nvidia,ahub-cif-ids to I2S nodes
> ---
> ?arch/arm/boot/dts/tegra30.dtsi | ? 41 ++++++++++++++++++++++++++++++++++++++++
> ?1 files changed, 41 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
> index 62a7b39..98c29d1 100644
> --- a/arch/arm/boot/dts/tegra30.dtsi
> +++ b/arch/arm/boot/dts/tegra30.dtsi
> @@ -183,4 +183,45 @@
> ? ? ? ? ? ? ? ?reg = < 0x70000868 0xd0 ? ? /* Pad control registers */
> ? ? ? ? ? ? ? ? ? ? ? ?0x70003000 0x3e0 >; /* Mux registers */
> ? ? ? ?};
> +
> + ? ? ? ahub at 70080000 {
No need for unit address here since there's only one node with this
name -- "ahub {" is sufficient.
> + ? ? ? ? ? ? ? compatible = "nvidia,tegra30-ahub";
> + ? ? ? ? ? ? ? reg = <0x70080000 0x200 0x70080200 0x100>;
Why not just use 0x70080000 0x300?
> + ? ? ? ? ? ? ? interrupts = < 0 103 0x04 >;
> + ? ? ? ? ? ? ? nvidia,dma-request-selector = <&apbdma 1>;
> +
> + ? ? ? ? ? ? ? ranges;
> + ? ? ? ? ? ? ? #address-cells = <1>;
> + ? ? ? ? ? ? ? #size-cells = <1>;
> +
> + ? ? ? ? ? ? ? tegra_i2s0: i2s at 70080300 {
> + ? ? ? ? ? ? ? ? ? ? ? compatible = "nvidia,tegra30-i2s";
> + ? ? ? ? ? ? ? ? ? ? ? reg = <0x70080300 0x100>;
> + ? ? ? ? ? ? ? ? ? ? ? nvidia,ahub-cif-ids = <4 4>;
> + ? ? ? ? ? ? ? };
> +
> + ? ? ? ? ? ? ? tegra_i2s1: i2s at 70080400 {
> + ? ? ? ? ? ? ? ? ? ? ? compatible = "nvidia,tegra30-i2s";
> + ? ? ? ? ? ? ? ? ? ? ? reg = <0x70080400 0x100>;
> + ? ? ? ? ? ? ? ? ? ? ? nvidia,ahub-cif-ids = <5 5>;
> + ? ? ? ? ? ? ? };
> +
> + ? ? ? ? ? ? ? tegra_i2s2: i2s at 70080500 {
> + ? ? ? ? ? ? ? ? ? ? ? compatible = "nvidia,tegra30-i2s";
> + ? ? ? ? ? ? ? ? ? ? ? reg = <0x70080500 0x100>;
> + ? ? ? ? ? ? ? ? ? ? ? nvidia,ahub-cif-ids = <6 6>;
> + ? ? ? ? ? ? ? };
> +
> + ? ? ? ? ? ? ? tegra_i2s3: i2s at 70080600 {
> + ? ? ? ? ? ? ? ? ? ? ? compatible = "nvidia,tegra30-i2s";
> + ? ? ? ? ? ? ? ? ? ? ? reg = <0x70080600 0x100>;
> + ? ? ? ? ? ? ? ? ? ? ? nvidia,ahub-cif-ids = <7 7>;
> + ? ? ? ? ? ? ? };
> +
> + ? ? ? ? ? ? ? tegra_i2s4: i2s at 70080700 {
> + ? ? ? ? ? ? ? ? ? ? ? compatible = "nvidia,tegra30-i2s";
> + ? ? ? ? ? ? ? ? ? ? ? reg = <0x70080700 0x100>;
> + ? ? ? ? ? ? ? ? ? ? ? nvidia,ahub-cif-ids = <8 8>;
> + ? ? ? ? ? ? ? };
> + ? ? ? };
> ?};
> --
> 1.7.0.4
>
next prev parent reply other threads:[~2012-04-11 4:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 23:19 [PATCH V2 1/5] ARM: tegra: provide clock aliases for AHUB configlink Stephen Warren
2012-04-10 23:19 ` Stephen Warren
[not found] ` <1334099980-19527-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-10 23:19 ` [PATCH V2 2/5] ARM: tegra: set up audio clocks for tegra30 dt Stephen Warren
2012-04-10 23:19 ` Stephen Warren
2012-04-10 23:19 ` [PATCH V2 3/5] ARM: tegra: add AUXDATA required for audio Stephen Warren
2012-04-10 23:19 ` Stephen Warren
2012-04-10 23:19 ` [PATCH V2 4/5] ARM: dt: tegra30.dtsi: Add audio-related nodes Stephen Warren
2012-04-10 23:19 ` Stephen Warren
2012-04-11 4:27 ` Olof Johansson [this message]
2012-04-11 4:27 ` Olof Johansson
[not found] ` <CAOesGMhDDenRK_GeR=jWJbcoacRMUPnjFu5w4DCyUWC=CadnbA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-11 5:28 ` Stephen Warren
2012-04-11 5:28 ` Stephen Warren
2012-04-13 20:59 ` Olof Johansson
2012-04-13 20:59 ` Olof Johansson
2012-04-10 23:19 ` [PATCH V2 5/5] ARM: dt: tegra cardhu: basic audio support Stephen Warren
2012-04-10 23:19 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOesGMhDDenRK_GeR=jWJbcoacRMUPnjFu5w4DCyUWC=CadnbA@mail.gmail.com' \
--to=olof@lixom.net \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=ccross@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lrg@ti.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.