All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: EXYNOS: Fix compile error in dev-audio.c
@ 2012-12-14  8:15 Jonghwan Choi
  2012-12-17  0:42   ` Olof Johansson
  0 siblings, 1 reply; 9+ messages in thread
From: Jonghwan Choi @ 2012-12-14  8:15 UTC (permalink / raw)
  To: 'Jonghwan Choi', linux-samsung-soc
  Cc: 'Kukjin Kim', 'Russell King'

arch/arm/mach-exynos/dev-audio.c:58:4: error: unknown field 'src_clk'
specified in initializer
arch/arm/mach-exynos/dev-audio.c:58:4: warning: initialization makes integer
from pointer without a cast [enabled by default]
arch/arm/mach-exynos/dev-audio.c:58:4: warning: (near initialization for
'i2sv5_pdata.type.i2s.idma_addr') [enabled by default]
arch/arm/mach-exynos/dev-audio.c:91:4: error: unknown field 'src_clk'
specified in initializer
arch/arm/mach-exynos/dev-audio.c:91:4: warning: initialization makes integer
from pointer without a cast [enabled by default]
arch/arm/mach-exynos/dev-audio.c:91:4: warning: (near initialization for
'i2sv3_pdata.type.i2s.idma_addr') [enabled by default]

Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
---
 arch/arm/mach-exynos/dev-audio.c |   12 ------------
 1 files changed, 0 insertions(+), 12 deletions(-)

diff --git a/arch/arm/mach-exynos/dev-audio.c
b/arch/arm/mach-exynos/dev-audio.c
index a1cb42c..9d1a609 100644
--- a/arch/arm/mach-exynos/dev-audio.c
+++ b/arch/arm/mach-exynos/dev-audio.c
@@ -23,11 +23,6 @@
 #include <mach/irqs.h>
 #include <mach/regs-audss.h>
 
-static const char *rclksrc[] = {
-	[0] = "busclk",
-	[1] = "i2sclk",
-};
-
 static int exynos4_cfg_i2s(struct platform_device *pdev)
 {
 	/* configure GPIO for i2s port */
@@ -55,7 +50,6 @@ static struct s3c_audio_pdata i2sv5_pdata = {
 		.i2s = {
 			.quirks = QUIRK_PRI_6CHAN | QUIRK_SEC_DAI
 					 | QUIRK_NEED_RSTCLR,
-			.src_clk = rclksrc,
 			.idma_addr = EXYNOS4_AUDSS_INT_MEM,
 		},
 	},
@@ -78,17 +72,11 @@ struct platform_device exynos4_device_i2s0 = {
 	},
 };
 
-static const char *rclksrc_v3[] = {
-	[0] = "sclk_i2s",
-	[1] = "no_such_clock",
-};
-
 static struct s3c_audio_pdata i2sv3_pdata = {
 	.cfg_gpio = exynos4_cfg_i2s,
 	.type = {
 		.i2s = {
 			.quirks = QUIRK_NO_MUXPSR,
-			.src_clk = rclksrc_v3,
 		},
 	},
 };
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: EXYNOS: Fix compile error in dev-audio.c
  2012-12-14  8:15 [PATCH] ARM: EXYNOS: Fix compile error in dev-audio.c Jonghwan Choi
@ 2012-12-17  0:42   ` Olof Johansson
  0 siblings, 0 replies; 9+ messages in thread
From: Olof Johansson @ 2012-12-17  0:42 UTC (permalink / raw)
  To: Jonghwan Choi, Padmavathi Venna
  Cc: linux-samsung-soc, Kukjin Kim, Russell King, Mark Brown,
	linux-arm-kernel

On Fri, Dec 14, 2012 at 12:15 AM, Jonghwan Choi <jhbird.choi@samsung.com> wrote:
> arch/arm/mach-exynos/dev-audio.c:58:4: error: unknown field 'src_clk'
> specified in initializer
> arch/arm/mach-exynos/dev-audio.c:58:4: warning: initialization makes integer
> from pointer without a cast [enabled by default]
> arch/arm/mach-exynos/dev-audio.c:58:4: warning: (near initialization for
> 'i2sv5_pdata.type.i2s.idma_addr') [enabled by default]
> arch/arm/mach-exynos/dev-audio.c:91:4: error: unknown field 'src_clk'
> specified in initializer
> arch/arm/mach-exynos/dev-audio.c:91:4: warning: initialization makes integer
> from pointer without a cast [enabled by default]
> arch/arm/mach-exynos/dev-audio.c:91:4: warning: (near initialization for
> 'i2sv3_pdata.type.i2s.idma_addr') [enabled by default]
>
> Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>

This only fixes one of many build errors caused by the i2s change:

      1 arch/arm/mach-s3c64xx/dev-audio.c:113:4: warning:
initialization makes integer from pointer without a cast [enabled by
default]
      1 arch/arm/mach-s3c64xx/dev-audio.c:113:4: warning: (near
initialization for 'i2sv4_pdata.type.i2s.idma_addr') [enabled by
default]
      1 arch/arm/mach-s3c64xx/dev-audio.c:69:4: warning:
initialization makes integer from pointer without a cast [enabled by
default]
      1 arch/arm/mach-s3c64xx/dev-audio.c:69:4: warning: (near
initialization for 'i2sv3_pdata.type.i2s.quirks') [enabled by default]
      1 arch/arm/mach-s5p64x0/dev-audio.c:115:4: warning:
initialization makes integer from pointer without a cast [enabled by
default]
      1 arch/arm/mach-s5p64x0/dev-audio.c:115:4: warning: (near
initialization for 's5p6450_i2s_pdata.type.i2s.quirks') [enabled by
default]
      1 arch/arm/mach-s5p64x0/dev-audio.c:48:4: warning:
initialization makes integer from pointer without a cast [enabled by
default]
      1 arch/arm/mach-s5p64x0/dev-audio.c:48:4: warning: (near
initialization for 's5p6440_i2s_pdata.type.i2s.idma_addr') [enabled by
default]
      1 arch/arm/mach-s5p64x0/dev-audio.c:96:4: warning:
initialization makes integer from pointer without a cast [enabled by
default]
      1 arch/arm/mach-s5p64x0/dev-audio.c:96:4: warning: (near
initialization for 's5p6450_i2s0_pdata.type.i2s.idma_addr') [enabled
by default]
      1 arch/arm/mach-s5pc100/dev-audio.c:53:4: warning:
initialization makes integer from pointer without a cast [enabled by
default]
      1 arch/arm/mach-s5pc100/dev-audio.c:53:4: warning: (near
initialization for 'i2sv5_pdata.type.i2s.idma_addr') [enabled by
default]
      1 arch/arm/mach-s5pc100/dev-audio.c:84:4: warning:
initialization makes integer from pointer without a cast [enabled by
default]
      1 arch/arm/mach-s5pc100/dev-audio.c:84:4: warning: (near
initialization for 'i2sv3_pdata.type.i2s.quirks') [enabled by default]
      1 arch/arm/mach-s5pv210/dev-audio.c:55:4: warning:
initialization makes integer from pointer without a cast [enabled by
default]
      1 arch/arm/mach-s5pv210/dev-audio.c:55:4: warning: (near
initialization for 'i2sv5_pdata.type.i2s.idma_addr') [enabled by
default]
      1 arch/arm/mach-s5pv210/dev-audio.c:87:4: warning:
initialization makes integer from pointer without a cast [enabled by
default]
      1 arch/arm/mach-s5pv210/dev-audio.c:87:4: warning: (near
initialization for 'i2sv3_pdata.type.i2s.quirks') [enabled by default]


Looks like the breakage was caused by the following commit:

commit 1974a042dd15f1f007a3a1a2dd7a23ca0e42c01d
Author:     Padmavathi Venna <padma.v@samsung.com>
AuthorDate: Wed Nov 28 16:17:48 2012 +0530
Commit:     Mark Brown <broonie@opensource.wolfsonmicro.com>
CommitDate: Wed Nov 28 19:18:00 2012 +0000

    ASoC: Samsung: Get I2S src_clk from clock alias id.

Padmavathi, you can't send out code that breaks all Samsung platforms
like this, even if there are patches out there that fixes it. Changes
have to be bisectable, which means that you can't break and unbreak
the build, least of all if you merge through different maintainers.
And you need to tell the other maintainer that there are dependent
patches, you just sent the above patch to Mark without any such
information.

Kukjin, I see that Padmavathi has posted a V3 series of patches to
remove all this from the dev-audio files on November 23. Are you ok
with us picking them up and sending ASAP?


-Olof

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] ARM: EXYNOS: Fix compile error in dev-audio.c
@ 2012-12-17  0:42   ` Olof Johansson
  0 siblings, 0 replies; 9+ messages in thread
From: Olof Johansson @ 2012-12-17  0:42 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Dec 14, 2012 at 12:15 AM, Jonghwan Choi <jhbird.choi@samsung.com> wrote:
> arch/arm/mach-exynos/dev-audio.c:58:4: error: unknown field 'src_clk'
> specified in initializer
> arch/arm/mach-exynos/dev-audio.c:58:4: warning: initialization makes integer
> from pointer without a cast [enabled by default]
> arch/arm/mach-exynos/dev-audio.c:58:4: warning: (near initialization for
> 'i2sv5_pdata.type.i2s.idma_addr') [enabled by default]
> arch/arm/mach-exynos/dev-audio.c:91:4: error: unknown field 'src_clk'
> specified in initializer
> arch/arm/mach-exynos/dev-audio.c:91:4: warning: initialization makes integer
> from pointer without a cast [enabled by default]
> arch/arm/mach-exynos/dev-audio.c:91:4: warning: (near initialization for
> 'i2sv3_pdata.type.i2s.idma_addr') [enabled by default]
>
> Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>

This only fixes one of many build errors caused by the i2s change:

      1 arch/arm/mach-s3c64xx/dev-audio.c:113:4: warning:
initialization makes integer from pointer without a cast [enabled by
default]
      1 arch/arm/mach-s3c64xx/dev-audio.c:113:4: warning: (near
initialization for 'i2sv4_pdata.type.i2s.idma_addr') [enabled by
default]
      1 arch/arm/mach-s3c64xx/dev-audio.c:69:4: warning:
initialization makes integer from pointer without a cast [enabled by
default]
      1 arch/arm/mach-s3c64xx/dev-audio.c:69:4: warning: (near
initialization for 'i2sv3_pdata.type.i2s.quirks') [enabled by default]
      1 arch/arm/mach-s5p64x0/dev-audio.c:115:4: warning:
initialization makes integer from pointer without a cast [enabled by
default]
      1 arch/arm/mach-s5p64x0/dev-audio.c:115:4: warning: (near
initialization for 's5p6450_i2s_pdata.type.i2s.quirks') [enabled by
default]
      1 arch/arm/mach-s5p64x0/dev-audio.c:48:4: warning:
initialization makes integer from pointer without a cast [enabled by
default]
      1 arch/arm/mach-s5p64x0/dev-audio.c:48:4: warning: (near
initialization for 's5p6440_i2s_pdata.type.i2s.idma_addr') [enabled by
default]
      1 arch/arm/mach-s5p64x0/dev-audio.c:96:4: warning:
initialization makes integer from pointer without a cast [enabled by
default]
      1 arch/arm/mach-s5p64x0/dev-audio.c:96:4: warning: (near
initialization for 's5p6450_i2s0_pdata.type.i2s.idma_addr') [enabled
by default]
      1 arch/arm/mach-s5pc100/dev-audio.c:53:4: warning:
initialization makes integer from pointer without a cast [enabled by
default]
      1 arch/arm/mach-s5pc100/dev-audio.c:53:4: warning: (near
initialization for 'i2sv5_pdata.type.i2s.idma_addr') [enabled by
default]
      1 arch/arm/mach-s5pc100/dev-audio.c:84:4: warning:
initialization makes integer from pointer without a cast [enabled by
default]
      1 arch/arm/mach-s5pc100/dev-audio.c:84:4: warning: (near
initialization for 'i2sv3_pdata.type.i2s.quirks') [enabled by default]
      1 arch/arm/mach-s5pv210/dev-audio.c:55:4: warning:
initialization makes integer from pointer without a cast [enabled by
default]
      1 arch/arm/mach-s5pv210/dev-audio.c:55:4: warning: (near
initialization for 'i2sv5_pdata.type.i2s.idma_addr') [enabled by
default]
      1 arch/arm/mach-s5pv210/dev-audio.c:87:4: warning:
initialization makes integer from pointer without a cast [enabled by
default]
      1 arch/arm/mach-s5pv210/dev-audio.c:87:4: warning: (near
initialization for 'i2sv3_pdata.type.i2s.quirks') [enabled by default]


Looks like the breakage was caused by the following commit:

commit 1974a042dd15f1f007a3a1a2dd7a23ca0e42c01d
Author:     Padmavathi Venna <padma.v@samsung.com>
AuthorDate: Wed Nov 28 16:17:48 2012 +0530
Commit:     Mark Brown <broonie@opensource.wolfsonmicro.com>
CommitDate: Wed Nov 28 19:18:00 2012 +0000

    ASoC: Samsung: Get I2S src_clk from clock alias id.

Padmavathi, you can't send out code that breaks all Samsung platforms
like this, even if there are patches out there that fixes it. Changes
have to be bisectable, which means that you can't break and unbreak
the build, least of all if you merge through different maintainers.
And you need to tell the other maintainer that there are dependent
patches, you just sent the above patch to Mark without any such
information.

Kukjin, I see that Padmavathi has posted a V3 series of patches to
remove all this from the dev-audio files on November 23. Are you ok
with us picking them up and sending ASAP?


-Olof

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: EXYNOS: Fix compile error in dev-audio.c
  2012-12-17  0:42   ` Olof Johansson
@ 2012-12-17  4:18     ` Padma Venkat
  -1 siblings, 0 replies; 9+ messages in thread
From: Padma Venkat @ 2012-12-17  4:18 UTC (permalink / raw)
  To: Olof Johansson
  Cc: Jonghwan Choi, Padmavathi Venna, linux-samsung-soc, Kukjin Kim,
	Russell King, Mark Brown, linux-arm-kernel

Hi,

On Mon, Dec 17, 2012 at 6:12 AM, Olof Johansson <olof@lixom.net> wrote:
> On Fri, Dec 14, 2012 at 12:15 AM, Jonghwan Choi <jhbird.choi@samsung.com> wrote:
>> arch/arm/mach-exynos/dev-audio.c:58:4: error: unknown field 'src_clk'
>> specified in initializer
>> arch/arm/mach-exynos/dev-audio.c:58:4: warning: initialization makes integer
>> from pointer without a cast [enabled by default]
>> arch/arm/mach-exynos/dev-audio.c:58:4: warning: (near initialization for
>> 'i2sv5_pdata.type.i2s.idma_addr') [enabled by default]
>> arch/arm/mach-exynos/dev-audio.c:91:4: error: unknown field 'src_clk'
>> specified in initializer
>> arch/arm/mach-exynos/dev-audio.c:91:4: warning: initialization makes integer
>> from pointer without a cast [enabled by default]
>> arch/arm/mach-exynos/dev-audio.c:91:4: warning: (near initialization for
>> 'i2sv3_pdata.type.i2s.idma_addr') [enabled by default]
>>
>> Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
>
> This only fixes one of many build errors caused by the i2s change:
>
>       1 arch/arm/mach-s3c64xx/dev-audio.c:113:4: warning:
> initialization makes integer from pointer without a cast [enabled by
> default]
>       1 arch/arm/mach-s3c64xx/dev-audio.c:113:4: warning: (near
> initialization for 'i2sv4_pdata.type.i2s.idma_addr') [enabled by
> default]
>       1 arch/arm/mach-s3c64xx/dev-audio.c:69:4: warning:
> initialization makes integer from pointer without a cast [enabled by
> default]
>       1 arch/arm/mach-s3c64xx/dev-audio.c:69:4: warning: (near
> initialization for 'i2sv3_pdata.type.i2s.quirks') [enabled by default]
>       1 arch/arm/mach-s5p64x0/dev-audio.c:115:4: warning:
> initialization makes integer from pointer without a cast [enabled by
> default]
>       1 arch/arm/mach-s5p64x0/dev-audio.c:115:4: warning: (near
> initialization for 's5p6450_i2s_pdata.type.i2s.quirks') [enabled by
> default]
>       1 arch/arm/mach-s5p64x0/dev-audio.c:48:4: warning:
> initialization makes integer from pointer without a cast [enabled by
> default]
>       1 arch/arm/mach-s5p64x0/dev-audio.c:48:4: warning: (near
> initialization for 's5p6440_i2s_pdata.type.i2s.idma_addr') [enabled by
> default]
>       1 arch/arm/mach-s5p64x0/dev-audio.c:96:4: warning:
> initialization makes integer from pointer without a cast [enabled by
> default]
>       1 arch/arm/mach-s5p64x0/dev-audio.c:96:4: warning: (near
> initialization for 's5p6450_i2s0_pdata.type.i2s.idma_addr') [enabled
> by default]
>       1 arch/arm/mach-s5pc100/dev-audio.c:53:4: warning:
> initialization makes integer from pointer without a cast [enabled by
> default]
>       1 arch/arm/mach-s5pc100/dev-audio.c:53:4: warning: (near
> initialization for 'i2sv5_pdata.type.i2s.idma_addr') [enabled by
> default]
>       1 arch/arm/mach-s5pc100/dev-audio.c:84:4: warning:
> initialization makes integer from pointer without a cast [enabled by
> default]
>       1 arch/arm/mach-s5pc100/dev-audio.c:84:4: warning: (near
> initialization for 'i2sv3_pdata.type.i2s.quirks') [enabled by default]
>       1 arch/arm/mach-s5pv210/dev-audio.c:55:4: warning:
> initialization makes integer from pointer without a cast [enabled by
> default]
>       1 arch/arm/mach-s5pv210/dev-audio.c:55:4: warning: (near
> initialization for 'i2sv5_pdata.type.i2s.idma_addr') [enabled by
> default]
>       1 arch/arm/mach-s5pv210/dev-audio.c:87:4: warning:
> initialization makes integer from pointer without a cast [enabled by
> default]
>       1 arch/arm/mach-s5pv210/dev-audio.c:87:4: warning: (near
> initialization for 'i2sv3_pdata.type.i2s.quirks') [enabled by default]
>
>
> Looks like the breakage was caused by the following commit:
>
> commit 1974a042dd15f1f007a3a1a2dd7a23ca0e42c01d
> Author:     Padmavathi Venna <padma.v@samsung.com>
> AuthorDate: Wed Nov 28 16:17:48 2012 +0530
> Commit:     Mark Brown <broonie@opensource.wolfsonmicro.com>
> CommitDate: Wed Nov 28 19:18:00 2012 +0000
>
>     ASoC: Samsung: Get I2S src_clk from clock alias id.
>
> Padmavathi, you can't send out code that breaks all Samsung platforms
> like this, even if there are patches out there that fixes it. Changes
> have to be bisectable, which means that you can't break and unbreak
> the build, least of all if you merge through different maintainers.
> And you need to tell the other maintainer that there are dependent
> patches, you just sent the above patch to Mark without any such
> information.

In V3, as I posted all the patches together I didn't mention about the
dependency. But I could have mentioned about it in V4. I apologize for
the build break.

>
> Kukjin, I see that Padmavathi has posted a V3 series of patches to
> remove all this from the dev-audio files on November 23. Are you ok
> with us picking them up and sending ASAP?

Kukjin, Could you please give your conformation for the above patches?

>
>
> -Olof
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thanks
Padma

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] ARM: EXYNOS: Fix compile error in dev-audio.c
@ 2012-12-17  4:18     ` Padma Venkat
  0 siblings, 0 replies; 9+ messages in thread
From: Padma Venkat @ 2012-12-17  4:18 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On Mon, Dec 17, 2012 at 6:12 AM, Olof Johansson <olof@lixom.net> wrote:
> On Fri, Dec 14, 2012 at 12:15 AM, Jonghwan Choi <jhbird.choi@samsung.com> wrote:
>> arch/arm/mach-exynos/dev-audio.c:58:4: error: unknown field 'src_clk'
>> specified in initializer
>> arch/arm/mach-exynos/dev-audio.c:58:4: warning: initialization makes integer
>> from pointer without a cast [enabled by default]
>> arch/arm/mach-exynos/dev-audio.c:58:4: warning: (near initialization for
>> 'i2sv5_pdata.type.i2s.idma_addr') [enabled by default]
>> arch/arm/mach-exynos/dev-audio.c:91:4: error: unknown field 'src_clk'
>> specified in initializer
>> arch/arm/mach-exynos/dev-audio.c:91:4: warning: initialization makes integer
>> from pointer without a cast [enabled by default]
>> arch/arm/mach-exynos/dev-audio.c:91:4: warning: (near initialization for
>> 'i2sv3_pdata.type.i2s.idma_addr') [enabled by default]
>>
>> Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
>
> This only fixes one of many build errors caused by the i2s change:
>
>       1 arch/arm/mach-s3c64xx/dev-audio.c:113:4: warning:
> initialization makes integer from pointer without a cast [enabled by
> default]
>       1 arch/arm/mach-s3c64xx/dev-audio.c:113:4: warning: (near
> initialization for 'i2sv4_pdata.type.i2s.idma_addr') [enabled by
> default]
>       1 arch/arm/mach-s3c64xx/dev-audio.c:69:4: warning:
> initialization makes integer from pointer without a cast [enabled by
> default]
>       1 arch/arm/mach-s3c64xx/dev-audio.c:69:4: warning: (near
> initialization for 'i2sv3_pdata.type.i2s.quirks') [enabled by default]
>       1 arch/arm/mach-s5p64x0/dev-audio.c:115:4: warning:
> initialization makes integer from pointer without a cast [enabled by
> default]
>       1 arch/arm/mach-s5p64x0/dev-audio.c:115:4: warning: (near
> initialization for 's5p6450_i2s_pdata.type.i2s.quirks') [enabled by
> default]
>       1 arch/arm/mach-s5p64x0/dev-audio.c:48:4: warning:
> initialization makes integer from pointer without a cast [enabled by
> default]
>       1 arch/arm/mach-s5p64x0/dev-audio.c:48:4: warning: (near
> initialization for 's5p6440_i2s_pdata.type.i2s.idma_addr') [enabled by
> default]
>       1 arch/arm/mach-s5p64x0/dev-audio.c:96:4: warning:
> initialization makes integer from pointer without a cast [enabled by
> default]
>       1 arch/arm/mach-s5p64x0/dev-audio.c:96:4: warning: (near
> initialization for 's5p6450_i2s0_pdata.type.i2s.idma_addr') [enabled
> by default]
>       1 arch/arm/mach-s5pc100/dev-audio.c:53:4: warning:
> initialization makes integer from pointer without a cast [enabled by
> default]
>       1 arch/arm/mach-s5pc100/dev-audio.c:53:4: warning: (near
> initialization for 'i2sv5_pdata.type.i2s.idma_addr') [enabled by
> default]
>       1 arch/arm/mach-s5pc100/dev-audio.c:84:4: warning:
> initialization makes integer from pointer without a cast [enabled by
> default]
>       1 arch/arm/mach-s5pc100/dev-audio.c:84:4: warning: (near
> initialization for 'i2sv3_pdata.type.i2s.quirks') [enabled by default]
>       1 arch/arm/mach-s5pv210/dev-audio.c:55:4: warning:
> initialization makes integer from pointer without a cast [enabled by
> default]
>       1 arch/arm/mach-s5pv210/dev-audio.c:55:4: warning: (near
> initialization for 'i2sv5_pdata.type.i2s.idma_addr') [enabled by
> default]
>       1 arch/arm/mach-s5pv210/dev-audio.c:87:4: warning:
> initialization makes integer from pointer without a cast [enabled by
> default]
>       1 arch/arm/mach-s5pv210/dev-audio.c:87:4: warning: (near
> initialization for 'i2sv3_pdata.type.i2s.quirks') [enabled by default]
>
>
> Looks like the breakage was caused by the following commit:
>
> commit 1974a042dd15f1f007a3a1a2dd7a23ca0e42c01d
> Author:     Padmavathi Venna <padma.v@samsung.com>
> AuthorDate: Wed Nov 28 16:17:48 2012 +0530
> Commit:     Mark Brown <broonie@opensource.wolfsonmicro.com>
> CommitDate: Wed Nov 28 19:18:00 2012 +0000
>
>     ASoC: Samsung: Get I2S src_clk from clock alias id.
>
> Padmavathi, you can't send out code that breaks all Samsung platforms
> like this, even if there are patches out there that fixes it. Changes
> have to be bisectable, which means that you can't break and unbreak
> the build, least of all if you merge through different maintainers.
> And you need to tell the other maintainer that there are dependent
> patches, you just sent the above patch to Mark without any such
> information.

In V3, as I posted all the patches together I didn't mention about the
dependency. But I could have mentioned about it in V4. I apologize for
the build break.

>
> Kukjin, I see that Padmavathi has posted a V3 series of patches to
> remove all this from the dev-audio files on November 23. Are you ok
> with us picking them up and sending ASAP?

Kukjin, Could you please give your conformation for the above patches?

>
>
> -Olof
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thanks
Padma

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH] ARM: EXYNOS: Fix compile error in dev-audio.c
  2012-12-17  0:42   ` Olof Johansson
@ 2012-12-19  2:49     ` Kukjin Kim
  -1 siblings, 0 replies; 9+ messages in thread
From: Kukjin Kim @ 2012-12-19  2:49 UTC (permalink / raw)
  To: 'Olof Johansson', 'Jonghwan Choi',
	'Padmavathi Venna'
  Cc: linux-samsung-soc, 'Russell King', 'Mark Brown',
	linux-arm-kernel

Olof Johansson wrote:

[...]
 
> Looks like the breakage was caused by the following commit:
> 
> commit 1974a042dd15f1f007a3a1a2dd7a23ca0e42c01d
> Author:     Padmavathi Venna <padma.v@samsung.com>
> AuthorDate: Wed Nov 28 16:17:48 2012 +0530
> Commit:     Mark Brown <broonie@opensource.wolfsonmicro.com>
> CommitDate: Wed Nov 28 19:18:00 2012 +0000
> 
>     ASoC: Samsung: Get I2S src_clk from clock alias id.
> 
> Padmavathi, you can't send out code that breaks all Samsung platforms
> like this, even if there are patches out there that fixes it. Changes
> have to be bisectable, which means that you can't break and unbreak
> the build, least of all if you merge through different maintainers.
> And you need to tell the other maintainer that there are dependent
> patches, you just sent the above patch to Mark without any such
> information.
> 
Oops, I thought the 'src_clk'  should be restored with my drop the commit
48a2050d ("ARM: SAMSUNG: Delete the unnecessary variable"), however, seems
other patch has same changes...What's happening?

See below,
http://lists.infradead.org/pipermail/linux-arm-kernel/2012-November/134979.h
tml

> Kukjin, I see that Padmavathi has posted a V3 series of patches to
> remove all this from the dev-audio files on November 23. Are you ok
> with us picking them up and sending ASAP?
> 
Hmm, just Mark's following can fix it but I didn't look at it yet.

http://lists.infradead.org/pipermail/linux-arm-kernel/2012-November/134911.h
tml

- Kukjin

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] ARM: EXYNOS: Fix compile error in dev-audio.c
@ 2012-12-19  2:49     ` Kukjin Kim
  0 siblings, 0 replies; 9+ messages in thread
From: Kukjin Kim @ 2012-12-19  2:49 UTC (permalink / raw)
  To: linux-arm-kernel

Olof Johansson wrote:

[...]
 
> Looks like the breakage was caused by the following commit:
> 
> commit 1974a042dd15f1f007a3a1a2dd7a23ca0e42c01d
> Author:     Padmavathi Venna <padma.v@samsung.com>
> AuthorDate: Wed Nov 28 16:17:48 2012 +0530
> Commit:     Mark Brown <broonie@opensource.wolfsonmicro.com>
> CommitDate: Wed Nov 28 19:18:00 2012 +0000
> 
>     ASoC: Samsung: Get I2S src_clk from clock alias id.
> 
> Padmavathi, you can't send out code that breaks all Samsung platforms
> like this, even if there are patches out there that fixes it. Changes
> have to be bisectable, which means that you can't break and unbreak
> the build, least of all if you merge through different maintainers.
> And you need to tell the other maintainer that there are dependent
> patches, you just sent the above patch to Mark without any such
> information.
> 
Oops, I thought the 'src_clk'  should be restored with my drop the commit
48a2050d ("ARM: SAMSUNG: Delete the unnecessary variable"), however, seems
other patch has same changes...What's happening?

See below,
http://lists.infradead.org/pipermail/linux-arm-kernel/2012-November/134979.h
tml

> Kukjin, I see that Padmavathi has posted a V3 series of patches to
> remove all this from the dev-audio files on November 23. Are you ok
> with us picking them up and sending ASAP?
> 
Hmm, just Mark's following can fix it but I didn't look at it yet.

http://lists.infradead.org/pipermail/linux-arm-kernel/2012-November/134911.h
tml

- Kukjin

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH] ARM: EXYNOS: Fix compile error in dev-audio.c
  2012-12-17  0:42   ` Olof Johansson
@ 2012-12-19 18:30     ` Kukjin Kim
  -1 siblings, 0 replies; 9+ messages in thread
From: Kukjin Kim @ 2012-12-19 18:30 UTC (permalink / raw)
  To: 'Olof Johansson', 'Jonghwan Choi',
	'Padmavathi Venna'
  Cc: linux-samsung-soc, 'Russell King', 'Mark Brown',
	linux-arm-kernel

Kukjin Kim wrote:
> 
> Olof Johansson wrote:
> 
> [...]
> 
> > Looks like the breakage was caused by the following commit:
> >
> > commit 1974a042dd15f1f007a3a1a2dd7a23ca0e42c01d
> > Author:     Padmavathi Venna <padma.v@samsung.com>
> > AuthorDate: Wed Nov 28 16:17:48 2012 +0530
> > Commit:     Mark Brown <broonie@opensource.wolfsonmicro.com>
> > CommitDate: Wed Nov 28 19:18:00 2012 +0000
> >
> >     ASoC: Samsung: Get I2S src_clk from clock alias id.
> >
> > Padmavathi, you can't send out code that breaks all Samsung platforms
> > like this, even if there are patches out there that fixes it. Changes
> > have to be bisectable, which means that you can't break and unbreak
> > the build, least of all if you merge through different maintainers.
> > And you need to tell the other maintainer that there are dependent
> > patches, you just sent the above patch to Mark without any such
> > information.
> >
> Oops, I thought the 'src_clk'  should be restored with my drop the commit
> 48a2050d ("ARM: SAMSUNG: Delete the unnecessary variable"), however,
> seems other patch has same changes...What's happening?
> 
> See below,
> http://lists.infradead.org/pipermail/linux-arm-kernel/2012-
> November/134979.html
> 
> > Kukjin, I see that Padmavathi has posted a V3 series of patches to
> > remove all this from the dev-audio files on November 23. Are you ok
> > with us picking them up and sending ASAP?
> >
> Hmm, just Mark's following can fix it but I didn't look at it yet.
> 
> http://lists.infradead.org/pipermail/linux-arm-kernel/2012-
> November/134911.html
> 
Olof, I sent 'git pull request' for fix the problems just now, please check
it.

Thanks.

- Kukjin

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] ARM: EXYNOS: Fix compile error in dev-audio.c
@ 2012-12-19 18:30     ` Kukjin Kim
  0 siblings, 0 replies; 9+ messages in thread
From: Kukjin Kim @ 2012-12-19 18:30 UTC (permalink / raw)
  To: linux-arm-kernel

Kukjin Kim wrote:
> 
> Olof Johansson wrote:
> 
> [...]
> 
> > Looks like the breakage was caused by the following commit:
> >
> > commit 1974a042dd15f1f007a3a1a2dd7a23ca0e42c01d
> > Author:     Padmavathi Venna <padma.v@samsung.com>
> > AuthorDate: Wed Nov 28 16:17:48 2012 +0530
> > Commit:     Mark Brown <broonie@opensource.wolfsonmicro.com>
> > CommitDate: Wed Nov 28 19:18:00 2012 +0000
> >
> >     ASoC: Samsung: Get I2S src_clk from clock alias id.
> >
> > Padmavathi, you can't send out code that breaks all Samsung platforms
> > like this, even if there are patches out there that fixes it. Changes
> > have to be bisectable, which means that you can't break and unbreak
> > the build, least of all if you merge through different maintainers.
> > And you need to tell the other maintainer that there are dependent
> > patches, you just sent the above patch to Mark without any such
> > information.
> >
> Oops, I thought the 'src_clk'  should be restored with my drop the commit
> 48a2050d ("ARM: SAMSUNG: Delete the unnecessary variable"), however,
> seems other patch has same changes...What's happening?
> 
> See below,
> http://lists.infradead.org/pipermail/linux-arm-kernel/2012-
> November/134979.html
> 
> > Kukjin, I see that Padmavathi has posted a V3 series of patches to
> > remove all this from the dev-audio files on November 23. Are you ok
> > with us picking them up and sending ASAP?
> >
> Hmm, just Mark's following can fix it but I didn't look at it yet.
> 
> http://lists.infradead.org/pipermail/linux-arm-kernel/2012-
> November/134911.html
> 
Olof, I sent 'git pull request' for fix the problems just now, please check
it.

Thanks.

- Kukjin

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2012-12-19 18:30 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-14  8:15 [PATCH] ARM: EXYNOS: Fix compile error in dev-audio.c Jonghwan Choi
2012-12-17  0:42 ` Olof Johansson
2012-12-17  0:42   ` Olof Johansson
2012-12-17  4:18   ` Padma Venkat
2012-12-17  4:18     ` Padma Venkat
2012-12-19  2:49   ` Kukjin Kim
2012-12-19  2:49     ` Kukjin Kim
2012-12-19 18:30   ` Kukjin Kim
2012-12-19 18:30     ` Kukjin Kim

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.