All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: remove blank interrupt-parent properties
@ 2012-04-12 15:17 Rob Herring
  2012-04-13 11:11 ` Lee Jones
  2012-04-15  0:47 ` Olof Johansson
  0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2012-04-12 15:17 UTC (permalink / raw)
  To: linux-arm-kernel

From: Rob Herring <rob.herring@calxeda.com>

These were incorrectly introduced and can cause problems for of_irq_init.

The correct way to define a root controller is no interrupt-parent set at
all or the interrupt-parent is set to the root controller itself when
inherited from a parent node.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
---
Arnd, Olof,

Please apply for 3.4.

Rob

 arch/arm/boot/dts/at91sam9g20.dtsi |    1 -
 arch/arm/boot/dts/at91sam9g45.dtsi |    1 -
 arch/arm/boot/dts/at91sam9x5.dtsi  |    1 -
 arch/arm/boot/dts/db8500.dtsi      |    1 -
 arch/arm/boot/dts/highbank.dts     |    1 -
 5 files changed, 5 deletions(-)

diff --git a/arch/arm/boot/dts/at91sam9g20.dtsi b/arch/arm/boot/dts/at91sam9g20.dtsi
index 92f3662..6c33256 100644
--- a/arch/arm/boot/dts/at91sam9g20.dtsi
+++ b/arch/arm/boot/dts/at91sam9g20.dtsi
@@ -55,7 +55,6 @@
 				#interrupt-cells = <2>;
 				compatible = "atmel,at91rm9200-aic";
 				interrupt-controller;
-				interrupt-parent;
 				reg = <0xfffff000 0x200>;
 			};
 
diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi
index 3d0c32f..2815be1 100644
--- a/arch/arm/boot/dts/at91sam9g45.dtsi
+++ b/arch/arm/boot/dts/at91sam9g45.dtsi
@@ -56,7 +56,6 @@
 				#interrupt-cells = <2>;
 				compatible = "atmel,at91rm9200-aic";
 				interrupt-controller;
-				interrupt-parent;
 				reg = <0xfffff000 0x200>;
 			};
 
diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
index c111001..1995c44 100644
--- a/arch/arm/boot/dts/at91sam9x5.dtsi
+++ b/arch/arm/boot/dts/at91sam9x5.dtsi
@@ -54,7 +54,6 @@
 				#interrupt-cells = <2>;
 				compatible = "atmel,at91rm9200-aic";
 				interrupt-controller;
-				interrupt-parent;
 				reg = <0xfffff000 0x200>;
 			};
 
diff --git a/arch/arm/boot/dts/db8500.dtsi b/arch/arm/boot/dts/db8500.dtsi
index d73dce6..14bc307 100644
--- a/arch/arm/boot/dts/db8500.dtsi
+++ b/arch/arm/boot/dts/db8500.dtsi
@@ -24,7 +24,6 @@
 			#interrupt-cells = <3>;
 			#address-cells = <1>;
 			interrupt-controller;
-			interrupt-parent;
 			reg = <0xa0411000 0x1000>,
 			      <0xa0410100 0x100>;
 		};
diff --git a/arch/arm/boot/dts/highbank.dts b/arch/arm/boot/dts/highbank.dts
index 357e780..4121b06 100644
--- a/arch/arm/boot/dts/highbank.dts
+++ b/arch/arm/boot/dts/highbank.dts
@@ -100,7 +100,6 @@
 			#size-cells = <0>;
 			#address-cells = <1>;
 			interrupt-controller;
-			interrupt-parent;
 			reg = <0xfff11000 0x1000>,
 			      <0xfff10100 0x100>;
 		};
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [PATCH] ARM: dts: remove blank interrupt-parent properties
  2012-04-12 15:17 [PATCH] ARM: dts: remove blank interrupt-parent properties Rob Herring
@ 2012-04-13 11:11 ` Lee Jones
  2012-04-15  0:47 ` Olof Johansson
  1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2012-04-13 11:11 UTC (permalink / raw)
  To: linux-arm-kernel

On 12/04/12 16:17, Rob Herring wrote:
> From: Rob Herring<rob.herring@calxeda.com>
>
> These were incorrectly introduced and can cause problems for of_irq_init.
>
> The correct way to define a root controller is no interrupt-parent set at
> all or the interrupt-parent is set to the root controller itself when
> inherited from a parent node.
>
> Signed-off-by: Rob Herring<rob.herring@calxeda.com>

Tested-by: Lee Jones <lee.jones@linaro.org>

Works for me. Now I can use my GPIO chained IRQs correctly.

> ---
> Arnd, Olof,
>
> Please apply for 3.4.
>
> Rob
>
>   arch/arm/boot/dts/at91sam9g20.dtsi |    1 -
>   arch/arm/boot/dts/at91sam9g45.dtsi |    1 -
>   arch/arm/boot/dts/at91sam9x5.dtsi  |    1 -
>   arch/arm/boot/dts/db8500.dtsi      |    1 -
>   arch/arm/boot/dts/highbank.dts     |    1 -
>   5 files changed, 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91sam9g20.dtsi b/arch/arm/boot/dts/at91sam9g20.dtsi
> index 92f3662..6c33256 100644
> --- a/arch/arm/boot/dts/at91sam9g20.dtsi
> +++ b/arch/arm/boot/dts/at91sam9g20.dtsi
> @@ -55,7 +55,6 @@
>   				#interrupt-cells =<2>;
>   				compatible = "atmel,at91rm9200-aic";
>   				interrupt-controller;
> -				interrupt-parent;
>   				reg =<0xfffff000 0x200>;
>   			};
>
> diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi
> index 3d0c32f..2815be1 100644
> --- a/arch/arm/boot/dts/at91sam9g45.dtsi
> +++ b/arch/arm/boot/dts/at91sam9g45.dtsi
> @@ -56,7 +56,6 @@
>   				#interrupt-cells =<2>;
>   				compatible = "atmel,at91rm9200-aic";
>   				interrupt-controller;
> -				interrupt-parent;
>   				reg =<0xfffff000 0x200>;
>   			};
>
> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
> index c111001..1995c44 100644
> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
> @@ -54,7 +54,6 @@
>   				#interrupt-cells =<2>;
>   				compatible = "atmel,at91rm9200-aic";
>   				interrupt-controller;
> -				interrupt-parent;
>   				reg =<0xfffff000 0x200>;
>   			};
>
> diff --git a/arch/arm/boot/dts/db8500.dtsi b/arch/arm/boot/dts/db8500.dtsi
> index d73dce6..14bc307 100644
> --- a/arch/arm/boot/dts/db8500.dtsi
> +++ b/arch/arm/boot/dts/db8500.dtsi
> @@ -24,7 +24,6 @@
>   			#interrupt-cells =<3>;
>   			#address-cells =<1>;
>   			interrupt-controller;
> -			interrupt-parent;
>   			reg =<0xa0411000 0x1000>,
>   			<0xa0410100 0x100>;
>   		};
> diff --git a/arch/arm/boot/dts/highbank.dts b/arch/arm/boot/dts/highbank.dts
> index 357e780..4121b06 100644
> --- a/arch/arm/boot/dts/highbank.dts
> +++ b/arch/arm/boot/dts/highbank.dts
> @@ -100,7 +100,6 @@
>   			#size-cells =<0>;
>   			#address-cells =<1>;
>   			interrupt-controller;
> -			interrupt-parent;
>   			reg =<0xfff11000 0x1000>,
>   			<0xfff10100 0x100>;
>   		};


-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [PATCH] ARM: dts: remove blank interrupt-parent properties
  2012-04-12 15:17 [PATCH] ARM: dts: remove blank interrupt-parent properties Rob Herring
  2012-04-13 11:11 ` Lee Jones
@ 2012-04-15  0:47 ` Olof Johansson
  1 sibling, 0 replies; 3+ messages in thread
From: Olof Johansson @ 2012-04-15  0:47 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Apr 12, 2012 at 8:17 AM, Rob Herring <robherring2@gmail.com> wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> These were incorrectly introduced and can cause problems for of_irq_init.
>
> The correct way to define a root controller is no interrupt-parent set at
> all or the interrupt-parent is set to the root controller itself when
> inherited from a parent node.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> ---
> Arnd, Olof,
>
> Please apply for 3.4.

Thanks, applied.


-Olof

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-15  0:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-12 15:17 [PATCH] ARM: dts: remove blank interrupt-parent properties Rob Herring
2012-04-13 11:11 ` Lee Jones
2012-04-15  0:47 ` Olof Johansson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.