* [PATCH V2 0/3] ARM: dts: add Raspberry Pi Compute Module 3 and IO board @ 2018-08-27 18:05 ` Stefan Wahren 0 siblings, 0 replies; 26+ messages in thread From: Stefan Wahren @ 2018-08-27 18:05 UTC (permalink / raw) To: Florian Fainelli Cc: Mark Rutland, devicetree, Arnd Bergmann, Scott Branden, Ray Jui, Stefan Wahren, Phil Elwell, Alexander Graf, Eric Anholt, Rob Herring, bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel This patch series add support for Rasberry Pi Compute Module 3 and Compute Module 3 Lite. Changes in V2: - add Reviewed-by tag from Rob - split arm and arm64 into separate patches Stefan Wahren (3): dt-bindings: bcm: Add Raspberry Pi CM3 and CM3L ARM: dts: add Raspberry Pi Compute Module 3 and IO board arm64: dts: broadcom: Add reference to Compute Module IO Board V3 .../devicetree/bindings/arm/bcm/brcm,bcm2835.txt | 8 ++ arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dts | 87 ++++++++++++++++++++++ arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi | 52 +++++++++++++ arch/arm64/boot/dts/broadcom/Makefile | 3 +- .../boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 + 6 files changed, 152 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dts create mode 100644 arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi create mode 100644 arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts -- 2.7.4 ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH V2 0/3] ARM: dts: add Raspberry Pi Compute Module 3 and IO board @ 2018-08-27 18:05 ` Stefan Wahren 0 siblings, 0 replies; 26+ messages in thread From: Stefan Wahren @ 2018-08-27 18:05 UTC (permalink / raw) To: linux-arm-kernel This patch series add support for Rasberry Pi Compute Module 3 and Compute Module 3 Lite. Changes in V2: - add Reviewed-by tag from Rob - split arm and arm64 into separate patches Stefan Wahren (3): dt-bindings: bcm: Add Raspberry Pi CM3 and CM3L ARM: dts: add Raspberry Pi Compute Module 3 and IO board arm64: dts: broadcom: Add reference to Compute Module IO Board V3 .../devicetree/bindings/arm/bcm/brcm,bcm2835.txt | 8 ++ arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dts | 87 ++++++++++++++++++++++ arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi | 52 +++++++++++++ arch/arm64/boot/dts/broadcom/Makefile | 3 +- .../boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 + 6 files changed, 152 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dts create mode 100644 arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi create mode 100644 arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts -- 2.7.4 ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH V2 1/3] dt-bindings: bcm: Add Raspberry Pi CM3 and CM3L 2018-08-27 18:05 ` Stefan Wahren @ 2018-08-27 18:05 ` Stefan Wahren -1 siblings, 0 replies; 26+ messages in thread From: Stefan Wahren @ 2018-08-27 18:05 UTC (permalink / raw) To: Florian Fainelli Cc: Mark Rutland, devicetree, Arnd Bergmann, Scott Branden, Ray Jui, Stefan Wahren, Phil Elwell, Alexander Graf, Eric Anholt, Rob Herring, bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel This adds the root properties for Raspberry Pi Compute Module 3 and Compute Module 3 Lite. Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> Reviewed-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt index 1e3e29a..0dcc3ea 100644 --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt @@ -42,6 +42,14 @@ Raspberry Pi Compute Module Required root node properties: compatible = "raspberrypi,compute-module", "brcm,bcm2835"; +Raspberry Pi Compute Module 3 +Required root node properties: +compatible = "raspberrypi,3-compute-module", "brcm,bcm2837"; + +Raspberry Pi Compute Module 3 Lite +Required root node properties: +compatible = "raspberrypi,3-compute-module-lite", "brcm,bcm2837"; + Raspberry Pi Zero Required root node properties: compatible = "raspberrypi,model-zero", "brcm,bcm2835"; -- 2.7.4 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH V2 1/3] dt-bindings: bcm: Add Raspberry Pi CM3 and CM3L @ 2018-08-27 18:05 ` Stefan Wahren 0 siblings, 0 replies; 26+ messages in thread From: Stefan Wahren @ 2018-08-27 18:05 UTC (permalink / raw) To: linux-arm-kernel This adds the root properties for Raspberry Pi Compute Module 3 and Compute Module 3 Lite. Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> Reviewed-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt index 1e3e29a..0dcc3ea 100644 --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt @@ -42,6 +42,14 @@ Raspberry Pi Compute Module Required root node properties: compatible = "raspberrypi,compute-module", "brcm,bcm2835"; +Raspberry Pi Compute Module 3 +Required root node properties: +compatible = "raspberrypi,3-compute-module", "brcm,bcm2837"; + +Raspberry Pi Compute Module 3 Lite +Required root node properties: +compatible = "raspberrypi,3-compute-module-lite", "brcm,bcm2837"; + Raspberry Pi Zero Required root node properties: compatible = "raspberrypi,model-zero", "brcm,bcm2835"; -- 2.7.4 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH V2 2/3] ARM: dts: add Raspberry Pi Compute Module 3 and IO board 2018-08-27 18:05 ` Stefan Wahren @ 2018-08-27 18:05 ` Stefan Wahren -1 siblings, 0 replies; 26+ messages in thread From: Stefan Wahren @ 2018-08-27 18:05 UTC (permalink / raw) To: Florian Fainelli Cc: Mark Rutland, devicetree, Arnd Bergmann, Scott Branden, Ray Jui, Stefan Wahren, Phil Elwell, Alexander Graf, Eric Anholt, Rob Herring, bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel The Raspberry Pi Compute Module 3 (CM3) and the Raspberry Pi Compute Module 3 Lite (CM3L) are SoMs which contains a BCM2837 processor, 1 GB RAM and a GPIO expander. The CM3 has a 4 GB eMMC, but on the CM3L the eMMC is unpopulated and it's up to the user to connect their own SD/MMC device. The dtsi file is designed to work for both modules. There is also a matching carrier board which is called Compute Module IO Board V3. Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dts | 87 +++++++++++++++++++++++++++++++ arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi | 52 ++++++++++++++++++ 3 files changed, 140 insertions(+) create mode 100644 arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dts create mode 100644 arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index b5bd3de..35c749f 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -81,6 +81,7 @@ dtb-$(CONFIG_ARCH_BCM2835) += \ bcm2836-rpi-2-b.dtb \ bcm2837-rpi-3-b.dtb \ bcm2837-rpi-3-b-plus.dtb \ + bcm2837-rpi-cm3-io3.dtb \ bcm2835-rpi-zero.dtb \ bcm2835-rpi-zero-w.dtb dtb-$(CONFIG_ARCH_BCM_5301X) += \ diff --git a/arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dts b/arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dts new file mode 100644 index 0000000..6c8233a --- /dev/null +++ b/arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dts @@ -0,0 +1,87 @@ +// SPDX-License-Identifier: GPL-2.0 +/dts-v1/; +#include "bcm2837-rpi-cm3.dtsi" +#include "bcm283x-rpi-usb-host.dtsi" + +/ { + compatible = "raspberrypi,3-compute-module", "brcm,bcm2837"; + model = "Raspberry Pi Compute Module 3 IO board V3.0"; +}; + +&gpio { + /* + * This is based on the official GPU firmware DT blob. + * + * Legend: + * "NC" = not connected (no rail from the SoC) + * "FOO" = GPIO line named "FOO" on the schematic + * "FOO_N" = GPIO line named "FOO" on schematic, active low + */ + gpio-line-names = "GPIO0", + "GPIO1", + "GPIO2", + "GPIO3", + "GPIO4", + "GPIO5", + "GPIO6", + "GPIO7", + "GPIO8", + "GPIO9", + "GPIO10", + "GPIO11", + "GPIO12", + "GPIO13", + "GPIO14", + "GPIO15", + "GPIO16", + "GPIO17", + "GPIO18", + "GPIO19", + "GPIO20", + "GPIO21", + "GPIO22", + "GPIO23", + "GPIO24", + "GPIO25", + "GPIO26", + "GPIO27", + "GPIO28", + "GPIO29", + "GPIO30", + "GPIO31", + "GPIO32", + "GPIO33", + "GPIO34", + "GPIO35", + "GPIO36", + "GPIO37", + "GPIO38", + "GPIO39", + "GPIO40", + "GPIO41", + "GPIO42", + "GPIO43", + "GPIO44", + "GPIO45", + "GPIO46", + "GPIO47", + /* Used by eMMC */ + "SD_CLK_R", + "SD_CMD_R", + "SD_DATA0_R", + "SD_DATA1_R", + "SD_DATA2_R", + "SD_DATA3_R"; + + pinctrl-0 = <&gpioout &alt0>; +}; + +&hdmi { + hpd-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>; +}; + +&uart0 { + pinctrl-names = "default"; + pinctrl-0 = <&uart0_gpio14>; + status = "okay"; +}; diff --git a/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi b/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi new file mode 100644 index 0000000..7b7ab6a --- /dev/null +++ b/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi @@ -0,0 +1,52 @@ +// SPDX-License-Identifier: GPL-2.0 +/dts-v1/; +#include "bcm2837.dtsi" +#include "bcm2835-rpi.dtsi" + +/ { + memory { + reg = <0 0x40000000>; + }; + + reg_3v3: fixed-regulator { + compatible = "regulator-fixed"; + regulator-name = "3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + reg_1v8: fixed-regulator { + compatible = "regulator-fixed"; + regulator-name = "1V8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + }; +}; + +&firmware { + expgpio: gpio { + compatible = "raspberrypi,firmware-gpio"; + gpio-controller; + #gpio-cells = <2>; + gpio-line-names = "HDMI_HPD_N", + "EMMC_EN_N", + "NC", + "NC", + "NC", + "NC", + "NC", + "NC"; + status = "okay"; + }; +}; + +&sdhost { + pinctrl-names = "default"; + pinctrl-0 = <&sdhost_gpio48>; + bus-width = <4>; + vmmc-supply = <®_3v3>; + vqmmc-supply = <®_1v8>; + status = "okay"; +}; -- 2.7.4 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH V2 2/3] ARM: dts: add Raspberry Pi Compute Module 3 and IO board @ 2018-08-27 18:05 ` Stefan Wahren 0 siblings, 0 replies; 26+ messages in thread From: Stefan Wahren @ 2018-08-27 18:05 UTC (permalink / raw) To: linux-arm-kernel The Raspberry Pi Compute Module 3 (CM3) and the Raspberry Pi Compute Module 3 Lite (CM3L) are SoMs which contains a BCM2837 processor, 1 GB RAM and a GPIO expander. The CM3 has a 4 GB eMMC, but on the CM3L the eMMC is unpopulated and it's up to the user to connect their own SD/MMC device. The dtsi file is designed to work for both modules. There is also a matching carrier board which is called Compute Module IO Board V3. Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dts | 87 +++++++++++++++++++++++++++++++ arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi | 52 ++++++++++++++++++ 3 files changed, 140 insertions(+) create mode 100644 arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dts create mode 100644 arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index b5bd3de..35c749f 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -81,6 +81,7 @@ dtb-$(CONFIG_ARCH_BCM2835) += \ bcm2836-rpi-2-b.dtb \ bcm2837-rpi-3-b.dtb \ bcm2837-rpi-3-b-plus.dtb \ + bcm2837-rpi-cm3-io3.dtb \ bcm2835-rpi-zero.dtb \ bcm2835-rpi-zero-w.dtb dtb-$(CONFIG_ARCH_BCM_5301X) += \ diff --git a/arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dts b/arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dts new file mode 100644 index 0000000..6c8233a --- /dev/null +++ b/arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dts @@ -0,0 +1,87 @@ +// SPDX-License-Identifier: GPL-2.0 +/dts-v1/; +#include "bcm2837-rpi-cm3.dtsi" +#include "bcm283x-rpi-usb-host.dtsi" + +/ { + compatible = "raspberrypi,3-compute-module", "brcm,bcm2837"; + model = "Raspberry Pi Compute Module 3 IO board V3.0"; +}; + +&gpio { + /* + * This is based on the official GPU firmware DT blob. + * + * Legend: + * "NC" = not connected (no rail from the SoC) + * "FOO" = GPIO line named "FOO" on the schematic + * "FOO_N" = GPIO line named "FOO" on schematic, active low + */ + gpio-line-names = "GPIO0", + "GPIO1", + "GPIO2", + "GPIO3", + "GPIO4", + "GPIO5", + "GPIO6", + "GPIO7", + "GPIO8", + "GPIO9", + "GPIO10", + "GPIO11", + "GPIO12", + "GPIO13", + "GPIO14", + "GPIO15", + "GPIO16", + "GPIO17", + "GPIO18", + "GPIO19", + "GPIO20", + "GPIO21", + "GPIO22", + "GPIO23", + "GPIO24", + "GPIO25", + "GPIO26", + "GPIO27", + "GPIO28", + "GPIO29", + "GPIO30", + "GPIO31", + "GPIO32", + "GPIO33", + "GPIO34", + "GPIO35", + "GPIO36", + "GPIO37", + "GPIO38", + "GPIO39", + "GPIO40", + "GPIO41", + "GPIO42", + "GPIO43", + "GPIO44", + "GPIO45", + "GPIO46", + "GPIO47", + /* Used by eMMC */ + "SD_CLK_R", + "SD_CMD_R", + "SD_DATA0_R", + "SD_DATA1_R", + "SD_DATA2_R", + "SD_DATA3_R"; + + pinctrl-0 = <&gpioout &alt0>; +}; + +&hdmi { + hpd-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>; +}; + +&uart0 { + pinctrl-names = "default"; + pinctrl-0 = <&uart0_gpio14>; + status = "okay"; +}; diff --git a/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi b/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi new file mode 100644 index 0000000..7b7ab6a --- /dev/null +++ b/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi @@ -0,0 +1,52 @@ +// SPDX-License-Identifier: GPL-2.0 +/dts-v1/; +#include "bcm2837.dtsi" +#include "bcm2835-rpi.dtsi" + +/ { + memory { + reg = <0 0x40000000>; + }; + + reg_3v3: fixed-regulator { + compatible = "regulator-fixed"; + regulator-name = "3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + reg_1v8: fixed-regulator { + compatible = "regulator-fixed"; + regulator-name = "1V8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + }; +}; + +&firmware { + expgpio: gpio { + compatible = "raspberrypi,firmware-gpio"; + gpio-controller; + #gpio-cells = <2>; + gpio-line-names = "HDMI_HPD_N", + "EMMC_EN_N", + "NC", + "NC", + "NC", + "NC", + "NC", + "NC"; + status = "okay"; + }; +}; + +&sdhost { + pinctrl-names = "default"; + pinctrl-0 = <&sdhost_gpio48>; + bus-width = <4>; + vmmc-supply = <®_3v3>; + vqmmc-supply = <®_1v8>; + status = "okay"; +}; -- 2.7.4 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH V2 3/3] arm64: dts: broadcom: Add reference to Compute Module IO Board V3 2018-08-27 18:05 ` Stefan Wahren @ 2018-08-27 18:05 ` Stefan Wahren -1 siblings, 0 replies; 26+ messages in thread From: Stefan Wahren @ 2018-08-27 18:05 UTC (permalink / raw) To: Florian Fainelli Cc: Mark Rutland, devicetree, Arnd Bergmann, Scott Branden, Ray Jui, Stefan Wahren, Phil Elwell, Alexander Graf, Eric Anholt, Rob Herring, bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel This adds a reference to the dts of the Compute Module IO Board V3 in arm, so we don't need to maintain the content in arm64. Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> --- arch/arm64/boot/dts/broadcom/Makefile | 3 ++- arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts diff --git a/arch/arm64/boot/dts/broadcom/Makefile b/arch/arm64/boot/dts/broadcom/Makefile index 1193a9e..3d98f5f 100644 --- a/arch/arm64/boot/dts/broadcom/Makefile +++ b/arch/arm64/boot/dts/broadcom/Makefile @@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 dtb-$(CONFIG_ARCH_BCM2835) += bcm2837-rpi-3-b.dtb \ - bcm2837-rpi-3-b-plus.dtb + bcm2837-rpi-3-b-plus.dtb \ + bcm2837-rpi-cm3-io3.dts subdir-y += northstar2 subdir-y += stingray diff --git a/arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts b/arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts new file mode 100644 index 0000000..b1c4ab2 --- /dev/null +++ b/arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts @@ -0,0 +1,2 @@ +// SPDX-License-Identifier: GPL-2.0 +#include "arm/bcm2837-rpi-cm3-io3.dts" -- 2.7.4 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH V2 3/3] arm64: dts: broadcom: Add reference to Compute Module IO Board V3 @ 2018-08-27 18:05 ` Stefan Wahren 0 siblings, 0 replies; 26+ messages in thread From: Stefan Wahren @ 2018-08-27 18:05 UTC (permalink / raw) To: linux-arm-kernel This adds a reference to the dts of the Compute Module IO Board V3 in arm, so we don't need to maintain the content in arm64. Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> --- arch/arm64/boot/dts/broadcom/Makefile | 3 ++- arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts diff --git a/arch/arm64/boot/dts/broadcom/Makefile b/arch/arm64/boot/dts/broadcom/Makefile index 1193a9e..3d98f5f 100644 --- a/arch/arm64/boot/dts/broadcom/Makefile +++ b/arch/arm64/boot/dts/broadcom/Makefile @@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 dtb-$(CONFIG_ARCH_BCM2835) += bcm2837-rpi-3-b.dtb \ - bcm2837-rpi-3-b-plus.dtb + bcm2837-rpi-3-b-plus.dtb \ + bcm2837-rpi-cm3-io3.dts subdir-y += northstar2 subdir-y += stingray diff --git a/arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts b/arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts new file mode 100644 index 0000000..b1c4ab2 --- /dev/null +++ b/arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts @@ -0,0 +1,2 @@ +// SPDX-License-Identifier: GPL-2.0 +#include "arm/bcm2837-rpi-cm3-io3.dts" -- 2.7.4 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH V2 3/3] arm64: dts: broadcom: Add reference to Compute Module IO Board V3 2018-08-27 18:05 ` Stefan Wahren @ 2018-09-23 17:39 ` Liviu Dudau -1 siblings, 0 replies; 26+ messages in thread From: Liviu Dudau @ 2018-09-23 17:39 UTC (permalink / raw) To: Stefan Wahren Cc: Mark Rutland, devicetree, Florian Fainelli, Arnd Bergmann, Scott Branden, Ray Jui, Phil Elwell, Alexander Graf, Eric Anholt, Rob Herring, bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel On Mon, Aug 27, 2018 at 08:05:48PM +0200, Stefan Wahren wrote: > This adds a reference to the dts of the Compute Module IO Board V3 in arm, > so we don't need to maintain the content in arm64. > > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > --- > arch/arm64/boot/dts/broadcom/Makefile | 3 ++- > arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 ++ > 2 files changed, 4 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts > > diff --git a/arch/arm64/boot/dts/broadcom/Makefile b/arch/arm64/boot/dts/broadcom/Makefile > index 1193a9e..3d98f5f 100644 > --- a/arch/arm64/boot/dts/broadcom/Makefile > +++ b/arch/arm64/boot/dts/broadcom/Makefile > @@ -1,6 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > dtb-$(CONFIG_ARCH_BCM2835) += bcm2837-rpi-3-b.dtb \ > - bcm2837-rpi-3-b-plus.dtb > + bcm2837-rpi-3-b-plus.dtb \ > + bcm2837-rpi-cm3-io3.dts This should be the .dtb file, not the .dts. At compile time make is not going to complain, because it finds the file, but make dtbs_install will fail. I'm not sure if you want a patch or if you can fix it in your public tree. Found out while trying to install the dtbs from linux-next 20180920 Best regards, Liviu > > subdir-y += northstar2 > subdir-y += stingray > diff --git a/arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts b/arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts > new file mode 100644 > index 0000000..b1c4ab2 > --- /dev/null > +++ b/arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts > @@ -0,0 +1,2 @@ > +// SPDX-License-Identifier: GPL-2.0 > +#include "arm/bcm2837-rpi-cm3-io3.dts" > -- > 2.7.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH V2 3/3] arm64: dts: broadcom: Add reference to Compute Module IO Board V3 @ 2018-09-23 17:39 ` Liviu Dudau 0 siblings, 0 replies; 26+ messages in thread From: Liviu Dudau @ 2018-09-23 17:39 UTC (permalink / raw) To: linux-arm-kernel On Mon, Aug 27, 2018 at 08:05:48PM +0200, Stefan Wahren wrote: > This adds a reference to the dts of the Compute Module IO Board V3 in arm, > so we don't need to maintain the content in arm64. > > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > --- > arch/arm64/boot/dts/broadcom/Makefile | 3 ++- > arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 ++ > 2 files changed, 4 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts > > diff --git a/arch/arm64/boot/dts/broadcom/Makefile b/arch/arm64/boot/dts/broadcom/Makefile > index 1193a9e..3d98f5f 100644 > --- a/arch/arm64/boot/dts/broadcom/Makefile > +++ b/arch/arm64/boot/dts/broadcom/Makefile > @@ -1,6 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > dtb-$(CONFIG_ARCH_BCM2835) += bcm2837-rpi-3-b.dtb \ > - bcm2837-rpi-3-b-plus.dtb > + bcm2837-rpi-3-b-plus.dtb \ > + bcm2837-rpi-cm3-io3.dts This should be the .dtb file, not the .dts. At compile time make is not going to complain, because it finds the file, but make dtbs_install will fail. I'm not sure if you want a patch or if you can fix it in your public tree. Found out while trying to install the dtbs from linux-next 20180920 Best regards, Liviu > > subdir-y += northstar2 > subdir-y += stingray > diff --git a/arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts b/arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts > new file mode 100644 > index 0000000..b1c4ab2 > --- /dev/null > +++ b/arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts > @@ -0,0 +1,2 @@ > +// SPDX-License-Identifier: GPL-2.0 > +#include "arm/bcm2837-rpi-cm3-io3.dts" > -- > 2.7.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH V2 3/3] arm64: dts: broadcom: Add reference to Compute Module IO Board V3 2018-09-23 17:39 ` Liviu Dudau @ 2018-09-24 8:17 ` Stefan Wahren -1 siblings, 0 replies; 26+ messages in thread From: Stefan Wahren @ 2018-09-24 8:17 UTC (permalink / raw) To: Liviu Dudau Cc: Mark Rutland, devicetree, Florian Fainelli, Arnd Bergmann, Scott Branden, Ray Jui, Phil Elwell, Alexander Graf, Eric Anholt, Rob Herring, bcm-kernel-feedback-list, linux-rpi-kernel, Olof Johansson, linux-arm-kernel Hi Liviu, [add Arnd and Olof] Am 23.09.2018 um 19:39 schrieb Liviu Dudau: > On Mon, Aug 27, 2018 at 08:05:48PM +0200, Stefan Wahren wrote: >> This adds a reference to the dts of the Compute Module IO Board V3 in arm, >> so we don't need to maintain the content in arm64. >> >> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> >> --- >> arch/arm64/boot/dts/broadcom/Makefile | 3 ++- >> arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 ++ >> 2 files changed, 4 insertions(+), 1 deletion(-) >> create mode 100644 arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts >> >> diff --git a/arch/arm64/boot/dts/broadcom/Makefile b/arch/arm64/boot/dts/broadcom/Makefile >> index 1193a9e..3d98f5f 100644 >> --- a/arch/arm64/boot/dts/broadcom/Makefile >> +++ b/arch/arm64/boot/dts/broadcom/Makefile >> @@ -1,6 +1,7 @@ >> # SPDX-License-Identifier: GPL-2.0 >> dtb-$(CONFIG_ARCH_BCM2835) += bcm2837-rpi-3-b.dtb \ >> - bcm2837-rpi-3-b-plus.dtb >> + bcm2837-rpi-3-b-plus.dtb \ >> + bcm2837-rpi-cm3-io3.dts > This should be the .dtb file, not the .dts. At compile time make is not going > to complain, because it finds the file, but make dtbs_install will fail. > > I'm not sure if you want a patch or if you can fix it in your public tree. oops, please send a patch (with a fixes tag and Arnd & Olof in CC) because this patch has already been pulled for 4.20. > > > Found out while trying to install the dtbs from linux-next 20180920 > > Best regards, > Liviu > >> >> subdir-y += northstar2 >> subdir-y += stingray >> diff --git a/arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts b/arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts >> new file mode 100644 >> index 0000000..b1c4ab2 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts >> @@ -0,0 +1,2 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +#include "arm/bcm2837-rpi-cm3-io3.dts" >> -- >> 2.7.4 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH V2 3/3] arm64: dts: broadcom: Add reference to Compute Module IO Board V3 @ 2018-09-24 8:17 ` Stefan Wahren 0 siblings, 0 replies; 26+ messages in thread From: Stefan Wahren @ 2018-09-24 8:17 UTC (permalink / raw) To: linux-arm-kernel Hi Liviu, [add Arnd and Olof] Am 23.09.2018 um 19:39 schrieb Liviu Dudau: > On Mon, Aug 27, 2018 at 08:05:48PM +0200, Stefan Wahren wrote: >> This adds a reference to the dts of the Compute Module IO Board V3 in arm, >> so we don't need to maintain the content in arm64. >> >> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> >> --- >> arch/arm64/boot/dts/broadcom/Makefile | 3 ++- >> arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 ++ >> 2 files changed, 4 insertions(+), 1 deletion(-) >> create mode 100644 arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts >> >> diff --git a/arch/arm64/boot/dts/broadcom/Makefile b/arch/arm64/boot/dts/broadcom/Makefile >> index 1193a9e..3d98f5f 100644 >> --- a/arch/arm64/boot/dts/broadcom/Makefile >> +++ b/arch/arm64/boot/dts/broadcom/Makefile >> @@ -1,6 +1,7 @@ >> # SPDX-License-Identifier: GPL-2.0 >> dtb-$(CONFIG_ARCH_BCM2835) += bcm2837-rpi-3-b.dtb \ >> - bcm2837-rpi-3-b-plus.dtb >> + bcm2837-rpi-3-b-plus.dtb \ >> + bcm2837-rpi-cm3-io3.dts > This should be the .dtb file, not the .dts. At compile time make is not going > to complain, because it finds the file, but make dtbs_install will fail. > > I'm not sure if you want a patch or if you can fix it in your public tree. oops, please send a patch (with a fixes tag and Arnd & Olof in CC) because this patch has already been pulled for 4.20. > > > Found out while trying to install the dtbs from linux-next 20180920 > > Best regards, > Liviu > >> >> subdir-y += northstar2 >> subdir-y += stingray >> diff --git a/arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts b/arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts >> new file mode 100644 >> index 0000000..b1c4ab2 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts >> @@ -0,0 +1,2 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +#include "arm/bcm2837-rpi-cm3-io3.dts" >> -- >> 2.7.4 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel at lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH] arm64: dts: broadcom: Use the .dtb name in the rule, rather than .dts 2018-09-24 8:17 ` Stefan Wahren @ 2018-09-24 10:22 ` Liviu Dudau -1 siblings, 0 replies; 26+ messages in thread From: Liviu Dudau @ 2018-09-24 10:22 UTC (permalink / raw) To: Stefan Wahren Cc: Mark Rutland, devicetree, Florian Fainelli, Arnd Bergmann, Scott Branden, Ray Jui, Phil Elwell, Eric Anholt, Rob Herring, bcm-kernel-feedback-list, linux-rpi-kernel, Olof Johansson, linux-arm-kernel Commit a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute Module IO Board V3") adds the bcm2837-rpi-cm3-io3.dts file as a target in the Makefile, rather than the .dtb name. This will skip the generation of the .dtb file at compile time and will fail the dtbs_install target. Fixes: a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute Module IO Board V3") Signed-off-by: Liviu Dudau <liviu@dudau.co.uk> --- arch/arm64/boot/dts/broadcom/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/broadcom/Makefile b/arch/arm64/boot/dts/broadcom/Makefile index 3d98f5f5ab88..667ca989c11b 100644 --- a/arch/arm64/boot/dts/broadcom/Makefile +++ b/arch/arm64/boot/dts/broadcom/Makefile @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 dtb-$(CONFIG_ARCH_BCM2835) += bcm2837-rpi-3-b.dtb \ bcm2837-rpi-3-b-plus.dtb \ - bcm2837-rpi-cm3-io3.dts + bcm2837-rpi-cm3-io3.dtb subdir-y += northstar2 subdir-y += stingray -- 2.18.0 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH] arm64: dts: broadcom: Use the .dtb name in the rule, rather than .dts @ 2018-09-24 10:22 ` Liviu Dudau 0 siblings, 0 replies; 26+ messages in thread From: Liviu Dudau @ 2018-09-24 10:22 UTC (permalink / raw) To: linux-arm-kernel Commit a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute Module IO Board V3") adds the bcm2837-rpi-cm3-io3.dts file as a target in the Makefile, rather than the .dtb name. This will skip the generation of the .dtb file at compile time and will fail the dtbs_install target. Fixes: a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute Module IO Board V3") Signed-off-by: Liviu Dudau <liviu@dudau.co.uk> --- arch/arm64/boot/dts/broadcom/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/broadcom/Makefile b/arch/arm64/boot/dts/broadcom/Makefile index 3d98f5f5ab88..667ca989c11b 100644 --- a/arch/arm64/boot/dts/broadcom/Makefile +++ b/arch/arm64/boot/dts/broadcom/Makefile @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 dtb-$(CONFIG_ARCH_BCM2835) += bcm2837-rpi-3-b.dtb \ bcm2837-rpi-3-b-plus.dtb \ - bcm2837-rpi-cm3-io3.dts + bcm2837-rpi-cm3-io3.dtb subdir-y += northstar2 subdir-y += stingray -- 2.18.0 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH] arm64: dts: broadcom: Use the .dtb name in the rule, rather than .dts 2018-09-24 10:22 ` Liviu Dudau @ 2018-09-24 11:03 ` Stefan Wahren -1 siblings, 0 replies; 26+ messages in thread From: Stefan Wahren @ 2018-09-24 11:03 UTC (permalink / raw) To: Liviu Dudau, Arnd Bergmann, Olof Johansson Cc: Mark Rutland, devicetree, Florian Fainelli, arm-soc, Scott Branden, Ray Jui, Phil Elwell, Eric Anholt, Rob Herring, bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel Am 24.09.2018 um 12:22 schrieb Liviu Dudau: > Commit a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute > Module IO Board V3") adds the bcm2837-rpi-cm3-io3.dts file as a target > in the Makefile, rather than the .dtb name. This will skip the > generation of the .dtb file at compile time and will fail the dtbs_install > target. > > Fixes: a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute > Module IO Board V3") > > Signed-off-by: Liviu Dudau <liviu@dudau.co.uk> Acked-by: Stefan Wahren <stefan.wahren@i2se.com> Thanks, i will add a dtbs_install step to my test jobs. @Arnd @Olof Should this fix for 4.20 go via pull request or can you apply it directly to your tree? > --- > arch/arm64/boot/dts/broadcom/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/broadcom/Makefile b/arch/arm64/boot/dts/broadcom/Makefile > index 3d98f5f5ab88..667ca989c11b 100644 > --- a/arch/arm64/boot/dts/broadcom/Makefile > +++ b/arch/arm64/boot/dts/broadcom/Makefile > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > dtb-$(CONFIG_ARCH_BCM2835) += bcm2837-rpi-3-b.dtb \ > bcm2837-rpi-3-b-plus.dtb \ > - bcm2837-rpi-cm3-io3.dts > + bcm2837-rpi-cm3-io3.dtb > > subdir-y += northstar2 > subdir-y += stingray ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH] arm64: dts: broadcom: Use the .dtb name in the rule, rather than .dts @ 2018-09-24 11:03 ` Stefan Wahren 0 siblings, 0 replies; 26+ messages in thread From: Stefan Wahren @ 2018-09-24 11:03 UTC (permalink / raw) To: linux-arm-kernel Am 24.09.2018 um 12:22 schrieb Liviu Dudau: > Commit a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute > Module IO Board V3") adds the bcm2837-rpi-cm3-io3.dts file as a target > in the Makefile, rather than the .dtb name. This will skip the > generation of the .dtb file at compile time and will fail the dtbs_install > target. > > Fixes: a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute > Module IO Board V3") > > Signed-off-by: Liviu Dudau <liviu@dudau.co.uk> Acked-by: Stefan Wahren <stefan.wahren@i2se.com> Thanks, i will add a dtbs_install step to my test jobs. @Arnd @Olof Should this fix for 4.20 go via pull request or can you apply it directly to your tree? > --- > arch/arm64/boot/dts/broadcom/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/broadcom/Makefile b/arch/arm64/boot/dts/broadcom/Makefile > index 3d98f5f5ab88..667ca989c11b 100644 > --- a/arch/arm64/boot/dts/broadcom/Makefile > +++ b/arch/arm64/boot/dts/broadcom/Makefile > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > dtb-$(CONFIG_ARCH_BCM2835) += bcm2837-rpi-3-b.dtb \ > bcm2837-rpi-3-b-plus.dtb \ > - bcm2837-rpi-cm3-io3.dts > + bcm2837-rpi-cm3-io3.dtb > > subdir-y += northstar2 > subdir-y += stingray ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] arm64: dts: broadcom: Use the .dtb name in the rule, rather than .dts 2018-09-24 11:03 ` Stefan Wahren @ 2018-09-25 18:17 ` Florian Fainelli -1 siblings, 0 replies; 26+ messages in thread From: Florian Fainelli @ 2018-09-25 18:17 UTC (permalink / raw) To: Stefan Wahren, Liviu Dudau, Arnd Bergmann, Olof Johansson Cc: Mark Rutland, devicetree, Florian Fainelli, arm-soc, Scott Branden, Ray Jui, Phil Elwell, Eric Anholt, Rob Herring, bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel On 09/24/2018 04:03 AM, Stefan Wahren wrote: > Am 24.09.2018 um 12:22 schrieb Liviu Dudau: >> Commit a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute >> Module IO Board V3") adds the bcm2837-rpi-cm3-io3.dts file as a target >> in the Makefile, rather than the .dtb name. This will skip the >> generation of the .dtb file at compile time and will fail the dtbs_install >> target. >> >> Fixes: a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute >> Module IO Board V3") >> >> Signed-off-by: Liviu Dudau <liviu@dudau.co.uk> > > Acked-by: Stefan Wahren <stefan.wahren@i2se.com> > > Thanks, i will add a dtbs_install step to my test jobs. Same here. > > @Arnd @Olof Should this fix for 4.20 go via pull request or can you > apply it directly to your tree? That would be my preference here as well. -- Florian ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH] arm64: dts: broadcom: Use the .dtb name in the rule, rather than .dts @ 2018-09-25 18:17 ` Florian Fainelli 0 siblings, 0 replies; 26+ messages in thread From: Florian Fainelli @ 2018-09-25 18:17 UTC (permalink / raw) To: linux-arm-kernel On 09/24/2018 04:03 AM, Stefan Wahren wrote: > Am 24.09.2018 um 12:22 schrieb Liviu Dudau: >> Commit a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute >> Module IO Board V3") adds the bcm2837-rpi-cm3-io3.dts file as a target >> in the Makefile, rather than the .dtb name. This will skip the >> generation of the .dtb file at compile time and will fail the dtbs_install >> target. >> >> Fixes: a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute >> Module IO Board V3") >> >> Signed-off-by: Liviu Dudau <liviu@dudau.co.uk> > > Acked-by: Stefan Wahren <stefan.wahren@i2se.com> > > Thanks, i will add a dtbs_install step to my test jobs. Same here. > > @Arnd @Olof Should this fix for 4.20 go via pull request or can you > apply it directly to your tree? That would be my preference here as well. -- Florian ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] arm64: dts: broadcom: Use the .dtb name in the rule, rather than .dts 2018-09-25 18:17 ` Florian Fainelli @ 2018-09-25 18:51 ` Olof Johansson -1 siblings, 0 replies; 26+ messages in thread From: Olof Johansson @ 2018-09-25 18:51 UTC (permalink / raw) To: Florian Fainelli Cc: Stefan Wahren, Arnd Bergmann, Scott Branden, devicetree, Ray Jui, Phil Elwell, arm-soc, Eric Anholt, Rob Herring, bcm-kernel-feedback-list, linux-rpi-kernel, Mark Rutland, linux-arm-kernel On Tue, Sep 25, 2018 at 11:17:52AM -0700, Florian Fainelli wrote: > On 09/24/2018 04:03 AM, Stefan Wahren wrote: > > Am 24.09.2018 um 12:22 schrieb Liviu Dudau: > >> Commit a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute > >> Module IO Board V3") adds the bcm2837-rpi-cm3-io3.dts file as a target > >> in the Makefile, rather than the .dtb name. This will skip the > >> generation of the .dtb file at compile time and will fail the dtbs_install > >> target. > >> > >> Fixes: a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute > >> Module IO Board V3") > >> > >> Signed-off-by: Liviu Dudau <liviu@dudau.co.uk> > > > > Acked-by: Stefan Wahren <stefan.wahren@i2se.com> > > > > Thanks, i will add a dtbs_install step to my test jobs. > > Same here. I do but I don't seem to catch any errors from it. :-/ > > @Arnd @Olof Should this fix for 4.20 go via pull request or can you > > apply it directly to your tree? > > That would be my preference here as well. Applied to next/dt now. Thanks! -Olof ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH] arm64: dts: broadcom: Use the .dtb name in the rule, rather than .dts @ 2018-09-25 18:51 ` Olof Johansson 0 siblings, 0 replies; 26+ messages in thread From: Olof Johansson @ 2018-09-25 18:51 UTC (permalink / raw) To: linux-arm-kernel On Tue, Sep 25, 2018 at 11:17:52AM -0700, Florian Fainelli wrote: > On 09/24/2018 04:03 AM, Stefan Wahren wrote: > > Am 24.09.2018 um 12:22 schrieb Liviu Dudau: > >> Commit a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute > >> Module IO Board V3") adds the bcm2837-rpi-cm3-io3.dts file as a target > >> in the Makefile, rather than the .dtb name. This will skip the > >> generation of the .dtb file at compile time and will fail the dtbs_install > >> target. > >> > >> Fixes: a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute > >> Module IO Board V3") > >> > >> Signed-off-by: Liviu Dudau <liviu@dudau.co.uk> > > > > Acked-by: Stefan Wahren <stefan.wahren@i2se.com> > > > > Thanks, i will add a dtbs_install step to my test jobs. > > Same here. I do but I don't seem to catch any errors from it. :-/ > > @Arnd @Olof Should this fix for 4.20 go via pull request or can you > > apply it directly to your tree? > > That would be my preference here as well. Applied to next/dt now. Thanks! -Olof ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] arm64: dts: broadcom: Use the .dtb name in the rule, rather than .dts 2018-09-25 18:51 ` Olof Johansson @ 2018-09-25 20:33 ` Stefan Wahren -1 siblings, 0 replies; 26+ messages in thread From: Stefan Wahren @ 2018-09-25 20:33 UTC (permalink / raw) To: Olof Johansson, Florian Fainelli Cc: Mark Rutland, devicetree, Arnd Bergmann, Scott Branden, Ray Jui, Phil Elwell, Rob Herring, Eric Anholt, arm-soc, bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel > Olof Johansson <olof@lixom.net> hat am 25. September 2018 um 20:51 geschrieben: > > > On Tue, Sep 25, 2018 at 11:17:52AM -0700, Florian Fainelli wrote: > > On 09/24/2018 04:03 AM, Stefan Wahren wrote: > > > Am 24.09.2018 um 12:22 schrieb Liviu Dudau: > > >> Commit a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute > > >> Module IO Board V3") adds the bcm2837-rpi-cm3-io3.dts file as a target > > >> in the Makefile, rather than the .dtb name. This will skip the > > >> generation of the .dtb file at compile time and will fail the dtbs_install > > >> target. > > >> > > >> Fixes: a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute > > >> Module IO Board V3") > > >> > > >> Signed-off-by: Liviu Dudau <liviu@dudau.co.uk> > > > > > > Acked-by: Stefan Wahren <stefan.wahren@i2se.com> > > > > > > Thanks, i will add a dtbs_install step to my test jobs. > > > > Same here. > > I do but I don't seem to catch any errors from it. :-/ Strange, i'm get getting this: scripts/Makefile.dtbinst:31: Target „bcm2837-rpi-cm3-io3.dts“ passt nicht zum Ziel-Muster INSTALL arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b-plus.dtb INSTALL arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dtb INSTALL cp: Fehlender Zieldatei‐Operand hinter '/tmp/broadcom' „cp --help“ liefert weitere Informationen. scripts/Makefile.dtbinst:32: die Regel für Ziel „bcm2837-rpi-cm3-io3.dts“ scheiterte make[2]: *** [bcm2837-rpi-cm3-io3.dts] Fehler 1 scripts/Makefile.dtbinst:35: die Regel für Ziel „broadcom“ scheiterte make[1]: *** [broadcom] Fehler 2 arch/arm64/Makefile:139: die Regel für Ziel „dtbs_install“ scheiterte make: *** [dtbs_install] Fehler 2 > > > > @Arnd @Olof Should this fix for 4.20 go via pull request or can you > > > apply it directly to your tree? > > > > That would be my preference here as well. > > Applied to next/dt now. Thanks! Thanks > > > -Olof > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH] arm64: dts: broadcom: Use the .dtb name in the rule, rather than .dts @ 2018-09-25 20:33 ` Stefan Wahren 0 siblings, 0 replies; 26+ messages in thread From: Stefan Wahren @ 2018-09-25 20:33 UTC (permalink / raw) To: linux-arm-kernel > Olof Johansson <olof@lixom.net> hat am 25. September 2018 um 20:51 geschrieben: > > > On Tue, Sep 25, 2018 at 11:17:52AM -0700, Florian Fainelli wrote: > > On 09/24/2018 04:03 AM, Stefan Wahren wrote: > > > Am 24.09.2018 um 12:22 schrieb Liviu Dudau: > > >> Commit a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute > > >> Module IO Board V3") adds the bcm2837-rpi-cm3-io3.dts file as a target > > >> in the Makefile, rather than the .dtb name. This will skip the > > >> generation of the .dtb file at compile time and will fail the dtbs_install > > >> target. > > >> > > >> Fixes: a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute > > >> Module IO Board V3") > > >> > > >> Signed-off-by: Liviu Dudau <liviu@dudau.co.uk> > > > > > > Acked-by: Stefan Wahren <stefan.wahren@i2se.com> > > > > > > Thanks, i will add a dtbs_install step to my test jobs. > > > > Same here. > > I do but I don't seem to catch any errors from it. :-/ Strange, i'm get getting this: scripts/Makefile.dtbinst:31: Target ?bcm2837-rpi-cm3-io3.dts? passt nicht zum Ziel-Muster INSTALL arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b-plus.dtb INSTALL arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dtb INSTALL cp: Fehlender Zieldatei?Operand hinter '/tmp/broadcom' ?cp --help? liefert weitere Informationen. scripts/Makefile.dtbinst:32: die Regel f?r Ziel ?bcm2837-rpi-cm3-io3.dts? scheiterte make[2]: *** [bcm2837-rpi-cm3-io3.dts] Fehler 1 scripts/Makefile.dtbinst:35: die Regel f?r Ziel ?broadcom? scheiterte make[1]: *** [broadcom] Fehler 2 arch/arm64/Makefile:139: die Regel f?r Ziel ?dtbs_install? scheiterte make: *** [dtbs_install] Fehler 2 > > > > @Arnd @Olof Should this fix for 4.20 go via pull request or can you > > > apply it directly to your tree? > > > > That would be my preference here as well. > > Applied to next/dt now. Thanks! Thanks > > > -Olof > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] arm64: dts: broadcom: Use the .dtb name in the rule, rather than .dts 2018-09-25 20:33 ` Stefan Wahren @ 2018-09-25 20:36 ` Olof Johansson -1 siblings, 0 replies; 26+ messages in thread From: Olof Johansson @ 2018-09-25 20:36 UTC (permalink / raw) To: Stefan Wahren Cc: Mark Rutland, DTML, Florian Fainelli, Arnd Bergmann, Scott Branden, Ray Jui, Phil Elwell, Rob Herring, Eric Anholt, ARM-SoC Maintainers, Broadcom Kernel Feedback List, linux-rpi-kernel, Linux ARM Mailing List On Tue, Sep 25, 2018 at 10:33 PM Stefan Wahren <stefan.wahren@i2se.com> wrote: > > > > Olof Johansson <olof@lixom.net> hat am 25. September 2018 um 20:51 geschrieben: > > > > > > On Tue, Sep 25, 2018 at 11:17:52AM -0700, Florian Fainelli wrote: > > > On 09/24/2018 04:03 AM, Stefan Wahren wrote: > > > > Am 24.09.2018 um 12:22 schrieb Liviu Dudau: > > > >> Commit a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute > > > >> Module IO Board V3") adds the bcm2837-rpi-cm3-io3.dts file as a target > > > >> in the Makefile, rather than the .dtb name. This will skip the > > > >> generation of the .dtb file at compile time and will fail the dtbs_install > > > >> target. > > > >> > > > >> Fixes: a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute > > > >> Module IO Board V3") > > > >> > > > >> Signed-off-by: Liviu Dudau <liviu@dudau.co.uk> > > > > > > > > Acked-by: Stefan Wahren <stefan.wahren@i2se.com> > > > > > > > > Thanks, i will add a dtbs_install step to my test jobs. > > > > > > Same here. > > > > I do but I don't seem to catch any errors from it. :-/ > > Strange, i'm get getting this: > > scripts/Makefile.dtbinst:31: Target „bcm2837-rpi-cm3-io3.dts“ passt nicht zum Ziel-Muster > INSTALL arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b-plus.dtb > INSTALL arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dtb > INSTALL > cp: Fehlender Zieldatei‐Operand hinter '/tmp/broadcom' > „cp --help“ liefert weitere Informationen. > scripts/Makefile.dtbinst:32: die Regel für Ziel „bcm2837-rpi-cm3-io3.dts“ scheiterte > make[2]: *** [bcm2837-rpi-cm3-io3.dts] Fehler 1 > scripts/Makefile.dtbinst:35: die Regel für Ziel „broadcom“ scheiterte > make[1]: *** [broadcom] Fehler 2 > arch/arm64/Makefile:139: die Regel für Ziel „dtbs_install“ scheiterte > make: *** [dtbs_install] Fehler 2 Oh, it fails but my reporting scripts don't notice it since I usually don't capture errors from the install phase. -Olof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH] arm64: dts: broadcom: Use the .dtb name in the rule, rather than .dts @ 2018-09-25 20:36 ` Olof Johansson 0 siblings, 0 replies; 26+ messages in thread From: Olof Johansson @ 2018-09-25 20:36 UTC (permalink / raw) To: linux-arm-kernel On Tue, Sep 25, 2018 at 10:33 PM Stefan Wahren <stefan.wahren@i2se.com> wrote: > > > > Olof Johansson <olof@lixom.net> hat am 25. September 2018 um 20:51 geschrieben: > > > > > > On Tue, Sep 25, 2018 at 11:17:52AM -0700, Florian Fainelli wrote: > > > On 09/24/2018 04:03 AM, Stefan Wahren wrote: > > > > Am 24.09.2018 um 12:22 schrieb Liviu Dudau: > > > >> Commit a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute > > > >> Module IO Board V3") adds the bcm2837-rpi-cm3-io3.dts file as a target > > > >> in the Makefile, rather than the .dtb name. This will skip the > > > >> generation of the .dtb file at compile time and will fail the dtbs_install > > > >> target. > > > >> > > > >> Fixes: a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute > > > >> Module IO Board V3") > > > >> > > > >> Signed-off-by: Liviu Dudau <liviu@dudau.co.uk> > > > > > > > > Acked-by: Stefan Wahren <stefan.wahren@i2se.com> > > > > > > > > Thanks, i will add a dtbs_install step to my test jobs. > > > > > > Same here. > > > > I do but I don't seem to catch any errors from it. :-/ > > Strange, i'm get getting this: > > scripts/Makefile.dtbinst:31: Target ?bcm2837-rpi-cm3-io3.dts? passt nicht zum Ziel-Muster > INSTALL arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b-plus.dtb > INSTALL arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dtb > INSTALL > cp: Fehlender Zieldatei?Operand hinter '/tmp/broadcom' > ?cp --help? liefert weitere Informationen. > scripts/Makefile.dtbinst:32: die Regel f?r Ziel ?bcm2837-rpi-cm3-io3.dts? scheiterte > make[2]: *** [bcm2837-rpi-cm3-io3.dts] Fehler 1 > scripts/Makefile.dtbinst:35: die Regel f?r Ziel ?broadcom? scheiterte > make[1]: *** [broadcom] Fehler 2 > arch/arm64/Makefile:139: die Regel f?r Ziel ?dtbs_install? scheiterte > make: *** [dtbs_install] Fehler 2 Oh, it fails but my reporting scripts don't notice it since I usually don't capture errors from the install phase. -Olof ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH V2 0/3] ARM: dts: add Raspberry Pi Compute Module 3 and IO board 2018-08-27 18:05 ` Stefan Wahren @ 2018-08-31 9:35 ` Stefan Wahren -1 siblings, 0 replies; 26+ messages in thread From: Stefan Wahren @ 2018-08-31 9:35 UTC (permalink / raw) To: Florian Fainelli Cc: Mark Rutland, devicetree, Arnd Bergmann, Scott Branden, Ray Jui, Phil Elwell, Alexander Graf, Eric Anholt, Rob Herring, bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel Am 27.08.2018 um 20:05 schrieb Stefan Wahren: > This patch series add support for Rasberry Pi Compute Module 3 and > Compute Module 3 Lite. > > Changes in V2: > - add Reviewed-by tag from Rob > - split arm and arm64 into separate patches > > Stefan Wahren (3): > dt-bindings: bcm: Add Raspberry Pi CM3 and CM3L > ARM: dts: add Raspberry Pi Compute Module 3 and IO board > arm64: dts: broadcom: Add reference to Compute Module IO Board V3 > series applied to bcm2835-dt-next ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH V2 0/3] ARM: dts: add Raspberry Pi Compute Module 3 and IO board @ 2018-08-31 9:35 ` Stefan Wahren 0 siblings, 0 replies; 26+ messages in thread From: Stefan Wahren @ 2018-08-31 9:35 UTC (permalink / raw) To: linux-arm-kernel Am 27.08.2018 um 20:05 schrieb Stefan Wahren: > This patch series add support for Rasberry Pi Compute Module 3 and > Compute Module 3 Lite. > > Changes in V2: > - add Reviewed-by tag from Rob > - split arm and arm64 into separate patches > > Stefan Wahren (3): > dt-bindings: bcm: Add Raspberry Pi CM3 and CM3L > ARM: dts: add Raspberry Pi Compute Module 3 and IO board > arm64: dts: broadcom: Add reference to Compute Module IO Board V3 > series applied to bcm2835-dt-next ^ permalink raw reply [flat|nested] 26+ messages in thread
end of thread, other threads:[~2018-09-25 20:36 UTC | newest] Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-08-27 18:05 [PATCH V2 0/3] ARM: dts: add Raspberry Pi Compute Module 3 and IO board Stefan Wahren 2018-08-27 18:05 ` Stefan Wahren 2018-08-27 18:05 ` [PATCH V2 1/3] dt-bindings: bcm: Add Raspberry Pi CM3 and CM3L Stefan Wahren 2018-08-27 18:05 ` Stefan Wahren 2018-08-27 18:05 ` [PATCH V2 2/3] ARM: dts: add Raspberry Pi Compute Module 3 and IO board Stefan Wahren 2018-08-27 18:05 ` Stefan Wahren 2018-08-27 18:05 ` [PATCH V2 3/3] arm64: dts: broadcom: Add reference to Compute Module IO Board V3 Stefan Wahren 2018-08-27 18:05 ` Stefan Wahren 2018-09-23 17:39 ` Liviu Dudau 2018-09-23 17:39 ` Liviu Dudau 2018-09-24 8:17 ` Stefan Wahren 2018-09-24 8:17 ` Stefan Wahren 2018-09-24 10:22 ` [PATCH] arm64: dts: broadcom: Use the .dtb name in the rule, rather than .dts Liviu Dudau 2018-09-24 10:22 ` Liviu Dudau 2018-09-24 11:03 ` Stefan Wahren 2018-09-24 11:03 ` Stefan Wahren 2018-09-25 18:17 ` Florian Fainelli 2018-09-25 18:17 ` Florian Fainelli 2018-09-25 18:51 ` Olof Johansson 2018-09-25 18:51 ` Olof Johansson 2018-09-25 20:33 ` Stefan Wahren 2018-09-25 20:33 ` Stefan Wahren 2018-09-25 20:36 ` Olof Johansson 2018-09-25 20:36 ` Olof Johansson 2018-08-31 9:35 ` [PATCH V2 0/3] ARM: dts: add Raspberry Pi Compute Module 3 and IO board Stefan Wahren 2018-08-31 9:35 ` Stefan Wahren
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.