All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mtd: nand: denali: Add SPL image loader
@ 2022-09-05 14:14 Jit Loon Lim
  2022-10-21  3:26 ` Jagan Teki
  0 siblings, 1 reply; 3+ messages in thread
From: Jit Loon Lim @ 2022-09-05 14:14 UTC (permalink / raw)
  To: u-boot
  Cc: Jagan Teki, Vignesh R, Marek, Simon, Tien Fong, Kok Kiang,
	Siew Chin, Sin Hui, Raaj, Dinesh, Boon Khai, Alif, Teik Heng,
	Hazim, Sieu Mun Tang, Jit Loon Lim

From: Tien Fong Chee <tien.fong.chee@intel.com>

Add image loader used by the NAND SPL into the full Denali NAND
driver. This allows usage of the full Denali NAND driver in SPL instead
of the reduced SPL-only version.

Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
Signed-off-by: Jit Loon Lim <jit.loon.lim@intel.com>
---
 drivers/mtd/nand/raw/denali.c | 55 +++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)

diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c
index c827f80281..499b4acc6e 100644
--- a/drivers/mtd/nand/raw/denali.c
+++ b/drivers/mtd/nand/raw/denali.c
@@ -7,7 +7,9 @@
 
 #include <common.h>
 #include <dm.h>
+#include <hang.h>
 #include <malloc.h>
+#include <memalign.h>
 #include <nand.h>
 #include <asm/cache.h>
 #include <asm/dma-mapping.h>
@@ -1374,3 +1376,56 @@ free_buf:
 
 	return ret;
 }
+
+#ifdef CONFIG_SPL_BUILD
+int nand_spl_load_image(u32 offset, u32 len, void *dst)
+{
+	size_t count = len, actual = 0, page_align_overhead = 0;
+	u32 page_align_offset = 0;
+	u8 *page_buffer;
+	int err = 0;
+	struct mtd_info *mtd;
+
+	if (!len || !dst)
+		return -EINVAL;
+
+	mtd = get_nand_dev_by_index(nand_curr_device);
+	if (!mtd)
+		hang();
+
+	if ((offset & (mtd->writesize - 1)) != 0) {
+		page_buffer = malloc_cache_aligned(mtd->writesize);
+		if (!page_buffer) {
+			debug("Error: allocating buffer\n");
+			return -ENOMEM;
+		}
+
+		page_align_overhead = offset % mtd->writesize;
+		page_align_offset = (offset / mtd->writesize) * mtd->writesize;
+		count = mtd->writesize;
+
+		err = nand_read_skip_bad(mtd, page_align_offset, &count,
+					 &actual, mtd->size, page_buffer);
+
+		if (err)
+			return err;
+
+		count -= page_align_overhead;
+		count = min((size_t)len, count);
+		memcpy(dst, page_buffer + page_align_overhead, count);
+		free(page_buffer);
+
+		len -= count;
+		if (!len)
+			return err;
+
+		offset += count;
+		dst += count;
+		count = len;
+	}
+
+	return nand_read_skip_bad(mtd, offset, &count, &actual, mtd->size, dst);
+}
+
+void nand_deselect(void) {}
+#endif
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] mtd: nand: denali: Add SPL image loader
  2022-09-05 14:14 [PATCH] mtd: nand: denali: Add SPL image loader Jit Loon Lim
@ 2022-10-21  3:26 ` Jagan Teki
  2022-10-21  5:54   ` Michael Nazzareno Trimarchi
  0 siblings, 1 reply; 3+ messages in thread
From: Jagan Teki @ 2022-10-21  3:26 UTC (permalink / raw)
  To: Jit Loon Lim, Michael Nazzareno Trimarchi, Dario Binacchi
  Cc: u-boot, Vignesh R, Marek, Simon, Tien Fong, Kok Kiang, Siew Chin,
	Sin Hui, Raaj, Dinesh, Boon Khai, Alif, Teik Heng, Hazim,
	Sieu Mun Tang

On Mon, Sep 5, 2022 at 7:44 PM Jit Loon Lim <jit.loon.lim@intel.com> wrote:
>
> From: Tien Fong Chee <tien.fong.chee@intel.com>
>
> Add image loader used by the NAND SPL into the full Denali NAND
> driver. This allows usage of the full Denali NAND driver in SPL instead
> of the reduced SPL-only version.
>
> Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> Signed-off-by: Jit Loon Lim <jit.loon.lim@intel.com>
> ---

+ MTD Maintainers

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mtd: nand: denali: Add SPL image loader
  2022-10-21  3:26 ` Jagan Teki
@ 2022-10-21  5:54   ` Michael Nazzareno Trimarchi
  0 siblings, 0 replies; 3+ messages in thread
From: Michael Nazzareno Trimarchi @ 2022-10-21  5:54 UTC (permalink / raw)
  To: Jagan Teki
  Cc: Jit Loon Lim, Dario Binacchi, u-boot, Vignesh R, Marek, Simon,
	Tien Fong, Kok Kiang, Siew Chin, Sin Hui, Raaj, Dinesh,
	Boon Khai, Alif, Teik Heng, Hazim, Sieu Mun Tang

Hi

On Fri, Oct 21, 2022 at 5:26 AM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> On Mon, Sep 5, 2022 at 7:44 PM Jit Loon Lim <jit.loon.lim@intel.com> wrote:
> >
> > From: Tien Fong Chee <tien.fong.chee@intel.com>
> >
> > Add image loader used by the NAND SPL into the full Denali NAND
> > driver. This allows usage of the full Denali NAND driver in SPL instead
> > of the reduced SPL-only version.
> >
> > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > Signed-off-by: Jit Loon Lim <jit.loon.lim@intel.com>
> > ---
>
> + MTD Maintainers

Please take a look of commit 9f6a14c47ff95354185248ea6e7b1c695e64939e
and implement
nand_spl_adjust_offset. I think that same can be used by any cpu that
has enough space
inside the first stage boot.

Michael


Michael

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-21  5:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-05 14:14 [PATCH] mtd: nand: denali: Add SPL image loader Jit Loon Lim
2022-10-21  3:26 ` Jagan Teki
2022-10-21  5:54   ` Michael Nazzareno Trimarchi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.