All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] soc: apple: rtkit: Add apple_rtkit_idle() function
@ 2023-01-23  6:53 ` Hector Martin
  0 siblings, 0 replies; 8+ messages in thread
From: Hector Martin @ 2023-01-23  6:53 UTC (permalink / raw)
  To: Sven Peter
  Cc: Alyssa Rosenzweig, Janne Grunau, asahi, linux-arm-kernel,
	linux-kernel, Hector Martin

This is yet another low power mode, used by DCP.

Signed-off-by: Hector Martin <marcan@marcan.st>
---
 drivers/soc/apple/rtkit.c       | 21 +++++++++++++++++++++
 include/linux/soc/apple/rtkit.h |  5 +++++
 2 files changed, 26 insertions(+)

diff --git a/drivers/soc/apple/rtkit.c b/drivers/soc/apple/rtkit.c
index ceb4516e442c..509b050cf040 100644
--- a/drivers/soc/apple/rtkit.c
+++ b/drivers/soc/apple/rtkit.c
@@ -9,6 +9,7 @@
 enum {
 	APPLE_RTKIT_PWR_STATE_OFF = 0x00, /* power off, cannot be restarted */
 	APPLE_RTKIT_PWR_STATE_SLEEP = 0x01, /* sleeping, can be restarted */
+	APPLE_RTKIT_PWR_STATE_IDLE = 0x201, /* sleeping, retain state */
 	APPLE_RTKIT_PWR_STATE_QUIESCED = 0x10, /* running but no communication */
 	APPLE_RTKIT_PWR_STATE_ON = 0x20, /* normal operating state */
 };
@@ -882,6 +883,26 @@ int apple_rtkit_shutdown(struct apple_rtkit *rtk)
 }
 EXPORT_SYMBOL_GPL(apple_rtkit_shutdown);
 
+int apple_rtkit_idle(struct apple_rtkit *rtk)
+{
+	int ret;
+
+	/* if OFF is used here the co-processor will not wake up again */
+	ret = apple_rtkit_set_ap_power_state(rtk,
+					     APPLE_RTKIT_PWR_STATE_IDLE);
+	if (ret)
+		return ret;
+
+	ret = apple_rtkit_set_iop_power_state(rtk, APPLE_RTKIT_PWR_STATE_IDLE);
+	if (ret)
+		return ret;
+
+	rtk->iop_power_state = APPLE_RTKIT_PWR_STATE_IDLE;
+	rtk->ap_power_state = APPLE_RTKIT_PWR_STATE_IDLE;
+	return 0;
+}
+EXPORT_SYMBOL_GPL(apple_rtkit_idle);
+
 int apple_rtkit_quiesce(struct apple_rtkit *rtk)
 {
 	int ret;
diff --git a/include/linux/soc/apple/rtkit.h b/include/linux/soc/apple/rtkit.h
index 2a0edb5fa6fe..f8d9cc0691de 100644
--- a/include/linux/soc/apple/rtkit.h
+++ b/include/linux/soc/apple/rtkit.h
@@ -132,6 +132,11 @@ int apple_rtkit_wake(struct apple_rtkit *rtk);
  */
 int apple_rtkit_shutdown(struct apple_rtkit *rtk);
 
+/*
+ * Put the co-processor into idle mode
+ */
+int apple_rtkit_idle(struct apple_rtkit *rtk);
+
 /*
  * Checks if RTKit is running and ready to handle messages.
  */
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] soc: apple: rtkit: Add apple_rtkit_idle() function
@ 2023-01-23  6:53 ` Hector Martin
  0 siblings, 0 replies; 8+ messages in thread
From: Hector Martin @ 2023-01-23  6:53 UTC (permalink / raw)
  To: Sven Peter
  Cc: Alyssa Rosenzweig, Janne Grunau, asahi, linux-arm-kernel,
	linux-kernel, Hector Martin

This is yet another low power mode, used by DCP.

Signed-off-by: Hector Martin <marcan@marcan.st>
---
 drivers/soc/apple/rtkit.c       | 21 +++++++++++++++++++++
 include/linux/soc/apple/rtkit.h |  5 +++++
 2 files changed, 26 insertions(+)

diff --git a/drivers/soc/apple/rtkit.c b/drivers/soc/apple/rtkit.c
index ceb4516e442c..509b050cf040 100644
--- a/drivers/soc/apple/rtkit.c
+++ b/drivers/soc/apple/rtkit.c
@@ -9,6 +9,7 @@
 enum {
 	APPLE_RTKIT_PWR_STATE_OFF = 0x00, /* power off, cannot be restarted */
 	APPLE_RTKIT_PWR_STATE_SLEEP = 0x01, /* sleeping, can be restarted */
+	APPLE_RTKIT_PWR_STATE_IDLE = 0x201, /* sleeping, retain state */
 	APPLE_RTKIT_PWR_STATE_QUIESCED = 0x10, /* running but no communication */
 	APPLE_RTKIT_PWR_STATE_ON = 0x20, /* normal operating state */
 };
@@ -882,6 +883,26 @@ int apple_rtkit_shutdown(struct apple_rtkit *rtk)
 }
 EXPORT_SYMBOL_GPL(apple_rtkit_shutdown);
 
+int apple_rtkit_idle(struct apple_rtkit *rtk)
+{
+	int ret;
+
+	/* if OFF is used here the co-processor will not wake up again */
+	ret = apple_rtkit_set_ap_power_state(rtk,
+					     APPLE_RTKIT_PWR_STATE_IDLE);
+	if (ret)
+		return ret;
+
+	ret = apple_rtkit_set_iop_power_state(rtk, APPLE_RTKIT_PWR_STATE_IDLE);
+	if (ret)
+		return ret;
+
+	rtk->iop_power_state = APPLE_RTKIT_PWR_STATE_IDLE;
+	rtk->ap_power_state = APPLE_RTKIT_PWR_STATE_IDLE;
+	return 0;
+}
+EXPORT_SYMBOL_GPL(apple_rtkit_idle);
+
 int apple_rtkit_quiesce(struct apple_rtkit *rtk)
 {
 	int ret;
diff --git a/include/linux/soc/apple/rtkit.h b/include/linux/soc/apple/rtkit.h
index 2a0edb5fa6fe..f8d9cc0691de 100644
--- a/include/linux/soc/apple/rtkit.h
+++ b/include/linux/soc/apple/rtkit.h
@@ -132,6 +132,11 @@ int apple_rtkit_wake(struct apple_rtkit *rtk);
  */
 int apple_rtkit_shutdown(struct apple_rtkit *rtk);
 
+/*
+ * Put the co-processor into idle mode
+ */
+int apple_rtkit_idle(struct apple_rtkit *rtk);
+
 /*
  * Checks if RTKit is running and ready to handle messages.
  */
-- 
2.35.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] soc: apple: rtkit: Add apple_rtkit_idle() function
  2023-01-23  6:53 ` Hector Martin
@ 2023-01-23 11:11   ` Eric Curtin
  -1 siblings, 0 replies; 8+ messages in thread
From: Eric Curtin @ 2023-01-23 11:11 UTC (permalink / raw)
  To: Hector Martin
  Cc: Sven Peter, Alyssa Rosenzweig, Janne Grunau, asahi,
	linux-arm-kernel, linux-kernel

On Mon, 23 Jan 2023 at 07:03, Hector Martin <marcan@marcan.st> wrote:
>
> This is yet another low power mode, used by DCP.
>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---

New power state, nice

Reviewed-by: Eric Curtin <ecurtin@redhat.com>

Is mise le meas/Regards,

Eric Curtin

>  drivers/soc/apple/rtkit.c       | 21 +++++++++++++++++++++
>  include/linux/soc/apple/rtkit.h |  5 +++++
>  2 files changed, 26 insertions(+)
>
> diff --git a/drivers/soc/apple/rtkit.c b/drivers/soc/apple/rtkit.c
> index ceb4516e442c..509b050cf040 100644
> --- a/drivers/soc/apple/rtkit.c
> +++ b/drivers/soc/apple/rtkit.c
> @@ -9,6 +9,7 @@
>  enum {
>         APPLE_RTKIT_PWR_STATE_OFF = 0x00, /* power off, cannot be restarted */
>         APPLE_RTKIT_PWR_STATE_SLEEP = 0x01, /* sleeping, can be restarted */
> +       APPLE_RTKIT_PWR_STATE_IDLE = 0x201, /* sleeping, retain state */
>         APPLE_RTKIT_PWR_STATE_QUIESCED = 0x10, /* running but no communication */
>         APPLE_RTKIT_PWR_STATE_ON = 0x20, /* normal operating state */
>  };
> @@ -882,6 +883,26 @@ int apple_rtkit_shutdown(struct apple_rtkit *rtk)
>  }
>  EXPORT_SYMBOL_GPL(apple_rtkit_shutdown);
>
> +int apple_rtkit_idle(struct apple_rtkit *rtk)
> +{
> +       int ret;
> +
> +       /* if OFF is used here the co-processor will not wake up again */
> +       ret = apple_rtkit_set_ap_power_state(rtk,
> +                                            APPLE_RTKIT_PWR_STATE_IDLE);
> +       if (ret)
> +               return ret;
> +
> +       ret = apple_rtkit_set_iop_power_state(rtk, APPLE_RTKIT_PWR_STATE_IDLE);
> +       if (ret)
> +               return ret;
> +
> +       rtk->iop_power_state = APPLE_RTKIT_PWR_STATE_IDLE;
> +       rtk->ap_power_state = APPLE_RTKIT_PWR_STATE_IDLE;
> +       return 0;
> +}
> +EXPORT_SYMBOL_GPL(apple_rtkit_idle);
> +
>  int apple_rtkit_quiesce(struct apple_rtkit *rtk)
>  {
>         int ret;
> diff --git a/include/linux/soc/apple/rtkit.h b/include/linux/soc/apple/rtkit.h
> index 2a0edb5fa6fe..f8d9cc0691de 100644
> --- a/include/linux/soc/apple/rtkit.h
> +++ b/include/linux/soc/apple/rtkit.h
> @@ -132,6 +132,11 @@ int apple_rtkit_wake(struct apple_rtkit *rtk);
>   */
>  int apple_rtkit_shutdown(struct apple_rtkit *rtk);
>
> +/*
> + * Put the co-processor into idle mode
> + */
> +int apple_rtkit_idle(struct apple_rtkit *rtk);
> +
>  /*
>   * Checks if RTKit is running and ready to handle messages.
>   */
> --
> 2.35.1
>
>


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] soc: apple: rtkit: Add apple_rtkit_idle() function
@ 2023-01-23 11:11   ` Eric Curtin
  0 siblings, 0 replies; 8+ messages in thread
From: Eric Curtin @ 2023-01-23 11:11 UTC (permalink / raw)
  To: Hector Martin
  Cc: Sven Peter, Alyssa Rosenzweig, Janne Grunau, asahi,
	linux-arm-kernel, linux-kernel

On Mon, 23 Jan 2023 at 07:03, Hector Martin <marcan@marcan.st> wrote:
>
> This is yet another low power mode, used by DCP.
>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---

New power state, nice

Reviewed-by: Eric Curtin <ecurtin@redhat.com>

Is mise le meas/Regards,

Eric Curtin

>  drivers/soc/apple/rtkit.c       | 21 +++++++++++++++++++++
>  include/linux/soc/apple/rtkit.h |  5 +++++
>  2 files changed, 26 insertions(+)
>
> diff --git a/drivers/soc/apple/rtkit.c b/drivers/soc/apple/rtkit.c
> index ceb4516e442c..509b050cf040 100644
> --- a/drivers/soc/apple/rtkit.c
> +++ b/drivers/soc/apple/rtkit.c
> @@ -9,6 +9,7 @@
>  enum {
>         APPLE_RTKIT_PWR_STATE_OFF = 0x00, /* power off, cannot be restarted */
>         APPLE_RTKIT_PWR_STATE_SLEEP = 0x01, /* sleeping, can be restarted */
> +       APPLE_RTKIT_PWR_STATE_IDLE = 0x201, /* sleeping, retain state */
>         APPLE_RTKIT_PWR_STATE_QUIESCED = 0x10, /* running but no communication */
>         APPLE_RTKIT_PWR_STATE_ON = 0x20, /* normal operating state */
>  };
> @@ -882,6 +883,26 @@ int apple_rtkit_shutdown(struct apple_rtkit *rtk)
>  }
>  EXPORT_SYMBOL_GPL(apple_rtkit_shutdown);
>
> +int apple_rtkit_idle(struct apple_rtkit *rtk)
> +{
> +       int ret;
> +
> +       /* if OFF is used here the co-processor will not wake up again */
> +       ret = apple_rtkit_set_ap_power_state(rtk,
> +                                            APPLE_RTKIT_PWR_STATE_IDLE);
> +       if (ret)
> +               return ret;
> +
> +       ret = apple_rtkit_set_iop_power_state(rtk, APPLE_RTKIT_PWR_STATE_IDLE);
> +       if (ret)
> +               return ret;
> +
> +       rtk->iop_power_state = APPLE_RTKIT_PWR_STATE_IDLE;
> +       rtk->ap_power_state = APPLE_RTKIT_PWR_STATE_IDLE;
> +       return 0;
> +}
> +EXPORT_SYMBOL_GPL(apple_rtkit_idle);
> +
>  int apple_rtkit_quiesce(struct apple_rtkit *rtk)
>  {
>         int ret;
> diff --git a/include/linux/soc/apple/rtkit.h b/include/linux/soc/apple/rtkit.h
> index 2a0edb5fa6fe..f8d9cc0691de 100644
> --- a/include/linux/soc/apple/rtkit.h
> +++ b/include/linux/soc/apple/rtkit.h
> @@ -132,6 +132,11 @@ int apple_rtkit_wake(struct apple_rtkit *rtk);
>   */
>  int apple_rtkit_shutdown(struct apple_rtkit *rtk);
>
> +/*
> + * Put the co-processor into idle mode
> + */
> +int apple_rtkit_idle(struct apple_rtkit *rtk);
> +
>  /*
>   * Checks if RTKit is running and ready to handle messages.
>   */
> --
> 2.35.1
>
>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] soc: apple: rtkit: Add apple_rtkit_idle() function
  2023-01-23  6:53 ` Hector Martin
@ 2023-01-28 11:37   ` Sven Peter
  -1 siblings, 0 replies; 8+ messages in thread
From: Sven Peter @ 2023-01-28 11:37 UTC (permalink / raw)
  To: Hector Martin
  Cc: Alyssa Rosenzweig, Janne Grunau, asahi, linux-arm-kernel, linux-kernel

On Mon, Jan 23, 2023, at 07:53, Hector Martin wrote:
> This is yet another low power mode, used by DCP.
>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---

Reviewed-by: Sven Peter <sven@svenpeter.dev>


Sven

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] soc: apple: rtkit: Add apple_rtkit_idle() function
@ 2023-01-28 11:37   ` Sven Peter
  0 siblings, 0 replies; 8+ messages in thread
From: Sven Peter @ 2023-01-28 11:37 UTC (permalink / raw)
  To: Hector Martin
  Cc: Alyssa Rosenzweig, Janne Grunau, asahi, linux-arm-kernel, linux-kernel

On Mon, Jan 23, 2023, at 07:53, Hector Martin wrote:
> This is yet another low power mode, used by DCP.
>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---

Reviewed-by: Sven Peter <sven@svenpeter.dev>


Sven

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] soc: apple: rtkit: Add apple_rtkit_idle() function
  2023-01-23  6:53 ` Hector Martin
@ 2023-01-31 11:41   ` Hector Martin
  -1 siblings, 0 replies; 8+ messages in thread
From: Hector Martin @ 2023-01-31 11:41 UTC (permalink / raw)
  To: Sven Peter
  Cc: Alyssa Rosenzweig, Janne Grunau, asahi, linux-arm-kernel, linux-kernel

On 23/01/2023 15.53, Hector Martin wrote:
> This is yet another low power mode, used by DCP.
> 
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
>  drivers/soc/apple/rtkit.c       | 21 +++++++++++++++++++++
>  include/linux/soc/apple/rtkit.h |  5 +++++
>  2 files changed, 26 insertions(+)
> 

Thanks for the reviews, applied to asahi-soc/soc!

- Hector

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] soc: apple: rtkit: Add apple_rtkit_idle() function
@ 2023-01-31 11:41   ` Hector Martin
  0 siblings, 0 replies; 8+ messages in thread
From: Hector Martin @ 2023-01-31 11:41 UTC (permalink / raw)
  To: Sven Peter
  Cc: Alyssa Rosenzweig, Janne Grunau, asahi, linux-arm-kernel, linux-kernel

On 23/01/2023 15.53, Hector Martin wrote:
> This is yet another low power mode, used by DCP.
> 
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
>  drivers/soc/apple/rtkit.c       | 21 +++++++++++++++++++++
>  include/linux/soc/apple/rtkit.h |  5 +++++
>  2 files changed, 26 insertions(+)
> 

Thanks for the reviews, applied to asahi-soc/soc!

- Hector

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-01-31 11:42 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-23  6:53 [PATCH] soc: apple: rtkit: Add apple_rtkit_idle() function Hector Martin
2023-01-23  6:53 ` Hector Martin
2023-01-23 11:11 ` Eric Curtin
2023-01-23 11:11   ` Eric Curtin
2023-01-28 11:37 ` Sven Peter
2023-01-28 11:37   ` Sven Peter
2023-01-31 11:41 ` Hector Martin
2023-01-31 11:41   ` Hector Martin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.