All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clk: spear: Add stub functions for spear3[0|1|2]0_clk_init()
@ 2012-11-06  2:34 ` Axel Lin
  0 siblings, 0 replies; 6+ messages in thread
From: Axel Lin @ 2012-11-06  2:34 UTC (permalink / raw)
  To: Viresh Kumar
  Cc: Mike Turquette, Arnd Bergmann, spear-devel, linux-arm-kernel,
	linux-kernel

This fixes compile error if one of SPEAr3xx implementations is not selected.

  CC      drivers/clk/spear/spear3xx_clock.o
drivers/clk/spear/spear3xx_clock.c: In function 'spear3xx_clk_init':
drivers/clk/spear/spear3xx_clock.c:599:3: error: implicit declaration of function 'spear300_clk_init' [-Werror=implicit-function-declaration]
drivers/clk/spear/spear3xx_clock.c:601:3: error: implicit declaration of function 'spear310_clk_init' [-Werror=implicit-function-declaration]
drivers/clk/spear/spear3xx_clock.c:603:3: error: implicit declaration of function 'spear320_clk_init' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[3]: *** [drivers/clk/spear/spear3xx_clock.o] Error 1
make[2]: *** [drivers/clk/spear] Error 2
make[1]: *** [drivers/clk] Error 2
make: *** [drivers] Error 2

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/clk/spear/spear3xx_clock.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/clk/spear/spear3xx_clock.c b/drivers/clk/spear/spear3xx_clock.c
index c315745..59049cf 100644
--- a/drivers/clk/spear/spear3xx_clock.c
+++ b/drivers/clk/spear/spear3xx_clock.c
@@ -157,6 +157,8 @@ static void __init spear300_clk_init(void)
 			1);
 	clk_register_clkdev(clk, NULL, "a0000000.kbd");
 }
+#else
+static inline void spear300_clk_init(void) { }
 #endif
 
 /* array of all spear 310 clock lookups */
@@ -197,6 +199,8 @@ static void __init spear310_clk_init(void)
 			1);
 	clk_register_clkdev(clk, NULL, "b2200000.serial");
 }
+#else
+static inline void spear310_clk_init(void) { }
 #endif
 
 /* array of all spear 320 clock lookups */
@@ -336,6 +340,8 @@ static void __init spear320_clk_init(void)
 			&_lock);
 	clk_register_clkdev(clk, NULL, "60100000.serial");
 }
+#else
+static inline void spear320_clk_init(void) { }
 #endif
 
 void __init spear3xx_clk_init(void)
-- 
1.7.9.5





^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] clk: spear: Add stub functions for spear3[0|1|2]0_clk_init()
@ 2012-11-06  2:34 ` Axel Lin
  0 siblings, 0 replies; 6+ messages in thread
From: Axel Lin @ 2012-11-06  2:34 UTC (permalink / raw)
  To: linux-arm-kernel

This fixes compile error if one of SPEAr3xx implementations is not selected.

  CC      drivers/clk/spear/spear3xx_clock.o
drivers/clk/spear/spear3xx_clock.c: In function 'spear3xx_clk_init':
drivers/clk/spear/spear3xx_clock.c:599:3: error: implicit declaration of function 'spear300_clk_init' [-Werror=implicit-function-declaration]
drivers/clk/spear/spear3xx_clock.c:601:3: error: implicit declaration of function 'spear310_clk_init' [-Werror=implicit-function-declaration]
drivers/clk/spear/spear3xx_clock.c:603:3: error: implicit declaration of function 'spear320_clk_init' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[3]: *** [drivers/clk/spear/spear3xx_clock.o] Error 1
make[2]: *** [drivers/clk/spear] Error 2
make[1]: *** [drivers/clk] Error 2
make: *** [drivers] Error 2

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/clk/spear/spear3xx_clock.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/clk/spear/spear3xx_clock.c b/drivers/clk/spear/spear3xx_clock.c
index c315745..59049cf 100644
--- a/drivers/clk/spear/spear3xx_clock.c
+++ b/drivers/clk/spear/spear3xx_clock.c
@@ -157,6 +157,8 @@ static void __init spear300_clk_init(void)
 			1);
 	clk_register_clkdev(clk, NULL, "a0000000.kbd");
 }
+#else
+static inline void spear300_clk_init(void) { }
 #endif
 
 /* array of all spear 310 clock lookups */
@@ -197,6 +199,8 @@ static void __init spear310_clk_init(void)
 			1);
 	clk_register_clkdev(clk, NULL, "b2200000.serial");
 }
+#else
+static inline void spear310_clk_init(void) { }
 #endif
 
 /* array of all spear 320 clock lookups */
@@ -336,6 +340,8 @@ static void __init spear320_clk_init(void)
 			&_lock);
 	clk_register_clkdev(clk, NULL, "60100000.serial");
 }
+#else
+static inline void spear320_clk_init(void) { }
 #endif
 
 void __init spear3xx_clk_init(void)
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] clk: spear: Add stub functions for spear3[0|1|2]0_clk_init()
  2012-11-06  2:34 ` Axel Lin
@ 2012-11-06  3:36   ` viresh kumar
  -1 siblings, 0 replies; 6+ messages in thread
From: viresh kumar @ 2012-11-06  3:36 UTC (permalink / raw)
  To: Axel Lin
  Cc: Mike Turquette, Arnd Bergmann, spear-devel, linux-arm-kernel,
	linux-kernel

On Tue, Nov 6, 2012 at 8:04 AM, Axel Lin <axel.lin@ingics.com> wrote:
> This fixes compile error if one of SPEAr3xx implementations is not selected.
>
>   CC      drivers/clk/spear/spear3xx_clock.o
> drivers/clk/spear/spear3xx_clock.c: In function 'spear3xx_clk_init':
> drivers/clk/spear/spear3xx_clock.c:599:3: error: implicit declaration of function 'spear300_clk_init' [-Werror=implicit-function-declaration]
> drivers/clk/spear/spear3xx_clock.c:601:3: error: implicit declaration of function 'spear310_clk_init' [-Werror=implicit-function-declaration]
> drivers/clk/spear/spear3xx_clock.c:603:3: error: implicit declaration of function 'spear320_clk_init' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[3]: *** [drivers/clk/spear/spear3xx_clock.o] Error 1
> make[2]: *** [drivers/clk/spear] Error 2
> make[1]: *** [drivers/clk] Error 2
> make: *** [drivers] Error 2
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Thanks..
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] clk: spear: Add stub functions for spear3[0|1|2]0_clk_init()
@ 2012-11-06  3:36   ` viresh kumar
  0 siblings, 0 replies; 6+ messages in thread
From: viresh kumar @ 2012-11-06  3:36 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Nov 6, 2012 at 8:04 AM, Axel Lin <axel.lin@ingics.com> wrote:
> This fixes compile error if one of SPEAr3xx implementations is not selected.
>
>   CC      drivers/clk/spear/spear3xx_clock.o
> drivers/clk/spear/spear3xx_clock.c: In function 'spear3xx_clk_init':
> drivers/clk/spear/spear3xx_clock.c:599:3: error: implicit declaration of function 'spear300_clk_init' [-Werror=implicit-function-declaration]
> drivers/clk/spear/spear3xx_clock.c:601:3: error: implicit declaration of function 'spear310_clk_init' [-Werror=implicit-function-declaration]
> drivers/clk/spear/spear3xx_clock.c:603:3: error: implicit declaration of function 'spear320_clk_init' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[3]: *** [drivers/clk/spear/spear3xx_clock.o] Error 1
> make[2]: *** [drivers/clk/spear] Error 2
> make[1]: *** [drivers/clk] Error 2
> make: *** [drivers] Error 2
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Thanks..
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] clk: spear: Add stub functions for spear3[0|1|2]0_clk_init()
  2012-11-06  3:36   ` viresh kumar
@ 2012-11-12 21:15     ` Mike Turquette
  -1 siblings, 0 replies; 6+ messages in thread
From: Mike Turquette @ 2012-11-12 21:15 UTC (permalink / raw)
  To: viresh kumar, Axel Lin
  Cc: Arnd Bergmann, spear-devel, linux-arm-kernel, linux-kernel

Quoting viresh kumar (2012-11-05 19:36:18)
> On Tue, Nov 6, 2012 at 8:04 AM, Axel Lin <axel.lin@ingics.com> wrote:
> > This fixes compile error if one of SPEAr3xx implementations is not selected.
> >
> >   CC      drivers/clk/spear/spear3xx_clock.o
> > drivers/clk/spear/spear3xx_clock.c: In function 'spear3xx_clk_init':
> > drivers/clk/spear/spear3xx_clock.c:599:3: error: implicit declaration of function 'spear300_clk_init' [-Werror=implicit-function-declaration]
> > drivers/clk/spear/spear3xx_clock.c:601:3: error: implicit declaration of function 'spear310_clk_init' [-Werror=implicit-function-declaration]
> > drivers/clk/spear/spear3xx_clock.c:603:3: error: implicit declaration of function 'spear320_clk_init' [-Werror=implicit-function-declaration]
> > cc1: some warnings being treated as errors
> > make[3]: *** [drivers/clk/spear/spear3xx_clock.o] Error 1
> > make[2]: *** [drivers/clk/spear] Error 2
> > make[1]: *** [drivers/clk] Error 2
> > make: *** [drivers] Error 2
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> 
> Thanks..
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Taken into clk-next.

Thanks,
Mike

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] clk: spear: Add stub functions for spear3[0|1|2]0_clk_init()
@ 2012-11-12 21:15     ` Mike Turquette
  0 siblings, 0 replies; 6+ messages in thread
From: Mike Turquette @ 2012-11-12 21:15 UTC (permalink / raw)
  To: linux-arm-kernel

Quoting viresh kumar (2012-11-05 19:36:18)
> On Tue, Nov 6, 2012 at 8:04 AM, Axel Lin <axel.lin@ingics.com> wrote:
> > This fixes compile error if one of SPEAr3xx implementations is not selected.
> >
> >   CC      drivers/clk/spear/spear3xx_clock.o
> > drivers/clk/spear/spear3xx_clock.c: In function 'spear3xx_clk_init':
> > drivers/clk/spear/spear3xx_clock.c:599:3: error: implicit declaration of function 'spear300_clk_init' [-Werror=implicit-function-declaration]
> > drivers/clk/spear/spear3xx_clock.c:601:3: error: implicit declaration of function 'spear310_clk_init' [-Werror=implicit-function-declaration]
> > drivers/clk/spear/spear3xx_clock.c:603:3: error: implicit declaration of function 'spear320_clk_init' [-Werror=implicit-function-declaration]
> > cc1: some warnings being treated as errors
> > make[3]: *** [drivers/clk/spear/spear3xx_clock.o] Error 1
> > make[2]: *** [drivers/clk/spear] Error 2
> > make[1]: *** [drivers/clk] Error 2
> > make: *** [drivers] Error 2
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> 
> Thanks..
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Taken into clk-next.

Thanks,
Mike

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-11-12 21:15 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-06  2:34 [PATCH] clk: spear: Add stub functions for spear3[0|1|2]0_clk_init() Axel Lin
2012-11-06  2:34 ` Axel Lin
2012-11-06  3:36 ` viresh kumar
2012-11-06  3:36   ` viresh kumar
2012-11-12 21:15   ` Mike Turquette
2012-11-12 21:15     ` Mike Turquette

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.