* [PATCH] Make uapi/linux/irqnr.h non-empty
@ 2012-10-15 16:14 David Howells
2012-10-17 2:03 ` Linus Torvalds
0 siblings, 1 reply; 4+ messages in thread
From: David Howells @ 2012-10-15 16:14 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel, David Howells, Randy Dunlap, Alessandro Suardi
uapi/linux/irqnr.h was emitted by the UAPI disintegration script as an empty
file because the parent linux/irqnr.h had no UAPI stuff in it, despite being
marked with "header-y".
Unfortunately, it patch deletes the empty file when applying a kernel patch.
It's not clear why this file is part of the UAPI at all. Looking in:
/usr/include/linux/irqnr.h
there's nothing there but a header reinclusion guard and a comment.
So just stick a comment in there as a placeholder.
Without this, if the kernel is fabricated from, say, a tarball and a patch, you
can get this error when building x86_64 or usermode Linux (and probably
others):
include/linux/irqnr.h:4:30: fatal error: uapi/linux/irqnr.h: No such file or directory
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Randy Dunlap <rdunlap@xenotime.net>
cc: Alessandro Suardi <alessandro.suardi@gmail.com>
---
include/uapi/linux/irqnr.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/uapi/linux/irqnr.h b/include/uapi/linux/irqnr.h
index e69de29..ae5704f 100644
--- a/include/uapi/linux/irqnr.h
+++ b/include/uapi/linux/irqnr.h
@@ -0,0 +1,4 @@
+/*
+ * There isn't anything here anymore, but the file must not be empty or patch
+ * will delete it.
+ */
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Make uapi/linux/irqnr.h non-empty
2012-10-15 16:14 [PATCH] Make uapi/linux/irqnr.h non-empty David Howells
@ 2012-10-17 2:03 ` Linus Torvalds
2012-10-17 3:37 ` viresh kumar
0 siblings, 1 reply; 4+ messages in thread
From: Linus Torvalds @ 2012-10-17 2:03 UTC (permalink / raw)
To: David Howells
Cc: linux-kernel, Randy Dunlap, Alessandro Suardi, Viresh Kumar,
Michal Marek
On Mon, Oct 15, 2012 at 9:14 AM, David Howells <dhowells@redhat.com> wrote:
> uapi/linux/irqnr.h was emitted by the UAPI disintegration script as an empty
> file because the parent linux/irqnr.h had no UAPI stuff in it, despite being
> marked with "header-y".
>
> Unfortunately, it patch deletes the empty file when applying a kernel patch.
Sadly, this is by far not the only empty file we now have, so applying
this patch seems pointless..
Doing a "git clean -dqfx" followed by "find . -size 0" shows quite a
few empty files, most of them being Kbuild files, and most of them
having come in through the UAPI patches. Maybe some of those *should*
be removed?
Some of the empty files seem pointless. The
arch/arm/mach-spear13xx/include/mach/spear1310_misc_regs.h
file, for example, has always been empty, and does not seem to be actually used.
Hmm? I added a few more people to the cc list.
Linus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Make uapi/linux/irqnr.h non-empty
2012-10-17 2:03 ` Linus Torvalds
@ 2012-10-17 3:37 ` viresh kumar
2012-10-25 14:40 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: viresh kumar @ 2012-10-17 3:37 UTC (permalink / raw)
To: Linus Torvalds, Arnd Bergmann
Cc: David Howells, linux-kernel, Randy Dunlap, Alessandro Suardi,
Michal Marek, spear-devel
On Wed, Oct 17, 2012 at 7:33 AM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> Some of the empty files seem pointless. The
>
> arch/arm/mach-spear13xx/include/mach/spear1310_misc_regs.h
>
> file, for example, has always been empty, and does not seem to be actually used.
>
> Hmm? I added a few more people to the cc list.
Shocked :)
I never realized these files were added by my commit and it never got caught in
reviews :(
Probably because git log --stat or git show (stat part) doesn't show
files with zero
changes. Probably need to fix that too?
@Arnd: Can you please apply following patch to fix SPEAr's issues
point out by Linus?
------------------------x-------------------x------------------------
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: Wed, 17 Oct 2012 08:58:08 +0530
Subject: [PATCH] ARM: SPEAr: Remove unused empty files
Few empty files (spear1310_misc_regs.h and spear1340_misc_regs.h) are created by
commit:
commit b31e23726bb9d6cd8848fc539b23330769830110
Author: Viresh Kumar <viresh.kumar@st.com>
Date: Thu Apr 19 22:23:13 2012 +0530
SPEAr13xx: Add header files
Don't know how they got added, obviously my fault :)
But nobody could even catch them in reviews.
Remove them.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
0 files changed
delete mode 100644 arch/arm/mach-spear13xx/include/mach/spear1310_misc_regs.h
delete mode 100644 arch/arm/mach-spear13xx/include/mach/spear1340_misc_regs.h
diff --git a/arch/arm/mach-spear13xx/include/mach/spear1310_misc_regs.h
b/arch/arm/mach-spear13xx/include/mach/spear1310_misc_regs.h
deleted file mode 100644
index e69de29..0000000
diff --git a/arch/arm/mach-spear13xx/include/mach/spear1340_misc_regs.h
b/arch/arm/mach-spear13xx/include/mach/spear1340_misc_regs.h
deleted file mode 100644
index e69de29..0000000
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Make uapi/linux/irqnr.h non-empty
2012-10-17 3:37 ` viresh kumar
@ 2012-10-25 14:40 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2012-10-25 14:40 UTC (permalink / raw)
To: viresh kumar
Cc: Linus Torvalds, David Howells, linux-kernel, Randy Dunlap,
Alessandro Suardi, Michal Marek, spear-devel, Olof Johansson
On Wednesday 17 October 2012, viresh kumar wrote:
> commit b31e23726bb9d6cd8848fc539b23330769830110
> Author: Viresh Kumar <viresh.kumar@st.com>
> Date: Thu Apr 19 22:23:13 2012 +0530
>
> SPEAr13xx: Add header files
>
> Don't know how they got added, obviously my fault :)
> But nobody could even catch them in reviews.
>
> Remove them.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
Sorry for the delay. Olof has been handling the arm-soc patches in the recent
weeks, but he wasn't on Cc on this mail, so he missed it and I didn't look
closely.
I've applied it in the fixes branch now and will send it together
with the next round of arm-soc bug fixes. Please make sure you always
use the arm@kernel.org alias or have both Olof and me on Cc when submitting
patches for arm-soc.
Thanks for the reminders!
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-10-25 14:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-15 16:14 [PATCH] Make uapi/linux/irqnr.h non-empty David Howells
2012-10-17 2:03 ` Linus Torvalds
2012-10-17 3:37 ` viresh kumar
2012-10-25 14:40 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.