* [ceph-client:testing 2/5] net/ceph/osdmap.c:203:6: warning: no previous prototype for 'clear_crush_names'
@ 2020-05-30 18:34 ` kbuild test robot
0 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2020-05-30 18:34 UTC (permalink / raw)
To: Ilya, Dryomov,; +Cc: kbuild-all, ceph-devel
[-- Attachment #1: Type: text/plain, Size: 6272 bytes --]
tree: https://github.com/ceph/ceph-client.git testing
head: b3a5867e0780ac0279cf1541ed985db78f186221
commit: a9112bbf346099ab532fc52ef87d46935fe8e519 [2/5] libceph: decode CRUSH device/bucket types and names
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout a9112bbf346099ab532fc52ef87d46935fe8e519
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from arch/m68k/include/asm/io_mm.h:25,
from arch/m68k/include/asm/io.h:8,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from include/asm-generic/hardirq.h:13,
from ./arch/m68k/include/generated/asm/hardirq.h:1,
from include/linux/hardirq.h:9,
from include/linux/highmem.h:10,
from include/linux/pagemap.h:11,
from include/linux/blkdev.h:16,
from include/linux/backing-dev.h:15,
from include/linux/ceph/libceph.h:8,
from net/ceph/osdmap.c:8:
arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsb':
arch/m68k/include/asm/raw_io.h:83:7: warning: variable '__w' set but not used [-Wunused-but-set-variable]
83 | ({u8 __w, __v = (b); u32 _addr = ((u32) (addr)); | ^~~
arch/m68k/include/asm/raw_io.h:430:3: note: in expansion of macro 'rom_out_8'
430 | rom_out_8(port, *buf++);
| ^~~~~~~~~
arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw':
arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable]
86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); | ^~~
arch/m68k/include/asm/raw_io.h:448:3: note: in expansion of macro 'rom_out_be16'
448 | rom_out_be16(port, *buf++);
| ^~~~~~~~~~~~
arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw_swapw':
arch/m68k/include/asm/raw_io.h:90:8: warning: variable '__w' set but not used [-Wunused-but-set-variable]
90 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); | ^~~
arch/m68k/include/asm/raw_io.h:466:3: note: in expansion of macro 'rom_out_le16'
466 | rom_out_le16(port, *buf++);
| ^~~~~~~~~~~~
In file included from include/linux/string.h:6,
from include/linux/ceph/ceph_debug.h:7,
from net/ceph/osdmap.c:3:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
In file included from arch/m68k/include/asm/bug.h:32,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/preempt.h:5,
from ./arch/m68k/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/stat.h:19,
from include/linux/module.h:13,
from net/ceph/osdmap.c:5:
include/linux/dma-mapping.h: In function 'dma_map_resource':
arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/asm-generic/bug.h:139:27: note: in definition of macro 'WARN_ON_ONCE'
139 | int __ret_warn_once = !!(condition); | ^~~~~~~~~
arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid'
170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn))
| ^~~~~~~~~~~~~~~
include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~
net/ceph/osdmap.c: At top level:
>> net/ceph/osdmap.c:203:6: warning: no previous prototype for 'clear_crush_names' [-Wmissing-prototypes]
203 | void clear_crush_names(struct rb_root *root)
| ^~~~~~~~~~~~~~~~~
net/ceph/osdmap.c:249:6: warning: no previous prototype for 'clear_choose_args' [-Wmissing-prototypes]
249 | void clear_choose_args(struct crush_map *c)
| ^~~~~~~~~~~~~~~~~
In file included from net/ceph/osdmap.c:8:
include/linux/ceph/libceph.h:234:14: warning: 'lookup_crush_name' defined but not used [-Wunused-function]
234 | static type *lookup_##name(struct rb_root *root, lookup_param_type key) | ^~~~~~~
include/linux/ceph/libceph.h:268:1: note: in expansion of macro 'DEFINE_RB_LOOKUP_FUNC2'
268 | DEFINE_RB_LOOKUP_FUNC2(name, type, keyfld, RB_CMP3WAY, RB_BYVAL, | ^~~~~~~~~~~~~~~~~~~~~~
include/linux/ceph/libceph.h:273:1: note: in expansion of macro 'DEFINE_RB_LOOKUP_FUNC'
273 | DEFINE_RB_LOOKUP_FUNC(name, type, keyfld, nodefld)
| ^~~~~~~~~~~~~~~~~~~~~
net/ceph/osdmap.c:166:1: note: in expansion of macro 'DEFINE_RB_FUNCS'
166 | DEFINE_RB_FUNCS(crush_name, struct crush_name_node, cn_id, cn_node)
| ^~~~~~~~~~~~~~~
vim +/clear_crush_names +203 net/ceph/osdmap.c
202
> 203 void clear_crush_names(struct rb_root *root)
204 {
205 while (!RB_EMPTY_ROOT(root)) {
206 struct crush_name_node *cn =
207 rb_entry(rb_first(root), struct crush_name_node, cn_node);
208
209 erase_crush_name(root, cn);
210 free_crush_name(cn);
211 }
212 }
213
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 53982 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [ceph-client:testing 2/5] net/ceph/osdmap.c:203:6: warning: no previous prototype for 'clear_crush_names'
@ 2020-05-30 18:34 ` kbuild test robot
0 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2020-05-30 18:34 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 6399 bytes --]
tree: https://github.com/ceph/ceph-client.git testing
head: b3a5867e0780ac0279cf1541ed985db78f186221
commit: a9112bbf346099ab532fc52ef87d46935fe8e519 [2/5] libceph: decode CRUSH device/bucket types and names
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout a9112bbf346099ab532fc52ef87d46935fe8e519
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from arch/m68k/include/asm/io_mm.h:25,
from arch/m68k/include/asm/io.h:8,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from include/asm-generic/hardirq.h:13,
from ./arch/m68k/include/generated/asm/hardirq.h:1,
from include/linux/hardirq.h:9,
from include/linux/highmem.h:10,
from include/linux/pagemap.h:11,
from include/linux/blkdev.h:16,
from include/linux/backing-dev.h:15,
from include/linux/ceph/libceph.h:8,
from net/ceph/osdmap.c:8:
arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsb':
arch/m68k/include/asm/raw_io.h:83:7: warning: variable '__w' set but not used [-Wunused-but-set-variable]
83 | ({u8 __w, __v = (b); u32 _addr = ((u32) (addr)); | ^~~
arch/m68k/include/asm/raw_io.h:430:3: note: in expansion of macro 'rom_out_8'
430 | rom_out_8(port, *buf++);
| ^~~~~~~~~
arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw':
arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable]
86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); | ^~~
arch/m68k/include/asm/raw_io.h:448:3: note: in expansion of macro 'rom_out_be16'
448 | rom_out_be16(port, *buf++);
| ^~~~~~~~~~~~
arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw_swapw':
arch/m68k/include/asm/raw_io.h:90:8: warning: variable '__w' set but not used [-Wunused-but-set-variable]
90 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); | ^~~
arch/m68k/include/asm/raw_io.h:466:3: note: in expansion of macro 'rom_out_le16'
466 | rom_out_le16(port, *buf++);
| ^~~~~~~~~~~~
In file included from include/linux/string.h:6,
from include/linux/ceph/ceph_debug.h:7,
from net/ceph/osdmap.c:3:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
In file included from arch/m68k/include/asm/bug.h:32,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/preempt.h:5,
from ./arch/m68k/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/stat.h:19,
from include/linux/module.h:13,
from net/ceph/osdmap.c:5:
include/linux/dma-mapping.h: In function 'dma_map_resource':
arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/asm-generic/bug.h:139:27: note: in definition of macro 'WARN_ON_ONCE'
139 | int __ret_warn_once = !!(condition); | ^~~~~~~~~
arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid'
170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn))
| ^~~~~~~~~~~~~~~
include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~
net/ceph/osdmap.c: At top level:
>> net/ceph/osdmap.c:203:6: warning: no previous prototype for 'clear_crush_names' [-Wmissing-prototypes]
203 | void clear_crush_names(struct rb_root *root)
| ^~~~~~~~~~~~~~~~~
net/ceph/osdmap.c:249:6: warning: no previous prototype for 'clear_choose_args' [-Wmissing-prototypes]
249 | void clear_choose_args(struct crush_map *c)
| ^~~~~~~~~~~~~~~~~
In file included from net/ceph/osdmap.c:8:
include/linux/ceph/libceph.h:234:14: warning: 'lookup_crush_name' defined but not used [-Wunused-function]
234 | static type *lookup_##name(struct rb_root *root, lookup_param_type key) | ^~~~~~~
include/linux/ceph/libceph.h:268:1: note: in expansion of macro 'DEFINE_RB_LOOKUP_FUNC2'
268 | DEFINE_RB_LOOKUP_FUNC2(name, type, keyfld, RB_CMP3WAY, RB_BYVAL, | ^~~~~~~~~~~~~~~~~~~~~~
include/linux/ceph/libceph.h:273:1: note: in expansion of macro 'DEFINE_RB_LOOKUP_FUNC'
273 | DEFINE_RB_LOOKUP_FUNC(name, type, keyfld, nodefld)
| ^~~~~~~~~~~~~~~~~~~~~
net/ceph/osdmap.c:166:1: note: in expansion of macro 'DEFINE_RB_FUNCS'
166 | DEFINE_RB_FUNCS(crush_name, struct crush_name_node, cn_id, cn_node)
| ^~~~~~~~~~~~~~~
vim +/clear_crush_names +203 net/ceph/osdmap.c
202
> 203 void clear_crush_names(struct rb_root *root)
204 {
205 while (!RB_EMPTY_ROOT(root)) {
206 struct crush_name_node *cn =
207 rb_entry(rb_first(root), struct crush_name_node, cn_node);
208
209 erase_crush_name(root, cn);
210 free_crush_name(cn);
211 }
212 }
213
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 53982 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ceph-client:testing 2/5] net/ceph/osdmap.c:203:6: warning: no previous prototype for 'clear_crush_names'
2020-05-30 18:34 ` kbuild test robot
@ 2020-05-31 9:37 ` Ilya Dryomov
-1 siblings, 0 replies; 4+ messages in thread
From: Ilya Dryomov @ 2020-05-31 9:37 UTC (permalink / raw)
To: kbuild test robot; +Cc: kbuild-all, Ceph Development
On Sat, May 30, 2020 at 8:35 PM kbuild test robot <lkp@intel.com> wrote:
>
> tree: https://github.com/ceph/ceph-client.git testing
> head: b3a5867e0780ac0279cf1541ed985db78f186221
> commit: a9112bbf346099ab532fc52ef87d46935fe8e519 [2/5] libceph: decode CRUSH device/bucket types and names
> config: m68k-allmodconfig (attached as .config)
> compiler: m68k-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout a9112bbf346099ab532fc52ef87d46935fe8e519
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>, old ones prefixed by <<):
>
> In file included from arch/m68k/include/asm/io_mm.h:25,
> from arch/m68k/include/asm/io.h:8,
> from include/linux/io.h:13,
> from include/linux/irq.h:20,
> from include/asm-generic/hardirq.h:13,
> from ./arch/m68k/include/generated/asm/hardirq.h:1,
> from include/linux/hardirq.h:9,
> from include/linux/highmem.h:10,
> from include/linux/pagemap.h:11,
> from include/linux/blkdev.h:16,
> from include/linux/backing-dev.h:15,
> from include/linux/ceph/libceph.h:8,
> from net/ceph/osdmap.c:8:
> arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsb':
> arch/m68k/include/asm/raw_io.h:83:7: warning: variable '__w' set but not used [-Wunused-but-set-variable]
> 83 | ({u8 __w, __v = (b); u32 _addr = ((u32) (addr)); | ^~~
> arch/m68k/include/asm/raw_io.h:430:3: note: in expansion of macro 'rom_out_8'
> 430 | rom_out_8(port, *buf++);
> | ^~~~~~~~~
> arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw':
> arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable]
> 86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); | ^~~
> arch/m68k/include/asm/raw_io.h:448:3: note: in expansion of macro 'rom_out_be16'
> 448 | rom_out_be16(port, *buf++);
> | ^~~~~~~~~~~~
> arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw_swapw':
> arch/m68k/include/asm/raw_io.h:90:8: warning: variable '__w' set but not used [-Wunused-but-set-variable]
> 90 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); | ^~~
> arch/m68k/include/asm/raw_io.h:466:3: note: in expansion of macro 'rom_out_le16'
> 466 | rom_out_le16(port, *buf++);
> | ^~~~~~~~~~~~
> In file included from include/linux/string.h:6,
> from include/linux/ceph/ceph_debug.h:7,
> from net/ceph/osdmap.c:3:
> include/linux/scatterlist.h: In function 'sg_set_buf':
> arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
> 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
> | ^~
> include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
> 78 | # define unlikely(x) __builtin_expect(!!(x), 0)
> | ^
> include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
> 143 | BUG_ON(!virt_addr_valid(buf));
> | ^~~~~~
> include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
> 143 | BUG_ON(!virt_addr_valid(buf));
> | ^~~~~~~~~~~~~~~
> In file included from arch/m68k/include/asm/bug.h:32,
> from include/linux/bug.h:5,
> from include/linux/thread_info.h:12,
> from include/asm-generic/preempt.h:5,
> from ./arch/m68k/include/generated/asm/preempt.h:1,
> from include/linux/preempt.h:78,
> from include/linux/spinlock.h:51,
> from include/linux/seqlock.h:36,
> from include/linux/time.h:6,
> from include/linux/stat.h:19,
> from include/linux/module.h:13,
> from net/ceph/osdmap.c:5:
> include/linux/dma-mapping.h: In function 'dma_map_resource':
> arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
> 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
> | ^~
> include/asm-generic/bug.h:139:27: note: in definition of macro 'WARN_ON_ONCE'
> 139 | int __ret_warn_once = !!(condition); | ^~~~~~~~~
> arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid'
> 170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn))
> | ^~~~~~~~~~~~~~~
> include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
> 352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
> | ^~~~~~~~~
> net/ceph/osdmap.c: At top level:
> >> net/ceph/osdmap.c:203:6: warning: no previous prototype for 'clear_crush_names' [-Wmissing-prototypes]
> 203 | void clear_crush_names(struct rb_root *root)
> | ^~~~~~~~~~~~~~~~~
> net/ceph/osdmap.c:249:6: warning: no previous prototype for 'clear_choose_args' [-Wmissing-prototypes]
> 249 | void clear_choose_args(struct crush_map *c)
> | ^~~~~~~~~~~~~~~~~
> In file included from net/ceph/osdmap.c:8:
> include/linux/ceph/libceph.h:234:14: warning: 'lookup_crush_name' defined but not used [-Wunused-function]
> 234 | static type *lookup_##name(struct rb_root *root, lookup_param_type key) | ^~~~~~~
> include/linux/ceph/libceph.h:268:1: note: in expansion of macro 'DEFINE_RB_LOOKUP_FUNC2'
> 268 | DEFINE_RB_LOOKUP_FUNC2(name, type, keyfld, RB_CMP3WAY, RB_BYVAL, | ^~~~~~~~~~~~~~~~~~~~~~
> include/linux/ceph/libceph.h:273:1: note: in expansion of macro 'DEFINE_RB_LOOKUP_FUNC'
> 273 | DEFINE_RB_LOOKUP_FUNC(name, type, keyfld, nodefld)
> | ^~~~~~~~~~~~~~~~~~~~~
> net/ceph/osdmap.c:166:1: note: in expansion of macro 'DEFINE_RB_FUNCS'
> 166 | DEFINE_RB_FUNCS(crush_name, struct crush_name_node, cn_id, cn_node)
> | ^~~~~~~~~~~~~~~
>
> vim +/clear_crush_names +203 net/ceph/osdmap.c
>
> 202
> > 203 void clear_crush_names(struct rb_root *root)
> 204 {
> 205 while (!RB_EMPTY_ROOT(root)) {
> 206 struct crush_name_node *cn =
> 207 rb_entry(rb_first(root), struct crush_name_node, cn_node);
> 208
> 209 erase_crush_name(root, cn);
> 210 free_crush_name(cn);
> 211 }
> 212 }
> 213
Fixed.
Thanks,
Ilya
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ceph-client:testing 2/5] net/ceph/osdmap.c:203:6: warning: no previous prototype for 'clear_crush_names'
@ 2020-05-31 9:37 ` Ilya Dryomov
0 siblings, 0 replies; 4+ messages in thread
From: Ilya Dryomov @ 2020-05-31 9:37 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 6711 bytes --]
On Sat, May 30, 2020 at 8:35 PM kbuild test robot <lkp@intel.com> wrote:
>
> tree: https://github.com/ceph/ceph-client.git testing
> head: b3a5867e0780ac0279cf1541ed985db78f186221
> commit: a9112bbf346099ab532fc52ef87d46935fe8e519 [2/5] libceph: decode CRUSH device/bucket types and names
> config: m68k-allmodconfig (attached as .config)
> compiler: m68k-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout a9112bbf346099ab532fc52ef87d46935fe8e519
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>, old ones prefixed by <<):
>
> In file included from arch/m68k/include/asm/io_mm.h:25,
> from arch/m68k/include/asm/io.h:8,
> from include/linux/io.h:13,
> from include/linux/irq.h:20,
> from include/asm-generic/hardirq.h:13,
> from ./arch/m68k/include/generated/asm/hardirq.h:1,
> from include/linux/hardirq.h:9,
> from include/linux/highmem.h:10,
> from include/linux/pagemap.h:11,
> from include/linux/blkdev.h:16,
> from include/linux/backing-dev.h:15,
> from include/linux/ceph/libceph.h:8,
> from net/ceph/osdmap.c:8:
> arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsb':
> arch/m68k/include/asm/raw_io.h:83:7: warning: variable '__w' set but not used [-Wunused-but-set-variable]
> 83 | ({u8 __w, __v = (b); u32 _addr = ((u32) (addr)); | ^~~
> arch/m68k/include/asm/raw_io.h:430:3: note: in expansion of macro 'rom_out_8'
> 430 | rom_out_8(port, *buf++);
> | ^~~~~~~~~
> arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw':
> arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable]
> 86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); | ^~~
> arch/m68k/include/asm/raw_io.h:448:3: note: in expansion of macro 'rom_out_be16'
> 448 | rom_out_be16(port, *buf++);
> | ^~~~~~~~~~~~
> arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw_swapw':
> arch/m68k/include/asm/raw_io.h:90:8: warning: variable '__w' set but not used [-Wunused-but-set-variable]
> 90 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); | ^~~
> arch/m68k/include/asm/raw_io.h:466:3: note: in expansion of macro 'rom_out_le16'
> 466 | rom_out_le16(port, *buf++);
> | ^~~~~~~~~~~~
> In file included from include/linux/string.h:6,
> from include/linux/ceph/ceph_debug.h:7,
> from net/ceph/osdmap.c:3:
> include/linux/scatterlist.h: In function 'sg_set_buf':
> arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
> 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
> | ^~
> include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
> 78 | # define unlikely(x) __builtin_expect(!!(x), 0)
> | ^
> include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
> 143 | BUG_ON(!virt_addr_valid(buf));
> | ^~~~~~
> include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
> 143 | BUG_ON(!virt_addr_valid(buf));
> | ^~~~~~~~~~~~~~~
> In file included from arch/m68k/include/asm/bug.h:32,
> from include/linux/bug.h:5,
> from include/linux/thread_info.h:12,
> from include/asm-generic/preempt.h:5,
> from ./arch/m68k/include/generated/asm/preempt.h:1,
> from include/linux/preempt.h:78,
> from include/linux/spinlock.h:51,
> from include/linux/seqlock.h:36,
> from include/linux/time.h:6,
> from include/linux/stat.h:19,
> from include/linux/module.h:13,
> from net/ceph/osdmap.c:5:
> include/linux/dma-mapping.h: In function 'dma_map_resource':
> arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
> 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
> | ^~
> include/asm-generic/bug.h:139:27: note: in definition of macro 'WARN_ON_ONCE'
> 139 | int __ret_warn_once = !!(condition); | ^~~~~~~~~
> arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid'
> 170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn))
> | ^~~~~~~~~~~~~~~
> include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
> 352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
> | ^~~~~~~~~
> net/ceph/osdmap.c: At top level:
> >> net/ceph/osdmap.c:203:6: warning: no previous prototype for 'clear_crush_names' [-Wmissing-prototypes]
> 203 | void clear_crush_names(struct rb_root *root)
> | ^~~~~~~~~~~~~~~~~
> net/ceph/osdmap.c:249:6: warning: no previous prototype for 'clear_choose_args' [-Wmissing-prototypes]
> 249 | void clear_choose_args(struct crush_map *c)
> | ^~~~~~~~~~~~~~~~~
> In file included from net/ceph/osdmap.c:8:
> include/linux/ceph/libceph.h:234:14: warning: 'lookup_crush_name' defined but not used [-Wunused-function]
> 234 | static type *lookup_##name(struct rb_root *root, lookup_param_type key) | ^~~~~~~
> include/linux/ceph/libceph.h:268:1: note: in expansion of macro 'DEFINE_RB_LOOKUP_FUNC2'
> 268 | DEFINE_RB_LOOKUP_FUNC2(name, type, keyfld, RB_CMP3WAY, RB_BYVAL, | ^~~~~~~~~~~~~~~~~~~~~~
> include/linux/ceph/libceph.h:273:1: note: in expansion of macro 'DEFINE_RB_LOOKUP_FUNC'
> 273 | DEFINE_RB_LOOKUP_FUNC(name, type, keyfld, nodefld)
> | ^~~~~~~~~~~~~~~~~~~~~
> net/ceph/osdmap.c:166:1: note: in expansion of macro 'DEFINE_RB_FUNCS'
> 166 | DEFINE_RB_FUNCS(crush_name, struct crush_name_node, cn_id, cn_node)
> | ^~~~~~~~~~~~~~~
>
> vim +/clear_crush_names +203 net/ceph/osdmap.c
>
> 202
> > 203 void clear_crush_names(struct rb_root *root)
> 204 {
> 205 while (!RB_EMPTY_ROOT(root)) {
> 206 struct crush_name_node *cn =
> 207 rb_entry(rb_first(root), struct crush_name_node, cn_node);
> 208
> 209 erase_crush_name(root, cn);
> 210 free_crush_name(cn);
> 211 }
> 212 }
> 213
Fixed.
Thanks,
Ilya
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-31 9:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-30 18:34 [ceph-client:testing 2/5] net/ceph/osdmap.c:203:6: warning: no previous prototype for 'clear_crush_names' kbuild test robot
2020-05-30 18:34 ` kbuild test robot
2020-05-31 9:37 ` Ilya Dryomov
2020-05-31 9:37 ` Ilya Dryomov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.