All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-amlogic@lists.infradead.org, linux-media@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Carlo Caione <carlo@caione.org>,
	mchehab@kernel.org, devicetree <devicetree@vger.kernel.org>,
	Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH v3 0/4] Add Meson 8b / GXBB support to the IR driver
Date: Sun, 7 Aug 2016 22:54:59 -0700	[thread overview]
Message-ID: <CAOi56cV=mELtvUVAB8M=x6abfjQ-8dBj4HH8Xieuv14g8ppgWA@mail.gmail.com> (raw)
In-Reply-To: <20160628191802.21227-1-martin.blumenstingl@googlemail.com>

Hi Martin,

On Tue, Jun 28, 2016 at 12:17 PM, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
> Newer Amlogic platforms (Meson 8b and GXBB) use a slightly different
> register layout for their Infrared Remoete Controller. The decoder mode
> is now configured in another register. Without the changes to the
> meson-ir driver we are simply getting incorrect "durations" reported
> from the hardware (because the hardware is not in time measurement aka
> software decode mode).
>
> This problem was also noticed by some people trying to use this on an
> ODROID-C1 and ODROID-C2 - the workaround there (probably because the
> datasheets were not publicy available yet at that time) was to switch
> to ir_raw_event_store_edge (which leaves it up to the kernel to measure
> the duration of a pulse). See [0] and [1] for the corresponding
> patches.

I tried this on meson-gxbb-p200 and I'm not seeing any button press
events with evtest or ir-keytable when using the Amlogic remote that
came with the board.  Below is the register dump you requested on IRC:

[    1.068347] Registered IR keymap rc-empty
[    1.072422] input: meson-ir as
/devices/platform/soc/c8100000.aobus/c8100580.ir/rc/rc0/input0
[    1.080814] rc rc0: meson-ir as
/devices/platform/soc/c8100000.aobus/c8100580.ir/rc/rc0
[    1.088839] input: MCE IR Keyboard/Mouse (meson-ir) as
/devices/virtual/input/input1
[    1.096519] rc rc0: lirc_dev: driver ir-lirc-codec (meson-ir)
registered at minor = 0
[    1.104119] meson-ir c8100580.ir: receiver initialized
[    1.109172] IR: reg 0x00 = 0x01d801ac
[    1.112795] IR: reg 0x04 = 0x00f800ca
[    1.116416] IR: reg 0x08 = 0x007a0066
[    1.120037] IR: reg 0x0c = 0x0044002c
[    1.123660] IR: reg 0x10 = 0x70fa0009
[    1.127278] IR: reg 0x14 = 0x00000000
[    1.130907] IR: reg 0x18 = 0x08915c00
[    1.134527] IR: reg 0x1c = 0x00009f44
[    1.138152] IR: reg 0x20 = 0x00000002

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v3 0/4] Add Meson 8b / GXBB support to the IR driver
Date: Sun, 7 Aug 2016 22:54:59 -0700	[thread overview]
Message-ID: <CAOi56cV=mELtvUVAB8M=x6abfjQ-8dBj4HH8Xieuv14g8ppgWA@mail.gmail.com> (raw)
In-Reply-To: <20160628191802.21227-1-martin.blumenstingl@googlemail.com>

Hi Martin,

On Tue, Jun 28, 2016 at 12:17 PM, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
> Newer Amlogic platforms (Meson 8b and GXBB) use a slightly different
> register layout for their Infrared Remoete Controller. The decoder mode
> is now configured in another register. Without the changes to the
> meson-ir driver we are simply getting incorrect "durations" reported
> from the hardware (because the hardware is not in time measurement aka
> software decode mode).
>
> This problem was also noticed by some people trying to use this on an
> ODROID-C1 and ODROID-C2 - the workaround there (probably because the
> datasheets were not publicy available yet at that time) was to switch
> to ir_raw_event_store_edge (which leaves it up to the kernel to measure
> the duration of a pulse). See [0] and [1] for the corresponding
> patches.

I tried this on meson-gxbb-p200 and I'm not seeing any button press
events with evtest or ir-keytable when using the Amlogic remote that
came with the board.  Below is the register dump you requested on IRC:

[    1.068347] Registered IR keymap rc-empty
[    1.072422] input: meson-ir as
/devices/platform/soc/c8100000.aobus/c8100580.ir/rc/rc0/input0
[    1.080814] rc rc0: meson-ir as
/devices/platform/soc/c8100000.aobus/c8100580.ir/rc/rc0
[    1.088839] input: MCE IR Keyboard/Mouse (meson-ir) as
/devices/virtual/input/input1
[    1.096519] rc rc0: lirc_dev: driver ir-lirc-codec (meson-ir)
registered at minor = 0
[    1.104119] meson-ir c8100580.ir: receiver initialized
[    1.109172] IR: reg 0x00 = 0x01d801ac
[    1.112795] IR: reg 0x04 = 0x00f800ca
[    1.116416] IR: reg 0x08 = 0x007a0066
[    1.120037] IR: reg 0x0c = 0x0044002c
[    1.123660] IR: reg 0x10 = 0x70fa0009
[    1.127278] IR: reg 0x14 = 0x00000000
[    1.130907] IR: reg 0x18 = 0x08915c00
[    1.134527] IR: reg 0x1c = 0x00009f44
[    1.138152] IR: reg 0x20 = 0x00000002

Kevin

  parent reply	other threads:[~2016-08-08  5:54 UTC|newest]

Thread overview: 112+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-26 21:06 [v2] media: rc: fix Meson IR decoder Martin Blumenstingl
2016-06-26 21:06 ` Martin Blumenstingl
2016-06-26 21:06 ` Martin Blumenstingl
2016-06-26 21:06 ` [PATCH v2 1/2] media: rc: meson-ir: fix enabling raw/soft-decoding mode Martin Blumenstingl
2016-06-26 21:06   ` Martin Blumenstingl
2016-06-26 21:06   ` Martin Blumenstingl
2016-06-26 21:06 ` [PATCH v2 2/2] ARM: dts: meson: fixed size of the meson-ir registers Martin Blumenstingl
2016-06-26 21:06   ` Martin Blumenstingl
2016-06-26 21:06   ` Martin Blumenstingl
2016-06-27  8:43   ` Carlo Caione
2016-06-27  8:43     ` Carlo Caione
2016-06-27  8:43     ` Carlo Caione
2016-06-27  6:27 ` [v2] media: rc: fix Meson IR decoder Neil Armstrong
2016-06-27 10:53   ` Martin Blumenstingl
2016-06-27  6:28 ` Neil Armstrong
2016-06-27  6:28   ` Neil Armstrong
     [not found] ` <20160626210622.5257-1-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-06-27 12:57   ` Neil Armstrong
2016-06-27 12:57     ` Neil Armstrong
2016-06-27 12:57     ` Neil Armstrong
2016-06-27 12:57     ` Neil Armstrong
2016-06-28 19:17 ` [PATCH v3 0/4] Add Meson 8b / GXBB support to the IR driver Martin Blumenstingl
2016-06-28 19:17   ` Martin Blumenstingl
2016-06-28 19:17   ` [PATCH v3 1/4] dt-bindings: media: meson-ir: Add Meson8b and GXBB compatible strings Martin Blumenstingl
2016-06-28 19:17     ` Martin Blumenstingl
2016-07-01  1:34     ` Rob Herring
2016-07-01  1:34       ` Rob Herring
2016-06-28 19:18   ` [PATCH v3 2/4] media: rc: meson-ir: Add support for newer versions of the IR decoder Martin Blumenstingl
2016-06-28 19:18     ` Martin Blumenstingl
2016-06-28 19:18   ` [PATCH v3 3/4] ARM64: meson-gxbb: Add Infrared Remote Controller decoder Martin Blumenstingl
2016-06-28 19:18     ` Martin Blumenstingl
2016-06-28 19:18   ` [PATCH v3 4/4] ARM64: dts: meson-gxbb: Enable the the IR decoder on supported boards Martin Blumenstingl
2016-06-28 19:18     ` Martin Blumenstingl
2016-08-08  5:54   ` Kevin Hilman [this message]
2016-08-08  5:54     ` [PATCH v3 0/4] Add Meson 8b / GXBB support to the IR driver Kevin Hilman
2016-08-19 21:55   ` [PATCH v4 0/6] " Martin Blumenstingl
2016-08-19 21:55     ` Martin Blumenstingl
2016-08-19 21:55     ` Martin Blumenstingl
2016-08-19 21:55     ` Martin Blumenstingl
2016-08-19 21:55     ` [PATCH v4 1/6] pinctrl: amlogic: gxbb: add the IR remote pin Martin Blumenstingl
2016-08-19 21:55       ` Martin Blumenstingl
2016-08-19 21:55       ` Martin Blumenstingl
2016-08-19 21:55       ` Martin Blumenstingl
2016-08-19 22:23       ` Kevin Hilman
2016-08-19 22:23         ` Kevin Hilman
2016-08-19 22:23         ` Kevin Hilman
     [not found]     ` <20160819215547.20063-1-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-08-19 21:55       ` [PATCH v4 2/6] ARM64: dts: amlogic: add the pin for the IR remote Martin Blumenstingl
2016-08-19 21:55         ` Martin Blumenstingl
2016-08-19 21:55         ` Martin Blumenstingl
2016-08-19 21:55         ` Martin Blumenstingl
2016-08-19 21:55       ` [PATCH v4 3/6] dt-bindings: media: meson-ir: Add Meson8b and GXBB compatible strings Martin Blumenstingl
2016-08-19 21:55         ` Martin Blumenstingl
2016-08-19 21:55         ` Martin Blumenstingl
2016-08-19 21:55         ` Martin Blumenstingl
2016-08-19 21:55       ` [PATCH v4 6/6] ARM64: dts: meson-gxbb: Enable the the IR decoder on supported boards Martin Blumenstingl
2016-08-19 21:55         ` Martin Blumenstingl
2016-08-19 21:55         ` Martin Blumenstingl
2016-08-19 21:55         ` Martin Blumenstingl
2016-08-19 21:55     ` [PATCH v4 4/6] media: rc: meson-ir: Add support for newer versions of the IR decoder Martin Blumenstingl
2016-08-19 21:55       ` Martin Blumenstingl
2016-08-19 21:55       ` Martin Blumenstingl
2016-08-19 22:28       ` Kevin Hilman
2016-08-19 22:28         ` Kevin Hilman
2016-08-19 22:28         ` Kevin Hilman
2016-08-19 22:28         ` Kevin Hilman
2016-08-25 12:41         ` Mauro Carvalho Chehab
2016-08-25 12:41           ` Mauro Carvalho Chehab
2016-08-25 12:41           ` Mauro Carvalho Chehab
2016-08-19 21:55     ` [PATCH v4 5/6] ARM64: dts: meson-gxbb: Add Infrared Remote Controller decoder Martin Blumenstingl
2016-08-19 21:55       ` Martin Blumenstingl
2016-08-19 21:55       ` Martin Blumenstingl
2016-08-20  9:54     ` [PATCH v5 0/6] Add Meson 8b / GXBB support to the IR driver Martin Blumenstingl
2016-08-20  9:54       ` Martin Blumenstingl
2016-08-20  9:54       ` Martin Blumenstingl
2016-08-20  9:54       ` Martin Blumenstingl
2016-08-20  9:54       ` [PATCH v5 1/6] pinctrl: amlogic: gxbb: add the IR remote input pin Martin Blumenstingl
2016-08-20  9:54         ` Martin Blumenstingl
2016-08-20  9:54         ` Martin Blumenstingl
2016-08-20  9:54         ` Martin Blumenstingl
     [not found]         ` <20160820095424.636-2-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-08-22 13:51           ` Linus Walleij
2016-08-22 13:51             ` Linus Walleij
2016-08-22 13:51             ` Linus Walleij
2016-08-22 13:51             ` Linus Walleij
2016-08-20  9:54       ` [PATCH v5 3/6] dt-bindings: media: meson-ir: Add Meson8b and GXBB compatible strings Martin Blumenstingl
2016-08-20  9:54         ` Martin Blumenstingl
2016-08-20  9:54         ` Martin Blumenstingl
2016-08-20  9:54         ` Martin Blumenstingl
2016-08-20  9:54       ` [PATCH v5 4/6] media: rc: meson-ir: Add support for newer versions of the IR decoder Martin Blumenstingl
2016-08-20  9:54         ` Martin Blumenstingl
2016-08-20  9:54         ` Martin Blumenstingl
2016-08-20  9:54       ` [PATCH v5 5/6] ARM64: dts: meson-gxbb: Add Infrared Remote Controller decoder Martin Blumenstingl
2016-08-20  9:54         ` Martin Blumenstingl
2016-08-20  9:54         ` Martin Blumenstingl
     [not found]       ` <20160820095424.636-1-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-08-20  9:54         ` [PATCH v5 2/6] ARM64: dts: amlogic: add the input pin for the IR remote Martin Blumenstingl
2016-08-20  9:54           ` Martin Blumenstingl
2016-08-20  9:54           ` Martin Blumenstingl
2016-08-20  9:54           ` Martin Blumenstingl
     [not found]           ` <20160820095424.636-3-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-08-22 13:52             ` Linus Walleij
2016-08-22 13:52               ` Linus Walleij
2016-08-22 13:52               ` Linus Walleij
2016-08-22 13:52               ` Linus Walleij
2016-08-20  9:54         ` [PATCH v5 6/6] ARM64: dts: meson-gxbb: Enable the the IR decoder on supported boards Martin Blumenstingl
2016-08-20  9:54           ` Martin Blumenstingl
2016-08-20  9:54           ` Martin Blumenstingl
2016-08-20  9:54           ` Martin Blumenstingl
2016-08-29 19:28         ` [PATCH v5 0/6] Add Meson 8b / GXBB support to the IR driver Kevin Hilman
2016-08-29 19:28           ` Kevin Hilman
2016-08-29 19:28           ` Kevin Hilman
2016-08-29 19:28           ` Kevin Hilman
2016-08-20  9:53   ` Martin Blumenstingl
2016-08-20  9:53     ` Martin Blumenstingl
2016-08-20  9:53     ` Martin Blumenstingl
2016-08-20  9:53     ` Martin Blumenstingl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOi56cV=mELtvUVAB8M=x6abfjQ-8dBj4HH8Xieuv14g8ppgWA@mail.gmail.com' \
    --to=khilman@baylibre.com \
    --cc=carlo@caione.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=mchehab@kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.