From: Jonas Gorski <jonas.gorski@gmail.com> To: Rob Herring <robh@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>, Boris Brezillon <boris.brezillon@bootlin.com>, Richard Weinberger <richard@nod.at>, Marek Vasut <marek.vasut@gmail.com>, MTD Maling List <linux-mtd@lists.infradead.org>, Brian Norris <computersforpeace@gmail.com>, David Woodhouse <dwmw2@infradead.org> Subject: Re: [PATCH 4/5] dt-bindings: mtd: describe BCM963XX ImageTag format and usage Date: Mon, 10 Sep 2018 11:02:40 +0200 [thread overview] Message-ID: <CAOiHx=koYJR_m1RdxxSjxQH-8MuWBw18YfNDun3OWnca=CoT_g@mail.gmail.com> (raw) In-Reply-To: <5b8e8a58.1c69fb81.12eaa.f292@mx.google.com> On 4 September 2018 at 02:30, Rob Herring <robh@kernel.org> wrote: > On Tue, Aug 28, 2018 at 01:19:43PM +0200, Jonas Gorski wrote: >> Describe how to use the BCM963XX ImageTag format in a mixed flash layout >> environment. >> >> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com> >> --- >> .../mtd/partitions/brcm,bcm963xx-imagetag.txt | 78 ++++++++++++++++++++++ >> 1 file changed, 78 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mtd/partitions/brcm,bcm963xx-imagetag.txt >> >> diff --git a/Documentation/devicetree/bindings/mtd/partitions/brcm,bcm963xx-imagetag.txt b/Documentation/devicetree/bindings/mtd/partitions/brcm,bcm963xx-imagetag.txt >> new file mode 100644 >> index 000000000000..f4a444d69d9a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mtd/partitions/brcm,bcm963xx-imagetag.txt >> @@ -0,0 +1,78 @@ >> +Broadcom BCM963XX ImageTag Partition Container >> +============================================== >> + >> +Some Broadcom BCM63XX SoC based devices contain additional, non discoverable >> +partitions or non standard bootloader partition sizes. For these a mixed layout >> +needs to be used with an explicit firmware partition. >> + >> +The BCM963XX ImageTag is a simple firmware header describing the offsets and >> +sizes of the rootfs and kernel parts contained in the firmware. >> + >> +Required properties: >> +- compatible : must be "brcm,bcm963xx-imagetag" >> + >> +Examples: >> + >> +flash@1e000000 { >> + compatible = "cfi-flash"; >> + reg = <0x1e000000 0x2000000>; >> + bank-width = <2>; >> + >> + partitions { >> + compatible = "fixed-partitions"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + >> + cfe@0 { >> + reg = <0x0 0x10000>; >> + read-only; >> + }; >> + >> + firmware@10000 { >> + reg = <0x10000 0x7d0000>; >> + compatible = "brcm,bcm963xx-imagetag"; >> + }; >> + >> + caldata@7e0000 { >> + reg = <0x7e0000 0x10000>; >> + read-only; >> + }; >> + >> + nvram@7f0000 { >> + reg = <0x7f0000 0x10000>; >> + }; >> + }; >> +}; >> + >> + >> +flash@1e000000 { >> + compatible = "cfi-flash"; >> + reg = <0x1e000000 0x2000000>; >> + bank-width = <2>; >> + >> + partitions { >> + compatible = "fixed-partitions"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + >> + /* >> + * Some devices use a flash chip with 64k erase blocks, some >> + * use one with 128k erase blocks, so the vendor decided to >> + * always use 128k as the firmware offset. >> + */ > > That's a interesting piece of info, but not really a reason to have a > second example. Generally, I'd rather have one example too many than one too few, but I can drop it if you think it's unnecessary. If I do that, can I add your Ack then here as well for the v2? > >> + >> + cfe@0 { >> + reg = <0x0 0x20000>; >> + read-only; >> + }; >> + >> + firmware@20000 { >> + reg = <0x20000 0x7c0000>; >> + compatible = "brcm,bcm963xx-imagetag"; >> + }; >> + >> + nvram@7e0000 { >> + reg = <0x7e0000 0x20000>; >> + }; >> + }; >> +}; >> -- >> 2.13.2 >> > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Jonas Gorski <jonas.gorski@gmail.com> To: Rob Herring <robh@kernel.org> Cc: MTD Maling List <linux-mtd@lists.infradead.org>, devicetree@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, Boris Brezillon <boris.brezillon@bootlin.com>, Marek Vasut <marek.vasut@gmail.com>, Richard Weinberger <richard@nod.at>, Mark Rutland <mark.rutland@arm.com>, Florian Fainelli <f.fainelli@gmail.com> Subject: Re: [PATCH 4/5] dt-bindings: mtd: describe BCM963XX ImageTag format and usage Date: Mon, 10 Sep 2018 11:02:40 +0200 [thread overview] Message-ID: <CAOiHx=koYJR_m1RdxxSjxQH-8MuWBw18YfNDun3OWnca=CoT_g@mail.gmail.com> (raw) In-Reply-To: <5b8e8a58.1c69fb81.12eaa.f292@mx.google.com> On 4 September 2018 at 02:30, Rob Herring <robh@kernel.org> wrote: > On Tue, Aug 28, 2018 at 01:19:43PM +0200, Jonas Gorski wrote: >> Describe how to use the BCM963XX ImageTag format in a mixed flash layout >> environment. >> >> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com> >> --- >> .../mtd/partitions/brcm,bcm963xx-imagetag.txt | 78 ++++++++++++++++++++++ >> 1 file changed, 78 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mtd/partitions/brcm,bcm963xx-imagetag.txt >> >> diff --git a/Documentation/devicetree/bindings/mtd/partitions/brcm,bcm963xx-imagetag.txt b/Documentation/devicetree/bindings/mtd/partitions/brcm,bcm963xx-imagetag.txt >> new file mode 100644 >> index 000000000000..f4a444d69d9a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mtd/partitions/brcm,bcm963xx-imagetag.txt >> @@ -0,0 +1,78 @@ >> +Broadcom BCM963XX ImageTag Partition Container >> +============================================== >> + >> +Some Broadcom BCM63XX SoC based devices contain additional, non discoverable >> +partitions or non standard bootloader partition sizes. For these a mixed layout >> +needs to be used with an explicit firmware partition. >> + >> +The BCM963XX ImageTag is a simple firmware header describing the offsets and >> +sizes of the rootfs and kernel parts contained in the firmware. >> + >> +Required properties: >> +- compatible : must be "brcm,bcm963xx-imagetag" >> + >> +Examples: >> + >> +flash@1e000000 { >> + compatible = "cfi-flash"; >> + reg = <0x1e000000 0x2000000>; >> + bank-width = <2>; >> + >> + partitions { >> + compatible = "fixed-partitions"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + >> + cfe@0 { >> + reg = <0x0 0x10000>; >> + read-only; >> + }; >> + >> + firmware@10000 { >> + reg = <0x10000 0x7d0000>; >> + compatible = "brcm,bcm963xx-imagetag"; >> + }; >> + >> + caldata@7e0000 { >> + reg = <0x7e0000 0x10000>; >> + read-only; >> + }; >> + >> + nvram@7f0000 { >> + reg = <0x7f0000 0x10000>; >> + }; >> + }; >> +}; >> + >> + >> +flash@1e000000 { >> + compatible = "cfi-flash"; >> + reg = <0x1e000000 0x2000000>; >> + bank-width = <2>; >> + >> + partitions { >> + compatible = "fixed-partitions"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + >> + /* >> + * Some devices use a flash chip with 64k erase blocks, some >> + * use one with 128k erase blocks, so the vendor decided to >> + * always use 128k as the firmware offset. >> + */ > > That's a interesting piece of info, but not really a reason to have a > second example. Generally, I'd rather have one example too many than one too few, but I can drop it if you think it's unnecessary. If I do that, can I add your Ack then here as well for the v2? > >> + >> + cfe@0 { >> + reg = <0x0 0x20000>; >> + read-only; >> + }; >> + >> + firmware@20000 { >> + reg = <0x20000 0x7c0000>; >> + compatible = "brcm,bcm963xx-imagetag"; >> + }; >> + >> + nvram@7e0000 { >> + reg = <0x7e0000 0x20000>; >> + }; >> + }; >> +}; >> -- >> 2.13.2 >> >
next prev parent reply other threads:[~2018-09-10 9:02 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-28 11:19 [PATCH 0/5] mtd: bcm63xxpart: add device tree support Jonas Gorski 2018-08-28 11:19 ` Jonas Gorski 2018-08-28 11:19 ` [PATCH 1/5] dt-bindings: mtd: describe the simple BCM963XX NOR flash layout Jonas Gorski 2018-08-28 11:19 ` Jonas Gorski 2018-09-04 13:33 ` Rob Herring 2018-09-04 13:33 ` Rob Herring 2018-08-28 11:19 ` [PATCH 2/5] mtd: bcm63xxpart: add of_match_table support Jonas Gorski 2018-08-28 11:19 ` Jonas Gorski 2018-08-28 11:19 ` [PATCH 3/5] mtd: bcm63xxpart: move imagetag parsing to its own parser Jonas Gorski 2018-08-28 11:19 ` Jonas Gorski 2018-08-28 11:19 ` [PATCH 4/5] dt-bindings: mtd: describe BCM963XX ImageTag format and usage Jonas Gorski 2018-08-28 11:19 ` Jonas Gorski 2018-09-04 0:30 ` Rob Herring 2018-09-04 0:30 ` Rob Herring 2018-09-10 9:02 ` Jonas Gorski [this message] 2018-09-10 9:02 ` Jonas Gorski 2018-09-10 9:09 ` Jonas Gorski 2018-09-10 9:09 ` Jonas Gorski 2018-09-10 12:12 ` Rob Herring 2018-09-10 12:12 ` Rob Herring 2018-08-28 11:19 ` [PATCH 5/5] mtd: parser_imagetag: add of_match_table support Jonas Gorski 2018-08-28 11:19 ` Jonas Gorski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAOiHx=koYJR_m1RdxxSjxQH-8MuWBw18YfNDun3OWnca=CoT_g@mail.gmail.com' \ --to=jonas.gorski@gmail.com \ --cc=boris.brezillon@bootlin.com \ --cc=computersforpeace@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=dwmw2@infradead.org \ --cc=f.fainelli@gmail.com \ --cc=linux-mtd@lists.infradead.org \ --cc=marek.vasut@gmail.com \ --cc=mark.rutland@arm.com \ --cc=richard@nod.at \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.