* [patch] ASoC: sh: dma-sh7760: fix a debug printf
@ 2016-11-17 11:00 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-11-17 11:00 UTC (permalink / raw)
To: Liam Girdwood, Manuel Lauss
Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, alsa-devel, kernel-janitors
We intended to print a hex here, but the code will print a base 10 with
an x on the end.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/sh/dma-sh7760.c b/sound/soc/sh/dma-sh7760.c
index 8fad444..c28ee1a 100644
--- a/sound/soc/sh/dma-sh7760.c
+++ b/sound/soc/sh/dma-sh7760.c
@@ -204,7 +204,7 @@ static int camelot_prepare(struct snd_pcm_substream *substream)
struct snd_soc_pcm_runtime *rtd = substream->private_data;
struct camelot_pcm *cam = &cam_pcm_data[rtd->cpu_dai->id];
- pr_debug("PCM data: addr 0x%08ulx len %d\n",
+ pr_debug("PCM data: addr 0x%08lx len %d\n",
(u32)runtime->dma_addr, runtime->dma_bytes);
if (substream->stream = SNDRV_PCM_STREAM_PLAYBACK) {
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [patch] ASoC: sh: dma-sh7760: fix a debug printf
@ 2016-11-17 11:00 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-11-17 11:00 UTC (permalink / raw)
To: Liam Girdwood, Manuel Lauss
Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, alsa-devel, kernel-janitors
We intended to print a hex here, but the code will print a base 10 with
an x on the end.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/sh/dma-sh7760.c b/sound/soc/sh/dma-sh7760.c
index 8fad444..c28ee1a 100644
--- a/sound/soc/sh/dma-sh7760.c
+++ b/sound/soc/sh/dma-sh7760.c
@@ -204,7 +204,7 @@ static int camelot_prepare(struct snd_pcm_substream *substream)
struct snd_soc_pcm_runtime *rtd = substream->private_data;
struct camelot_pcm *cam = &cam_pcm_data[rtd->cpu_dai->id];
- pr_debug("PCM data: addr 0x%08ulx len %d\n",
+ pr_debug("PCM data: addr 0x%08lx len %d\n",
(u32)runtime->dma_addr, runtime->dma_bytes);
if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [patch] ASoC: sh: dma-sh7760: fix a debug printf
2016-11-17 11:00 ` Dan Carpenter
@ 2016-11-17 13:31 ` bojan prtvar
-1 siblings, 0 replies; 6+ messages in thread
From: bojan prtvar @ 2016-11-17 13:31 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Manuel Lauss, Mark Brown, Jaroslav Kysela,
Takashi Iwai, alsa-devel, kernel-janitors
Hi,
On Thu, Nov 17, 2016 at 12:00 PM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> - pr_debug("PCM data: addr 0x%08ulx len %d\n",
> + pr_debug("PCM data: addr 0x%08lx len %d\n",
> (u32)runtime->dma_addr, runtime->dma_bytes);
While there, why not using %pad as suggested by
Documentation/printk-formats.txt?
Regards,
Bojan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] ASoC: sh: dma-sh7760: fix a debug printf
@ 2016-11-17 13:31 ` bojan prtvar
0 siblings, 0 replies; 6+ messages in thread
From: bojan prtvar @ 2016-11-17 13:31 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Manuel Lauss, Mark Brown, Jaroslav Kysela,
Takashi Iwai, alsa-devel, kernel-janitors
Hi,
On Thu, Nov 17, 2016 at 12:00 PM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> - pr_debug("PCM data: addr 0x%08ulx len %d\n",
> + pr_debug("PCM data: addr 0x%08lx len %d\n",
> (u32)runtime->dma_addr, runtime->dma_bytes);
While there, why not using %pad as suggested by
Documentation/printk-formats.txt?
Regards,
Bojan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] ASoC: sh: dma-sh7760: fix a debug printf
2016-11-17 13:31 ` bojan prtvar
@ 2016-11-17 13:55 ` Dan Carpenter
-1 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-11-17 13:55 UTC (permalink / raw)
To: bojan prtvar
Cc: alsa-devel, Manuel Lauss, kernel-janitors, Takashi Iwai,
Liam Girdwood, Mark Brown
On Thu, Nov 17, 2016 at 02:31:06PM +0100, bojan prtvar wrote:
> Hi,
>
> On Thu, Nov 17, 2016 at 12:00 PM, Dan Carpenter
> <dan.carpenter@oracle.com> wrote:
>
> > - pr_debug("PCM data: addr 0x%08ulx len %d\n",
> > + pr_debug("PCM data: addr 0x%08lx len %d\n",
> > (u32)runtime->dma_addr, runtime->dma_bytes);
>
> While there, why not using %pad as suggested by
> Documentation/printk-formats.txt?
Oh crap. I never even compiled this stuff... I'm really sorry it's
been a while since I screwed up like this. Sorry about this.
That sounds like a good idea but I don't have a cross compiler set up
so I'm going to leave it alone for now.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] ASoC: sh: dma-sh7760: fix a debug printf
@ 2016-11-17 13:55 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-11-17 13:55 UTC (permalink / raw)
To: bojan prtvar
Cc: alsa-devel, Manuel Lauss, kernel-janitors, Takashi Iwai,
Liam Girdwood, Mark Brown
On Thu, Nov 17, 2016 at 02:31:06PM +0100, bojan prtvar wrote:
> Hi,
>
> On Thu, Nov 17, 2016 at 12:00 PM, Dan Carpenter
> <dan.carpenter@oracle.com> wrote:
>
> > - pr_debug("PCM data: addr 0x%08ulx len %d\n",
> > + pr_debug("PCM data: addr 0x%08lx len %d\n",
> > (u32)runtime->dma_addr, runtime->dma_bytes);
>
> While there, why not using %pad as suggested by
> Documentation/printk-formats.txt?
Oh crap. I never even compiled this stuff... I'm really sorry it's
been a while since I screwed up like this. Sorry about this.
That sounds like a good idea but I don't have a cross compiler set up
so I'm going to leave it alone for now.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-11-17 13:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-17 11:00 [patch] ASoC: sh: dma-sh7760: fix a debug printf Dan Carpenter
2016-11-17 11:00 ` Dan Carpenter
2016-11-17 13:31 ` bojan prtvar
2016-11-17 13:31 ` bojan prtvar
2016-11-17 13:55 ` Dan Carpenter
2016-11-17 13:55 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.