From: Atish Patra <atishp@atishpatra.org> To: Mike Rapoport <rppt@kernel.org> Cc: Atish Patra <atish.patra@wdc.com>, Albert Ou <aou@eecs.berkeley.edu>, Kees Cook <keescook@chromium.org>, Anup Patel <anup@brainfault.org>, "linux-kernel@vger.kernel.org List" <linux-kernel@vger.kernel.org>, linux-riscv <linux-riscv@lists.infradead.org>, Palmer Dabbelt <palmer@dabbelt.com>, Zong Li <zong.li@sifive.com>, Paul Walmsley <paul.walmsley@sifive.com>, Greentime Hu <greentime.hu@sifive.com>, Andrew Morton <akpm@linux-foundation.org>, Borislav Petkov <bp@suse.de>, Michel Lespinasse <walken@google.com>, Ard Biesheuvel <ardb@kernel.org> Subject: Re: [PATCH v2 2/6] RISC-V: Initialize SBI early Date: Tue, 27 Oct 2020 11:38:35 -0700 [thread overview] Message-ID: <CAOnJCUJF8DTNpiGxL0Tz8CUk43CvfJS2w5fw=Y51afKgW22cTQ@mail.gmail.com> (raw) In-Reply-To: <20201027100427.GL1154158@kernel.org> On Tue, Oct 27, 2020 at 3:04 AM Mike Rapoport <rppt@kernel.org> wrote: > > On Mon, Oct 26, 2020 at 04:02:50PM -0700, Atish Patra wrote: > > Currently, SBI is initialized towards the end of arch setup. This prevents > > the set memory operations to be invoked earlier as it requires a full tlb > > flush. > > > > Initialize SBI as early as possible. > > > > Signed-off-by: Atish Patra <atish.patra@wdc.com> > > --- > > arch/riscv/kernel/setup.c | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c > > index c424cc6dd833..7d6a04ae3929 100644 > > --- a/arch/riscv/kernel/setup.c > > +++ b/arch/riscv/kernel/setup.c > > @@ -89,6 +89,9 @@ void __init setup_arch(char **cmdline_p) > > pr_err("No DTB found in kernel mappings\n"); > > #endif > > > > +#if IS_ENABLED(CONFIG_RISCV_SBI) > > Maybe > if (IS_ENABLED(CONFIG_RISCV_SBI)) > sbi_init() > ok. Will update. > > + sbi_init(); > > +#endif > > #ifdef CONFIG_SWIOTLB > > swiotlb_init(1); > > #endif > > @@ -97,10 +100,6 @@ void __init setup_arch(char **cmdline_p) > > kasan_init(); > > #endif > > > > -#if IS_ENABLED(CONFIG_RISCV_SBI) > > - sbi_init(); > > -#endif > > - > > #ifdef CONFIG_SMP > > setup_smp(); > > #endif > > -- > > 2.25.1 > > > > -- > Sincerely yours, > Mike. > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv -- Regards, Atish
WARNING: multiple messages have this Message-ID (diff)
From: Atish Patra <atishp@atishpatra.org> To: Mike Rapoport <rppt@kernel.org> Cc: Albert Ou <aou@eecs.berkeley.edu>, Kees Cook <keescook@chromium.org>, Anup Patel <anup@brainfault.org>, "linux-kernel@vger.kernel.org List" <linux-kernel@vger.kernel.org>, Ard Biesheuvel <ardb@kernel.org>, Atish Patra <atish.patra@wdc.com>, Palmer Dabbelt <palmer@dabbelt.com>, Zong Li <zong.li@sifive.com>, Paul Walmsley <paul.walmsley@sifive.com>, Greentime Hu <greentime.hu@sifive.com>, linux-riscv <linux-riscv@lists.infradead.org>, Borislav Petkov <bp@suse.de>, Michel Lespinasse <walken@google.com>, Andrew Morton <akpm@linux-foundation.org> Subject: Re: [PATCH v2 2/6] RISC-V: Initialize SBI early Date: Tue, 27 Oct 2020 11:38:35 -0700 [thread overview] Message-ID: <CAOnJCUJF8DTNpiGxL0Tz8CUk43CvfJS2w5fw=Y51afKgW22cTQ@mail.gmail.com> (raw) In-Reply-To: <20201027100427.GL1154158@kernel.org> On Tue, Oct 27, 2020 at 3:04 AM Mike Rapoport <rppt@kernel.org> wrote: > > On Mon, Oct 26, 2020 at 04:02:50PM -0700, Atish Patra wrote: > > Currently, SBI is initialized towards the end of arch setup. This prevents > > the set memory operations to be invoked earlier as it requires a full tlb > > flush. > > > > Initialize SBI as early as possible. > > > > Signed-off-by: Atish Patra <atish.patra@wdc.com> > > --- > > arch/riscv/kernel/setup.c | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c > > index c424cc6dd833..7d6a04ae3929 100644 > > --- a/arch/riscv/kernel/setup.c > > +++ b/arch/riscv/kernel/setup.c > > @@ -89,6 +89,9 @@ void __init setup_arch(char **cmdline_p) > > pr_err("No DTB found in kernel mappings\n"); > > #endif > > > > +#if IS_ENABLED(CONFIG_RISCV_SBI) > > Maybe > if (IS_ENABLED(CONFIG_RISCV_SBI)) > sbi_init() > ok. Will update. > > + sbi_init(); > > +#endif > > #ifdef CONFIG_SWIOTLB > > swiotlb_init(1); > > #endif > > @@ -97,10 +100,6 @@ void __init setup_arch(char **cmdline_p) > > kasan_init(); > > #endif > > > > -#if IS_ENABLED(CONFIG_RISCV_SBI) > > - sbi_init(); > > -#endif > > - > > #ifdef CONFIG_SMP > > setup_smp(); > > #endif > > -- > > 2.25.1 > > > > -- > Sincerely yours, > Mike. > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv -- Regards, Atish _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2020-10-27 18:38 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-26 23:02 [PATCH v2 0/6] Improve kernel section protections Atish Patra 2020-10-26 23:02 ` Atish Patra 2020-10-26 23:02 ` [PATCH v2 1/6] RISC-V: Move __start_kernel to .head.text Atish Patra 2020-10-26 23:02 ` Atish Patra 2020-10-26 23:02 ` [PATCH v2 2/6] RISC-V: Initialize SBI early Atish Patra 2020-10-26 23:02 ` Atish Patra 2020-10-27 10:04 ` Mike Rapoport 2020-10-27 10:04 ` Mike Rapoport 2020-10-27 18:38 ` Atish Patra [this message] 2020-10-27 18:38 ` Atish Patra 2020-10-26 23:02 ` [PATCH v2 3/6] RISC-V: Enforce protections for kernel sections early Atish Patra 2020-10-26 23:02 ` Atish Patra 2020-10-27 10:00 ` Mike Rapoport 2020-10-27 10:00 ` Mike Rapoport 2020-10-27 18:38 ` Atish Patra 2020-10-27 18:38 ` Atish Patra 2020-10-26 23:02 ` [PATCH v2 4/6] RISC-V: Align the .init.text section Atish Patra 2020-10-26 23:02 ` Atish Patra 2020-10-26 23:02 ` [PATCH v2 5/6] RISC-V: Protect .init.text & .init.data Atish Patra 2020-10-26 23:02 ` Atish Patra 2020-10-27 10:45 ` Mike Rapoport 2020-10-27 10:45 ` Mike Rapoport 2020-10-29 19:21 ` Atish Patra 2020-10-29 19:21 ` Atish Patra 2020-10-30 8:49 ` Mike Rapoport 2020-10-30 8:49 ` Mike Rapoport 2020-10-30 20:29 ` Atish Patra 2020-10-30 20:29 ` Atish Patra 2020-10-26 23:02 ` [PATCH v2 6/6] RISC-V: Move dynamic relocation section under __init Atish Patra 2020-10-26 23:02 ` Atish Patra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAOnJCUJF8DTNpiGxL0Tz8CUk43CvfJS2w5fw=Y51afKgW22cTQ@mail.gmail.com' \ --to=atishp@atishpatra.org \ --cc=akpm@linux-foundation.org \ --cc=anup@brainfault.org \ --cc=aou@eecs.berkeley.edu \ --cc=ardb@kernel.org \ --cc=atish.patra@wdc.com \ --cc=bp@suse.de \ --cc=greentime.hu@sifive.com \ --cc=keescook@chromium.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=rppt@kernel.org \ --cc=walken@google.com \ --cc=zong.li@sifive.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.