[PATCH] test-runner: Drop unused parameter

[PATCH] test-runner: Drop unused parameter

[Andrew Zaborowski]

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

---
 tools/test-runner | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/test-runner b/tools/test-runner
index 75e46444..f5ab7c58 100755
--- a/tools/test-runner
+++ b/tools/test-runner
@@ -164,7 +164,7 @@ class Process:
 		case.
 	'''
 	def __init__(self, args, wait=False, env=None, ctx=None, check=False,
-				outfile=None, namespace=None, need_out=False, cleanup=None):
+				outfile=None, namespace=None, cleanup=None):
 		self.killed = False
 		self.args = args
 		self.wait = wait
-- 
2.30.2

Re: [PATCH] test-runner: Drop unused parameter

[James Prestwood]

[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]

Hi Andrew,

On Sat, 2021-08-07 at 03:51 +0200, Andrew Zaborowski wrote:
> ---
>  tools/test-runner | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/test-runner b/tools/test-runner
> index 75e46444..f5ab7c58 100755
> --- a/tools/test-runner
> +++ b/tools/test-runner
> @@ -164,7 +164,7 @@ class Process:
>                 case.
>         '''
>         def __init__(self, args, wait=False, env=None, ctx=None,
> check=False,
> -                               outfile=None, namespace=None,
> need_out=False, cleanup=None):
> +                               outfile=None, namespace=None,
> cleanup=None):

This is fine, but we also need to remove the use in hostapd.py for
list_sta/send_bss_transition.

>                 self.killed = False
>                 self.args = args
>                 self.wait = wait

Thanks,
James

Re: [PATCH] test-runner: Drop unused parameter

[Andrew Zaborowski]

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

On Sat, 7 Aug 2021 at 04:46, James Prestwood <prestwoj@gmail.com> wrote:
> On Sat, 2021-08-07 at 03:51 +0200, Andrew Zaborowski wrote:
> > --- a/tools/test-runner
> > +++ b/tools/test-runner
> > @@ -164,7 +164,7 @@ class Process:
> >                 case.
> >         '''
> >         def __init__(self, args, wait=False, env=None, ctx=None,
> > check=False,
> > -                               outfile=None, namespace=None,
> > need_out=False, cleanup=None):
> > +                               outfile=None, namespace=None,
> > cleanup=None):
>
> This is fine, but we also need to remove the use in hostapd.py for
> list_sta/send_bss_transition.

Good point, looks like some tests will fail without that.  I'm also
fine dropping this patch.

Best regards

Re: [PATCH] test-runner: Drop unused parameter

[James Prestwood]

[-- Attachment #1: Type: text/plain, Size: 1267 bytes --]

On Mon, 2021-08-09 at 11:20 +0200, Andrew Zaborowski wrote:
> On Sat, 7 Aug 2021 at 04:46, James Prestwood <prestwoj@gmail.com>
> wrote:
> > On Sat, 2021-08-07 at 03:51 +0200, Andrew Zaborowski wrote:
> > > --- a/tools/test-runner
> > > +++ b/tools/test-runner
> > > @@ -164,7 +164,7 @@ class Process:
> > >                 case.
> > >         '''
> > >         def __init__(self, args, wait=False, env=None, ctx=None,
> > > check=False,
> > > -                               outfile=None, namespace=None,
> > > need_out=False, cleanup=None):
> > > +                               outfile=None, namespace=None,
> > > cleanup=None):
> > 
> > This is fine, but we also need to remove the use in hostapd.py for
> > list_sta/send_bss_transition.
> 
> Good point, looks like some tests will fail without that.  I'm also
> fine dropping this patch.

I think we should still remove it since Process.out is always populated
now. But another consideration is that I am touching just about every
autotest in existence as well as utility files so I can just tack this
onto my current patch set to avoid any rebase pain.

Thanks,
James

> 
> Best regards