* [Qemu-devel] "qemu -device ?" segfaults
@ 2012-02-23 8:20 Gerd Hoffmann
2012-02-23 8:23 ` Gerd Hoffmann
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Gerd Hoffmann @ 2012-02-23 8:20 UTC (permalink / raw)
To: qemu-devel
Hi,
$subject says all, which pretty much breaks libvirt-managed qemu ...
cheers,
Gerd
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] "qemu -device ?" segfaults
2012-02-23 8:20 [Qemu-devel] "qemu -device ?" segfaults Gerd Hoffmann
@ 2012-02-23 8:23 ` Gerd Hoffmann
2012-02-23 8:23 ` Peter Maydell
2012-02-23 8:25 ` andrzej zaborowski
2 siblings, 0 replies; 7+ messages in thread
From: Gerd Hoffmann @ 2012-02-23 8:23 UTC (permalink / raw)
To: qemu-devel
On 02/23/12 09:20, Gerd Hoffmann wrote:
> Hi,
>
> $subject says all, which pretty much breaks libvirt-managed qemu ...
Even just "qemu" segfaults, right here:
(gdb) bt
#0 qemu_opt_get (opts=0x0, name=0x7ffff7f7478f "kernel")
at /home/kraxel/projects/qemu/qemu-option.c:545
#1 0x00007ffff7deb1b0 in main (argc=<value optimized out>, argv=<value
optimized out>,
envp=<value optimized out>) at /home/kraxel/projects/qemu/vl.c:3250
cheers,
Gerd
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] "qemu -device ?" segfaults
2012-02-23 8:20 [Qemu-devel] "qemu -device ?" segfaults Gerd Hoffmann
2012-02-23 8:23 ` Gerd Hoffmann
@ 2012-02-23 8:23 ` Peter Maydell
2012-02-23 8:52 ` Gerd Hoffmann
2012-02-23 8:25 ` andrzej zaborowski
2 siblings, 1 reply; 7+ messages in thread
From: Peter Maydell @ 2012-02-23 8:23 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
On 23 February 2012 08:20, Gerd Hoffmann <kraxel@redhat.com> wrote:
> $subject says all, which pretty much breaks libvirt-managed qemu ...
Does http://patchwork.ozlabs.org/patch/142548/ fix this for you?
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] "qemu -device ?" segfaults
2012-02-23 8:20 [Qemu-devel] "qemu -device ?" segfaults Gerd Hoffmann
2012-02-23 8:23 ` Gerd Hoffmann
2012-02-23 8:23 ` Peter Maydell
@ 2012-02-23 8:25 ` andrzej zaborowski
2012-02-23 8:48 ` Markus Armbruster
2 siblings, 1 reply; 7+ messages in thread
From: andrzej zaborowski @ 2012-02-23 8:25 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
On 23 February 2012 09:20, Gerd Hoffmann <kraxel@redhat.com> wrote:
> $subject says all, which pretty much breaks libvirt-managed qemu ...
Also "device_add nonexistent-device" in the monitor gives a rather
unhelpful message:
Parameter 'driver' expects device type
Cheers
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] "qemu -device ?" segfaults
2012-02-23 8:25 ` andrzej zaborowski
@ 2012-02-23 8:48 ` Markus Armbruster
2012-02-23 8:57 ` andrzej zaborowski
0 siblings, 1 reply; 7+ messages in thread
From: Markus Armbruster @ 2012-02-23 8:48 UTC (permalink / raw)
To: andrzej zaborowski; +Cc: Gerd Hoffmann, qemu-devel
andrzej zaborowski <balrogg@gmail.com> writes:
> On 23 February 2012 09:20, Gerd Hoffmann <kraxel@redhat.com> wrote:
>> $subject says all, which pretty much breaks libvirt-managed qemu ...
>
> Also "device_add nonexistent-device" in the monitor gives a rather
> unhelpful message:
>
> Parameter 'driver' expects device type
"-device foo" is really shorthand for "-device driver=foo". And deep
down in the bowels of qdev, where the error get reported, the value of
parameter "driver" gets treated like any other parameter's value: if
it's not within ACCEPTABLE-SET, complain "Parameter 'NAME' expected
ACCEPTABLE-SET".
Overuse of syntactic sugar considered harmful.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] "qemu -device ?" segfaults
2012-02-23 8:23 ` Peter Maydell
@ 2012-02-23 8:52 ` Gerd Hoffmann
0 siblings, 0 replies; 7+ messages in thread
From: Gerd Hoffmann @ 2012-02-23 8:52 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel
On 02/23/12 09:23, Peter Maydell wrote:
> On 23 February 2012 08:20, Gerd Hoffmann <kraxel@redhat.com> wrote:
>> $subject says all, which pretty much breaks libvirt-managed qemu ...
>
> Does http://patchwork.ozlabs.org/patch/142548/ fix this for you?
Yes.
thanks,
Gerd
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] "qemu -device ?" segfaults
2012-02-23 8:48 ` Markus Armbruster
@ 2012-02-23 8:57 ` andrzej zaborowski
0 siblings, 0 replies; 7+ messages in thread
From: andrzej zaborowski @ 2012-02-23 8:57 UTC (permalink / raw)
To: Markus Armbruster; +Cc: Gerd Hoffmann, qemu-devel
On 23 February 2012 09:48, Markus Armbruster <armbru@redhat.com> wrote:
> andrzej zaborowski <balrogg@gmail.com> writes:
>
>> On 23 February 2012 09:20, Gerd Hoffmann <kraxel@redhat.com> wrote:
>>> $subject says all, which pretty much breaks libvirt-managed qemu ...
>>
>> Also "device_add nonexistent-device" in the monitor gives a rather
>> unhelpful message:
>>
>> Parameter 'driver' expects device type
>
> "-device foo" is really shorthand for "-device driver=foo". And deep
> down in the bowels of qdev, where the error get reported, the value of
> parameter "driver" gets treated like any other parameter's value: if
> it's not within ACCEPTABLE-SET, complain "Parameter 'NAME' expected
> ACCEPTABLE-SET".
Yeah, I looked at this code, perhaps "'INPUT' is not a valid
'ACCEPTABLE-SET'" would be more helpful. In my message I was talking
about the monitor command though. Something like "you typoed in the
device name" should be reported by the human readable monitor.
Cheers
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-02-23 8:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-23 8:20 [Qemu-devel] "qemu -device ?" segfaults Gerd Hoffmann
2012-02-23 8:23 ` Gerd Hoffmann
2012-02-23 8:23 ` Peter Maydell
2012-02-23 8:52 ` Gerd Hoffmann
2012-02-23 8:25 ` andrzej zaborowski
2012-02-23 8:48 ` Markus Armbruster
2012-02-23 8:57 ` andrzej zaborowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.