From: Andrew Zaborowski <andrew.zaborowski@intel.com>
To: iwd@lists.01.org
Subject: Re: [PATCH 3/3] station: Stop periodic scan when netdev connected
Date: Fri, 18 Jun 2021 19:27:31 +0200 [thread overview]
Message-ID: <CAOq732JQVgOxYw5+uEmj=G7gJ5G2pY+=FZEDEFoxRQLqjH7GUA@mail.gmail.com> (raw)
In-Reply-To: <fc43e0e1-eb99-97d1-e528-6955c72671a3@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 800 bytes --]
On Fri, 18 Jun 2021 at 19:21, Denis Kenzior <denkenz@gmail.com> wrote:
> On 6/18/21 11:16 AM, Andrew Zaborowski wrote:
> > On Fri, 18 Jun 2021 at 17:05, Denis Kenzior <denkenz@gmail.com> wrote:
> >> We should be calling periodic_scan_stop as soon as we
> >> transition to CONNECTING/CONNECTING_AUTO state.
> >
> > That's another option but I think the logic until now was that if the
> > connection failed we'd just return to periodic scanning without ever
> > stopping and restarting it. During the netdev CMD_CONNECT it would be
>
> I don't think so. See commit c3e160880f32f and commit da485179a6e92 prior to
> that. It looks like we have stopped periodic scan when entering CONNECTING
> state for quite some time.
True, I missed this. Please ignore this patch.
Best regards
next prev parent reply other threads:[~2021-06-18 17:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 7:33 [PATCH 1/3] station: Remove diagnostics interface reliably Andrew Zaborowski
2021-06-18 7:33 ` [PATCH 2/3] station: Check if busy in station_get_diagnostics Andrew Zaborowski
2021-06-18 15:00 ` Denis Kenzior
2021-06-18 7:33 ` [PATCH 3/3] station: Stop periodic scan when netdev connected Andrew Zaborowski
2021-06-18 15:05 ` Denis Kenzior
2021-06-18 16:16 ` Andrew Zaborowski
2021-06-18 17:21 ` Denis Kenzior
2021-06-18 17:27 ` Andrew Zaborowski [this message]
2021-06-18 15:07 ` [PATCH 1/3] station: Remove diagnostics interface reliably Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOq732JQVgOxYw5+uEmj=G7gJ5G2pY+=FZEDEFoxRQLqjH7GUA@mail.gmail.com' \
--to=andrew.zaborowski@intel.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.