All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.01.org
Subject: Re: [PATCH 3/3] station: Stop periodic scan when netdev connected
Date: Fri, 18 Jun 2021 12:21:16 -0500	[thread overview]
Message-ID: <fc43e0e1-eb99-97d1-e528-6955c72671a3@gmail.com> (raw)
In-Reply-To: <CAOq732+9jc8Mj4Gi+xrgJaVt4BHLx-LEwU9JcaDKg=efL6s0LQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1342 bytes --]

Hi Andrew,

On 6/18/21 11:16 AM, Andrew Zaborowski wrote:
> On Fri, 18 Jun 2021 at 17:05, Denis Kenzior <denkenz@gmail.com> wrote:
>> On 6/18/21 2:33 AM, Andrew Zaborowski wrote:
>>> For consistency call periodic_scan_stop() right after netdev signals
>>> connected even if station stays in the CONNECTING state because it's
>>> waiting for netconfig to finish.
>>
>> Hmm, why is this needed?  We should be calling periodic_scan_stop as soon as we
>> transition to CONNECTING/CONNECTING_AUTO state.
> 
> That's another option but I think the logic until now was that if the
> connection failed we'd just return to periodic scanning without ever
> stopping and restarting it.  During the netdev CMD_CONNECT it would be

I don't think so.  See commit c3e160880f32f and commit da485179a6e92 prior to 
that.  It looks like we have stopped periodic scan when entering CONNECTING 
state for quite some time.

> inhibited by the kernel or by the radio work.  We only needed to
> explicitly stop the scanning when CMD_CONNECT succeeded, so that's
> what I was trying to restore in this patch, otherwise if we were
> unlucky we might have been scanning during the netconfig.

Fair enough, but it doesn't look like your patch does that since we stop the 
periodic scan when we reach CONNECTING state today.

Regards,
-Denis

  reply	other threads:[~2021-06-18 17:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18  7:33 [PATCH 1/3] station: Remove diagnostics interface reliably Andrew Zaborowski
2021-06-18  7:33 ` [PATCH 2/3] station: Check if busy in station_get_diagnostics Andrew Zaborowski
2021-06-18 15:00   ` Denis Kenzior
2021-06-18  7:33 ` [PATCH 3/3] station: Stop periodic scan when netdev connected Andrew Zaborowski
2021-06-18 15:05   ` Denis Kenzior
2021-06-18 16:16     ` Andrew Zaborowski
2021-06-18 17:21       ` Denis Kenzior [this message]
2021-06-18 17:27         ` Andrew Zaborowski
2021-06-18 15:07 ` [PATCH 1/3] station: Remove diagnostics interface reliably Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc43e0e1-eb99-97d1-e528-6955c72671a3@gmail.com \
    --to=denkenz@gmail.com \
    --cc=iwd@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.