From: Andrew Zaborowski <andrew.zaborowski@intel.com>
To: ell@lists.01.org
Subject: Re: [PATCH 3/9] tls: Add TLS version number printf macros
Date: Fri, 14 Dec 2018 19:48:18 +0100 [thread overview]
Message-ID: <CAOq732JaQFAm7-t2DJV5F40o1QTN19tignU_hWRANMHi1nex-g@mail.gmail.com> (raw)
In-Reply-To: <ab96eccf-b6bf-dfd8-e8a2-545207d8aa19@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
Hi Denis,
On Fri, 14 Dec 2018 at 16:53, Denis Kenzior <denkenz@gmail.com> wrote:
> On 12/13/2018 01:57 PM, Andrew Zaborowski wrote:
> > ---
> > ell/tls-private.h | 3 +++
> > ell/tls.c | 17 +++++++++++------
> > 2 files changed, 14 insertions(+), 6 deletions(-)
> >
>
> ell/tls.c: In function ‘tls_cipher_suite_is_compatible’:
> ell/tls.c:540:34: error: ‘L_TLS_V12’ undeclared (first use in this
> function); did you mean ‘TLS_V12’?
> if (negotiated && negotiated < L_TLS_V12) {
> ^~~~~~~~~
> TLS_V12
> ell/tls.c:540:34: note: each undeclared identifier is reported only once
> for each function it appears in
>
> I know we allow breaking compilation if unavoidable, but I think here
> this can be easily avoided.
Ah indeed, I try to not break compilation if possible, will fix this patch.
Best regards
next prev parent reply other threads:[~2018-12-14 18:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 19:57 [PATCH 1/9] tls: Don't send Client Hello in l_tls_new Andrew Zaborowski
2018-12-13 19:57 ` [PATCH 2/9] unit: Call l_tls_start in tls tests Andrew Zaborowski
2018-12-13 19:57 ` [PATCH 3/9] tls: Add TLS version number printf macros Andrew Zaborowski
2018-12-14 15:53 ` Denis Kenzior
2018-12-14 18:48 ` Andrew Zaborowski [this message]
2018-12-13 19:57 ` [PATCH 4/9] tls: Implement l_tls_set_version_range Andrew Zaborowski
2018-12-14 15:55 ` Denis Kenzior
2018-12-13 19:57 ` [PATCH 5/9] unit: Test TLS 1.0, 1.1 and 1.2 Andrew Zaborowski
2018-12-13 19:57 ` [PATCH 6/9] unit: Move tls_cert_load_file to relevant unit tests Andrew Zaborowski
2018-12-14 16:01 ` Denis Kenzior
2018-12-13 19:57 ` [PATCH 7/9] tls, pem: Drop tls_cert_load_file, l_pem_load_certificate Andrew Zaborowski
2018-12-13 19:57 ` [PATCH 8/9] tls: Allow user to set custom list of cipher suites Andrew Zaborowski
2018-12-14 16:33 ` Denis Kenzior
2018-12-14 19:12 ` Andrew Zaborowski
2018-12-14 19:28 ` Denis Kenzior
2018-12-14 19:49 ` Andrew Zaborowski
2018-12-14 19:57 ` Denis Kenzior
2018-12-13 19:57 ` [PATCH 9/9] unit: Test many TLS cipher suite and version combinations Andrew Zaborowski
2018-12-19 0:57 [PATCH 1/9] tls: Don't send Client Hello in l_tls_new Andrew Zaborowski
2018-12-19 0:57 ` [PATCH 3/9] tls: Add TLS version number printf macros Andrew Zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOq732JaQFAm7-t2DJV5F40o1QTN19tignU_hWRANMHi1nex-g@mail.gmail.com \
--to=andrew.zaborowski@intel.com \
--cc=ell@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.