* [PATCH net-next] openvswitch: Make local function ovs_nsh_key_attr_size() static
@ 2017-11-14 6:27 Wei Yongjun
2017-11-14 10:57 ` [ovs-dev] " Pravin Shelar
2017-11-14 13:02 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2017-11-14 6:27 UTC (permalink / raw)
To: Pravin Shelar, Yi Yang
Cc: dev-yBygre7rU0TnMu66kgdUjQ, netdev-u79uwXL29TY76Z2rM5mHXA, Wei Yongjun
Fixes the following sparse warnings:
net/openvswitch/flow_netlink.c:340:8: warning:
symbol 'ovs_nsh_key_attr_size' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
---
net/openvswitch/flow_netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
index 4201f92..d79c364 100644
--- a/net/openvswitch/flow_netlink.c
+++ b/net/openvswitch/flow_netlink.c
@@ -337,7 +337,7 @@ size_t ovs_tun_key_attr_size(void)
+ nla_total_size(4); /* OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS */
}
-size_t ovs_nsh_key_attr_size(void)
+static size_t ovs_nsh_key_attr_size(void)
{
/* Whenever adding new OVS_NSH_KEY_ FIELDS, we should consider
* updating this function.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [ovs-dev] [PATCH net-next] openvswitch: Make local function ovs_nsh_key_attr_size() static
2017-11-14 6:27 [PATCH net-next] openvswitch: Make local function ovs_nsh_key_attr_size() static Wei Yongjun
@ 2017-11-14 10:57 ` Pravin Shelar
2017-11-14 13:02 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Pravin Shelar @ 2017-11-14 10:57 UTC (permalink / raw)
To: Wei Yongjun
Cc: Pravin Shelar, Yi Yang, ovs dev, Linux Kernel Network Developers
On Tue, Nov 14, 2017 at 11:57 AM, Wei Yongjun <weiyongjun1@huawei.com> wrote:
> Fixes the following sparse warnings:
>
> net/openvswitch/flow_netlink.c:340:8: warning:
> symbol 'ovs_nsh_key_attr_size' was not declared. Should it be static?
>
Acked-by: Pravin B Shelar <pshelar@ovn.org>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> net/openvswitch/flow_netlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
> index 4201f92..d79c364 100644
> --- a/net/openvswitch/flow_netlink.c
> +++ b/net/openvswitch/flow_netlink.c
> @@ -337,7 +337,7 @@ size_t ovs_tun_key_attr_size(void)
> + nla_total_size(4); /* OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS */
> }
>
> -size_t ovs_nsh_key_attr_size(void)
> +static size_t ovs_nsh_key_attr_size(void)
> {
> /* Whenever adding new OVS_NSH_KEY_ FIELDS, we should consider
> * updating this function.
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] openvswitch: Make local function ovs_nsh_key_attr_size() static
2017-11-14 6:27 [PATCH net-next] openvswitch: Make local function ovs_nsh_key_attr_size() static Wei Yongjun
2017-11-14 10:57 ` [ovs-dev] " Pravin Shelar
@ 2017-11-14 13:02 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-11-14 13:02 UTC (permalink / raw)
To: weiyongjun1; +Cc: pshelar, yi.y.yang, netdev, dev
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Tue, 14 Nov 2017 06:27:03 +0000
> Fixes the following sparse warnings:
>
> net/openvswitch/flow_netlink.c:340:8: warning:
> symbol 'ovs_nsh_key_attr_size' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-14 13:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-14 6:27 [PATCH net-next] openvswitch: Make local function ovs_nsh_key_attr_size() static Wei Yongjun
2017-11-14 10:57 ` [ovs-dev] " Pravin Shelar
2017-11-14 13:02 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.