From: Gilad Ben-Yossef <gilad@benyossef.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
David Miller <davem@davemloft.net>,
Ofir Drang <ofir.drang@arm.com>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] crypto: add output feedback mode
Date: Fri, 28 Sep 2018 18:27:13 +0300 [thread overview]
Message-ID: <CAOtvUMd68Bv7O8za5CLn7SGSgCDyR0fEE3MFU+5MfhfVBd2WHw@mail.gmail.com> (raw)
In-Reply-To: <CAKv+Gu9T7Z2oV8TEaN8uVdrFxGmmCKLh6ZjDnRnhgCmLwuVf4w@mail.gmail.com>
Hi,
On Fri, Sep 28, 2018 at 1:06 PM Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
>
> On 20 September 2018 at 15:18, Gilad Ben-Yossef <gilad@benyossef.com> wrote:
> > Add a generic version of output feedback mode. We already have support of
> > several hardware based transformations of this mode and the needed test
> > vectors but we somehow missed adding a generic software one. Fix this now.
> >
> > Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
>
> I couldn't find any users of OFB in the kernel. Any idea who is using
> it and for what?
Most probably nothing in-kernel, as there was no generic software
implementation up till now and no one complained. :-)
It is available via the user space crpto API *if* you happened to have
supporting hardware, which is a very odd situation.
The kernel has test vectors for OFB for DES, 3DES and AES. We have
multiple HW based implementation registering
and making available their support for this mode for some time now,
but not software implementation and probably no in kernel users.
Had we have no support for it in the kernel at, I wouldn't have
offered a generic software implementation, but since
we do and have for some time supported using this operation mode (but
only if you have supporting HW), it seems
we are in a strange limbo position and should go to either removing
all support or adding generic support - hence my patch.
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
values of β will give rise to dom!
next prev parent reply other threads:[~2018-09-28 15:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 13:18 [PATCH 0/3] crypto: OFB and tests Gilad Ben-Yossef
2018-09-20 13:18 ` [PATCH 1/3] crypto: testmgr: update sm4 test vectors Gilad Ben-Yossef
2018-09-20 13:18 ` [PATCH 2/3] crypto: add output feedback mode Gilad Ben-Yossef
2018-09-28 10:06 ` Ard Biesheuvel
2018-09-28 10:06 ` Ard Biesheuvel
2018-09-28 15:27 ` Gilad Ben-Yossef [this message]
2018-10-05 2:31 ` Herbert Xu
2018-10-05 2:31 ` Herbert Xu
2018-10-05 6:45 ` Ard Biesheuvel
2018-10-05 6:45 ` Ard Biesheuvel
2018-09-20 13:18 ` [PATCH 3/3] crypto: tcrypt: add OFB functional tests Gilad Ben-Yossef
2018-09-28 5:09 ` [PATCH 0/3] crypto: OFB and tests Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOtvUMd68Bv7O8za5CLn7SGSgCDyR0fEE3MFU+5MfhfVBd2WHw@mail.gmail.com \
--to=gilad@benyossef.com \
--cc=ard.biesheuvel@linaro.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ofir.drang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.