All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Gilad Ben-Yossef <gilad@benyossef.com>,
	"David S. Miller" <davem@davemloft.net>,
	ofir.drang@arm.com,
	"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
	<linux-crypto@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] crypto: add output feedback mode
Date: Fri, 5 Oct 2018 08:45:35 +0200	[thread overview]
Message-ID: <CAKv+Gu_a1n2fWXn0U+ApXoRGDRLieOkbMo_ROq51gZc1sBxYXQ@mail.gmail.com> (raw)
In-Reply-To: <20181005023138.dg22cn4salb3p6zl@gondor.apana.org.au>

On 5 October 2018 at 04:31, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Fri, Sep 28, 2018 at 12:06:29PM +0200, Ard Biesheuvel wrote:
>> On 20 September 2018 at 15:18, Gilad Ben-Yossef <gilad@benyossef.com> wrote:
>> > Add a generic version of output feedback mode. We already have support of
>> > several hardware based transformations of this mode and the needed test
>> > vectors but we somehow missed adding a generic software one. Fix this now.
>> >
>> > Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
>>
>> I couldn't find any users of OFB in the kernel. Any idea who is using
>> it and for what?
>
> Yes this shouldn't have been accepted however the driver did go
> in with OFB and it's been there for a while so that's why I'm
> making this exception.
>

Fair enough

  reply	other threads:[~2018-10-05  6:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20 13:18 [PATCH 0/3] crypto: OFB and tests Gilad Ben-Yossef
2018-09-20 13:18 ` [PATCH 1/3] crypto: testmgr: update sm4 test vectors Gilad Ben-Yossef
2018-09-20 13:18 ` [PATCH 2/3] crypto: add output feedback mode Gilad Ben-Yossef
2018-09-28 10:06   ` Ard Biesheuvel
2018-09-28 10:06     ` Ard Biesheuvel
2018-09-28 15:27     ` Gilad Ben-Yossef
2018-10-05  2:31     ` Herbert Xu
2018-10-05  2:31       ` Herbert Xu
2018-10-05  6:45       ` Ard Biesheuvel [this message]
2018-10-05  6:45         ` Ard Biesheuvel
2018-09-20 13:18 ` [PATCH 3/3] crypto: tcrypt: add OFB functional tests Gilad Ben-Yossef
2018-09-28  5:09 ` [PATCH 0/3] crypto: OFB and tests Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu_a1n2fWXn0U+ApXoRGDRLieOkbMo_ROq51gZc1sBxYXQ@mail.gmail.com \
    --to=ard.biesheuvel@linaro.org \
    --cc=davem@davemloft.net \
    --cc=gilad@benyossef.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ofir.drang@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.