* [PATCH resend] staging: sm750fb: lower case to fix camelcase checkpatch warning
@ 2019-03-25 17:59 Jules Irenge
2019-03-25 19:27 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Jules Irenge @ 2019-03-25 17:59 UTC (permalink / raw)
To: gregkh; +Cc: sudipm.mukherjee, outreachy-kernel, jules.octave
Lower case to fix CamelCase checkpatch.pl warning
"CHECK: Avoid CamelCase: <ulActualMxClk>".
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/staging/sm750fb/ddk750_chip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 6bdf643707c2..3fe4479401e5 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -56,7 +56,7 @@ static unsigned int get_mxclk_freq(void)
static void set_chip_clock(unsigned int frequency)
{
struct pll_value pll;
- unsigned int ulActualMxClk;
+ unsigned int ul_actual_mx_clk;
/* Cheok_0509: For SM750LE, the chip clock is fixed. Nothing to set. */
if (sm750_get_chip_type() == SM750LE)
@@ -76,7 +76,7 @@ static void set_chip_clock(unsigned int frequency)
* Return value of sm750_calc_pll_value gives the actual
* possible clock.
*/
- ulActualMxClk = sm750_calc_pll_value(frequency, &pll);
+ ul_actual_mx_clk = sm750_calc_pll_value(frequency, &pll);
/* Master Clock Control: MXCLK_PLL */
poke32(MXCLK_PLL_CTRL, sm750_format_pll_reg(&pll));
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH resend] staging: sm750fb: lower case to fix camelcase checkpatch warning
2019-03-25 17:59 [PATCH resend] staging: sm750fb: lower case to fix camelcase checkpatch warning Jules Irenge
@ 2019-03-25 19:27 ` Greg KH
2019-03-25 20:48 ` Jules Octave
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2019-03-25 19:27 UTC (permalink / raw)
To: Jules Irenge; +Cc: sudipm.mukherjee, outreachy-kernel, jules.octave
On Mon, Mar 25, 2019 at 05:59:07PM +0000, Jules Irenge wrote:
> Lower case to fix CamelCase checkpatch.pl warning
> "CHECK: Avoid CamelCase: <ulActualMxClk>".
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_chip.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 6bdf643707c2..3fe4479401e5 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -56,7 +56,7 @@ static unsigned int get_mxclk_freq(void)
> static void set_chip_clock(unsigned int frequency)
> {
> struct pll_value pll;
> - unsigned int ulActualMxClk;
> + unsigned int ul_actual_mx_clk;
There is no need for the "ul" right?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH resend] staging: sm750fb: lower case to fix camelcase checkpatch warning
2019-03-25 19:27 ` Greg KH
@ 2019-03-25 20:48 ` Jules Octave
0 siblings, 0 replies; 3+ messages in thread
From: Jules Octave @ 2019-03-25 20:48 UTC (permalink / raw)
To: Greg KH; +Cc: Sudip Mukherjee, outreachy-kernel, jules.octave
[-- Attachment #1: Type: text/plain, Size: 996 bytes --]
On Mon, 25 Mar 2019 at 20:12, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Mar 25, 2019 at 05:59:07PM +0000, Jules Irenge wrote:
> > Lower case to fix CamelCase checkpatch.pl warning
> > "CHECK: Avoid CamelCase: <ulActualMxClk>".
> >
> > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> > ---
> > drivers/staging/sm750fb/ddk750_chip.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/sm750fb/ddk750_chip.c
> b/drivers/staging/sm750fb/ddk750_chip.c
> > index 6bdf643707c2..3fe4479401e5 100644
> > --- a/drivers/staging/sm750fb/ddk750_chip.c
> > +++ b/drivers/staging/sm750fb/ddk750_chip.c
> > @@ -56,7 +56,7 @@ static unsigned int get_mxclk_freq(void)
> > static void set_chip_clock(unsigned int frequency)
> > {
> > struct pll_value pll;
> > - unsigned int ulActualMxClk;
> > + unsigned int ul_actual_mx_clk;
> >There is no need for the "ul" right?
>
Yes, there is no need. I am removing it now and resend.
Thanks
[-- Attachment #2: Type: text/html, Size: 1648 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-25 20:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-25 17:59 [PATCH resend] staging: sm750fb: lower case to fix camelcase checkpatch warning Jules Irenge
2019-03-25 19:27 ` Greg KH
2019-03-25 20:48 ` Jules Octave
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.