bug while cloning http repo

bug while cloning http repo

[andrey a]

Thank you for filling out a Git bug report!
Please answer the following questions to help us understand your issue.

What did you do before the bug happened? (Steps to reproduce your issue)

git clone http://git.altlinux.org/gears/r/rust.git


What did you expect to happen? (Expected behavior)

Normal cloned repo appears.

What happened instead? (Actual behavior)

git clone http://git.altlinux.org/gears/r/rust.git
Cloning into 'rust'...
error: Unable to get pack file
http://git.altlinux.org/gears/r/rust.git/objects/pack/pack-42e36950f8cd6e0d242719691491d16dd2e270e6.pack
transfer closed with 7043414950 bytes remaining to read
error: Unable to find 7f4c666c73ca05cecab9089c91d8c6dfff5a7cb7 under
http://git.altlinux.org/gears/r/rust.git
Cannot obtain needed object 7f4c666c73ca05cecab9089c91d8c6dfff5a7cb7
error: fetch failed.

Note that hash of broken object is always same.
What's different between what you expected and what actually happened?

Looks like versions before 2.33.4 works fine. And after 2.33.5 (and
2.34.1 2.35.1) reproduce bug.

Anything else you want to add:

Reproducible on Ubuntu 22(2.34.1), Altlinux p10(2.33.5), Gentoo(2.35.1)
Bug reproducible with latest git version 2.38.1.385.g3b08839926/

Please review the rest of the bug report below.
You can delete any lines you don't wish to share.


[System Info]
git version:
git version 2.34.1
cpu: x86_64
no commit associated with this build
sizeof-long: 8
sizeof-size_t: 8
shell-path: /bin/sh
uname: Linux 5.15.0-52-generic #58-Ubuntu SMP Thu Oct 13 08:03:55 UTC
2022 x86_64
compiler info: gnuc: 11.2
libc info: glibc: 2.35
$SHELL (typically, interactive shell): /bin/bash

$ GIT_TRACE2=2 git clone http://git.altlinux.org/gears/r/rust.git
17:28:03.618164 common-main.c:48                  version 2.34.1
17:28:03.618728 common-main.c:49                  start git clone
http://git.altlinux.org/gears/r/rust.git
17:28:03.618840 compat/linux/procinfo.c:170       cmd_ancestry bash <-
konsole <- gnome-shell <- systemd <- systemd
17:28:03.619295 git.c:456                         cmd_name clone (clone)
17:28:03.620976 repository.c:132                  worktree /home/krom/soft/rust
Cloning into 'rust'...
17:28:03.629163 run-command.c:740                 child_start[0] git
remote-http origin http://git.altlinux.org/gears/r/rust.git
17:28:03.641629 common-main.c:48                  version 2.34.1
17:28:03.642043 common-main.c:49                  start
/usr/lib/git-core/git remote-http origin
http://git.altlinux.org/gears/r/rust.git
17:28:03.642169 compat/linux/procinfo.c:170       cmd_ancestry git <-
bash <- konsole <- gnome-shell <- systemd <- systemd
17:28:03.642678 git.c:736                         cmd_name
_run_dashed_ (clone/_run_dashed_)
17:28:03.643132 run-command.c:740                 child_start[0]
git-remote-http origin http://git.altlinux.org/gears/r/rust.git
17:28:03.649348 common-main.c:48                  version 2.34.1
17:28:03.649841 common-main.c:49                  start
/usr/lib/git-core/git-remote-http origin
http://git.altlinux.org/gears/r/rust.git
17:28:03.649975 compat/linux/procinfo.c:170       cmd_ancestry git <-
git <- bash <- konsole <- gnome-shell <- systemd <- systemd
17:28:03.650025 repository.c:132                  worktree /home/krom/soft
17:28:03.650044 remote-curl.c:1493                cmd_name remote-curl
(clone/_run_dashed_/remote-curl)
remote: 09912a27cf9a7028344e23986c14fd03341600af        refs/heads/c7
remote: 09912a27cf9a7028344e23986c14fd03341600af        refs/heads/c7.1

...

remote: d8a6a190551618fae1b205c3210fad9f5955877e        refs/tags/1.58.0-alt1^{}
remote: a3658ef7fb155cfa1f877abf6e59fb95acebc5f9        refs/tags/1.58.1
remote: b2f00be3d04a8f1eeb605957ceaa7e9325f892fe        refs/tags/1.58.1^{}
remote: 12bd79da893d981a2588d6b414da48cc2950fd3b        refs/tags/1.58.1-alt1
remote: e0905262166aff9e8a6c245294dba39f4cc0
17:32:29.224262 usage.c:65                        error unable to
access 'http://git.altlinux.org/gears/r/rust.git/': Recv failure:
Connection reset by peer
fatal: unable to access 'http://git.altlinux.org/gears/r/rust.git/':
Recv failure: Connection reset by peer
17:32:29.224313 usage.c:69                        exit
elapsed:265.575951 code:128
17:32:29.224331 trace2/tr2_tgt_normal.c:123       atexit
elapsed:265.575982 code:128
17:32:29.225644 run-command.c:996                 child_exit[0]
pid:190489 code:128 elapsed:265.582499
17:32:29.225698 git.c:758                         exit
elapsed:265.591604 code:128
17:32:29.225733 trace2/tr2_tgt_normal.c:123       atexit
elapsed:265.591639 code:128
17:32:29.226442 transport-helper.c:581            exit
elapsed:265.971163 code:128
17:32:29.228597 trace2/tr2_tgt_normal.c:123       atexit
elapsed:265.973323 code:128


[Enabled Hooks]
not run from a git repository - no hooks to show

Hope this report can help. Feel free to ask additional questions or
contact me directly.
Andrey Yakunin

Re: bug while cloning http repo

[Taylor Blau]

On Mon, Nov 07, 2022 at 07:58:03PM +0300, andrey a wrote:
> Thank you for filling out a Git bug report!
> Please answer the following questions to help us understand your issue.
>
> What did you do before the bug happened? (Steps to reproduce your issue)
>
> git clone http://git.altlinux.org/gears/r/rust.git
>
>
> What did you expect to happen? (Expected behavior)
>
> Normal cloned repo appears.
>
> What happened instead? (Actual behavior)
>
> git clone http://git.altlinux.org/gears/r/rust.git
> Cloning into 'rust'...
> error: Unable to get pack file
> http://git.altlinux.org/gears/r/rust.git/objects/pack/pack-42e36950f8cd6e0d242719691491d16dd2e270e6.pack
> transfer closed with 7043414950 bytes remaining to read

It looks like something (e.g., firewall, anti-virus software) between
your workstation and git.altlinux.org is terminating the connection
earlier than it should be.

So your client is only getting part of the pack that it asked for, and
some of the objects appear missing.

> Looks like versions before 2.33.4 works fine. And after 2.33.5 (and
> 2.34.1 2.35.1) reproduce bug.

If there is a bisection which conclusively points to a single commit,
that would be interesting to know. That might not necessarily indicate a
bug in Git, but instead a behavior change which tickles whatever
mechanism is sitting on either side of the connection.

Thanks,
Taylor