Re: [PATCH v2 2/5] drm/radeon: squash lines for simple wrapper functions

From: Sean Paul <seanpaul@google.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: David Airlie <airlied@linux.ie>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"Christian K?nig" <christian.koenig@amd.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Alexander Deucher <Alexander.Deucher@amd.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: Re: [PATCH v2 2/5] drm/radeon: squash lines for simple wrapper functions
Date: Thu, 15 Sep 2016 10:45:08 -0400	[thread overview]
Message-ID: <CAOw6vb+ZOB33nDZ1orKkndy_hu-cV2TvB_V_shR3D_1p21wnnQ@mail.gmail.com> (raw)
In-Reply-To: <1473863952-7658-3-git-send-email-yamada.masahiro@socionext.com>

On Wed, Sep 14, 2016 at 10:39 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> Remove unneeded variables and assignments.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Applied to drm-misc

Sean

> ---
>
>  drivers/gpu/drm/radeon/cik.c  | 6 +-----
>  drivers/gpu/drm/radeon/r100.c | 6 +-----
>  drivers/gpu/drm/radeon/r600.c | 6 +-----
>  3 files changed, 3 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c
> index b1784a1..f6ff41a 100644
> --- a/drivers/gpu/drm/radeon/cik.c
> +++ b/drivers/gpu/drm/radeon/cik.c
> @@ -4193,11 +4193,7 @@ u32 cik_gfx_get_rptr(struct radeon_device *rdev,
>  u32 cik_gfx_get_wptr(struct radeon_device *rdev,
>                      struct radeon_ring *ring)
>  {
> -       u32 wptr;
> -
> -       wptr = RREG32(CP_RB0_WPTR);
> -
> -       return wptr;
> +       return RREG32(CP_RB0_WPTR);
>  }
>
>  void cik_gfx_set_wptr(struct radeon_device *rdev,
> diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c
> index f25994b..f5e84f4 100644
> --- a/drivers/gpu/drm/radeon/r100.c
> +++ b/drivers/gpu/drm/radeon/r100.c
> @@ -1071,11 +1071,7 @@ u32 r100_gfx_get_rptr(struct radeon_device *rdev,
>  u32 r100_gfx_get_wptr(struct radeon_device *rdev,
>                       struct radeon_ring *ring)
>  {
> -       u32 wptr;
> -
> -       wptr = RREG32(RADEON_CP_RB_WPTR);
> -
> -       return wptr;
> +       return RREG32(RADEON_CP_RB_WPTR);
>  }
>
>  void r100_gfx_set_wptr(struct radeon_device *rdev,
> diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c
> index 6406536..a951881 100644
> --- a/drivers/gpu/drm/radeon/r600.c
> +++ b/drivers/gpu/drm/radeon/r600.c
> @@ -2631,11 +2631,7 @@ u32 r600_gfx_get_rptr(struct radeon_device *rdev,
>  u32 r600_gfx_get_wptr(struct radeon_device *rdev,
>                       struct radeon_ring *ring)
>  {
> -       u32 wptr;
> -
> -       wptr = RREG32(R600_CP_RB_WPTR);
> -
> -       return wptr;
> +       return RREG32(R600_CP_RB_WPTR);
>  }
>
>  void r600_gfx_set_wptr(struct radeon_device *rdev,
> --
> 1.9.1
>