All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Paul <seanpaul@chromium.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Archit <architt@codeaurora.org>
Cc: David Airlie <airlied@linux.ie>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"Christian K?nig" <christian.koenig@amd.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Alexander Deucher <Alexander.Deucher@amd.com>,
	Heiko Stuebner <heiko@sntech.de>, Yakir Yang <ykk@rock-chips.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Tomasz Figa <tfiga@chromium.org>,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: Re: [PATCH v2 3/5] drm/bridge: squash lines for simple wrapper functions
Date: Thu, 15 Sep 2016 10:46:35 -0400	[thread overview]
Message-ID: <CAOw6vbKOW_d7vC4wzyhpnXkbcEz_QiHnM5s4h5tYm7D457x8nQ@mail.gmail.com> (raw)
In-Reply-To: <CAOw6vb+3vcnSWAg4hi1GebSytExB5OoHRXUHvdv03ZvHrGFdgQ@mail.gmail.com>

On Thu, Sep 15, 2016 at 9:51 AM, Sean Paul <seanpaul@chromium.org> wrote:
> On Wed, Sep 14, 2016 at 10:39 AM, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>> Remove unneeded variables and assignments.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Reviewed-by: Sean Paul <seanpaul@chromium.org>
>

Decided to apply patches 1-4 to drm-misc

Thanks,

Sean

>> ---
>>
>>  drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 20 ++++----------------
>>  1 file changed, 4 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
>> index 52c1b6b..fae0293 100644
>> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
>> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
>> @@ -1073,34 +1073,22 @@ void analogix_dp_set_lane3_link_training(struct analogix_dp_device *dp,
>>
>>  u32 analogix_dp_get_lane0_link_training(struct analogix_dp_device *dp)
>>  {
>> -       u32 reg;
>> -
>> -       reg = readl(dp->reg_base + ANALOGIX_DP_LN0_LINK_TRAINING_CTL);
>> -       return reg;
>> +       return readl(dp->reg_base + ANALOGIX_DP_LN0_LINK_TRAINING_CTL);
>>  }
>>
>>  u32 analogix_dp_get_lane1_link_training(struct analogix_dp_device *dp)
>>  {
>> -       u32 reg;
>> -
>> -       reg = readl(dp->reg_base + ANALOGIX_DP_LN1_LINK_TRAINING_CTL);
>> -       return reg;
>> +       return readl(dp->reg_base + ANALOGIX_DP_LN1_LINK_TRAINING_CTL);
>>  }
>>
>>  u32 analogix_dp_get_lane2_link_training(struct analogix_dp_device *dp)
>>  {
>> -       u32 reg;
>> -
>> -       reg = readl(dp->reg_base + ANALOGIX_DP_LN2_LINK_TRAINING_CTL);
>> -       return reg;
>> +       return readl(dp->reg_base + ANALOGIX_DP_LN2_LINK_TRAINING_CTL);
>>  }
>>
>>  u32 analogix_dp_get_lane3_link_training(struct analogix_dp_device *dp)
>>  {
>> -       u32 reg;
>> -
>> -       reg = readl(dp->reg_base + ANALOGIX_DP_LN3_LINK_TRAINING_CTL);
>> -       return reg;
>> +       return readl(dp->reg_base + ANALOGIX_DP_LN3_LINK_TRAINING_CTL);
>>  }
>>
>>  void analogix_dp_reset_macro(struct analogix_dp_device *dp)
>> --
>> 1.9.1
>>

WARNING: multiple messages have this Message-ID (diff)
From: Sean Paul <seanpaul@chromium.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Archit <architt@codeaurora.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Tomasz Figa <tfiga@chromium.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Alexander Deucher <Alexander.Deucher@amd.com>,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
	Christian K?nig <christian.koenig@amd.com>
Subject: Re: [PATCH v2 3/5] drm/bridge: squash lines for simple wrapper functions
Date: Thu, 15 Sep 2016 10:46:35 -0400	[thread overview]
Message-ID: <CAOw6vbKOW_d7vC4wzyhpnXkbcEz_QiHnM5s4h5tYm7D457x8nQ@mail.gmail.com> (raw)
In-Reply-To: <CAOw6vb+3vcnSWAg4hi1GebSytExB5OoHRXUHvdv03ZvHrGFdgQ@mail.gmail.com>

On Thu, Sep 15, 2016 at 9:51 AM, Sean Paul <seanpaul@chromium.org> wrote:
> On Wed, Sep 14, 2016 at 10:39 AM, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>> Remove unneeded variables and assignments.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Reviewed-by: Sean Paul <seanpaul@chromium.org>
>

Decided to apply patches 1-4 to drm-misc

Thanks,

Sean

>> ---
>>
>>  drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 20 ++++----------------
>>  1 file changed, 4 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
>> index 52c1b6b..fae0293 100644
>> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
>> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
>> @@ -1073,34 +1073,22 @@ void analogix_dp_set_lane3_link_training(struct analogix_dp_device *dp,
>>
>>  u32 analogix_dp_get_lane0_link_training(struct analogix_dp_device *dp)
>>  {
>> -       u32 reg;
>> -
>> -       reg = readl(dp->reg_base + ANALOGIX_DP_LN0_LINK_TRAINING_CTL);
>> -       return reg;
>> +       return readl(dp->reg_base + ANALOGIX_DP_LN0_LINK_TRAINING_CTL);
>>  }
>>
>>  u32 analogix_dp_get_lane1_link_training(struct analogix_dp_device *dp)
>>  {
>> -       u32 reg;
>> -
>> -       reg = readl(dp->reg_base + ANALOGIX_DP_LN1_LINK_TRAINING_CTL);
>> -       return reg;
>> +       return readl(dp->reg_base + ANALOGIX_DP_LN1_LINK_TRAINING_CTL);
>>  }
>>
>>  u32 analogix_dp_get_lane2_link_training(struct analogix_dp_device *dp)
>>  {
>> -       u32 reg;
>> -
>> -       reg = readl(dp->reg_base + ANALOGIX_DP_LN2_LINK_TRAINING_CTL);
>> -       return reg;
>> +       return readl(dp->reg_base + ANALOGIX_DP_LN2_LINK_TRAINING_CTL);
>>  }
>>
>>  u32 analogix_dp_get_lane3_link_training(struct analogix_dp_device *dp)
>>  {
>> -       u32 reg;
>> -
>> -       reg = readl(dp->reg_base + ANALOGIX_DP_LN3_LINK_TRAINING_CTL);
>> -       return reg;
>> +       return readl(dp->reg_base + ANALOGIX_DP_LN3_LINK_TRAINING_CTL);
>>  }
>>
>>  void analogix_dp_reset_macro(struct analogix_dp_device *dp)
>> --
>> 1.9.1
>>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-09-15 14:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-14 14:39 [PATCH v2 0/5] drm: clean up several wrapper functions Masahiro Yamada
2016-09-14 14:39 ` Masahiro Yamada
2016-09-14 14:39 ` [PATCH v2 1/5] drm/amdgpu: squash lines for simple " Masahiro Yamada
2016-09-15 14:45   ` Sean Paul
2016-09-14 14:39 ` [PATCH v2 2/5] drm/radeon: " Masahiro Yamada
2016-09-15 14:45   ` Sean Paul
2016-09-14 14:39 ` [PATCH v2 3/5] drm/bridge: " Masahiro Yamada
2016-09-15 13:51   ` Sean Paul
2016-09-15 13:51     ` Sean Paul
2016-09-15 14:46     ` Sean Paul [this message]
2016-09-15 14:46       ` Sean Paul
2016-09-16  1:41       ` Masahiro Yamada
2016-09-14 14:39 ` [PATCH v2 4/5] drm/qxl: " Masahiro Yamada
2016-09-15 12:30   ` Gustavo Padovan
2016-09-15 13:47   ` Gustavo Padovan
2016-09-15 13:47     ` Gustavo Padovan
2016-09-15 14:45     ` Sean Paul
2016-09-15 14:45       ` Sean Paul
2016-09-14 14:39 ` [PATCH v2 5/5] drm/i915: use i915_gem_open() directly instead of i915_driver_open() Masahiro Yamada
2016-09-14 14:39   ` Masahiro Yamada
2016-09-15  9:46   ` Jani Nikula
2016-09-15  9:46     ` Jani Nikula
2016-09-15  9:48     ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOw6vbKOW_d7vC4wzyhpnXkbcEz_QiHnM5s4h5tYm7D457x8nQ@mail.gmail.com \
    --to=seanpaul@chromium.org \
    --cc=Alexander.Deucher@amd.com \
    --cc=airlied@linux.ie \
    --cc=architt@codeaurora.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=heiko@sntech.de \
    --cc=jani.nikula@linux.intel.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tfiga@chromium.org \
    --cc=yamada.masahiro@socionext.com \
    --cc=ykk@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.