All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fs/block_dev: remove vfs_msg() interface
@ 2017-10-11 12:08 Rakesh Pandit
  2017-10-11 19:41 ` Ross Zwisler
  0 siblings, 1 reply; 5+ messages in thread
From: Rakesh Pandit @ 2017-10-11 12:08 UTC (permalink / raw)
  To: linux-fsdevel, linux-kernel
  Cc: Alexander Viro, Jens Axboe, Bart Van Assche, Martin K. Petersen,
	Hannes Reinecke, Omar Sandoval, Dan Williams, Ming Lei,
	Damien Le Moal

Replaced by pr_err usage in commit ef51042472f5 ("block, dax: move
"select DAX" from BLOCK to FS_DAX")

Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
---
 fs/block_dev.c         | 12 ------------
 include/linux/blkdev.h | 11 -----------
 2 files changed, 23 deletions(-)

diff --git a/fs/block_dev.c b/fs/block_dev.c
index 93d088f..07ddccd 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -54,18 +54,6 @@ struct block_device *I_BDEV(struct inode *inode)
 }
 EXPORT_SYMBOL(I_BDEV);
 
-void __vfs_msg(struct super_block *sb, const char *prefix, const char *fmt, ...)
-{
-	struct va_format vaf;
-	va_list args;
-
-	va_start(args, fmt);
-	vaf.fmt = fmt;
-	vaf.va = &args;
-	printk_ratelimited("%sVFS (%s): %pV\n", prefix, sb->s_id, &vaf);
-	va_end(args);
-}
-
 static void bdev_write_inode(struct block_device *bdev)
 {
 	struct inode *inode = bdev->bd_inode;
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 9fb71fc..7263702 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -917,17 +917,6 @@ static inline void rq_flush_dcache_pages(struct request *rq)
 }
 #endif
 
-#ifdef CONFIG_PRINTK
-#define vfs_msg(sb, level, fmt, ...)				\
-	__vfs_msg(sb, level, fmt, ##__VA_ARGS__)
-#else
-#define vfs_msg(sb, level, fmt, ...)				\
-do {								\
-	no_printk(fmt, ##__VA_ARGS__);				\
-	__vfs_msg(sb, "", " ");					\
-} while (0)
-#endif
-
 extern int blk_register_queue(struct gendisk *disk);
 extern void blk_unregister_queue(struct gendisk *disk);
 extern blk_qc_t generic_make_request(struct bio *bio);
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] fs/block_dev: remove vfs_msg() interface
  2017-10-11 12:08 [PATCH] fs/block_dev: remove vfs_msg() interface Rakesh Pandit
@ 2017-10-11 19:41 ` Ross Zwisler
  0 siblings, 0 replies; 5+ messages in thread
From: Ross Zwisler @ 2017-10-11 19:41 UTC (permalink / raw)
  To: Rakesh Pandit
  Cc: linux-fsdevel, LKML, Alexander Viro, Jens Axboe, Bart Van Assche,
	Martin K. Petersen, Hannes Reinecke, Omar Sandoval, Dan Williams,
	Ming Lei, Damien Le Moal

On Wed, Oct 11, 2017 at 6:08 AM, Rakesh Pandit <rakesh@tuxera.com> wrote:
> Replaced by pr_err usage in commit ef51042472f5 ("block, dax: move
> "select DAX" from BLOCK to FS_DAX")
>
> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>

Acked-by: Ross Zwisler <ross.zwisler@linux.intel.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] fs/block_dev: remove vfs_msg() interface
  2017-10-12 18:11 ` Dan Williams
@ 2017-10-12 18:31   ` Jens Axboe
  0 siblings, 0 replies; 5+ messages in thread
From: Jens Axboe @ 2017-10-12 18:31 UTC (permalink / raw)
  To: Dan Williams, Rakesh Pandit
  Cc: Alexander Viro, Bart Van Assche, Martin K. Petersen,
	Hannes Reinecke, Omar Sandoval, Ming Lei, Damien Le Moal,
	Ross Zwisler, linux-fsdevel, LKML

On 10/12/2017 12:11 PM, Dan Williams wrote:
> On Thu, Oct 12, 2017 at 9:58 AM, Rakesh Pandit <rakesh@tuxera.com> wrote:
>> Replaced by pr_err usage in commit ef51042472f5 ("block, dax: move
>> "select DAX" from BLOCK to FS_DAX")
>>
>> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
>> Acked-by: Ross Zwisler <ross.zwisler@linux.intel.com>
>> ---
>>
>> Al, May you consider queuing this for v4.15 ? Thank you.
> 
> Should go through Jens, but if it lingers a few more days I'll grab it.

I've picked it up.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] fs/block_dev: remove vfs_msg() interface
  2017-10-12 16:58 Rakesh Pandit
@ 2017-10-12 18:11 ` Dan Williams
  2017-10-12 18:31   ` Jens Axboe
  0 siblings, 1 reply; 5+ messages in thread
From: Dan Williams @ 2017-10-12 18:11 UTC (permalink / raw)
  To: Rakesh Pandit
  Cc: Alexander Viro, Jens Axboe, Bart Van Assche, Martin K. Petersen,
	Hannes Reinecke, Omar Sandoval, Ming Lei, Damien Le Moal,
	Ross Zwisler, linux-fsdevel, LKML

On Thu, Oct 12, 2017 at 9:58 AM, Rakesh Pandit <rakesh@tuxera.com> wrote:
> Replaced by pr_err usage in commit ef51042472f5 ("block, dax: move
> "select DAX" from BLOCK to FS_DAX")
>
> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
> Acked-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> ---
>
> Al, May you consider queuing this for v4.15 ? Thank you.

Should go through Jens, but if it lingers a few more days I'll grab it.

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] fs/block_dev: remove vfs_msg() interface
@ 2017-10-12 16:58 Rakesh Pandit
  2017-10-12 18:11 ` Dan Williams
  0 siblings, 1 reply; 5+ messages in thread
From: Rakesh Pandit @ 2017-10-12 16:58 UTC (permalink / raw)
  To: Alexander Viro
  Cc: Jens Axboe, Bart Van Assche, Martin K. Petersen, Hannes Reinecke,
	Omar Sandoval, Dan Williams, Ming Lei, Damien Le Moal,
	Ross Zwisler, linux-fsdevel, LKML

Replaced by pr_err usage in commit ef51042472f5 ("block, dax: move
"select DAX" from BLOCK to FS_DAX")

Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
Acked-by: Ross Zwisler <ross.zwisler@linux.intel.com>
---

Al, May you consider queuing this for v4.15 ? Thank you.

 fs/block_dev.c         | 12 ------------
 include/linux/blkdev.h | 11 -----------
 2 files changed, 23 deletions(-)

diff --git a/fs/block_dev.c b/fs/block_dev.c
index 93d088f..07ddccd 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -54,18 +54,6 @@ struct block_device *I_BDEV(struct inode *inode)
 }
 EXPORT_SYMBOL(I_BDEV);
 
-void __vfs_msg(struct super_block *sb, const char *prefix, const char *fmt, ...)
-{
-	struct va_format vaf;
-	va_list args;
-
-	va_start(args, fmt);
-	vaf.fmt = fmt;
-	vaf.va = &args;
-	printk_ratelimited("%sVFS (%s): %pV\n", prefix, sb->s_id, &vaf);
-	va_end(args);
-}
-
 static void bdev_write_inode(struct block_device *bdev)
 {
 	struct inode *inode = bdev->bd_inode;
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 02fa42d..a373246 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -922,17 +922,6 @@ static inline void rq_flush_dcache_pages(struct request *rq)
 }
 #endif
 
-#ifdef CONFIG_PRINTK
-#define vfs_msg(sb, level, fmt, ...)				\
-	__vfs_msg(sb, level, fmt, ##__VA_ARGS__)
-#else
-#define vfs_msg(sb, level, fmt, ...)				\
-do {								\
-	no_printk(fmt, ##__VA_ARGS__);				\
-	__vfs_msg(sb, "", " ");					\
-} while (0)
-#endif
-
 extern int blk_register_queue(struct gendisk *disk);
 extern void blk_unregister_queue(struct gendisk *disk);
 extern blk_qc_t generic_make_request(struct bio *bio);
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-12 18:31 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-11 12:08 [PATCH] fs/block_dev: remove vfs_msg() interface Rakesh Pandit
2017-10-11 19:41 ` Ross Zwisler
2017-10-12 16:58 Rakesh Pandit
2017-10-12 18:11 ` Dan Williams
2017-10-12 18:31   ` Jens Axboe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.