All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH RESEND] amd/display: convert DRM_DEBUG_ATOMIC to drm_dbg_atomic
@ 2021-05-26 13:55 Simon Ser
  2021-05-26 14:00 ` Bas Nieuwenhuizen
  0 siblings, 1 reply; 3+ messages in thread
From: Simon Ser @ 2021-05-26 13:55 UTC (permalink / raw)
  To: amd-gfx; +Cc: Alex Deucher, Harry Wentland, Nicholas Kazlauskas

This allows to tie the log message to a specific DRM device.

Signed-off-by: Simon Ser <contact@emersion.fr>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Harry Wentland <hwentlan@amd.com>
Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 2c9d099adfc2..4dd811816cba 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -10089,7 +10089,7 @@ static int dm_check_crtc_cursor(struct drm_atomic_state *state,
 
 	if (cursor_scale_w != primary_scale_w ||
 	    cursor_scale_h != primary_scale_h) {
-		DRM_DEBUG_ATOMIC("Cursor plane scaling doesn't match primary plane\n");
+		drm_dbg_atomic(crtc->dev, "Cursor plane scaling doesn't match primary plane\n");
 		return -EINVAL;
 	}
 
-- 
2.31.1


_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] amd/display: convert DRM_DEBUG_ATOMIC to drm_dbg_atomic
  2021-05-26 13:55 [PATCH RESEND] amd/display: convert DRM_DEBUG_ATOMIC to drm_dbg_atomic Simon Ser
@ 2021-05-26 14:00 ` Bas Nieuwenhuizen
  2021-06-02  1:43   ` Alex Deucher
  0 siblings, 1 reply; 3+ messages in thread
From: Bas Nieuwenhuizen @ 2021-05-26 14:00 UTC (permalink / raw)
  To: Simon Ser
  Cc: Alex Deucher, Harry Wentland, Nicholas Kazlauskas, amd-gfx mailing list

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>

I think there are plenty more occurrences too or did I miss the
cleanup of those?

On Wed, May 26, 2021 at 3:56 PM Simon Ser <contact@emersion.fr> wrote:
>
> This allows to tie the log message to a specific DRM device.
>
> Signed-off-by: Simon Ser <contact@emersion.fr>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Harry Wentland <hwentlan@amd.com>
> Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 2c9d099adfc2..4dd811816cba 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -10089,7 +10089,7 @@ static int dm_check_crtc_cursor(struct drm_atomic_state *state,
>
>         if (cursor_scale_w != primary_scale_w ||
>             cursor_scale_h != primary_scale_h) {
> -               DRM_DEBUG_ATOMIC("Cursor plane scaling doesn't match primary plane\n");
> +               drm_dbg_atomic(crtc->dev, "Cursor plane scaling doesn't match primary plane\n");
>                 return -EINVAL;
>         }
>
> --
> 2.31.1
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] amd/display: convert DRM_DEBUG_ATOMIC to drm_dbg_atomic
  2021-05-26 14:00 ` Bas Nieuwenhuizen
@ 2021-06-02  1:43   ` Alex Deucher
  0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2021-06-02  1:43 UTC (permalink / raw)
  To: Bas Nieuwenhuizen
  Cc: Alex Deucher, Simon Ser, Harry Wentland, Nicholas Kazlauskas,
	amd-gfx mailing list

Applied.  Thanks!

Alex

On Wed, May 26, 2021 at 10:00 AM Bas Nieuwenhuizen
<bas@basnieuwenhuizen.nl> wrote:
>
> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
>
> I think there are plenty more occurrences too or did I miss the
> cleanup of those?
>
> On Wed, May 26, 2021 at 3:56 PM Simon Ser <contact@emersion.fr> wrote:
> >
> > This allows to tie the log message to a specific DRM device.
> >
> > Signed-off-by: Simon Ser <contact@emersion.fr>
> > Cc: Alex Deucher <alexander.deucher@amd.com>
> > Cc: Harry Wentland <hwentlan@amd.com>
> > Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> > ---
> >  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > index 2c9d099adfc2..4dd811816cba 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > @@ -10089,7 +10089,7 @@ static int dm_check_crtc_cursor(struct drm_atomic_state *state,
> >
> >         if (cursor_scale_w != primary_scale_w ||
> >             cursor_scale_h != primary_scale_h) {
> > -               DRM_DEBUG_ATOMIC("Cursor plane scaling doesn't match primary plane\n");
> > +               drm_dbg_atomic(crtc->dev, "Cursor plane scaling doesn't match primary plane\n");
> >                 return -EINVAL;
> >         }
> >
> > --
> > 2.31.1
> >
> >
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-02  1:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-26 13:55 [PATCH RESEND] amd/display: convert DRM_DEBUG_ATOMIC to drm_dbg_atomic Simon Ser
2021-05-26 14:00 ` Bas Nieuwenhuizen
2021-06-02  1:43   ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.