[PATCH userspace] libsepol/cil: remove obsolete comment

[PATCH userspace] libsepol/cil: remove obsolete comment

[Ondrej Mosnacek]

Commit a60343cabfc2 ("libsepol/cil: remove unnecessary hash tables")
removed FILENAME_TRANS_TABLE_SIZE macro that this comment was referring
to. Remove the comment as well to avoid confusion.

Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
---
 libsepol/cil/src/cil_binary.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libsepol/cil/src/cil_binary.c b/libsepol/cil/src/cil_binary.c
index 41105c12..2b65c622 100644
--- a/libsepol/cil/src/cil_binary.c
+++ b/libsepol/cil/src/cil_binary.c
@@ -55,9 +55,6 @@
 #include "cil_find.h"
 #include "cil_build_ast.h"
 
-/* There are 44000 filename_trans in current fedora policy. 1.33 times this is the recommended
- * size of a hashtable. The next power of 2 of this is 2 ** 16.
- */
 #define ROLE_TRANS_TABLE_SIZE (1 << 10)
 #define AVRULEX_TABLE_SIZE (1 <<  10)
 #define PERMS_PER_CLASS 32
-- 
2.31.1

Re: [PATCH userspace] libsepol/cil: remove obsolete comment

[James Carter]

On Thu, Aug 5, 2021 at 5:16 AM Ondrej Mosnacek <omosnace@redhat.com> wrote:
>
> Commit a60343cabfc2 ("libsepol/cil: remove unnecessary hash tables")
> removed FILENAME_TRANS_TABLE_SIZE macro that this comment was referring
> to. Remove the comment as well to avoid confusion.
>
> Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>

Acked-by: James Carter <jwcart2@gmail.com>

> ---
>  libsepol/cil/src/cil_binary.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/libsepol/cil/src/cil_binary.c b/libsepol/cil/src/cil_binary.c
> index 41105c12..2b65c622 100644
> --- a/libsepol/cil/src/cil_binary.c
> +++ b/libsepol/cil/src/cil_binary.c
> @@ -55,9 +55,6 @@
>  #include "cil_find.h"
>  #include "cil_build_ast.h"
>
> -/* There are 44000 filename_trans in current fedora policy. 1.33 times this is the recommended
> - * size of a hashtable. The next power of 2 of this is 2 ** 16.
> - */
>  #define ROLE_TRANS_TABLE_SIZE (1 << 10)
>  #define AVRULEX_TABLE_SIZE (1 <<  10)
>  #define PERMS_PER_CLASS 32
> --
> 2.31.1
>

Re: [PATCH userspace] libsepol/cil: remove obsolete comment

[James Carter]

On Thu, Aug 5, 2021 at 10:01 AM James Carter <jwcart2@gmail.com> wrote:
>
> On Thu, Aug 5, 2021 at 5:16 AM Ondrej Mosnacek <omosnace@redhat.com> wrote:
> >
> > Commit a60343cabfc2 ("libsepol/cil: remove unnecessary hash tables")
> > removed FILENAME_TRANS_TABLE_SIZE macro that this comment was referring
> > to. Remove the comment as well to avoid confusion.
> >
> > Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
>
> Acked-by: James Carter <jwcart2@gmail.com>
>
Merged.
Thanks,
Jim

> > ---
> >  libsepol/cil/src/cil_binary.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/libsepol/cil/src/cil_binary.c b/libsepol/cil/src/cil_binary.c
> > index 41105c12..2b65c622 100644
> > --- a/libsepol/cil/src/cil_binary.c
> > +++ b/libsepol/cil/src/cil_binary.c
> > @@ -55,9 +55,6 @@
> >  #include "cil_find.h"
> >  #include "cil_build_ast.h"
> >
> > -/* There are 44000 filename_trans in current fedora policy. 1.33 times this is the recommended
> > - * size of a hashtable. The next power of 2 of this is 2 ** 16.
> > - */
> >  #define ROLE_TRANS_TABLE_SIZE (1 << 10)
> >  #define AVRULEX_TABLE_SIZE (1 <<  10)
> >  #define PERMS_PER_CLASS 32
> > --
> > 2.31.1
> >