* [PATCH] perf: fix typos of "its" and "reponse"
@ 2021-12-26 2:52 Randy Dunlap
2021-12-26 12:42 ` JSON typos " Arnaldo Carvalho de Melo
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Randy Dunlap @ 2021-12-26 2:52 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Mark Rutland, Alexander Shishkin,
Jiri Olsa, Namhyung Kim, linux-perf-users
Use the possessive "its" instead of the contraction of "it is" ("it's")
where needed in user-viewable messages.
Correct typos of "reponse" to "response" (reported by checkpatch).
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: linux-perf-users@vger.kernel.org
---
tools/perf/pmu-events/arch/x86/broadwell/uncore.json | 6 +++---
tools/perf/pmu-events/arch/x86/cascadelakex/uncore-other.json | 4 ++--
tools/perf/pmu-events/arch/x86/haswell/uncore.json | 6 +++---
tools/perf/pmu-events/arch/x86/skylakex/uncore-other.json | 4 ++--
4 files changed, 10 insertions(+), 10 deletions(-)
--- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/broadwell/uncore.json
+++ linux-next-20211224/tools/perf/pmu-events/arch/x86/broadwell/uncore.json
@@ -184,8 +184,8 @@
"EventCode": "0x80",
"UMask": "0x01",
"EventName": "UNC_ARB_TRK_OCCUPANCY.ALL",
- "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
- "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
+ "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
+ "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
"Counter": "0,",
"CounterMask": "0",
"Invert": "0",
@@ -275,4 +275,4 @@
"Invert": "0",
"EdgeDetect": "0"
}
-]
\ No newline at end of file
+]
--- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/cascadelakex/uncore-other.json
+++ linux-next-20211224/tools/perf/pmu-events/arch/x86/cascadelakex/uncore-other.json
@@ -514,7 +514,7 @@
"EventCode": "0x5C",
"EventName": "UNC_CHA_SNOOP_RESP.RSP_FWD_WB",
"PerPkg": "1",
- "PublicDescription": "Counts when a transaction with the opcode type Rsp*Fwd*WB Snoop Response was received which indicates the data was written back to it's home socket, and the cacheline was forwarded to the requestor socket. This snoop response is only used in >= 4 socket systems. It is used when a snoop HITM's in a remote caching agent and it directly forwards data to a requestor, and simultaneously returns data to it's home socket to be written back to memory.",
+ "PublicDescription": "Counts when a transaction with the opcode type Rsp*Fwd*WB Snoop Response was received which indicates the data was written back to its home socket, and the cacheline was forwarded to the requestor socket. This snoop response is only used in >= 4 socket systems. It is used when a snoop HITM's in a remote caching agent and it directly forwards data to a requestor, and simultaneously returns data to its home socket to be written back to memory.",
"UMask": "0x20",
"Unit": "CHA"
},
@@ -524,7 +524,7 @@
"EventCode": "0x5C",
"EventName": "UNC_CHA_SNOOP_RESP.RSP_WBWB",
"PerPkg": "1",
- "PublicDescription": "Counts when a transaction with the opcode type Rsp*WB Snoop Response was received which indicates which indicates the data was written back to it's home. This is returned when a non-RFO request hits a cacheline in the Modified state. The Cache can either downgrade the cacheline to a S (Shared) or I (Invalid) state depending on how the system has been configured. This reponse will also be sent when a cache requests E (Exclusive) ownership of a cache line without receiving data, because the cache must acquire ownership.",
+ "PublicDescription": "Counts when a transaction with the opcode type Rsp*WB Snoop Response was received which indicates which indicates the data was written back to its home. This is returned when a non-RFO request hits a cacheline in the Modified state. The Cache can either downgrade the cacheline to a S (Shared) or I (Invalid) state depending on how the system has been configured. This response will also be sent when a cache requests E (Exclusive) ownership of a cache line without receiving data, because the cache must acquire ownership.",
"UMask": "0x10",
"Unit": "CHA"
},
--- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/haswell/uncore.json
+++ linux-next-20211224/tools/perf/pmu-events/arch/x86/haswell/uncore.json
@@ -304,8 +304,8 @@
"EventCode": "0x80",
"UMask": "0x01",
"EventName": "UNC_ARB_TRK_OCCUPANCY.ALL",
- "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
- "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
+ "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
+ "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
"Counter": "0",
"CounterMask": "0",
"Invert": "0",
@@ -371,4 +371,4 @@
"Invert": "0",
"EdgeDetect": "0"
}
-]
\ No newline at end of file
+]
--- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/skylakex/uncore-other.json
+++ linux-next-20211224/tools/perf/pmu-events/arch/x86/skylakex/uncore-other.json
@@ -514,7 +514,7 @@
"EventCode": "0x5C",
"EventName": "UNC_CHA_SNOOP_RESP.RSP_FWD_WB",
"PerPkg": "1",
- "PublicDescription": "Counts when a transaction with the opcode type Rsp*Fwd*WB Snoop Response was received which indicates the data was written back to it's home socket, and the cacheline was forwarded to the requestor socket. This snoop response is only used in >= 4 socket systems. It is used when a snoop HITM's in a remote caching agent and it directly forwards data to a requestor, and simultaneously returns data to it's home socket to be written back to memory.",
+ "PublicDescription": "Counts when a transaction with the opcode type Rsp*Fwd*WB Snoop Response was received which indicates the data was written back to its home socket, and the cacheline was forwarded to the requestor socket. This snoop response is only used in >= 4 socket systems. It is used when a snoop HITM's in a remote caching agent and it directly forwards data to a requestor, and simultaneously returns data to its home socket to be written back to memory.",
"UMask": "0x20",
"Unit": "CHA"
},
@@ -524,7 +524,7 @@
"EventCode": "0x5C",
"EventName": "UNC_CHA_SNOOP_RESP.RSP_WBWB",
"PerPkg": "1",
- "PublicDescription": "Counts when a transaction with the opcode type Rsp*WB Snoop Response was received which indicates which indicates the data was written back to it's home. This is returned when a non-RFO request hits a cacheline in the Modified state. The Cache can either downgrade the cacheline to a S (Shared) or I (Invalid) state depending on how the system has been configured. This reponse will also be sent when a cache requests E (Exclusive) ownership of a cache line without receiving data, because the cache must acquire ownership.",
+ "PublicDescription": "Counts when a transaction with the opcode type Rsp*WB Snoop Response was received which indicates which indicates the data was written back to its home. This is returned when a non-RFO request hits a cacheline in the Modified state. The Cache can either downgrade the cacheline to a S (Shared) or I (Invalid) state depending on how the system has been configured. This response will also be sent when a cache requests E (Exclusive) ownership of a cache line without receiving data, because the cache must acquire ownership.",
"UMask": "0x10",
"Unit": "CHA"
},
^ permalink raw reply [flat|nested] 5+ messages in thread
* JSON typos Re: [PATCH] perf: fix typos of "its" and "reponse"
2021-12-26 2:52 [PATCH] perf: fix typos of "its" and "reponse" Randy Dunlap
@ 2021-12-26 12:42 ` Arnaldo Carvalho de Melo
2021-12-26 19:12 ` Andi Kleen
2022-01-02 22:50 ` Paul A. Clarke
2022-01-03 1:01 ` Ian Rogers
2 siblings, 1 reply; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-12-26 12:42 UTC (permalink / raw)
To: Randy Dunlap, Andi Kleen
Cc: linux-kernel, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Namhyung Kim, linux-perf-users
Em Sat, Dec 25, 2021 at 06:52:15PM -0800, Randy Dunlap escreveu:
> Use the possessive "its" instead of the contraction of "it is" ("it's")
> where needed in user-viewable messages.
>
> Correct typos of "reponse" to "response" (reported by checkpatch).
These files are made from other files, Andi?
- Arnaldo
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: linux-perf-users@vger.kernel.org
> ---
> tools/perf/pmu-events/arch/x86/broadwell/uncore.json | 6 +++---
> tools/perf/pmu-events/arch/x86/cascadelakex/uncore-other.json | 4 ++--
> tools/perf/pmu-events/arch/x86/haswell/uncore.json | 6 +++---
> tools/perf/pmu-events/arch/x86/skylakex/uncore-other.json | 4 ++--
> 4 files changed, 10 insertions(+), 10 deletions(-)
>
> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/broadwell/uncore.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/broadwell/uncore.json
> @@ -184,8 +184,8 @@
> "EventCode": "0x80",
> "UMask": "0x01",
> "EventName": "UNC_ARB_TRK_OCCUPANCY.ALL",
> - "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> - "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> + "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> + "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> "Counter": "0,",
> "CounterMask": "0",
> "Invert": "0",
> @@ -275,4 +275,4 @@
> "Invert": "0",
> "EdgeDetect": "0"
> }
> -]
> \ No newline at end of file
> +]
> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/cascadelakex/uncore-other.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/cascadelakex/uncore-other.json
> @@ -514,7 +514,7 @@
> "EventCode": "0x5C",
> "EventName": "UNC_CHA_SNOOP_RESP.RSP_FWD_WB",
> "PerPkg": "1",
> - "PublicDescription": "Counts when a transaction with the opcode type Rsp*Fwd*WB Snoop Response was received which indicates the data was written back to it's home socket, and the cacheline was forwarded to the requestor socket. This snoop response is only used in >= 4 socket systems. It is used when a snoop HITM's in a remote caching agent and it directly forwards data to a requestor, and simultaneously returns data to it's home socket to be written back to memory.",
> + "PublicDescription": "Counts when a transaction with the opcode type Rsp*Fwd*WB Snoop Response was received which indicates the data was written back to its home socket, and the cacheline was forwarded to the requestor socket. This snoop response is only used in >= 4 socket systems. It is used when a snoop HITM's in a remote caching agent and it directly forwards data to a requestor, and simultaneously returns data to its home socket to be written back to memory.",
> "UMask": "0x20",
> "Unit": "CHA"
> },
> @@ -524,7 +524,7 @@
> "EventCode": "0x5C",
> "EventName": "UNC_CHA_SNOOP_RESP.RSP_WBWB",
> "PerPkg": "1",
> - "PublicDescription": "Counts when a transaction with the opcode type Rsp*WB Snoop Response was received which indicates which indicates the data was written back to it's home. This is returned when a non-RFO request hits a cacheline in the Modified state. The Cache can either downgrade the cacheline to a S (Shared) or I (Invalid) state depending on how the system has been configured. This reponse will also be sent when a cache requests E (Exclusive) ownership of a cache line without receiving data, because the cache must acquire ownership.",
> + "PublicDescription": "Counts when a transaction with the opcode type Rsp*WB Snoop Response was received which indicates which indicates the data was written back to its home. This is returned when a non-RFO request hits a cacheline in the Modified state. The Cache can either downgrade the cacheline to a S (Shared) or I (Invalid) state depending on how the system has been configured. This response will also be sent when a cache requests E (Exclusive) ownership of a cache line without receiving data, because the cache must acquire ownership.",
> "UMask": "0x10",
> "Unit": "CHA"
> },
> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/haswell/uncore.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/haswell/uncore.json
> @@ -304,8 +304,8 @@
> "EventCode": "0x80",
> "UMask": "0x01",
> "EventName": "UNC_ARB_TRK_OCCUPANCY.ALL",
> - "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> - "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> + "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> + "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> "Counter": "0",
> "CounterMask": "0",
> "Invert": "0",
> @@ -371,4 +371,4 @@
> "Invert": "0",
> "EdgeDetect": "0"
> }
> -]
> \ No newline at end of file
> +]
> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/skylakex/uncore-other.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/skylakex/uncore-other.json
> @@ -514,7 +514,7 @@
> "EventCode": "0x5C",
> "EventName": "UNC_CHA_SNOOP_RESP.RSP_FWD_WB",
> "PerPkg": "1",
> - "PublicDescription": "Counts when a transaction with the opcode type Rsp*Fwd*WB Snoop Response was received which indicates the data was written back to it's home socket, and the cacheline was forwarded to the requestor socket. This snoop response is only used in >= 4 socket systems. It is used when a snoop HITM's in a remote caching agent and it directly forwards data to a requestor, and simultaneously returns data to it's home socket to be written back to memory.",
> + "PublicDescription": "Counts when a transaction with the opcode type Rsp*Fwd*WB Snoop Response was received which indicates the data was written back to its home socket, and the cacheline was forwarded to the requestor socket. This snoop response is only used in >= 4 socket systems. It is used when a snoop HITM's in a remote caching agent and it directly forwards data to a requestor, and simultaneously returns data to its home socket to be written back to memory.",
> "UMask": "0x20",
> "Unit": "CHA"
> },
> @@ -524,7 +524,7 @@
> "EventCode": "0x5C",
> "EventName": "UNC_CHA_SNOOP_RESP.RSP_WBWB",
> "PerPkg": "1",
> - "PublicDescription": "Counts when a transaction with the opcode type Rsp*WB Snoop Response was received which indicates which indicates the data was written back to it's home. This is returned when a non-RFO request hits a cacheline in the Modified state. The Cache can either downgrade the cacheline to a S (Shared) or I (Invalid) state depending on how the system has been configured. This reponse will also be sent when a cache requests E (Exclusive) ownership of a cache line without receiving data, because the cache must acquire ownership.",
> + "PublicDescription": "Counts when a transaction with the opcode type Rsp*WB Snoop Response was received which indicates which indicates the data was written back to its home. This is returned when a non-RFO request hits a cacheline in the Modified state. The Cache can either downgrade the cacheline to a S (Shared) or I (Invalid) state depending on how the system has been configured. This response will also be sent when a cache requests E (Exclusive) ownership of a cache line without receiving data, because the cache must acquire ownership.",
> "UMask": "0x10",
> "Unit": "CHA"
> },
--
- Arnaldo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: JSON typos Re: [PATCH] perf: fix typos of "its" and "reponse"
2021-12-26 12:42 ` JSON typos " Arnaldo Carvalho de Melo
@ 2021-12-26 19:12 ` Andi Kleen
0 siblings, 0 replies; 5+ messages in thread
From: Andi Kleen @ 2021-12-26 19:12 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Randy Dunlap, Andi Kleen, linux-kernel, Peter Zijlstra,
Ingo Molnar, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Namhyung Kim, linux-perf-users, zhengjun.xing
On Sun, Dec 26, 2021 at 09:42:37AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sat, Dec 25, 2021 at 06:52:15PM -0800, Randy Dunlap escreveu:
> > Use the possessive "its" instead of the contraction of "it is" ("it's")
> > where needed in user-viewable messages.
> >
> > Correct typos of "reponse" to "response" (reported by checkpatch).
>
> These files are made from other files, Andi?
I forwarded the patches. Thanks.
BTW for Intel event list related questions please always copy Zhengjun
-Andi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] perf: fix typos of "its" and "reponse"
2021-12-26 2:52 [PATCH] perf: fix typos of "its" and "reponse" Randy Dunlap
2021-12-26 12:42 ` JSON typos " Arnaldo Carvalho de Melo
@ 2022-01-02 22:50 ` Paul A. Clarke
2022-01-03 1:01 ` Ian Rogers
2 siblings, 0 replies; 5+ messages in thread
From: Paul A. Clarke @ 2022-01-02 22:50 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Mark Rutland, Alexander Shishkin,
Jiri Olsa, Namhyung Kim, linux-perf-users
On Sat, Dec 25, 2021 at 06:52:15PM -0800, Randy Dunlap wrote:
> Use the possessive "its" instead of the contraction of "it is" ("it's")
> where needed in user-viewable messages.
> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/broadwell/uncore.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/broadwell/uncore.json
> @@ -184,8 +184,8 @@
> "EventCode": "0x80",
> "UMask": "0x01",
> "EventName": "UNC_ARB_TRK_OCCUPANCY.ALL",
> - "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> - "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> + "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> + "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
You should probably s/till/until/, since you're already modifying those lines.
Is there a reason that "Coherent" is capitalized here?
> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/haswell/uncore.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/haswell/uncore.json
> @@ -304,8 +304,8 @@
> "EventCode": "0x80",
> "UMask": "0x01",
> "EventName": "UNC_ARB_TRK_OCCUPANCY.ALL",
> - "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> - "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> + "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> + "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
same
PC
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] perf: fix typos of "its" and "reponse"
2021-12-26 2:52 [PATCH] perf: fix typos of "its" and "reponse" Randy Dunlap
2021-12-26 12:42 ` JSON typos " Arnaldo Carvalho de Melo
2022-01-02 22:50 ` Paul A. Clarke
@ 2022-01-03 1:01 ` Ian Rogers
2 siblings, 0 replies; 5+ messages in thread
From: Ian Rogers @ 2022-01-03 1:01 UTC (permalink / raw)
To: Randy Dunlap, Andi Kleen, zhengjun.xing
Cc: linux-kernel, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Mark Rutland, Alexander Shishkin,
Jiri Olsa, Namhyung Kim, linux-perf-users
On Sat, Dec 25, 2021 at 6:52 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Use the possessive "its" instead of the contraction of "it is" ("it's")
> where needed in user-viewable messages.
>
> Correct typos of "reponse" to "response" (reported by checkpatch).
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: linux-perf-users@vger.kernel.org
Making this information better is valuable! The data is autogenerated
by these scripts:
https://github.com/intel/event-converter-for-linux-perf
From data here:
https://download.01.org/perfmon/
In a way the files that are in the tree are temporary build files.
Perhaps we can have the original source and scripts within the Linux
tools tree to simplify fixes like these.
Thanks,
Ian
> ---
> tools/perf/pmu-events/arch/x86/broadwell/uncore.json | 6 +++---
> tools/perf/pmu-events/arch/x86/cascadelakex/uncore-other.json | 4 ++--
> tools/perf/pmu-events/arch/x86/haswell/uncore.json | 6 +++---
> tools/perf/pmu-events/arch/x86/skylakex/uncore-other.json | 4 ++--
> 4 files changed, 10 insertions(+), 10 deletions(-)
>
> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/broadwell/uncore.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/broadwell/uncore.json
> @@ -184,8 +184,8 @@
> "EventCode": "0x80",
> "UMask": "0x01",
> "EventName": "UNC_ARB_TRK_OCCUPANCY.ALL",
> - "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> - "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> + "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> + "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> "Counter": "0,",
> "CounterMask": "0",
> "Invert": "0",
> @@ -275,4 +275,4 @@
> "Invert": "0",
> "EdgeDetect": "0"
> }
> -]
> \ No newline at end of file
> +]
> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/cascadelakex/uncore-other.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/cascadelakex/uncore-other.json
> @@ -514,7 +514,7 @@
> "EventCode": "0x5C",
> "EventName": "UNC_CHA_SNOOP_RESP.RSP_FWD_WB",
> "PerPkg": "1",
> - "PublicDescription": "Counts when a transaction with the opcode type Rsp*Fwd*WB Snoop Response was received which indicates the data was written back to it's home socket, and the cacheline was forwarded to the requestor socket. This snoop response is only used in >= 4 socket systems. It is used when a snoop HITM's in a remote caching agent and it directly forwards data to a requestor, and simultaneously returns data to it's home socket to be written back to memory.",
> + "PublicDescription": "Counts when a transaction with the opcode type Rsp*Fwd*WB Snoop Response was received which indicates the data was written back to its home socket, and the cacheline was forwarded to the requestor socket. This snoop response is only used in >= 4 socket systems. It is used when a snoop HITM's in a remote caching agent and it directly forwards data to a requestor, and simultaneously returns data to its home socket to be written back to memory.",
> "UMask": "0x20",
> "Unit": "CHA"
> },
> @@ -524,7 +524,7 @@
> "EventCode": "0x5C",
> "EventName": "UNC_CHA_SNOOP_RESP.RSP_WBWB",
> "PerPkg": "1",
> - "PublicDescription": "Counts when a transaction with the opcode type Rsp*WB Snoop Response was received which indicates which indicates the data was written back to it's home. This is returned when a non-RFO request hits a cacheline in the Modified state. The Cache can either downgrade the cacheline to a S (Shared) or I (Invalid) state depending on how the system has been configured. This reponse will also be sent when a cache requests E (Exclusive) ownership of a cache line without receiving data, because the cache must acquire ownership.",
> + "PublicDescription": "Counts when a transaction with the opcode type Rsp*WB Snoop Response was received which indicates which indicates the data was written back to its home. This is returned when a non-RFO request hits a cacheline in the Modified state. The Cache can either downgrade the cacheline to a S (Shared) or I (Invalid) state depending on how the system has been configured. This response will also be sent when a cache requests E (Exclusive) ownership of a cache line without receiving data, because the cache must acquire ownership.",
> "UMask": "0x10",
> "Unit": "CHA"
> },
> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/haswell/uncore.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/haswell/uncore.json
> @@ -304,8 +304,8 @@
> "EventCode": "0x80",
> "UMask": "0x01",
> "EventName": "UNC_ARB_TRK_OCCUPANCY.ALL",
> - "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> - "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> + "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> + "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> "Counter": "0",
> "CounterMask": "0",
> "Invert": "0",
> @@ -371,4 +371,4 @@
> "Invert": "0",
> "EdgeDetect": "0"
> }
> -]
> \ No newline at end of file
> +]
> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/skylakex/uncore-other.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/skylakex/uncore-other.json
> @@ -514,7 +514,7 @@
> "EventCode": "0x5C",
> "EventName": "UNC_CHA_SNOOP_RESP.RSP_FWD_WB",
> "PerPkg": "1",
> - "PublicDescription": "Counts when a transaction with the opcode type Rsp*Fwd*WB Snoop Response was received which indicates the data was written back to it's home socket, and the cacheline was forwarded to the requestor socket. This snoop response is only used in >= 4 socket systems. It is used when a snoop HITM's in a remote caching agent and it directly forwards data to a requestor, and simultaneously returns data to it's home socket to be written back to memory.",
> + "PublicDescription": "Counts when a transaction with the opcode type Rsp*Fwd*WB Snoop Response was received which indicates the data was written back to its home socket, and the cacheline was forwarded to the requestor socket. This snoop response is only used in >= 4 socket systems. It is used when a snoop HITM's in a remote caching agent and it directly forwards data to a requestor, and simultaneously returns data to its home socket to be written back to memory.",
> "UMask": "0x20",
> "Unit": "CHA"
> },
> @@ -524,7 +524,7 @@
> "EventCode": "0x5C",
> "EventName": "UNC_CHA_SNOOP_RESP.RSP_WBWB",
> "PerPkg": "1",
> - "PublicDescription": "Counts when a transaction with the opcode type Rsp*WB Snoop Response was received which indicates which indicates the data was written back to it's home. This is returned when a non-RFO request hits a cacheline in the Modified state. The Cache can either downgrade the cacheline to a S (Shared) or I (Invalid) state depending on how the system has been configured. This reponse will also be sent when a cache requests E (Exclusive) ownership of a cache line without receiving data, because the cache must acquire ownership.",
> + "PublicDescription": "Counts when a transaction with the opcode type Rsp*WB Snoop Response was received which indicates which indicates the data was written back to its home. This is returned when a non-RFO request hits a cacheline in the Modified state. The Cache can either downgrade the cacheline to a S (Shared) or I (Invalid) state depending on how the system has been configured. This response will also be sent when a cache requests E (Exclusive) ownership of a cache line without receiving data, because the cache must acquire ownership.",
> "UMask": "0x10",
> "Unit": "CHA"
> },
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-03 1:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-26 2:52 [PATCH] perf: fix typos of "its" and "reponse" Randy Dunlap
2021-12-26 12:42 ` JSON typos " Arnaldo Carvalho de Melo
2021-12-26 19:12 ` Andi Kleen
2022-01-02 22:50 ` Paul A. Clarke
2022-01-03 1:01 ` Ian Rogers
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.