Re: [PATCH v7 0/3] net/i40e: configurable PTYPE mapping

From: Jianbo Liu <jianbo.liu@linaro.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Qi Zhang <qi.z.zhang@intel.com>,
	dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>,
	"Zhang, Helin" <helin.zhang@intel.com>,
	Jerin Jacob <jerin.jacob@caviumnetworks.com>,
	Chao Zhu <chaozhu@linux.vnet.ibm.com>
Subject: Re: [PATCH v7 0/3] net/i40e: configurable PTYPE mapping
Date: Wed, 5 Apr 2017 13:45:51 +0800	[thread overview]
Message-ID: <CAP4Qi39=oRMu0OEi_sEm-3cgAe_cTPQzCmcBwdgfb1r=AihxZg@mail.gmail.com> (raw)
In-Reply-To: <8195227.QCEXF4XZSi@xps13>

On 5 April 2017 at 04:22, Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 2017-04-04 10:30, Ferruh Yigit:
>> On 4/4/2017 2:55 AM, Qi Zhang wrote:
>> > The patch set create new APIs that help to change the mapping from hardware
>> > defined packet type to software defined packet type for i40e NICs.
>> > Keep these APIs private is because currently they are only meaningful for
>> > devices that support dynamic PTYPE configuration, which may not be a general
>> > device feature.
> [...]
>> > Qi Zhang (3):
>> >   net/i40e: enable per dev PTYPE mapping table
>> >   net/i40e: configurable PTYPE mapping
>> >   app/testpmd: add CL for ptype mapping configure
>>
>> Series applied to dpdk-next-net/master, thanks.
>
> It does not compile for ARM (not tested for POWER):
>         drivers/net/i40e/i40e_rxtx_vec_neon.c: In function '_recv_raw_pkts_vec':
>                 229:2: error: unknown type name 'uint32'
>                 uint32 *ptype_tbl = rxq->vsi->adapter->ptype_tbl;
>

It must be uint32_t.

> Given that
>         - it changes NEON and Altivec code
>         - it does not compile on ARM
>         - there is no Ack from NEON or Altivec maintainers (they were not Cc'ed)
> I really doubt it has been tested.
> That's why it won't be in RC1.
>
> If NEON and Altivec maintainers agree, we can give it a chance for RC2.
>

Other than the above error on ARM:
Acked-by: Jianbo Liu <jianbo.liu@linaro.org>

> PS: please use --in-reply-to to let us check the discussion history.