[PATCH v1 0/1] arm: npcm: enable L2 cache in NPCM7xx architecture

[PATCH v1 0/1] arm: npcm: enable L2 cache in NPCM7xx architecture

[Tomer Maimon]

This patch Enable ARM L2 cache module in Nuvoton NPCM7xx BMC
by adding L2 cache parameters into NPCM7xx DT machine start structure.

At patch V7 arm: npcm: add basic support for Nuvoton BMCs we got comments
regarding the flags use in L2 cache module.
- https://www.spinics.net/lists/arm-kernel/msg613212.html

After checking again the L2 cache use in the NPCM7xx,
the only L2 cache flag we need to set is L2C_AUX_CTRL_SHARED_OVERRIDE 
and it is done in the device tree:
https://patchwork.kernel.org/patch/10063497/

L2 cache flag mask allowed all the flag option.

Tomer Maimon (1):
  arm: npcm: enable L2 cache in NPCM7xx architecture

 arch/arm/mach-npcm/npcm7xx.c | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.14.1

[PATCH v1 1/1] arm: npcm: enable L2 cache in NPCM7xx architecture

[Tomer Maimon]

Enable ARM L2 cache module in Nuvoton NPCM7xx BMC by adding
L2 cache parameters into NPCM7xx DT machine start structure.

Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
---
 arch/arm/mach-npcm/npcm7xx.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-npcm/npcm7xx.c b/arch/arm/mach-npcm/npcm7xx.c
index 5f7cd88103ef..c5f77d854c4f 100644
--- a/arch/arm/mach-npcm/npcm7xx.c
+++ b/arch/arm/mach-npcm/npcm7xx.c
@@ -17,4 +17,6 @@ static const char *const npcm7xx_dt_match[] = {
 DT_MACHINE_START(NPCM7XX_DT, "NPCM7XX Chip family")
 	.atag_offset	= 0x100,
 	.dt_compat	= npcm7xx_dt_match,
+	.l2c_aux_val	= 0x0,
+	.l2c_aux_mask	= ~0x0,
 MACHINE_END
-- 
2.14.1

Re: [PATCH v1 0/1] arm: npcm: enable L2 cache in NPCM7xx architecture

[Arnd Bergmann]

On Sun, Apr 8, 2018 at 4:03 PM, Tomer Maimon <tmaimon77@gmail.com> wrote:
> This patch Enable ARM L2 cache module in Nuvoton NPCM7xx BMC
> by adding L2 cache parameters into NPCM7xx DT machine start structure.
>
> At patch V7 arm: npcm: add basic support for Nuvoton BMCs we got comments
> regarding the flags use in L2 cache module.
> - https://www.spinics.net/lists/arm-kernel/msg613212.html
>
> After checking again the L2 cache use in the NPCM7xx,
> the only L2 cache flag we need to set is L2C_AUX_CTRL_SHARED_OVERRIDE
> and it is done in the device tree:
> https://patchwork.kernel.org/patch/10063497/
>
> L2 cache flag mask allowed all the flag option.

I've applied the patch to my fixes branch now, but took your description above
instead of the two-line text that you had in the patch itself. I liked
the longer
text much better.

      Arnd

Re: [PATCH v1 0/1] arm: npcm: enable L2 cache in NPCM7xx architecture

[Arnd Bergmann]

On Sun, Apr 8, 2018 at 4:03 PM, Tomer Maimon <tmaimon77@gmail.com> wrote:
> This patch Enable ARM L2 cache module in Nuvoton NPCM7xx BMC
> by adding L2 cache parameters into NPCM7xx DT machine start structure.
>
> At patch V7 arm: npcm: add basic support for Nuvoton BMCs we got comments
> regarding the flags use in L2 cache module.
> - https://www.spinics.net/lists/arm-kernel/msg613212.html
>
> After checking again the L2 cache use in the NPCM7xx,
> the only L2 cache flag we need to set is L2C_AUX_CTRL_SHARED_OVERRIDE
> and it is done in the device tree:
> https://patchwork.kernel.org/patch/10063497/
>
> L2 cache flag mask allowed all the flag option.

I've applied the patch to my fixes branch now, but took your description above
instead of the two-line text that you had in the patch itself. I liked
the longer
text much better.

      Arnd

Re: [PATCH v1 0/1] arm: npcm: enable L2 cache in NPCM7xx architecture

[Tomer Maimon]

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

On 10 April 2018 at 17:41, Arnd Bergmann <arnd@arndb.de> wrote:

> On Sun, Apr 8, 2018 at 4:03 PM, Tomer Maimon <tmaimon77@gmail.com> wrote:
> > This patch Enable ARM L2 cache module in Nuvoton NPCM7xx BMC
> > by adding L2 cache parameters into NPCM7xx DT machine start structure.
> >
> > At patch V7 arm: npcm: add basic support for Nuvoton BMCs we got comments
> > regarding the flags use in L2 cache module.
> > - https://www.spinics.net/lists/arm-kernel/msg613212.html
> >
> > After checking again the L2 cache use in the NPCM7xx,
> > the only L2 cache flag we need to set is L2C_AUX_CTRL_SHARED_OVERRIDE
> > and it is done in the device tree:
> > https://patchwork.kernel.org/patch/10063497/
> >
> > L2 cache flag mask allowed all the flag option.
>
> I've applied the patch to my fixes branch now, but took your description
> above
> instead of the two-line text that you had in the patch itself. I liked
> the longer
> text much better.
>
>       Arnd
>

O.K.

Thanks a lot!

[-- Attachment #2: Type: text/html, Size: 1807 bytes --]