Re: [PATCH v1 1/4] dt-binding: watchdog: add restart priority documentation

From: Tomer Maimon <tmaimon77@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Joel Stanley <joel@jms.id.au>,
	 Avi Fishman <avifishman70@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	 Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	 linux-watchdog@vger.kernel.org,
	devicetree <devicetree@vger.kernel.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH v1 1/4] dt-binding: watchdog: add restart priority documentation
Date: Sun, 1 Mar 2020 17:36:37 +0200	[thread overview]
Message-ID: <CAP6Zq1gYvoGwNwr2zCopQ5CcyVUjgdYK6yX1wVMmWh5gapp+zQ@mail.gmail.com> (raw)
In-Reply-To: <6ecf9a6b-8fca-1e7a-10d0-ee518e6ecf64@roeck-us.net>

[-- Attachment #1: Type: text/plain, Size: 1681 bytes --]

On Sun, 1 Mar 2020 at 12:06, Guenter Roeck <linux@roeck-us.net> wrote:

> On 3/1/20 1:40 AM, Tomer Maimon wrote:
> > Add device tree restart priority documentation.
> >
>
> I think this warrants an explanation _why_ this is needed.
> What is the use case ? Not just theory, please.
>

In the NPCM750 there is two initiated restarts:

   - Software reset
   - WD reset

the Software restart found at NPCM reset driver
https://github.com/torvalds/linux/blob/master/drivers/reset/reset-npcm.c

In NPCM WD driver the restart is configure as well, I will like to add the
priority so the user will have maximum flexibility if he using both restarts

Thanks,

Tomer

> Guenter
>
> > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git
> a/Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt
> b/Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt
> > index 6d593003c933..0a0f86a25eb0 100644
> > --- a/Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt
> > +++ b/Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt
> > @@ -17,6 +17,7 @@ Required clocking property, have to be one of:
> >
> >  Optional properties:
> >  - timeout-sec : Contains the watchdog timeout in seconds
> > +- nuvoton,restart-priority : Contains the card restart priority.
> >
> >  Example:
> >
> > @@ -25,4 +26,5 @@ timer@f000801c {
> >      interrupts = <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>;
> >      reg = <0xf000801c 0x4>;
> >      clocks = <&clk NPCM7XX_CLK_TIMER>;
> > +     nuvoton,restart-priority = <155>;
> >  };
> >
>
>

[-- Attachment #2: Type: text/html, Size: 2774 bytes --]