All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomer Maimon <tmaimon77@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Joel Stanley <joel@jms.id.au>,
	 Avi Fishman <avifishman70@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	 Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	 linux-watchdog@vger.kernel.org,
	devicetree <devicetree@vger.kernel.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH v1 1/4] dt-binding: watchdog: add restart priority documentation
Date: Sun, 1 Mar 2020 18:19:43 +0200	[thread overview]
Message-ID: <CAP6Zq1j+MSCYgyQeJYid682pS0ZrHWGiX8oLr5f0GD4VLBdoPA@mail.gmail.com> (raw)
In-Reply-To: <e009d5e5-03a1-301c-0a65-c7f59c1be9fa@roeck-us.net>

[-- Attachment #1: Type: text/plain, Size: 1915 bytes --]

Thank you for the clarification.

I will remove the priority patch, and send a new patch set after receiving
comments for the boot status patch.

Tomer

On Sun, 1 Mar 2020 at 17:46, Guenter Roeck <linux@roeck-us.net> wrote:

> On 3/1/20 7:36 AM, Tomer Maimon wrote:
> >
> >
> > On Sun, 1 Mar 2020 at 12:06, Guenter Roeck <linux@roeck-us.net <mailto:
> linux@roeck-us.net>> wrote:
> >
> >     On 3/1/20 1:40 AM, Tomer Maimon wrote:
> >     > Add device tree restart priority documentation.
> >     >
> >
> >     I think this warrants an explanation _why_ this is needed.
> >     What is the use case ? Not just theory, please.
> >
> >
> > In the NPCM750 there is two initiated restarts:
> >
> >   * Software reset
> >   * WD reset
> >
> > the Software restart found at NPCM reset driver
> > https://github.com/torvalds/linux/blob/master/drivers/reset/reset-npcm.c
> >
> > In NPCM WD driver the restart is configure as well, I will like to add
> the priority so the user will have maximum flexibility if he using both
> restarts
> >
>
> This is not the intended use case for restart priority. It is not
> intended to be user configurable. The idea is that the more thorough
> restart gets higher priority. This is implied by the restart method,
> not by user preferences.
>
> Also, the idea behind supporting multiple means to reset the system
> is to be able to support multiple means to restart, some of which
> may not always be available. In that situation, the priority means,
> and is supposed to mean, "pick the best restart method available".
> Again, that is determined by system design, and not supposed to
> be configurable by the user.
>
> On top of that, a watchdog driver based reset is almost always
> a reset of last resort, to be chosen only if nothing else is available
> in a given system. The existence of the reset driver confirms that
> this is not different for this driver/chip.
>
> Guenter
>

[-- Attachment #2: Type: text/html, Size: 2726 bytes --]

  reply	other threads:[~2020-03-01 16:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-01  9:40 [PATCH v1 0/4] watchdog: npcm: support new capabilities Tomer Maimon
2020-03-01  9:40 ` [PATCH v1 1/4] dt-binding: watchdog: add restart priority documentation Tomer Maimon
2020-03-01 10:05   ` Guenter Roeck
2020-03-01 15:36     ` Tomer Maimon
2020-03-01 15:46       ` Guenter Roeck
2020-03-01 16:19         ` Tomer Maimon [this message]
2020-03-01  9:40 ` [PATCH v1 2/4] watchdog: npcm: add restart priority support Tomer Maimon
2020-03-01  9:40 ` [PATCH v1 3/4] dt-binding: watchdog: add bootstatus reset type documentation Tomer Maimon
2020-03-01  9:40 ` [PATCH v1 4/4] watchdog: npcm: sets card ext1 and ext2 bootstatus during probe Tomer Maimon
2020-03-01 10:48   ` Guenter Roeck
2020-03-01 16:08     ` Tomer Maimon
2020-03-01 16:10       ` Guenter Roeck
2020-03-01 17:03         ` Tomer Maimon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP6Zq1j+MSCYgyQeJYid682pS0ZrHWGiX8oLr5f0GD4VLBdoPA@mail.gmail.com \
    --to=tmaimon77@gmail.com \
    --cc=avifishman70@gmail.com \
    --cc=benjaminfair@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mark.rutland@arm.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh+dt@kernel.org \
    --cc=tali.perry1@gmail.com \
    --cc=wim@linux-watchdog.org \
    --cc=yuenn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.