From: Tomer Maimon <tmaimon77@gmail.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: "Avi Fishman" <avifishman70@gmail.com>, "Tali Perry" <tali.perry1@gmail.com>, "Joel Stanley" <joel@jms.id.au>, "Patrick Venture" <venture@google.com>, "Nancy Yuen" <yuenn@google.com>, "Benjamin Fair" <benjaminfair@google.com>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Michael Turquette" <mturquette@baylibre.com>, "Stephen Boyd" <sboyd@kernel.org>, "Philipp Zabel" <p.zabel@pengutronix.de>, "Greg KH" <gregkh@linuxfoundation.org>, "Daniel Lezcano" <daniel.lezcano@linaro.org>, "Thomas Gleixner" <tglx@linutronix.de>, "Wim Van Sebroeck" <wim@linux-watchdog.org>, "Guenter Roeck" <linux@roeck-us.net>, "Catalin Marinas" <catalin.marinas@arm.com>, "Will Deacon" <will@kernel.org>, "Arnd Bergmann" <arnd@arndb.de>, "Olof Johansson" <olof@lixom.net>, "Jiri Slaby" <jirislaby@kernel.org>, "Shawn Guo" <shawnguo@kernel.org>, "Bjorn Andersson" <bjorn.andersson@linaro.org>, "Geert Uytterhoeven" <geert+renesas@glider.be>, "Marcel Ziswiler" <marcel.ziswiler@toradex.com>, "Vinod Koul" <vkoul@kernel.org>, "Biju Das" <biju.das.jz@bp.renesas.com>, "Nobuhiro Iwamatsu" <nobuhiro1.iwamatsu@toshiba.co.jp>, "Robert Hancock" <robert.hancock@calian.com>, "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>, "Lubomir Rintel" <lkundrak@v3.sk>, devicetree <devicetree@vger.kernel.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, linux-clk <linux-clk@vger.kernel.org>, "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>, LINUXWATCHDOG <linux-watchdog@vger.kernel.org>, "Linux ARM" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v4 05/18] dt-binding: clk: npcm845: Add binding for Nuvoton NPCM8XX Clock Date: Tue, 21 Jun 2022 19:50:14 +0300 [thread overview] Message-ID: <CAP6Zq1itHGFw9ZV9cMr-9Fhx8fqYVGYXhmTOiLbGVjoV7TQ5hA@mail.gmail.com> (raw) In-Reply-To: <5832f7f1-3c8f-d88d-3b72-99effc1e2e83@linaro.org> Hi Krzysztof, On Tue, 21 Jun 2022 at 18:40, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 21/06/2022 15:14, Tomer Maimon wrote: > > Add binding for the Arbel BMC NPCM8XX Clock controller. > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > --- > > .../bindings/clock/nuvoton,npcm845-clk.yaml | 49 +++++++++++++++++++ > > .../dt-bindings/clock/nuvoton,npcm845-clk.h | 49 +++++++++++++++++++ > > 2 files changed, 98 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml > > create mode 100644 include/dt-bindings/clock/nuvoton,npcm845-clk.h > > > > diff --git a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml > > new file mode 100644 > > index 000000000000..3d4fddc090ca > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml > > @@ -0,0 +1,49 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/clock/nuvoton,npcm845-clk.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Nuvoton NPCM8XX Clock Controller Binding > > + > > +maintainers: > > + - Tomer Maimon <tmaimon77@gmail.com> > > + > > +description: | > > + Nuvoton Arbel BMC NPCM8XX contains an integrated clock controller, which > > + generates and supplies clocks to all modules within the BMC. > > + > > +properties: > > + compatible: > > + enum: > > + - nuvoton,npcm845-clk > > + > > + reg: > > + maxItems: 1 > > + > > + '#clock-cells': > > + const: 1 > > + description: > > + See include/dt-bindings/clock/nuvoton,npcm8xx-clock.h for the full > > + list of NPCM8XX clock IDs. > > + > > +required: > > + - compatible > > + - reg > > + - "#clock-cells" > > You fixed one comment and ignore second. The same was with v3. Sorry, I missed the quotes comment, will be addressed next version. > > This is still no. Implement all the comments you received. I have to > double check your patchsets every time because I cannot trust that you > implemented what I asked for. > > > Best regards, > Krzysztof Best regards, Tomer
WARNING: multiple messages have this Message-ID (diff)
From: Tomer Maimon <tmaimon77@gmail.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: "Avi Fishman" <avifishman70@gmail.com>, "Tali Perry" <tali.perry1@gmail.com>, "Joel Stanley" <joel@jms.id.au>, "Patrick Venture" <venture@google.com>, "Nancy Yuen" <yuenn@google.com>, "Benjamin Fair" <benjaminfair@google.com>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Michael Turquette" <mturquette@baylibre.com>, "Stephen Boyd" <sboyd@kernel.org>, "Philipp Zabel" <p.zabel@pengutronix.de>, "Greg KH" <gregkh@linuxfoundation.org>, "Daniel Lezcano" <daniel.lezcano@linaro.org>, "Thomas Gleixner" <tglx@linutronix.de>, "Wim Van Sebroeck" <wim@linux-watchdog.org>, "Guenter Roeck" <linux@roeck-us.net>, "Catalin Marinas" <catalin.marinas@arm.com>, "Will Deacon" <will@kernel.org>, "Arnd Bergmann" <arnd@arndb.de>, "Olof Johansson" <olof@lixom.net>, "Jiri Slaby" <jirislaby@kernel.org>, "Shawn Guo" <shawnguo@kernel.org>, "Bjorn Andersson" <bjorn.andersson@linaro.org>, "Geert Uytterhoeven" <geert+renesas@glider.be>, "Marcel Ziswiler" <marcel.ziswiler@toradex.com>, "Vinod Koul" <vkoul@kernel.org>, "Biju Das" <biju.das.jz@bp.renesas.com>, "Nobuhiro Iwamatsu" <nobuhiro1.iwamatsu@toshiba.co.jp>, "Robert Hancock" <robert.hancock@calian.com>, "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>, "Lubomir Rintel" <lkundrak@v3.sk>, devicetree <devicetree@vger.kernel.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, linux-clk <linux-clk@vger.kernel.org>, "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>, LINUXWATCHDOG <linux-watchdog@vger.kernel.org>, "Linux ARM" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v4 05/18] dt-binding: clk: npcm845: Add binding for Nuvoton NPCM8XX Clock Date: Tue, 21 Jun 2022 19:50:14 +0300 [thread overview] Message-ID: <CAP6Zq1itHGFw9ZV9cMr-9Fhx8fqYVGYXhmTOiLbGVjoV7TQ5hA@mail.gmail.com> (raw) In-Reply-To: <5832f7f1-3c8f-d88d-3b72-99effc1e2e83@linaro.org> Hi Krzysztof, On Tue, 21 Jun 2022 at 18:40, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 21/06/2022 15:14, Tomer Maimon wrote: > > Add binding for the Arbel BMC NPCM8XX Clock controller. > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > --- > > .../bindings/clock/nuvoton,npcm845-clk.yaml | 49 +++++++++++++++++++ > > .../dt-bindings/clock/nuvoton,npcm845-clk.h | 49 +++++++++++++++++++ > > 2 files changed, 98 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml > > create mode 100644 include/dt-bindings/clock/nuvoton,npcm845-clk.h > > > > diff --git a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml > > new file mode 100644 > > index 000000000000..3d4fddc090ca > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml > > @@ -0,0 +1,49 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/clock/nuvoton,npcm845-clk.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Nuvoton NPCM8XX Clock Controller Binding > > + > > +maintainers: > > + - Tomer Maimon <tmaimon77@gmail.com> > > + > > +description: | > > + Nuvoton Arbel BMC NPCM8XX contains an integrated clock controller, which > > + generates and supplies clocks to all modules within the BMC. > > + > > +properties: > > + compatible: > > + enum: > > + - nuvoton,npcm845-clk > > + > > + reg: > > + maxItems: 1 > > + > > + '#clock-cells': > > + const: 1 > > + description: > > + See include/dt-bindings/clock/nuvoton,npcm8xx-clock.h for the full > > + list of NPCM8XX clock IDs. > > + > > +required: > > + - compatible > > + - reg > > + - "#clock-cells" > > You fixed one comment and ignore second. The same was with v3. Sorry, I missed the quotes comment, will be addressed next version. > > This is still no. Implement all the comments you received. I have to > double check your patchsets every time because I cannot trust that you > implemented what I asked for. > > > Best regards, > Krzysztof Best regards, Tomer _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-21 16:50 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-21 13:14 [PATCH v4 00/18] Introduce Nuvoton Arbel NPCM8XX BMC SoC Tomer Maimon 2022-06-21 13:14 ` Tomer Maimon 2022-06-21 13:14 ` [PATCH v4 01/18] dt-bindings: timer: npcm: Add npcm845 compatible string Tomer Maimon 2022-06-21 13:14 ` Tomer Maimon 2022-06-21 13:14 ` [PATCH v4 02/18] clocksource: timer-npcm7xx: Add NPCM845 timer support Tomer Maimon 2022-06-21 13:14 ` Tomer Maimon 2022-06-21 13:14 ` [PATCH v4 03/18] dt-bindings: serial: 8250: Add npcm845 compatible string Tomer Maimon 2022-06-21 13:14 ` Tomer Maimon 2022-06-21 13:14 ` [PATCH v4 04/18] dt-bindings: watchdog: npcm: " Tomer Maimon 2022-06-21 13:14 ` Tomer Maimon 2022-06-21 14:39 ` Guenter Roeck 2022-06-21 14:39 ` Guenter Roeck 2022-06-21 13:14 ` [PATCH v4 05/18] dt-binding: clk: npcm845: Add binding for Nuvoton NPCM8XX Clock Tomer Maimon 2022-06-21 13:14 ` Tomer Maimon 2022-06-21 15:40 ` Krzysztof Kozlowski 2022-06-21 15:40 ` Krzysztof Kozlowski 2022-06-21 16:50 ` Tomer Maimon [this message] 2022-06-21 16:50 ` Tomer Maimon 2022-06-21 13:14 ` [PATCH v4 06/18] clk: npcm8xx: add clock controller Tomer Maimon 2022-06-21 13:14 ` Tomer Maimon 2022-06-23 8:08 ` Christophe JAILLET 2022-06-23 8:08 ` Christophe JAILLET 2022-06-23 14:22 ` Tomer Maimon 2022-06-23 14:22 ` Tomer Maimon 2022-06-21 13:14 ` [PATCH v4 07/18] dt-bindings: reset: npcm: add GCR syscon property Tomer Maimon 2022-06-21 13:14 ` Tomer Maimon 2022-06-21 15:41 ` Krzysztof Kozlowski 2022-06-21 15:41 ` Krzysztof Kozlowski 2022-06-21 13:14 ` [PATCH v4 08/18] ARM: dts: nuvoton: add reset " Tomer Maimon 2022-06-21 13:14 ` Tomer Maimon 2022-06-21 13:14 ` [PATCH v4 09/18] reset: npcm: using syscon instead of device data Tomer Maimon 2022-06-21 13:14 ` Tomer Maimon 2022-06-21 13:14 ` [PATCH v4 10/18] dt-bindings: reset: npcm: Add support for NPCM8XX Tomer Maimon 2022-06-21 13:14 ` Tomer Maimon 2022-06-21 13:14 ` [PATCH v4 11/18] reset: npcm: Add NPCM8XX support Tomer Maimon 2022-06-21 13:14 ` Tomer Maimon 2022-06-21 13:14 ` [PATCH v4 12/18] dt-bindings: arm: npcm: Add maintainer Tomer Maimon 2022-06-21 13:14 ` Tomer Maimon 2022-06-21 13:14 ` [PATCH v4 13/18] dt-bindings: arm: npcm: Add nuvoton,npcm845 compatible string Tomer Maimon 2022-06-21 13:14 ` Tomer Maimon 2022-06-21 13:14 ` [PATCH v4 14/18] dt-bindings: arm: npcm: Add nuvoton,npcm845 GCR " Tomer Maimon 2022-06-21 13:14 ` Tomer Maimon 2022-06-21 13:14 ` [PATCH v4 15/18] arm64: npcm: Add support for Nuvoton NPCM8XX BMC SoC Tomer Maimon 2022-06-21 13:14 ` Tomer Maimon 2022-06-21 13:14 ` [PATCH v4 16/18] arm64: dts: nuvoton: Add initial NPCM8XX device tree Tomer Maimon 2022-06-21 13:14 ` Tomer Maimon 2022-06-21 13:14 ` [PATCH v4 17/18] arm64: dts: nuvoton: Add initial NPCM845 EVB " Tomer Maimon 2022-06-21 13:14 ` Tomer Maimon 2022-06-21 13:14 ` [PATCH v4 18/18] arm64: defconfig: Add Nuvoton NPCM family support Tomer Maimon 2022-06-21 13:14 ` Tomer Maimon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAP6Zq1itHGFw9ZV9cMr-9Fhx8fqYVGYXhmTOiLbGVjoV7TQ5hA@mail.gmail.com \ --to=tmaimon77@gmail.com \ --cc=arnd@arndb.de \ --cc=avifishman70@gmail.com \ --cc=benjaminfair@google.com \ --cc=biju.das.jz@bp.renesas.com \ --cc=bjorn.andersson@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=geert+renesas@glider.be \ --cc=gregkh@linuxfoundation.org \ --cc=j.neuschaefer@gmx.net \ --cc=jirislaby@kernel.org \ --cc=joel@jms.id.au \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=lkundrak@v3.sk \ --cc=marcel.ziswiler@toradex.com \ --cc=mturquette@baylibre.com \ --cc=nobuhiro1.iwamatsu@toshiba.co.jp \ --cc=olof@lixom.net \ --cc=p.zabel@pengutronix.de \ --cc=robert.hancock@calian.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=shawnguo@kernel.org \ --cc=tali.perry1@gmail.com \ --cc=tglx@linutronix.de \ --cc=venture@google.com \ --cc=vkoul@kernel.org \ --cc=will@kernel.org \ --cc=wim@linux-watchdog.org \ --cc=yuenn@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.