All of lore.kernel.org
 help / color / mirror / Atom feed
* possible issue with buildhistory?
@ 2019-05-23  6:53 Nicolas Dechesne
  2019-05-23 23:53 ` Khem Raj
  0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Dechesne @ 2019-05-23  6:53 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

hi,

not sure if it's been discussed reported before. but i ended up in a
situation where a package is "empty" (e.g. it's not created) even
though "files-in-packages.txt" in its buildhistory folder shows it
should contain a file.

I have a synthetic example:

$ cat buildhistory/packages/aarch64-linaro-linux/helloworld/latest
PV = 1.0
PR = r0
DEPENDS = autoconf-native automake-native gnu-config-native
libtool-cross libtool-native virtual/aarch64-linaro-linux-compilerlibs
virtual/aarch64-linaro-linux-gcc virtual/libc
PACKAGES = helloworld-src helloworld-dbg helloworld-staticdev
helloworld-dev helloworld-doc helloworld-locale helloworld
goodbyeworld
LAYER = meta-rpb

then:

$ cat buildhistory/packages/aarch64-linaro-linux/helloworld/goodbyeworld/files-in-package.txt
drwxr-xr-x root       root             4096 ./usr
drwxr-xr-x root       root             4096 ./usr/bin
-rwxr-xr-x root       root             6144 ./usr/bin/goodbyeworld

However goodbyeworld package does not exist, and /usr/bin/goodbyeworld
is in the helloworld package:

$ dpkg -c tmp-rpb-glibc/deploy/ipk/aarch64/helloworld_1.0-r0_aarch64.ipk
drwxrwxrwx root/root         0 2019-05-23 08:25 ./
drwxr-xr-x root/root         0 2019-05-23 08:25 ./usr/
drwxr-xr-x root/root         0 2019-05-23 08:25 ./usr/bin/
-rwxr-xr-x root/root      6144 2019-05-23 08:25 ./usr/bin/goodbyeworld
-rwxr-xr-x root/root      6144 2019-05-23 08:25 ./usr/bin/helloworld

It is worth saying that the file should indeed be in helloworld
package since there was a bug in my recipe! So buildhistory is wrong
here.

The recipe is a simple one:

SRC_URI = "file://helloworld.c \
  file://goodbyeworld.c \
  file://Makefile.am \
  file://configure.ac \
  file://COPYING"
S = "${WORKDIR}"
inherit autotools
PACKAGES += "goodbyeworld"
FILES_goodbyeworld += "${bindir}/goodbyeworld"

Clearly the recipe has a bug, and if I do this instead:
PACKAGES =+ "goodbyeworld"

/usr/bin/goodbyeworld ends up in the right package... however I think
in the previous case, buildhistory should have shown
/usb/bin/goodbyeworld in helloworld package, not goodbyeworld...

I was testing on warrior, but i can try to reproduce on master if needed..

thanks!


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: possible issue with buildhistory?
  2019-05-23  6:53 possible issue with buildhistory? Nicolas Dechesne
@ 2019-05-23 23:53 ` Khem Raj
  0 siblings, 0 replies; 2+ messages in thread
From: Khem Raj @ 2019-05-23 23:53 UTC (permalink / raw)
  To: Nicolas Dechesne, Patches and discussions about the oe-core layer



On 5/22/19 11:53 PM, Nicolas Dechesne wrote:
> hi,
> 
> not sure if it's been discussed reported before. but i ended up in a
> situation where a package is "empty" (e.g. it's not created) even
> though "files-in-packages.txt" in its buildhistory folder shows it
> should contain a file.
> 
> I have a synthetic example:
> 
> $ cat buildhistory/packages/aarch64-linaro-linux/helloworld/latest
> PV = 1.0
> PR = r0
> DEPENDS = autoconf-native automake-native gnu-config-native
> libtool-cross libtool-native virtual/aarch64-linaro-linux-compilerlibs
> virtual/aarch64-linaro-linux-gcc virtual/libc
> PACKAGES = helloworld-src helloworld-dbg helloworld-staticdev
> helloworld-dev helloworld-doc helloworld-locale helloworld
> goodbyeworld
> LAYER = meta-rpb
> 
> then:
> 
> $ cat buildhistory/packages/aarch64-linaro-linux/helloworld/goodbyeworld/files-in-package.txt
> drwxr-xr-x root       root             4096 ./usr
> drwxr-xr-x root       root             4096 ./usr/bin
> -rwxr-xr-x root       root             6144 ./usr/bin/goodbyeworld
> 
> However goodbyeworld package does not exist, and /usr/bin/goodbyeworld
> is in the helloworld package:
> 
> $ dpkg -c tmp-rpb-glibc/deploy/ipk/aarch64/helloworld_1.0-r0_aarch64.ipk
> drwxrwxrwx root/root         0 2019-05-23 08:25 ./
> drwxr-xr-x root/root         0 2019-05-23 08:25 ./usr/
> drwxr-xr-x root/root         0 2019-05-23 08:25 ./usr/bin/
> -rwxr-xr-x root/root      6144 2019-05-23 08:25 ./usr/bin/goodbyeworld
> -rwxr-xr-x root/root      6144 2019-05-23 08:25 ./usr/bin/helloworld
> 
> It is worth saying that the file should indeed be in helloworld
> package since there was a bug in my recipe! So buildhistory is wrong
> here.
> 
> The recipe is a simple one:
> 
> SRC_URI = "file://helloworld.c \
>    file://goodbyeworld.c \
>    file://Makefile.am \
>    file://configure.ac \
>    file://COPYING"
> S = "${WORKDIR}"
> inherit autotools
> PACKAGES += "goodbyeworld"
> FILES_goodbyeworld += "${bindir}/goodbyeworld"
> 
> Clearly the recipe has a bug, and if I do this instead:
> PACKAGES =+ "goodbyeworld"
> 
> /usr/bin/goodbyeworld ends up in the right package... however I think
> in the previous case, buildhistory should have shown
> /usb/bin/goodbyeworld in helloworld package, not goodbyeworld...
> 
> I was testing on warrior, but i can try to reproduce on master if needed..
> 

I think this could be happening since removing empty package is an 
optimization which is not considered by buildhistory. Its worth a bug 
report.

> thanks!
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-23 23:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-23  6:53 possible issue with buildhistory? Nicolas Dechesne
2019-05-23 23:53 ` Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.