From: Christian Couder <christian.couder@gmail.com>
To: ZheNing Hu <adlternative@gmail.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>,
"Hariom verma" <hariom18599@gmail.com>
Subject: Re: [GSOC] How to improve the performance of git cat-file --batch
Date: Mon, 26 Jul 2021 11:38:20 +0200 [thread overview]
Message-ID: <CAP8UFD1szPO-qmusSqiLRWxynV0gcy8UsnZORNn0USYAmRUGVw@mail.gmail.com> (raw)
In-Reply-To: <CAOLTT8Sbusr8=iJbG1qXcSerivZqP5xm-GS8R7TqDMh7QXSZaA@mail.gmail.com>
On Sun, Jul 25, 2021 at 2:04 PM ZheNing Hu <adlternative@gmail.com> wrote:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> 于2021年7月25日周日 上午5:23写道：
> > Having skimmed it I'm a bit confused about this in reference to
> > performance generally. I haven't looked into the case you're discussing,
> > but as I noted in
> > https://lore.kernel.org/git/87im1p6x34.fsf@evledraar.gmail.com/ the
> > profiling clearly shows that the main problem is that you've added
> > object lookups we skipped before.
>
> Yeah, you showed me last time that lookup_object() took up a lot of time.
Could the document explain with some details why there are more calls
to lookup_object()? For example it could take an example `git cat-file
--batch ...` command (if possible a simple one), and say which
functions like lookup_object() it was using (and how many times) to
get the data it needs before using the ref-filter logic, and then the
same information after using the ref-filter logic.
It could be nice if there were also some data about how much time used
to be spent in lookup_object() and how much time is now spent there,
and how this compares with the whole slowdown we are seeing. If Ævar
already showed that, you can of course reuse what he already did.
The GIT_TRACE_PERFORMANCE, GIT_TRACE2_PERF env variables and the
associated trace_*() and trace2_*() functions might help you with
measuring how much time is spent in different functions.
next prev parent reply other threads:[~2021-07-26 9:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 14:22 [GSOC] How to improve the performance of git cat-file --batch ZheNing Hu
2021-07-24 21:20 ` Ævar Arnfjörð Bjarmason
2021-07-25 12:05 ` ZheNing Hu
2021-07-26 9:38 ` Christian Couder [this message]
2021-07-27 1:37 ` ZheNing Hu
2021-07-28 7:34 ` Christian Couder
2021-07-28 13:38 ` ZheNing Hu
2021-07-28 15:36 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8UFD1szPO-qmusSqiLRWxynV0gcy8UsnZORNn0USYAmRUGVw@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=adlternative@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hariom18599@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.