[meta-freescale-layer][PATCH] remove gobject-introspection-data feature which is not needed

[meta-freescale-layer][PATCH] remove gobject-introspection-data feature which is not needed

[Zhenhua Luo]

Currently qemu doesn't support ppce6500, accordingly gobject-introspection
oesn't build for e6500 targets. Since the gobject-introspection-data feature
is not needed for e6500, remove it from default build list.

The e6500 support issue of qemu is tracked by:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=10304

Signed-off-by: Zhenhua Luo <zhenhua.luo@nxp.com>
---
 conf/machine/include/e6500-64b.inc | 2 ++
 conf/machine/include/e6500.inc     | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/conf/machine/include/e6500-64b.inc b/conf/machine/include/e6500-64b.inc
index 33346d7..540d2d3 100644
--- a/conf/machine/include/e6500-64b.inc
+++ b/conf/machine/include/e6500-64b.inc
@@ -6,6 +6,8 @@ require conf/machine/include/tune-ppce6500.inc
 MACHINEOVERRIDES =. "e6500-64b:"
 require conf/machine/include/qoriq-ppc.inc
 
+DISTRO_FEATURES_BACKFILL_CONSIDERED += "gobject-introspection-data"
+
 require conf/multilib.conf
 MULTILIBS ?= "multilib:lib32"
 DEFAULTTUNE_virtclass-multilib-lib32 ?= "ppce6500"
diff --git a/conf/machine/include/e6500.inc b/conf/machine/include/e6500.inc
index b838c8d..fc45ef2 100644
--- a/conf/machine/include/e6500.inc
+++ b/conf/machine/include/e6500.inc
@@ -7,6 +7,8 @@ require conf/machine/include/qoriq-ppc.inc
 
 BUILD_64BIT_KERNEL = "1"
 
+DISTRO_FEATURES_BACKFILL_CONSIDERED += "gobject-introspection-data"
+
 require conf/multilib.conf
 MULTILIBS ?= "multilib:lib64"
 DEFAULTTUNE_virtclass-multilib-lib64 ?= "ppc64e6500"
-- 
2.7.4

Re: [meta-freescale-layer][PATCH] remove gobject-introspection-data feature which is not needed

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 648 bytes --]

On 22 September 2016 at 09:40, Zhenhua Luo <zhenhua.luo@nxp.com> wrote:

> Currently qemu doesn't support ppce6500, accordingly gobject-introspection
> oesn't build for e6500 targets. Since the gobject-introspection-data
> feature
> is not needed for e6500, remove it from default build list.
>

gobject-introspection-data.bbclass:

GI_DATA_ENABLED ?= "${@bb.utils.contains('DISTRO_FEATURES',
'gobject-introspection-data', \
                      bb.utils.contains('MACHINE_FEATURES',
'qemu-usermode', 'True', 'False', d), 'False', d)}"

Instead of manipulating DISTRO_FEATURES you can just set MACHINE_FEATURES
correctly.

Ross

[-- Attachment #2: Type: text/html, Size: 1322 bytes --]

Re: [meta-freescale-layer][PATCH] remove gobject-introspection-data feature which is not needed

[Otavio Salvador]

On Thu, Sep 22, 2016 at 7:18 AM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 22 September 2016 at 09:40, Zhenhua Luo <zhenhua.luo@nxp.com> wrote:
>>
>> Currently qemu doesn't support ppce6500, accordingly gobject-introspection
>> oesn't build for e6500 targets. Since the gobject-introspection-data
>> feature
>> is not needed for e6500, remove it from default build list.
>
>
> gobject-introspection-data.bbclass:
>
> GI_DATA_ENABLED ?= "${@bb.utils.contains('DISTRO_FEATURES',
> 'gobject-introspection-data', \
>                       bb.utils.contains('MACHINE_FEATURES', 'qemu-usermode',
> 'True', 'False', d), 'False', d)}"
>
> Instead of manipulating DISTRO_FEATURES you can just set MACHINE_FEATURES
> correctly.

Agreed; however it must be said that the GObject support will be
broken so people using those language bindings will have problems.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-freescale-layer][PATCH] remove gobject-introspection-data feature which is not needed

[Zhenhua Luo]

Thanks for your comments, v2 is out. 


Best Regards, 

Zhenhua

> -----Original Message-----
> From: Otavio Salvador [mailto:otavio.salvador@ossystems.com.br]
> Sent: Thursday, September 22, 2016 7:08 PM
> To: Burton, Ross <ross.burton@intel.com>
> Cc: Zhenhua Luo <zhenhua.luo@nxp.com>; meta-freescale Mailing List <meta-
> freescale@yoctoproject.org>
> Subject: Re: [meta-freescale] [meta-freescale-layer][PATCH] remove gobject-
> introspection-data feature which is not needed
> 
> On Thu, Sep 22, 2016 at 7:18 AM, Burton, Ross <ross.burton@intel.com> wrote:
> >
> > On 22 September 2016 at 09:40, Zhenhua Luo <zhenhua.luo@nxp.com> wrote:
> >>
> >> Currently qemu doesn't support ppce6500, accordingly
> >> gobject-introspection oesn't build for e6500 targets. Since the
> >> gobject-introspection-data feature is not needed for e6500, remove it
> >> from default build list.
> >
> >
> > gobject-introspection-data.bbclass:
> >
> > GI_DATA_ENABLED ?= "${@bb.utils.contains('DISTRO_FEATURES',
> > 'gobject-introspection-data', \
> >                       bb.utils.contains('MACHINE_FEATURES',
> > 'qemu-usermode', 'True', 'False', d), 'False', d)}"
> >
> > Instead of manipulating DISTRO_FEATURES you can just set
> > MACHINE_FEATURES correctly.
> 
> Agreed; however it must be said that the GObject support will be broken so
> people using those language bindings will have problems.
> 
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750