* [PATCH] grub git: workaround debugedit problems for 64 bit targets
@ 2014-01-15 10:15 Koen Kooi
2014-01-15 11:22 ` Otavio Salvador
2014-02-12 8:03 ` Koen Kooi
0 siblings, 2 replies; 13+ messages in thread
From: Koen Kooi @ 2014-01-15 10:15 UTC (permalink / raw)
To: openembedded-core; +Cc: Koen Kooi
I've limited it to 64bit targets, but to be honest debug splitting doesn't make sense for grub since it won't run in your rootfs and attaching gdb is pretty much impossible.
Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
---
meta/recipes-bsp/grub/grub_git.bb | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/meta/recipes-bsp/grub/grub_git.bb b/meta/recipes-bsp/grub/grub_git.bb
index 1796e7f..bc79cfa 100644
--- a/meta/recipes-bsp/grub/grub_git.bb
+++ b/meta/recipes-bsp/grub/grub_git.bb
@@ -51,8 +51,13 @@ do_configure_prepend() {
do_install_append () {
install -d ${D}${sysconfdir}/grub.d
install -m 0755 ${WORKDIR}/40_custom ${D}${sysconfdir}/grub.d/40_custom
+
}
+# debugedit chokes on 64 bit platforms
+INHIBIT_PACKAGE_DEBUG_SPLIT_aarch64 = "1"
+INHIBIT_PACKAGE_DEBUG_SPLIT_x86-64 = "1"
+
RDEPENDS_${PN} = "diffutils freetype"
FILES_${PN}-dbg += "${libdir}/${BPN}/*/.debug"
--
1.8.4.2
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] grub git: workaround debugedit problems for 64 bit targets
2014-01-15 10:15 [PATCH] grub git: workaround debugedit problems for 64 bit targets Koen Kooi
@ 2014-01-15 11:22 ` Otavio Salvador
2014-01-16 9:27 ` Koen Kooi
2014-02-12 8:03 ` Koen Kooi
1 sibling, 1 reply; 13+ messages in thread
From: Otavio Salvador @ 2014-01-15 11:22 UTC (permalink / raw)
To: Koen Kooi; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]
On Wed, Jan 15, 2014 at 8:15 AM, Koen Kooi <koen.kooi@linaro.org> wrote:
> I've limited it to 64bit targets, but to be honest debug splitting doesn't
> make sense for grub since it won't run in your rootfs and attaching gdb is
> pretty much impossible.
>
> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
>
I'd prefer to remove the debug systems than skip the split. What others
think?
> ---
> meta/recipes-bsp/grub/grub_git.bb | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/meta/recipes-bsp/grub/grub_git.bb b/meta/recipes-bsp/grub/
> grub_git.bb
> index 1796e7f..bc79cfa 100644
> --- a/meta/recipes-bsp/grub/grub_git.bb
> +++ b/meta/recipes-bsp/grub/grub_git.bb
> @@ -51,8 +51,13 @@ do_configure_prepend() {
> do_install_append () {
> install -d ${D}${sysconfdir}/grub.d
> install -m 0755 ${WORKDIR}/40_custom
> ${D}${sysconfdir}/grub.d/40_custom
> +
> }
>
Please remove this.
> +# debugedit chokes on 64 bit platforms
> +INHIBIT_PACKAGE_DEBUG_SPLIT_aarch64 = "1"
> +INHIBIT_PACKAGE_DEBUG_SPLIT_x86-64 = "1"
> +
> RDEPENDS_${PN} = "diffutils freetype"
> FILES_${PN}-dbg += "${libdir}/${BPN}/*/.debug"
>
> --
> 1.8.4.2
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
[-- Attachment #2: Type: text/html, Size: 3054 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] grub git: workaround debugedit problems for 64 bit targets
2014-01-15 11:22 ` Otavio Salvador
@ 2014-01-16 9:27 ` Koen Kooi
2014-01-16 10:38 ` Otavio Salvador
0 siblings, 1 reply; 13+ messages in thread
From: Koen Kooi @ 2014-01-16 9:27 UTC (permalink / raw)
To: Otavio Salvador; +Cc: Patches and discussions about the oe-core layer
On 01/15/2014 12:22 PM, Otavio Salvador wrote:
>
>
>
> On Wed, Jan 15, 2014 at 8:15 AM, Koen Kooi <koen.kooi@linaro.org
> <mailto:koen.kooi@linaro.org>> wrote:
>
> I've limited it to 64bit targets, but to be honest debug splitting
> doesn't make sense for grub since it won't run in your rootfs and
> attaching gdb is pretty much impossible.
>
> Signed-off-by: Koen Kooi <koen.kooi@linaro.org
> <mailto:koen.kooi@linaro.org>>
>
>
> I'd prefer to remove the debug systems than skip the split. What others
> think?
I'm not sure what you mean by that, do you mean using
INHIBIT_PACKAGE_STRIP or something else?
regards,
Koen
>
> ---
> meta/recipes-bsp/grub/grub_git.bb <http://grub_git.bb> | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/meta/recipes-bsp/grub/grub_git.bb <http://grub_git.bb>
> b/meta/recipes-bsp/grub/grub_git.bb <http://grub_git.bb>
> index 1796e7f..bc79cfa 100644
> --- a/meta/recipes-bsp/grub/grub_git.bb <http://grub_git.bb>
> +++ b/meta/recipes-bsp/grub/grub_git.bb <http://grub_git.bb>
> @@ -51,8 +51,13 @@ do_configure_prepend() {
> do_install_append () {
> install -d ${D}${sysconfdir}/grub.d
> install -m 0755 ${WORKDIR}/40_custom
> ${D}${sysconfdir}/grub.d/40_custom
> +
> }
>
>
> Please remove this.
>
> +# debugedit chokes on 64 bit platforms
> +INHIBIT_PACKAGE_DEBUG_SPLIT_aarch64 = "1"
> +INHIBIT_PACKAGE_DEBUG_SPLIT_x86-64 = "1"
> +
> RDEPENDS_${PN} = "diffutils freetype"
> FILES_${PN}-dbg += "${libdir}/${BPN}/*/.debug"
>
> --
> 1.8.4.2
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> <mailto:Openembedded-core@lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
>
>
> --
> Otavio Salvador O.S. Systems
> http://www.ossystems.com.br http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
--
Koen Kooi
Builds and Baselines | Release Manager
Linaro.org | Open source software for ARM SoCs
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] grub git: workaround debugedit problems for 64 bit targets
2014-01-16 9:27 ` Koen Kooi
@ 2014-01-16 10:38 ` Otavio Salvador
2014-01-16 10:46 ` Koen Kooi
0 siblings, 1 reply; 13+ messages in thread
From: Otavio Salvador @ 2014-01-16 10:38 UTC (permalink / raw)
To: Koen Kooi; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]
On Thu, Jan 16, 2014 at 7:27 AM, Koen Kooi <koen.kooi@linaro.org> wrote:
> On 01/15/2014 12:22 PM, Otavio Salvador wrote:
>
>>
>>
>>
>> On Wed, Jan 15, 2014 at 8:15 AM, Koen Kooi <koen.kooi@linaro.org
>> <mailto:koen.kooi@linaro.org>> wrote:
>>
>> I've limited it to 64bit targets, but to be honest debug splitting
>> doesn't make sense for grub since it won't run in your rootfs and
>> attaching gdb is pretty much impossible.
>>
>> Signed-off-by: Koen Kooi <koen.kooi@linaro.org
>> <mailto:koen.kooi@linaro.org>>
>>
>>
>>
>> I'd prefer to remove the debug systems than skip the split. What others
>> think?
>>
>
> I'm not sure what you mean by that, do you mean using
> INHIBIT_PACKAGE_STRIP or something else?
>
Yes and be sure it has been stripped during build.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
[-- Attachment #2: Type: text/html, Size: 1987 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] grub git: workaround debugedit problems for 64 bit targets
2014-01-16 10:38 ` Otavio Salvador
@ 2014-01-16 10:46 ` Koen Kooi
2014-01-16 10:47 ` Otavio Salvador
0 siblings, 1 reply; 13+ messages in thread
From: Koen Kooi @ 2014-01-16 10:46 UTC (permalink / raw)
To: Otavio Salvador; +Cc: Patches and discussions about the oe-core layer
Op 16 jan. 2014, om 11:38 heeft Otavio Salvador <otavio@ossystems.com.br> het volgende geschreven:
>
>
>
> On Thu, Jan 16, 2014 at 7:27 AM, Koen Kooi <koen.kooi@linaro.org> wrote:
> On 01/15/2014 12:22 PM, Otavio Salvador wrote:
>
>
>
> On Wed, Jan 15, 2014 at 8:15 AM, Koen Kooi <koen.kooi@linaro.org
> <mailto:koen.kooi@linaro.org>> wrote:
>
> I've limited it to 64bit targets, but to be honest debug splitting
> doesn't make sense for grub since it won't run in your rootfs and
> attaching gdb is pretty much impossible.
>
> Signed-off-by: Koen Kooi <koen.kooi@linaro.org
> <mailto:koen.kooi@linaro.org>>
>
>
>
> I'd prefer to remove the debug systems than skip the split. What others
> think?
>
> I'm not sure what you mean by that, do you mean using INHIBIT_PACKAGE_STRIP or something else?
>
>
> Yes and be sure it has been stripped during build.
That seems to be a lot more work for the same effect. Stripping isn't the problem, it's debugedit trying to do its magic that fails.
regards,
Koen
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] grub git: workaround debugedit problems for 64 bit targets
2014-01-16 10:46 ` Koen Kooi
@ 2014-01-16 10:47 ` Otavio Salvador
2014-01-21 9:40 ` Koen Kooi
0 siblings, 1 reply; 13+ messages in thread
From: Otavio Salvador @ 2014-01-16 10:47 UTC (permalink / raw)
To: Koen Kooi; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 1439 bytes --]
On Thu, Jan 16, 2014 at 8:46 AM, Koen Kooi <koen.kooi@linaro.org> wrote:
> Op 16 jan. 2014, om 11:38 heeft Otavio Salvador <otavio@ossystems.com.br>
> het volgende geschreven:
> > On Thu, Jan 16, 2014 at 7:27 AM, Koen Kooi <koen.kooi@linaro.org> wrote:
> > On 01/15/2014 12:22 PM, Otavio Salvador wrote:
> > On Wed, Jan 15, 2014 at 8:15 AM, Koen Kooi <koen.kooi@linaro.org
> > <mailto:koen.kooi@linaro.org>> wrote:
> >
> > I've limited it to 64bit targets, but to be honest debug splitting
> > doesn't make sense for grub since it won't run in your rootfs and
> > attaching gdb is pretty much impossible.
> >
> > Signed-off-by: Koen Kooi <koen.kooi@linaro.org
> > <mailto:koen.kooi@linaro.org>>
> >
> >
> >
> > I'd prefer to remove the debug systems than skip the split. What others
> > think?
> >
> > I'm not sure what you mean by that, do you mean using
> INHIBIT_PACKAGE_STRIP or something else?
> >
> >
> > Yes and be sure it has been stripped during build.
>
> That seems to be a lot more work for the same effect. Stripping isn't the
> problem, it's debugedit trying to do its magic that fails.
>
Well, if not stripped the symbols will be left in the binaries which is not
expected.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
[-- Attachment #2: Type: text/html, Size: 2329 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] grub git: workaround debugedit problems for 64 bit targets
2014-01-16 10:47 ` Otavio Salvador
@ 2014-01-21 9:40 ` Koen Kooi
0 siblings, 0 replies; 13+ messages in thread
From: Koen Kooi @ 2014-01-21 9:40 UTC (permalink / raw)
To: Otavio Salvador; +Cc: Patches and discussions about the oe-core layer
On 01/16/2014 11:47 AM, Otavio Salvador wrote:
> On Thu, Jan 16, 2014 at 8:46 AM, Koen Kooi <koen.kooi@linaro.org
> <mailto:koen.kooi@linaro.org>> wrote:
>
> Op 16 jan. 2014, om 11:38 heeft Otavio Salvador
> <otavio@ossystems.com.br <mailto:otavio@ossystems.com.br>> het
> volgende geschreven:
> > On Thu, Jan 16, 2014 at 7:27 AM, Koen Kooi <koen.kooi@linaro.org
> <mailto:koen.kooi@linaro.org>> wrote:
> > On 01/15/2014 12:22 PM, Otavio Salvador wrote:
> > On Wed, Jan 15, 2014 at 8:15 AM, Koen Kooi <koen.kooi@linaro.org
> <mailto:koen.kooi@linaro.org>
> > <mailto:koen.kooi@linaro.org <mailto:koen.kooi@linaro.org>>> wrote:
> >
> > I've limited it to 64bit targets, but to be honest debug
> splitting
> > doesn't make sense for grub since it won't run in your rootfs and
> > attaching gdb is pretty much impossible.
> >
> > Signed-off-by: Koen Kooi <koen.kooi@linaro.org
> <mailto:koen.kooi@linaro.org>
> > <mailto:koen.kooi@linaro.org <mailto:koen.kooi@linaro.org>>>
> >
> >
> >
> > I'd prefer to remove the debug systems than skip the split. What
> others
> > think?
> >
> > I'm not sure what you mean by that, do you mean using
> INHIBIT_PACKAGE_STRIP or something else?
> >
> >
> > Yes and be sure it has been stripped during build.
>
> That seems to be a lot more work for the same effect. Stripping
> isn't the problem, it's debugedit trying to do its magic that fails.
>
>
> Well, if not stripped the symbols will be left in the binaries which is
> not expected.
I've looked into package.bbclass and it's a classic case of code not
matching docs :(
--
Koen Kooi
Builds and Baselines | Release Manager
Linaro.org | Open source software for ARM SoCs
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] grub git: workaround debugedit problems for 64 bit targets
2014-01-15 10:15 [PATCH] grub git: workaround debugedit problems for 64 bit targets Koen Kooi
2014-01-15 11:22 ` Otavio Salvador
@ 2014-02-12 8:03 ` Koen Kooi
2014-02-12 8:31 ` Richard Purdie
1 sibling, 1 reply; 13+ messages in thread
From: Koen Kooi @ 2014-02-12 8:03 UTC (permalink / raw)
To: openembedded-core
On 01/15/2014 11:15 AM, Koen Kooi wrote:
> I've limited it to 64bit targets, but to be honest debug splitting doesn't make sense for grub since it won't run in your rootfs and attaching gdb is pretty much impossible.
>
> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
> ---
> meta/recipes-bsp/grub/grub_git.bb | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/meta/recipes-bsp/grub/grub_git.bb b/meta/recipes-bsp/grub/grub_git.bb
> index 1796e7f..bc79cfa 100644
> --- a/meta/recipes-bsp/grub/grub_git.bb
> +++ b/meta/recipes-bsp/grub/grub_git.bb
> @@ -51,8 +51,13 @@ do_configure_prepend() {
> do_install_append () {
> install -d ${D}${sysconfdir}/grub.d
> install -m 0755 ${WORKDIR}/40_custom ${D}${sysconfdir}/grub.d/40_custom
> +
> }
>
> +# debugedit chokes on 64 bit platforms
> +INHIBIT_PACKAGE_DEBUG_SPLIT_aarch64 = "1"
> +INHIBIT_PACKAGE_DEBUG_SPLIT_x86-64 = "1"
> +
> RDEPENDS_${PN} = "diffutils freetype"
> FILES_${PN}-dbg += "${libdir}/${BPN}/*/.debug"
>
>
Since the package.bbclass change went in yesterday: ping
--
Koen Kooi
Builds and Baselines | Release Manager
Linaro.org | Open source software for ARM SoCs
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] grub git: workaround debugedit problems for 64 bit targets
2014-02-12 8:03 ` Koen Kooi
@ 2014-02-12 8:31 ` Richard Purdie
2014-02-15 10:27 ` Koen Kooi
0 siblings, 1 reply; 13+ messages in thread
From: Richard Purdie @ 2014-02-12 8:31 UTC (permalink / raw)
To: Koen Kooi; +Cc: openembedded-core
On Wed, 2014-02-12 at 09:03 +0100, Koen Kooi wrote:
> On 01/15/2014 11:15 AM, Koen Kooi wrote:
> > I've limited it to 64bit targets, but to be honest debug splitting doesn't make sense for grub since it won't run in your rootfs and attaching gdb is pretty much impossible.
> >
> > Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
> > ---
> > meta/recipes-bsp/grub/grub_git.bb | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/meta/recipes-bsp/grub/grub_git.bb b/meta/recipes-bsp/grub/grub_git.bb
> > index 1796e7f..bc79cfa 100644
> > --- a/meta/recipes-bsp/grub/grub_git.bb
> > +++ b/meta/recipes-bsp/grub/grub_git.bb
> > @@ -51,8 +51,13 @@ do_configure_prepend() {
> > do_install_append () {
> > install -d ${D}${sysconfdir}/grub.d
> > install -m 0755 ${WORKDIR}/40_custom ${D}${sysconfdir}/grub.d/40_custom
> > +
> > }
> >
> > +# debugedit chokes on 64 bit platforms
> > +INHIBIT_PACKAGE_DEBUG_SPLIT_aarch64 = "1"
> > +INHIBIT_PACKAGE_DEBUG_SPLIT_x86-64 = "1"
> > +
> > RDEPENDS_${PN} = "diffutils freetype"
> > FILES_${PN}-dbg += "${libdir}/${BPN}/*/.debug"
> >
> >
>
> Since the package.bbclass change went in yesterday: ping
Should we just do this for 64 bit targets or should we be doing it
unconventionally?
Cheers,
Richard
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] grub git: workaround debugedit problems for 64 bit targets
2014-02-12 8:31 ` Richard Purdie
@ 2014-02-15 10:27 ` Koen Kooi
2014-03-13 9:08 ` Koen Kooi
0 siblings, 1 reply; 13+ messages in thread
From: Koen Kooi @ 2014-02-15 10:27 UTC (permalink / raw)
To: Richard Purdie; +Cc: Koen Kooi, openembedded-core
Op 12 feb. 2014, om 09:31 heeft Richard Purdie <richard.purdie@linuxfoundation.org> het volgende geschreven:
> On Wed, 2014-02-12 at 09:03 +0100, Koen Kooi wrote:
>> On 01/15/2014 11:15 AM, Koen Kooi wrote:
>>> I've limited it to 64bit targets, but to be honest debug splitting doesn't make sense for grub since it won't run in your rootfs and attaching gdb is pretty much impossible.
>>>
>>> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
>>> ---
>>> meta/recipes-bsp/grub/grub_git.bb | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/meta/recipes-bsp/grub/grub_git.bb b/meta/recipes-bsp/grub/grub_git.bb
>>> index 1796e7f..bc79cfa 100644
>>> --- a/meta/recipes-bsp/grub/grub_git.bb
>>> +++ b/meta/recipes-bsp/grub/grub_git.bb
>>> @@ -51,8 +51,13 @@ do_configure_prepend() {
>>> do_install_append () {
>>> install -d ${D}${sysconfdir}/grub.d
>>> install -m 0755 ${WORKDIR}/40_custom ${D}${sysconfdir}/grub.d/40_custom
>>> +
>>> }
>>>
>>> +# debugedit chokes on 64 bit platforms
>>> +INHIBIT_PACKAGE_DEBUG_SPLIT_aarch64 = "1"
>>> +INHIBIT_PACKAGE_DEBUG_SPLIT_x86-64 = "1"
>>> +
>>> RDEPENDS_${PN} = "diffutils freetype"
>>> FILES_${PN}-dbg += "${libdir}/${BPN}/*/.debug"
>>>
>>>
>>
>> Since the package.bbclass change went in yesterday: ping
>
> Should we just do this for 64 bit targets or should we be doing it
> unconventionally?
It is needed for every 'bare metal' binary we run through debugedit. But for some reason debugedit doesn't choke on 32bit binaries. I'm not sure what the right answer is here, I only fixed it for the archs I ran into problems myself.
I'd be happy to respin this patch if you let me know what the preferred solution is.
regards,
Koen
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] grub git: workaround debugedit problems for 64 bit targets
2014-02-15 10:27 ` Koen Kooi
@ 2014-03-13 9:08 ` Koen Kooi
2014-04-08 12:46 ` Koen Kooi
0 siblings, 1 reply; 13+ messages in thread
From: Koen Kooi @ 2014-03-13 9:08 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
Op 15 feb. 2014, om 11:27 heeft Koen Kooi <koen@dominion.thruhere.net> het volgende geschreven:
>
> Op 12 feb. 2014, om 09:31 heeft Richard Purdie <richard.purdie@linuxfoundation.org> het volgende geschreven:
>
>> On Wed, 2014-02-12 at 09:03 +0100, Koen Kooi wrote:
>>> On 01/15/2014 11:15 AM, Koen Kooi wrote:
>>>> I've limited it to 64bit targets, but to be honest debug splitting doesn't make sense for grub since it won't run in your rootfs and attaching gdb is pretty much impossible.
>>>>
>>>> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
>>>> ---
>>>> meta/recipes-bsp/grub/grub_git.bb | 5 +++++
>>>> 1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/meta/recipes-bsp/grub/grub_git.bb b/meta/recipes-bsp/grub/grub_git.bb
>>>> index 1796e7f..bc79cfa 100644
>>>> --- a/meta/recipes-bsp/grub/grub_git.bb
>>>> +++ b/meta/recipes-bsp/grub/grub_git.bb
>>>> @@ -51,8 +51,13 @@ do_configure_prepend() {
>>>> do_install_append () {
>>>> install -d ${D}${sysconfdir}/grub.d
>>>> install -m 0755 ${WORKDIR}/40_custom ${D}${sysconfdir}/grub.d/40_custom
>>>> +
>>>> }
>>>>
>>>> +# debugedit chokes on 64 bit platforms
>>>> +INHIBIT_PACKAGE_DEBUG_SPLIT_aarch64 = "1"
>>>> +INHIBIT_PACKAGE_DEBUG_SPLIT_x86-64 = "1"
>>>> +
>>>> RDEPENDS_${PN} = "diffutils freetype"
>>>> FILES_${PN}-dbg += "${libdir}/${BPN}/*/.debug"
>>>>
>>>>
>>>
>>> Since the package.bbclass change went in yesterday: ping
>>
>> Should we just do this for 64 bit targets or should we be doing it
>> unconventionally?
>
> It is needed for every 'bare metal' binary we run through debugedit. But for some reason debugedit doesn't choke on 32bit binaries. I'm not sure what the right answer is here, I only fixed it for the archs I ran into problems myself.
>
> I'd be happy to respin this patch if you let me know what the preferred solution is.
Ping
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] grub git: workaround debugedit problems for 64 bit targets
2014-03-13 9:08 ` Koen Kooi
@ 2014-04-08 12:46 ` Koen Kooi
2014-04-12 8:59 ` Koen Kooi
0 siblings, 1 reply; 13+ messages in thread
From: Koen Kooi @ 2014-04-08 12:46 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
Op 13 mrt. 2014, om 10:08 heeft Koen Kooi <koen@dominion.thruhere.net> het volgende geschreven:
>
> Op 15 feb. 2014, om 11:27 heeft Koen Kooi <koen@dominion.thruhere.net> het volgende geschreven:
>
>>
>> Op 12 feb. 2014, om 09:31 heeft Richard Purdie <richard.purdie@linuxfoundation.org> het volgende geschreven:
>>
>>> On Wed, 2014-02-12 at 09:03 +0100, Koen Kooi wrote:
>>>> On 01/15/2014 11:15 AM, Koen Kooi wrote:
>>>>> I've limited it to 64bit targets, but to be honest debug splitting doesn't make sense for grub since it won't run in your rootfs and attaching gdb is pretty much impossible.
>>>>>
>>>>> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
>>>>> ---
>>>>> meta/recipes-bsp/grub/grub_git.bb | 5 +++++
>>>>> 1 file changed, 5 insertions(+)
>>>>>
>>>>> diff --git a/meta/recipes-bsp/grub/grub_git.bb b/meta/recipes-bsp/grub/grub_git.bb
>>>>> index 1796e7f..bc79cfa 100644
>>>>> --- a/meta/recipes-bsp/grub/grub_git.bb
>>>>> +++ b/meta/recipes-bsp/grub/grub_git.bb
>>>>> @@ -51,8 +51,13 @@ do_configure_prepend() {
>>>>> do_install_append () {
>>>>> install -d ${D}${sysconfdir}/grub.d
>>>>> install -m 0755 ${WORKDIR}/40_custom ${D}${sysconfdir}/grub.d/40_custom
>>>>> +
>>>>> }
>>>>>
>>>>> +# debugedit chokes on 64 bit platforms
>>>>> +INHIBIT_PACKAGE_DEBUG_SPLIT_aarch64 = "1"
>>>>> +INHIBIT_PACKAGE_DEBUG_SPLIT_x86-64 = "1"
>>>>> +
>>>>> RDEPENDS_${PN} = "diffutils freetype"
>>>>> FILES_${PN}-dbg += "${libdir}/${BPN}/*/.debug"
>>>>>
>>>>>
>>>>
>>>> Since the package.bbclass change went in yesterday: ping
>>>
>>> Should we just do this for 64 bit targets or should we be doing it
>>> unconventionally?
>>
>> It is needed for every 'bare metal' binary we run through debugedit. But for some reason debugedit doesn't choke on 32bit binaries. I'm not sure what the right answer is here, I only fixed it for the archs I ran into problems myself.
>>
>> I'd be happy to respin this patch if you let me know what the preferred solution is.
>
> Ping
Ping again
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] grub git: workaround debugedit problems for 64 bit targets
2014-04-08 12:46 ` Koen Kooi
@ 2014-04-12 8:59 ` Koen Kooi
0 siblings, 0 replies; 13+ messages in thread
From: Koen Kooi @ 2014-04-12 8:59 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
Op 8 apr. 2014, om 14:46 heeft Koen Kooi <koen@dominion.thruhere.net> het volgende geschreven:
>
> Op 13 mrt. 2014, om 10:08 heeft Koen Kooi <koen@dominion.thruhere.net> het volgende geschreven:
>
>>
>> Op 15 feb. 2014, om 11:27 heeft Koen Kooi <koen@dominion.thruhere.net> het volgende geschreven:
>>
>>>
>>> Op 12 feb. 2014, om 09:31 heeft Richard Purdie <richard.purdie@linuxfoundation.org> het volgende geschreven:
>>>
>>>> On Wed, 2014-02-12 at 09:03 +0100, Koen Kooi wrote:
>>>>> On 01/15/2014 11:15 AM, Koen Kooi wrote:
>>>>>> I've limited it to 64bit targets, but to be honest debug splitting doesn't make sense for grub since it won't run in your rootfs and attaching gdb is pretty much impossible.
>>>>>>
>>>>>> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
>>>>>> ---
>>>>>> meta/recipes-bsp/grub/grub_git.bb | 5 +++++
>>>>>> 1 file changed, 5 insertions(+)
>>>>>>
>>>>>> diff --git a/meta/recipes-bsp/grub/grub_git.bb b/meta/recipes-bsp/grub/grub_git.bb
>>>>>> index 1796e7f..bc79cfa 100644
>>>>>> --- a/meta/recipes-bsp/grub/grub_git.bb
>>>>>> +++ b/meta/recipes-bsp/grub/grub_git.bb
>>>>>> @@ -51,8 +51,13 @@ do_configure_prepend() {
>>>>>> do_install_append () {
>>>>>> install -d ${D}${sysconfdir}/grub.d
>>>>>> install -m 0755 ${WORKDIR}/40_custom ${D}${sysconfdir}/grub.d/40_custom
>>>>>> +
>>>>>> }
>>>>>>
>>>>>> +# debugedit chokes on 64 bit platforms
>>>>>> +INHIBIT_PACKAGE_DEBUG_SPLIT_aarch64 = "1"
>>>>>> +INHIBIT_PACKAGE_DEBUG_SPLIT_x86-64 = "1"
>>>>>> +
>>>>>> RDEPENDS_${PN} = "diffutils freetype"
>>>>>> FILES_${PN}-dbg += "${libdir}/${BPN}/*/.debug"
>>>>>>
>>>>>>
>>>>>
>>>>> Since the package.bbclass change went in yesterday: ping
>>>>
>>>> Should we just do this for 64 bit targets or should we be doing it
>>>> unconventionally?
>>>
>>> It is needed for every 'bare metal' binary we run through debugedit. But for some reason debugedit doesn't choke on 32bit binaries. I'm not sure what the right answer is here, I only fixed it for the archs I ran into problems myself.
>>>
>>> I'd be happy to respin this patch if you let me know what the preferred solution is.
>>
>> Ping
>
> Ping again
With my non-work hat on: I can't build grub for 64-bit non-efi targets (e.g. my core2quad machine at home) due to this, it would be nice to get this into the 'daisy' branch to fix those buildfailures.
regards,
Koen
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2014-04-12 8:59 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-15 10:15 [PATCH] grub git: workaround debugedit problems for 64 bit targets Koen Kooi
2014-01-15 11:22 ` Otavio Salvador
2014-01-16 9:27 ` Koen Kooi
2014-01-16 10:38 ` Otavio Salvador
2014-01-16 10:46 ` Koen Kooi
2014-01-16 10:47 ` Otavio Salvador
2014-01-21 9:40 ` Koen Kooi
2014-02-12 8:03 ` Koen Kooi
2014-02-12 8:31 ` Richard Purdie
2014-02-15 10:27 ` Koen Kooi
2014-03-13 9:08 ` Koen Kooi
2014-04-08 12:46 ` Koen Kooi
2014-04-12 8:59 ` Koen Kooi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.